Skip to content

add AKS listClusterMonitoringUserCredential API for 2019-11-01 and 2020-01-01#8103

Merged
lirenhe merged 1 commit intoAzure:masterfrom
bingosummer:aks-cluster-monitoring-user
Jan 14, 2020
Merged

add AKS listClusterMonitoringUserCredential API for 2019-11-01 and 2020-01-01#8103
lirenhe merged 1 commit intoAzure:masterfrom
bingosummer:aks-cluster-monitoring-user

Conversation

@bingosummer
Copy link
Member

@bingosummer bingosummer commented Jan 9, 2020

The API listClusterMonitoringUserCredential is missing in the version 2019-11-01 and 2020-01-01

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

  • I have reviewed the documentation for the workflow.
  • Validation tools were run on swagger spec(s) and have all been fixed in this PR.
  • The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

  • Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
  • adding/removing APIs.
  • adding/removing properties.
  • adding/removing API-version.
  • adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

  • If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
    Please follow the link to find more details on API review process.

@azure-pipelines
Copy link

azure-pipelines bot commented Jan 9, 2020

Azure Pipelines successfully started running 1 pipeline(s).

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Jan 9, 2020 •
edited
Loading

azure-sdk-for-go - Release

️✔️ succeeded [Logs] [Expand Details]

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Jan 9, 2020 •
edited
Loading

azure-sdk-for-net - Release

️✔️ succeeded [Logs] [Expand Details]

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Jan 9, 2020 •
edited
Loading

azure-sdk-for-java - Release

️✔️ succeeded [Logs] [Expand Details]

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Jan 9, 2020 •
edited
Loading

azure-sdk-for-js - Release

️✔️ succeeded [Logs] [Expand Details]
  • ️✔️ Generate from 486ba0e with merge commit 3245f64. SDK Automation 13.0.17.20191226.1
  • ️✔️@azure/arm-containerservice [Logs]  [Release SDK Changes] 
    [npmPack] npm WARN deprecated rollup-plugin-node-resolve@5.2.0: This package has been deprecated and is no longer maintained. Please use @rollup/plugin-node-resolve.
[npmPack] loaded rollup.config.js with warnings
[npmPack] (!) Unused external imports
[npmPack] default imported from external module 'rollup' but never used
[npmPack] 
[npmPack] ./esm/containerServiceClient.js → ./dist/arm-containerservice.js...
[npmPack] created ./dist/arm-containerservice.js in 400ms

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Jan 9, 2020 •
edited
Loading

azure-sdk-for-python - Release

️✔️ succeeded [Logs] [Expand Details]
  • ️✔️ Generate from 486ba0e with merge commit 3245f64. SDK Automation 13.0.17.20191226.1
  • ️✔️azure-mgmt-containerservice [Logs]  [Release SDK Changes] 
    [after_scripts|python] WARNING:__main__:Found too much API version: {'2017-07-01', '2019-04-01'} in label v2017_07_01
[after_scripts|python] WARNING:__main__:Guessing you want 2017-07-01 based on label v2017_07_01
[build_package] /usr/lib/python3.6/distutils/dist.py:261: UserWarning: Unknown distribution option: 'long_description_content_type'
[build_package]   warnings.warn(msg)
[build_package] /usr/lib/python3.6/distutils/dist.py:261: UserWarning: Unknown distribution option: 'long_description_content_type'
[build_package]   warnings.warn(msg)

@openapi-sdkautomation openapi-sdkautomation bot mentioned this pull request Jan 9, 2020
Closed
@bingosummer
Copy link
Member Author

bingosummer commented Jan 9, 2020

@gtracer / @andyzhangx FYI.

This was referenced Jan 9, 2020
Closed
Closed
Closed
Closed
Closed
Closed
Closed
@andyzhangx
Copy link
Contributor

andyzhangx commented Jan 9, 2020

@xizhamsft

@lirenhe lirenhe added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Jan 10, 2020
@bingosummer bingosummer mentioned this pull request Jan 10, 2020
Merged
3 tasks
ryansbenson
ryansbenson reviewed Jan 10, 2020
View reviewed changes
Copy link
Contributor

@ryansbenson ryansbenson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved from ARMs side

@ryansbenson ryansbenson added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Jan 10, 2020
@azuresdkci
Copy link
Contributor

azuresdkci commented Jan 13, 2020

Can one of the admins verify this patch?

@lirenhe lirenhe merged commit 3245f64 into Azure:master Jan 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ryansbenson ryansbenson ryansbenson left review comments

@lirenhe lirenhe lirenhe approved these changes

Assignees

@lirenhe lirenhe

Labels

ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@bingosummer @andyzhangx @azuresdkci @lirenhe @ryansbenson