-
Notifications
You must be signed in to change notification settings - Fork 1.5k
Add the func list_cluster_monitoring_user_credentials in the vendored sdk for the version v2020_01_01 #1188
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add the func list_cluster_monitoring_user_credentials in the vendored sdk for the version v2020_01_01 #1188
Conversation
… sdk for the version v2020_01_01
|
If this PR is for a new extension or change to an existing extension, use the following to try out the changes in this PR: |
|
@zqingqing1 Please have a review. Thanks! |
|
@zqingqing1 / @myronfanqiu could you please help approve/merge the PR? |
|
@bingosummer I'm ok with this PR since it doesn't change any CLI code. Do you need sign off from @zqingqing1 ? If you don't need I can merge this one. |
|
Besides, I'm curious about the purpose of this PR. Since it won't have any impact for customers. |
|
@myronfanqiu Without this PR, the function list_cluster_monitoring_user_credentials is missing. When customer runs the following command, he will get an error. Please help merge this PR directly. Thanks. |
|
@bingosummer I see. Merged. |
… sdk for the version v2020_01_01 (Azure#1188)
This checklist is used to make sure that common guidelines for a pull request are followed.
General Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally?For new extensions: