You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The identity in workspace should not be readonly, there are examples in other services you can find here, here, here and more (I only listed those in the compute service).
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
[build_package] /usr/lib/python3.6/distutils/dist.py:261: UserWarning: Unknown distribution option: 'long_description_content_type'
[build_package] warnings.warn(msg)
[build_package] warning: no files found matching '*.py' under directory 'tests'
[build_package] warning: no files found matching '*.yaml' under directory 'tests'
[build_package] /usr/lib/python3.6/distutils/dist.py:261: UserWarning: Unknown distribution option: 'long_description_content_type'
[build_package] warnings.warn(msg)
[build_package] warning: no files found matching '*.py' under directory 'tests'
[build_package] warning: no files found matching '*.yaml' under directory 'tests'
[npmPack] npm WARN deprecated [email protected]: This package has been deprecated and is no longer maintained. Please use @rollup/plugin-node-resolve.
[npmPack] loaded rollup.config.js with warnings
[npmPack] (!) Unused external imports
[npmPack] default imported from external module 'rollup' but never used
[npmPack]
[npmPack] ./esm/azureMachineLearningWorkspaces.js → ./dist/arm-machinelearningservices.js...
[npmPack] created ./dist/arm-machinelearningservices.js in 416ms
This change should be of low risk. However IMHO the point is whether service support changing of the property, not whether it should or should not be read-only.
Please let me know if you need @vrushg-ms or any owner of the service to sign-off this PR.
This change should be of low risk. However IMHO the point is whether service support changing of the property, not whether it should or should not be read-only.
Please let me know if you need @vrushg-ms or any owner of the service to sign-off this PR.
I am asking the service team to have a review on this.
Actually I already done some experiments on this rest api.
Despite the identity is marked as readOnly, the rest api call with a body without identity will be rejected by the service saying You must call this api using a client that supports MSI which indicates that you must assign this identity property.
If the rest api was sent with identity, everything is fine.
I submit this pr to change the readOnly in swagger because the readOnly field will affect how the SDK is generated. The code generator will recognize this field and do not put the read only fields when the SDK is marshalling or serializing SDK-structs to the json body in the rest api. In this case, it will cause the SDK call to fail.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The identity in workspace should not be readonly, there are examples in other services you can find here, here, here and more (I only listed those in the compute service).