Skip to content

Ready to merge : Workspace: Swagger updates for CMK #7967

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ArcturusZhang merged 7 commits into from
Jan 14, 2020
Merged

Ready to merge : Workspace: Swagger updates for CMK #7967

ArcturusZhang merged 7 commits into from
Jan 14, 2020

Conversation

@DeMale
Copy link
Contributor

@DeMale DeMale commented Dec 12, 2019 •
edited
Loading

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

  • I have reviewed the documentation for the workflow.
  • Validation tools were run on swagger spec(s) and have all been fixed in this PR.
  • The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

  • Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
  • adding/removing APIs.
  • adding/removing properties.
  • adding/removing API-version.
  • adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

  • If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
    Please follow the link to find more details on API review process.

@AutorestCI
Copy link

AutorestCI commented Dec 12, 2019

You don't have permission to trigger SDK Automation.
Please add yourself to Azure group from opensource portal if you are MSFT employee,
or please ask reviewer to add comment *** /openapibot sdkautomation ***.
Please ask [email protected] (or NullMDR in github) for additional help.

@azuresdkci
Copy link
Contributor

azuresdkci commented Dec 12, 2019

Can one of the admins verify this patch?

@ArcturusZhang
Copy link
Member

ArcturusZhang commented Dec 13, 2019

Hi @DeMale I do not know if this is a good place, but I just happened to work on bringing this particular resource (MachineLearningService.Workspace) to terraform. But I found that this rest api does not work. Please have a check or we can discuss this more in an internal email.

@ArcturusZhang ArcturusZhang added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Dec 13, 2019
@ArcturusZhang
Copy link
Member

ArcturusZhang commented Dec 13, 2019

This is a flag to mark the workspace as High Business Impact one on workspace creation. The flag to signal HBI data in the workspace and reduce diagnostic data collected by the downstream services

I strongly recommend you refine the current description of hbiWorkspace to include this information.

ArcturusZhang
ArcturusZhang requested changes Dec 13, 2019
View reviewed changes
Copy link
Member

@ArcturusZhang ArcturusZhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove the readOnly: true for identity (here).
You can refer to this pr for details.

@vrushg-ms
Copy link
Contributor

vrushg-ms commented Dec 13, 2019

Hi @DeMale I do not know if this is a good place, but I just happened to work on bringing this particular resource (MachineLearningService.Workspace) to terraform. But I found that this rest api does not work. Please have a check or we can discuss this more in an internal email.

@ArcturusZhang Let's not combine other changes in this PR. We will create a separate PR for that change.

@DeMale
Copy link
Contributor Author

DeMale commented Dec 13, 2019

Please remove the readOnly: true for identity (here).
You can refer to this pr for details.

@ArcturusZhang Since you have a separate PR for the change requested, can we get this PR going?

@ArcturusZhang
Copy link
Member

ArcturusZhang commented Dec 16, 2019

Hi @DeMale I do not know if this is a good place, but I just happened to work on bringing this particular resource (MachineLearningService.Workspace) to terraform. But I found that this rest api does not work. Please have a check or we can discuss this more in an internal email.

@ArcturusZhang Let's not combine other changes in this PR. We will create a separate PR for that change.

Sure, thanks.

@vrushg-ms
PR comments fixes
045a841 
PR comments fixes
pilor
pilor approved these changes Dec 17, 2019
View reviewed changes
Copy link
Contributor

@pilor pilor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor final comments

@pilor pilor added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed ARMChangesRequested WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Dec 17, 2019
@vrushg-ms vrushg-ms changed the title Workspace: Swagger updates for CMK Merge on 01/13/2020 : Workspace: Swagger updates for CMK Dec 18, 2019
@ArcturusZhang
Copy link
Member

ArcturusZhang commented Dec 20, 2019

Hi @DeMale please let me know when you have resolved all the comments and ready to merge this pr

@ArcturusZhang ArcturusZhang added the DoNotMerge <valid label in PR review process> use to hold merge after approval label Dec 26, 2019
@ArcturusZhang
Copy link
Member

ArcturusZhang commented Dec 27, 2019

Hi @DeMale is this ready for merge? Or it has to wait until 01/13/2020?

@DeMale
Copy link
Contributor Author

DeMale commented Dec 27, 2019

Hi @ArcturusZhang It has to wait until 01/13/2020 until all the JEDI work gets into production regions.

@ArcturusZhang
Copy link
Member

ArcturusZhang commented Dec 27, 2019

Hi @ArcturusZhang It has to wait until 01/13/2020 until all the JEDI work gets into production regions.

Got it

@DeMale DeMale changed the title Merge on 01/13/2020 : Workspace: Swagger updates for CMK Ready to merge : Workspace: Swagger updates for CMK Jan 13, 2020
@vrushg-ms vrushg-ms added Approved-OkToMerge <valid label in PR review process>add this label when assignee approve to merge the updates and removed DoNotMerge <valid label in PR review process> use to hold merge after approval labels Jan 13, 2020
@ArcturusZhang
Copy link
Member

ArcturusZhang commented Jan 14, 2020

/azp run

@azure-pipelines
Copy link

azure-pipelines bot commented Jan 14, 2020

Azure Pipelines successfully started running 3 pipeline(s).

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Jan 14, 2020 •
edited
Loading

azure-sdk-for-net - Release

️✔️ succeeded [Logs] [Expand Details]
  • ️✔️ Generate from 465c1c1 with merge commit 536782b. SDK Automation 13.0.17.20191226.1 
    [AutoRest] realpath(): Permission denied
[AutoRest] realpath(): Permission denied
[AutoRest] realpath(): Permission denied
[AutoRest] realpath(): Permission denied
[AutoRest] realpath(): Permission denied
[AutoRest] realpath(): Permission denied
  • ️✔️Microsoft.Azure.Management.MachineLearningServices [Logs]  [Release SDK Changes]
      No Artifact Generated.

    @openapi-sdkautomation
    Copy link

    openapi-sdkautomation bot commented Jan 14, 2020 •
    edited
    Loading

    azure-sdk-for-go - Release

    ️✔️ succeeded [Logs] [Expand Details]

    @openapi-sdkautomation
    Copy link

    openapi-sdkautomation bot commented Jan 14, 2020 •
    edited
    Loading

    azure-sdk-for-java - Release

    No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

    @openapi-sdkautomation
    Copy link

    openapi-sdkautomation bot commented Jan 14, 2020 •
    edited
    Loading

    azure-sdk-for-js - Release

    ️✔️ succeeded [Logs] [Expand Details]
    • ️✔️ Generate from 465c1c1 with merge commit 536782b. SDK Automation 13.0.17.20191226.1
    • ️✔️@azure/arm-machinelearningservices [Logs]  [Release SDK Changes] 
      [npmPack] npm WARN deprecated [email protected]: This package has been deprecated and is no longer maintained. Please use @rollup/plugin-node-resolve.
[npmPack] loaded rollup.config.js with warnings
[npmPack] (!) Unused external imports
[npmPack] default imported from external module 'rollup' but never used
[npmPack] 
[npmPack] ./esm/azureMachineLearningWorkspaces.js → ./dist/arm-machinelearningservices.js...
[npmPack] created ./dist/arm-machinelearningservices.js in 452ms

    @openapi-sdkautomation
    Copy link

    openapi-sdkautomation bot commented Jan 14, 2020 •
    edited
    Loading

    azure-sdk-for-python - Release

    ️✔️ succeeded [Logs] [Expand Details]
    • ️✔️ Generate from 465c1c1 with merge commit 536782b. SDK Automation 13.0.17.20191226.1
    • ️✔️azure-mgmt-machinelearningservices [Logs]  [Release SDK Changes] 
      [build_package] /usr/lib/python3.6/distutils/dist.py:261: UserWarning: Unknown distribution option: 'long_description_content_type'
[build_package]   warnings.warn(msg)
[build_package] warning: no files found matching '*.py' under directory 'tests'
[build_package] warning: no files found matching '*.yaml' under directory 'tests'
[build_package] /usr/lib/python3.6/distutils/dist.py:261: UserWarning: Unknown distribution option: 'long_description_content_type'
[build_package]   warnings.warn(msg)
[build_package] warning: no files found matching '*.py' under directory 'tests'
[build_package] warning: no files found matching '*.yaml' under directory 'tests'

    This was referenced Jan 14, 2020
    Closed
    Closed
    Closed
    @ArcturusZhang ArcturusZhang mentioned this pull request Jan 14, 2020
    Merged
    5 tasks
    @ArcturusZhang
    Copy link
    Member

    ArcturusZhang commented Jan 14, 2020

    /azp run

    @azure-pipelines
    Copy link

    azure-pipelines bot commented Jan 14, 2020

    Azure Pipelines successfully started running 3 pipeline(s).

    @ArcturusZhang ArcturusZhang merged commit 536782b into Azure:master Jan 14, 2020
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

    Reviewers

    @ArcturusZhang ArcturusZhang ArcturusZhang approved these changes

    +2 more reviewers

    @vrushg-ms vrushg-ms vrushg-ms left review comments

    @pilor pilor pilor approved these changes

    Reviewers whose approvals may not affect merge requirements

    Assignees

    @ArcturusZhang ArcturusZhang

    Labels

    Approved-OkToMerge <valid label in PR review process>add this label when assignee approve to merge the updates ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review

    Projects

    None yet

    Milestone

    No milestone

    Development

    Successfully merging this pull request may close these issues.

    7 participants

    @DeMale @AutorestCI @azuresdkci @ArcturusZhang @vrushg-ms @pilor @zhaomuzhi