[Do Not Merge][Private Repo PR# 974] Tag based object filter support for OLCM by HimanshuChhabra · Pull Request #7953 · Azure/azure-rest-api-specs

HimanshuChhabra · 2019-12-11T22:18:48Z

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

I have reviewed the documentation for the workflow.
Validation tools were run on swagger spec(s) and have all been fixed in this PR.
The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
adding/removing APIs.
adding/removing properties.
adding/removing API-version.
adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Please follow the link to find more details on API review process.

azure-pipelines · 2019-12-11T22:19:05Z

Azure Pipelines successfully started running 1 pipeline(s).

openapi-sdkautomation · 2019-12-11T22:21:05Z

azure-sdk-for-python

️✔️ succeeded [Logs] [Expand Details]

️✔️ Generate from 8aea9cf with merge commit 53c09d9e27dca9dfb1ddc403436d0cc3363e8216. SDK Automation 13.0.17.20191226.1

️✔️azure-mgmt-storage [Logs] [Preview SDK Changes]

[after_scripts|python] WARNING:__main__:Found too much API version: {'2018-07-01', '2018-03-01-preview'} in label v2018_07_01
[after_scripts|python] WARNING:__main__:Guessing you want 2018-07-01 based on label v2018_07_01
[build_package] /usr/lib/python3.6/distutils/dist.py:261: UserWarning: Unknown distribution option: 'long_description_content_type'
[build_package]   warnings.warn(msg)
[build_package] /usr/lib/python3.6/distutils/dist.py:261: UserWarning: Unknown distribution option: 'long_description_content_type'
[build_package]   warnings.warn(msg)

openapi-sdkautomation · 2019-12-11T22:21:06Z

azure-sdk-for-net

️✔️ succeeded [Logs] [Expand Details]

️✔️ Generate from 11cbf4e with merge commit 6a2548027a3002a03a3aedf47fabdb682c3267d0. SDK Automation 13.0.17.20191226.1

[AutoRest] realpath(): Permission denied
[AutoRest] realpath(): Permission denied
[AutoRest] realpath(): Permission denied
[AutoRest] realpath(): Permission denied
[AutoRest] realpath(): Permission denied
[AutoRest] realpath(): Permission denied

️✔️Microsoft.Azure.Management.Storage [Logs] [Preview SDK Changes]

openapi-sdkautomation · 2019-12-11T22:21:13Z

azure-sdk-for-go

⚠️ warning [Logs] [Expand Details]

⚠️ Generate from 8aea9cf with merge commit 53c09d9e27dca9dfb1ddc403436d0cc3363e8216. SDK Automation 13.0.17.20191226.1
⚠️preview/storage/mgmt/2015-05-01-preview [Logs]
```
No file is changed.
```
⚠️preview/storage/mgmt/2018-03-01-preview [Logs]
```
No file is changed.
```
⚠️storage/mgmt/2015-06-15 [Logs]
```
No file is changed.
```
⚠️storage/mgmt/2016-01-01 [Logs]
```
No file is changed.
```
⚠️storage/mgmt/2016-05-01 [Logs]
```
No file is changed.
```
⚠️storage/mgmt/2016-12-01 [Logs]
```
No file is changed.
```
⚠️storage/mgmt/2017-06-01 [Logs]
```
No file is changed.
```
⚠️storage/mgmt/2017-10-01 [Logs]
```
No file is changed.
```
⚠️storage/mgmt/2018-02-01 [Logs]
```
No file is changed.
```
⚠️storage/mgmt/2018-07-01 [Logs]
```
No file is changed.
```
⚠️storage/mgmt/2018-11-01 [Logs]
```
No file is changed.
```
⚠️storage/mgmt/2019-04-01 [Logs]
```
No file is changed.
```
️✔️storage/mgmt/2019-06-01 [Logs] [Preview SDK Changes]
- storage.mgmt.2019-06-01.zip

openapi-sdkautomation · 2019-12-11T22:21:17Z

azure-sdk-for-js

️✔️ succeeded [Logs] [Expand Details]

️✔️ Generate from 8aea9cf with merge commit 53c09d9e27dca9dfb1ddc403436d0cc3363e8216. SDK Automation 13.0.17.20191226.1

️✔️@azure/arm-storage [Logs] [Preview SDK Changes]

azure-arm-storage-13.1.0.tgz

[npmPack] npm WARN deprecated rollup-plugin-node-resolve@5.2.0: This package has been deprecated and is no longer maintained. Please use @rollup/plugin-node-resolve.
[npmPack] loaded rollup.config.js with warnings
[npmPack] (!) Unused external imports
[npmPack] default imported from external module 'rollup' but never used
[npmPack] 
[npmPack] ./esm/storageManagementClient.js → ./dist/arm-storage.js...
[npmPack] created ./dist/arm-storage.js in 530ms

openapi-sdkautomation · 2019-12-11T22:21:25Z

azure-sdk-for-java

⚠️ warning [Logs] [Expand Details]

⚠️ Generate from 8aea9cf with merge commit 53c09d9e27dca9dfb1ddc403436d0cc3363e8216. SDK Automation 13.0.17.20191226.1
️✔️sdk/storage/mgmt-v2016_01_01 [Logs] [Preview SDK Changes]
️✔️sdk/storage/mgmt-v2017_10_01 [Logs] [Preview SDK Changes]
️✔️sdk/storage/mgmt-v2018_02_01 [Logs] [Preview SDK Changes]
️✔️sdk/storage/mgmt-v2018_03_01_preview [Logs] [Preview SDK Changes]
️✔️sdk/storage/mgmt-v2018_07_01 [Logs] [Preview SDK Changes]
️✔️sdk/storage/mgmt-v2019_04_01 [Logs] [Preview SDK Changes]

⚠️sdk/storage/mgmt-v2019_06_01 [Logs] [Preview SDK Changes]

[mvn] [ERROR] COMPILATION ERROR : 
[mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/storage/mgmt-v2019_06_01/src/main/java/com/microsoft/azure/management/storage/v2019_06_01/BlobServiceProperties.java:[68,5] cannot find symbol
[mvn]   symbol:   class SkuInner
[mvn]   location: interface com.microsoft.azure.management.storage.v2019_06_01.BlobServiceProperties
[mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/storage/mgmt-v2019_06_01/src/main/java/com/microsoft/azure/management/storage/v2019_06_01/FileServiceProperties.java:[49,5] cannot find symbol
[mvn]   symbol:   class SkuInner
[mvn]   location: interface com.microsoft.azure.management.storage.v2019_06_01.FileServiceProperties
[mvn] [ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.1:compile (default-compile) on project azure-mgmt-storage: Compilation failure: Compilation failure: 
[mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/storage/mgmt-v2019_06_01/src/main/java/com/microsoft/azure/management/storage/v2019_06_01/BlobServiceProperties.java:[68,5] cannot find symbol
[mvn] [ERROR]   symbol:   class SkuInner
[mvn] [ERROR]   location: interface com.microsoft.azure.management.storage.v2019_06_01.BlobServiceProperties
[mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/storage/mgmt-v2019_06_01/src/main/java/com/microsoft/azure/management/storage/v2019_06_01/FileServiceProperties.java:[49,5] cannot find symbol
[mvn] [ERROR]   symbol:   class SkuInner
[mvn] [ERROR]   location: interface com.microsoft.azure.management.storage.v2019_06_01.FileServiceProperties
[mvn] [ERROR] -> [Help 1]
[mvn] [ERROR] 
[mvn] [ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
[mvn] [ERROR] Re-run Maven using the -X switch to enable full debug logging.
[mvn] [ERROR] 
[mvn] [ERROR] For more information about the errors and possible solutions, please read the following articles:
[mvn] [ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException

azuresdkci · 2019-12-11T23:13:27Z

Can one of the admins verify this patch?

azure-pipelines · 2019-12-12T18:32:15Z

Azure Pipelines successfully started running 1 pipeline(s).

lirenhe · 2019-12-17T02:14:01Z

@HimanshuChhabra, please let me know when the PR is ready to merge

HimanshuChhabra · 2019-12-17T18:26:33Z

@HimanshuChhabra, please let me know when the PR is ready to merge

I will update here once the server support is deployed to required regions

specification/storage/resource-manager/Microsoft.Storage/stable/2019-06-01/storage.json

blueww

I added 2 comments, please help to resolve them.

azure-pipelines · 2020-02-10T22:24:43Z

Comment was made before the most recent commit for PR 7953 in repo Azure/azure-rest-api-specs

azure-pipelines · 2020-02-10T23:53:04Z

Azure Pipelines successfully started running 1 pipeline(s).

…less service and ApplicationTypeVersionsCleanupPolicy to cluster (Azure#8944) Co-authored-by: Alfredo Santamaria Gomez <alsantam@microsoft.com>

Use separate line for prettier check guide as one line of command doesn't work on cmd

…ior (Phase 2) (Azure#8990) * Update swagger for missing properties * Revert "Update swagger for missing properties" This reverts commit dc74330. * Add provisioningOperation property to DeploymentOperation object Co-authored-by: Filiz Topatan <lsefitopata@microsoft.com>

azure-pipelines · 2020-04-10T19:13:11Z

No commit pushedDate could be found for PR 7953 in repo Azure/azure-rest-api-specs

azuresdkci assigned lirenhe Dec 11, 2019

azuresdkci requested a review from lirenhe December 11, 2019 22:41

lirenhe approved these changes Dec 17, 2019

View reviewed changes

lirenhe added the Approved-OkToMerge <valid label in PR review process>add this label when assignee approve to merge the updates label Dec 17, 2019

lirenhe added the DoNotMerge <valid label in PR review process> use to hold merge after approval label Dec 23, 2019

blueww reviewed Feb 10, 2020

View reviewed changes

specification/storage/resource-manager/Microsoft.Storage/stable/2019-06-01/storage.json Outdated Show resolved Hide resolved

blueww reviewed Feb 10, 2020

View reviewed changes

specification/storage/resource-manager/Microsoft.Storage/stable/2019-06-01/storage.json Show resolved Hide resolved

blueww reviewed Feb 10, 2020

View reviewed changes

a-santamaria and others added 13 commits April 10, 2020 09:22

adding serviceDnsName to service, instanceCloseDelayDuration to state…

6e7c6b9

…less service and ApplicationTypeVersionsCleanupPolicy to cluster (Azure#8944) Co-authored-by: Alfredo Santamaria Gomez <alsantam@microsoft.com>

Updates for Batch Management 2020-03 API version (Azure#8973)

0e912c1

Updated Description for the DiffDiskPlacement property. (Azure#8964)

2b208cb

Fix Python Readme for Network (Azure#9008)

c2b9fbf

Update ci-fix.md (Azure#9009)

b55b144

Use separate line for prettier check guide as one line of command doesn't work on cmd

Adding Tag based object filter support for LCM

7f380ad

Spell correction

cea3a88

Updating Sample Example For Put Management Policy

f1632bc

Updating blobIndexMatch.op description

07f8e48

Spell correction

8fcb817

Change min length constraint for tag value to 0 ; updated comments

cc25465

Resolving merge conflicts

cd71a0f

HimanshuChhabra requested review from RandalliLama, amarzavery, heaths, hitenjava, hyonholee, kalyanaj, kjeur, lmazuel, matthchr, solankisamir, v-Ajnava, wilcobmsft, xingwu1, yangyuan and yugangw-msft as code owners April 10, 2020 19:12

HimanshuChhabra closed this Apr 10, 2020

Conversation

HimanshuChhabra commented Dec 11, 2019

Latest improvements:

Contribution checklist:

ARM API Review Checklist

Uh oh!

azure-pipelines bot commented Dec 11, 2019

Uh oh!

openapi-sdkautomation bot commented Dec 11, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

azure-sdk-for-python

Uh oh!

openapi-sdkautomation bot commented Dec 11, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

azure-sdk-for-net

Uh oh!

openapi-sdkautomation bot commented Dec 11, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

azure-sdk-for-go

Uh oh!

openapi-sdkautomation bot commented Dec 11, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

azure-sdk-for-js

Uh oh!

openapi-sdkautomation bot commented Dec 11, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

azure-sdk-for-java

Uh oh!

azuresdkci commented Dec 11, 2019

Uh oh!

azure-pipelines bot commented Dec 12, 2019

Uh oh!

lirenhe commented Dec 17, 2019

Uh oh!

HimanshuChhabra commented Dec 17, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

blueww left a comment

Choose a reason for hiding this comment

Uh oh!

azure-pipelines bot commented Feb 10, 2020

Uh oh!

azure-pipelines bot commented Feb 10, 2020

Uh oh!

azure-pipelines bot commented Apr 10, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

20 participants

openapi-sdkautomation bot commented Dec 11, 2019 •

edited

Loading

openapi-sdkautomation bot commented Dec 11, 2019 •

edited

Loading

openapi-sdkautomation bot commented Dec 11, 2019 •

edited

Loading

openapi-sdkautomation bot commented Dec 11, 2019 •

edited

Loading

openapi-sdkautomation bot commented Dec 11, 2019 •

edited

Loading

HimanshuChhabra commented Dec 17, 2019 •

edited

Loading