Skip to content

Updates for Batch Management 2020-03 API version#8973

Merged
akning-ms merged 1 commit intoAzure:masterfrom
matthchr:feature/batch-mgmt-march-2020-fixes
Apr 10, 2020
Merged

Updates for Batch Management 2020-03 API version#8973
akning-ms merged 1 commit intoAzure:masterfrom
matthchr:feature/batch-mgmt-march-2020-fixes

Conversation

@matthchr
Copy link
Copy Markdown
Member

@matthchr matthchr commented Apr 7, 2020 •
edited
Loading

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

  • I have reviewed the documentation for the workflow.
  • Validation tools were run on swagger spec(s) and have all been fixed in this PR.
  • The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

  • Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
  • adding/removing APIs.
  • adding/removing properties.
  • adding/removing API-version.
  • adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

  • If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
    Please follow the link to find more details on API review process.

@matthchr matthchr requested a review from xingwu1 as a code owner April 7, 2020 18:22
@azure-pipelines
Copy link
Copy Markdown

azure-pipelines bot commented Apr 7, 2020

Azure Pipelines successfully started running 1 pipeline(s).

@openapi-sdkautomation
Copy link
Copy Markdown

openapi-sdkautomation bot commented Apr 7, 2020 •
edited
Loading

azure-sdk-for-go - Release

⚠️ warning [Logs] [Expand Details]
  • ⚠️ Generate from 864d50f with merge commit 0e912c1. SDK Automation 13.0.17.20200326.3
  • ⚠️batch/mgmt/2015-12-01 [Logs]  
      No file is changed.
    • ⚠️batch/mgmt/2017-01-01 [Logs]  
        No file is changed.
      • ⚠️batch/mgmt/2017-05-01 [Logs]  
          No file is changed.
        • ⚠️batch/mgmt/2017-09-01 [Logs]  
            No file is changed.
          • ⚠️batch/mgmt/2018-12-01 [Logs]  
              No file is changed.
            • ⚠️batch/mgmt/2019-04-01 [Logs]  
                No file is changed.
              • ⚠️batch/mgmt/2019-08-01 [Logs]  
                  No file is changed.
                • ️✔️batch/mgmt/2020-03-01 [Logs]  [Release SDK Changes]

                @openapi-sdkautomation
                Copy link
                Copy Markdown

                openapi-sdkautomation bot commented Apr 7, 2020 •
                edited
                Loading

                azure-sdk-for-java - Release

                ️✔️ succeeded [Logs] [Expand Details]

                @openapi-sdkautomation
                Copy link
                Copy Markdown

                openapi-sdkautomation bot commented Apr 7, 2020 •
                edited
                Loading

                azure-sdk-for-js - Release

                ️✔️ succeeded [Logs] [Expand Details]
                • ️✔️ Generate from 864d50f with merge commit 0e912c1. SDK Automation 13.0.17.20200326.3
                • ️✔️@azure/arm-batch [Logs]  [Release SDK Changes] 
                  [npmPack] npm WARN lifecycle @azure/arm-batch@4.0.0~prepack: cannot run in wd @azure/arm-batch@4.0.0 npm install && npm run build (wd=/z/work/azure-sdk-for-js/sdk/batch/arm-batch)

                @openapi-sdkautomation
                Copy link
                Copy Markdown

                openapi-sdkautomation bot commented Apr 7, 2020 •
                edited
                Loading

                azure-sdk-for-net - Release

                ️✔️ succeeded [Logs] [Expand Details]

                @openapi-sdkautomation
                Copy link
                Copy Markdown

                openapi-sdkautomation bot commented Apr 7, 2020 •
                edited
                Loading

                azure-cli-extensions - Release

                No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

                @openapi-sdkautomation
                Copy link
                Copy Markdown

                openapi-sdkautomation bot commented Apr 7, 2020 •
                edited
                Loading

                azure-sdk-for-python - Release

                - Breaking Change detected in SDK

                ⚠️ warning [Logs] [Expand Details]
                • ⚠️ Generate from 864d50f with merge commit 0e912c1. SDK Automation 13.0.17.20200326.3
                • ⚠️azure-mgmt-batch [Logs]  [Release SDK Changes] Breaking Change Detected
                  [build_package] /usr/lib/python3.6/distutils/dist.py:261: UserWarning: Unknown distribution option: 'long_description_content_type'
[build_package]   warnings.warn(msg)
[build_package] /usr/lib/python3.6/distutils/dist.py:261: UserWarning: Unknown distribution option: 'long_description_content_type'
[build_package]   warnings.warn(msg)
[breaking_change_setup] Ignoring mock: markers 'python_version <= "2.7"' don't match your environment
[breaking_change_setup] Cannot uninstall requirement azure-nspkg, not installed
[breaking_change_setup] Command '['/usr/local/bin/python', '-m', 'pip', 'uninstall', '-y', 'azure-nspkg']' returned non-zero exit status 1.
[ChangeLog] Size of delta 15.878% size of original (original: 54968 chars, delta: 8728 chars)
[ChangeLog] **Features**
[ChangeLog] 
[ChangeLog]   - Model NetworkConfiguration has a new parameter public_ip_address_configuration
[ChangeLog]   - Model VirtualMachineConfiguration has a new parameter disk_encryption_configuration
[ChangeLog]   - Model BatchAccountCreateParameters has a new parameter encryption
[ChangeLog]   - Model BatchAccountCreateParameters has a new parameter public_network_access
[ChangeLog]   - Model BatchAccount has a new parameter private_endpoint_connections
[ChangeLog]   - Model BatchAccount has a new parameter encryption
[ChangeLog]   - Model BatchAccount has a new parameter public_network_access
[ChangeLog]   - Model BatchAccountUpdateParameters has a new parameter encryption
[ChangeLog]   - Added operation group PrivateLinkResourceOperations
[ChangeLog]   - Added operation group PrivateEndpointConnectionOperations
[ChangeLog] 
[ChangeLog] **Breaking changes**
[ChangeLog] 
[ChangeLog]   - Operation BatchAccountOperations.update has a new signature
[ChangeLog]   - Model NetworkConfiguration no longer has parameter public_ips

                This was referenced Apr 7, 2020
                Closed
                Closed
                Closed
                Closed
                Closed
                Closed
                Closed
                @matthchr
                Copy link
                Copy Markdown
                Member Author

                matthchr commented Apr 7, 2020 •
                edited
                Loading

                This API version has not had SDKs published for it yet (we were waiting for these changes to be merged).

                The following two changes are additions required for JEDI:

                Info 1040 - AddedReadOnlyPropertyInResponse - The new version has a new read-only property 'privateEndpointConnections' in response that was not found in the old version.
Info 1040 - AddedReadOnlyPropertyInResponse - The new version has a new read-only property 'requiredZoneNames' in response that was not found in the old version.

                The following changes are corrects to errors in the specification (these properties were always required, we just didn't specify correctly). Also note, since these properties were only added on an object which is returned from GETs, it's documentation as required is just an FYI that the server will always return it.

                Error 1034 - AddedRequiredProperty - The new version has new required property 'status' that was not found in the old version.
Error 1034 - AddedRequiredProperty - The new version has new required property 'status' that was not found in the old version.

                Please let me know what we should do to silence the errors in the PR gate.

                @matthchr matthchr force-pushed the feature/batch-mgmt-march-2020-fixes branch from 3e81a93 to a3b7aeb Compare April 7, 2020 18:40
                @azure-pipelines
                Copy link
                Copy Markdown

                azure-pipelines bot commented Apr 7, 2020

                Azure Pipelines successfully started running 1 pipeline(s).

                @azuresdkci
                Copy link
                Copy Markdown
                Contributor

                azuresdkci commented Apr 7, 2020

                Can one of the admins verify this patch?

                KrisBash
                KrisBash approved these changes Apr 7, 2020
                View reviewed changes
                Copy link
                Copy Markdown
                Contributor

                @KrisBash KrisBash left a comment

                Choose a reason for hiding this comment

                The reason will be displayed to describe this comment to others. Learn more.

                LGTM. I understand this to not be breaking as SDKs have not shipped

                @KrisBash KrisBash added the ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review label Apr 7, 2020
                @matthchr
                Copy link
                Copy Markdown
                Member Author

                matthchr commented Apr 7, 2020

                @erich-wang - since SDKs have not yet shipped for this API version, I believe these breaking changes should be okay -- can you advise on what we can do to flag these changes as okay for the purposes of CI?

                @erich-wang erich-wang added the Approved-BreakingChange DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374 label Apr 8, 2020
                @erich-wang
                Copy link
                Copy Markdown
                Member

                erich-wang commented Apr 8, 2020

                @erich-wang - since SDKs have not yet shipped for this API version, I believe these breaking changes should be okay -- can you advise on what we can do to flag these changes as okay for the purposes of CI?

                Approve the breaking change since there's no sdk released for this version.

                @matthchr , please fix ModelValidation error https://dev.azure.com/azure-sdk/public/_build/results?buildId=347822&view=logs&j=8d2f9c49-cd83-5a9d-f3fe-2fd651afa742&t=43324f1f-6724-5d61-785f-f0ac9fd256a1

                @matthchr matthchr force-pushed the feature/batch-mgmt-march-2020-fixes branch from a3b7aeb to 864d50f Compare April 8, 2020 15:22
                @azure-pipelines
                Copy link
                Copy Markdown

                azure-pipelines bot commented Apr 8, 2020

                Azure Pipelines successfully started running 1 pipeline(s).

                @matthchr
                Copy link
                Copy Markdown
                Member Author

                matthchr commented Apr 8, 2020 •
                edited
                Loading

                @erich-wang I fixed the model validation failures that were added.

                I see that for some reason model validation is still failing with this error:

                operationId: Certificate_Create
scenario: CreateCertificate - Minimal Pfx
source: request
responseCode: ALL
severity: 0
code: PATTERN
details:
  code: PATTERN
  params:
    - '^[\w]+-[\w]+$'
    - sha10a0e4f50d51beadeac1d35afc5116098e7902e6e

                This error is incorrect though - somehow the validator is dropping the - which the parameter has. The actual parameter is sha-10a0e4f50d51beadeac1d35afc5116098e7902e6e (which matches the required regex).

                Additionally, these files were not changed. This looks like a bug in the validator to me.

                @erich-wang
                Copy link
                Copy Markdown
                Member

                erich-wang commented Apr 9, 2020

                @matthchr , I send email to swagger team to look into the model validation error.

                @akning-ms akning-ms merged commit 0e912c1 into Azure:master Apr 10, 2020
                @matthchr matthchr deleted the feature/batch-mgmt-march-2020-fixes branch May 1, 2020 17:25
                00Kai0 pushed a commit to 00Kai0/azure-rest-api-specs that referenced this pull request Oct 12, 2020
                @matthchr @00Kai0
                Updates for Batch Management 2020-03 API version (Azure#8973)
                0168c62
                Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

                Reviewers

                @xingwu1 xingwu1 Awaiting requested review from xingwu1

                2 more reviewers

                @KrisBash KrisBash KrisBash approved these changes

                @erich-wang erich-wang erich-wang approved these changes

                Reviewers whose approvals may not affect merge requirements

                Assignees

                @erich-wang erich-wang

                Labels

                Approved-BreakingChange DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374 ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review

                Projects

                None yet

                Milestone

                No milestone

                Development

                Successfully merging this pull request may close these issues.

                5 participants

                @matthchr @azuresdkci @erich-wang @KrisBash @akning-ms