Skip to content

[Azure Search] General fixes to swagger #7751

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sarangan12 merged 21 commits into from
Nov 12, 2019
Merged

[Azure Search] General fixes to swagger #7751

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
21 commits
Select commit Hold shift + click to select a range
3c1a484
Remove references to CosmosDB and make data source type a generated enum
Nov 8, 2019
5293e64
Remove named entity skill and associated models
Nov 8, 2019
b9df5f3
Expand the list of EntityRecognitionSkillLanguage
Nov 8, 2019
936cd15
Trial using opt-in-extensible-enums
Nov 8, 2019
56cebdb
Use extensible enum for language
Nov 8, 2019
7bfeb99
Use extensible enum for TokenizerName
Nov 9, 2019
79f0d50
Use extensible enum for TokenFilterName
Nov 9, 2019
1597770
Use extensible enum for CharFilterName
Nov 9, 2019
69e2e1c
Use extensible enum for RegexFlags
Nov 9, 2019
8aa6af7
Fix missing bool setting
Nov 9, 2019
771bd10
Remove RegexFlags
Nov 9, 2019
476441a
Add description for language properties
Nov 9, 2019
bec70ec
Add URL to description
Nov 10, 2019
46926ab
Apply x-ms-enum fixes to 2019-05-06 'track2' swagger
Nov 10, 2019
3c90c78
Fix model validation spelling errors
Nov 11, 2019
721a464
Actually fix model validation spelling errors via custom-words.txt
Nov 11, 2019
3213773
Opt-in extensible enums globally
Nov 11, 2019
f1afff8
Model failing validation enums as string (still customized in SDK side)
Nov 11, 2019
9288ae3
Remove the example in swagger specs that cause validation error for d…
Nov 11, 2019
1552e32
Remove NamedEntityRecognitionSkill from the yet to ship 'track2' SDK …
Nov 11, 2019
c6ba7fd
Fix swapping of name and description
Nov 12, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions custom-words.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -718,6 +718,7 @@ keyvaultproperties
keyvaulturi
keyversion
KHTML
Kiswahili
Knowledgebase
knowledgebases
koelner
Expand Down Expand Up @@ -988,6 +989,7 @@ osdiskforlinuxsimple
osdiskforwindowssimple
OSMAM
OSNIC
Otomi
outputdirectoryid
overprovision
overprovisioned
Expand Down Expand Up @@ -1097,6 +1099,7 @@ qnormal
querylogs
querypool
querystring
Queretaro
queueservices
quickbooks
quicktest
Expand Down Expand Up @@ -1645,6 +1648,7 @@ XBing
Xeon
Xero
XSMB
Yucatec
Ywhk
YYMMDD
Zabbix
Expand Down
1 change: 1 addition & 0 deletions specification/search/data-plane/Microsoft.Azure.Search.Data/readme.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,6 +114,7 @@ These settings apply only when `--tag=track1-package-2019-05-preview` is specifi
It is meant to be used for generating Track 1 .NET SDK only!

``` yaml $(tag) == 'track1-package-2019-05-preview'
opt-in-extensible-enums: true
input-file:
- track1/preview/2019-05-06-preview/searchindex.json
```
Expand Down
1 change: 1 addition & 0 deletions specification/search/data-plane/Microsoft.Azure.Search.Service/readme.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@ To see additional help and options, run:
These are the global settings for SearchServiceClient.

``` yaml
opt-in-extensible-enums: true
openapi-type: data-plane
tag: package-2019-05
```
Expand Down
13 changes: 0 additions & 13 deletions ...crosoft.Azure.Search.Service/stable/2019-05-06/examples/SearchServiceListDataSources.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,19 +29,6 @@
"softDeleteColumnName": "isDeleted",
"softDeleteMarkerValue": "true"
}
},
{
"name": "myblobdatasource",
"description": "My Azure Blob data source.",
"type": "azureblob",
"credentials": {
"connectionString": null
},
"container": {
"name": "mycontainer"
},
"dataChangeDetectionPolicy": null,
"dataDeletionDetectionPolicy": null
}
]
}
Expand Down
997 changes: 926 additions & 71 deletions ...ion/search/data-plane/Microsoft.Azure.Search.Service/stable/2019-05-06/searchservice.json
View file
Open in desktop

Large diffs are not rendered by default.

13 changes: 0 additions & 13 deletions ...arch.Service/track1/preview/2019-05-06-preview/examples/SearchServiceListDataSources.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,19 +29,6 @@
"softDeleteColumnName": "isDeleted",
"softDeleteMarkerValue": "true"
}
},
{
"name": "myblobdatasource",
"description": "My Azure Blob data source.",
"type": "azureblob",
"credentials": {
"connectionString": null
},
"container": {
"name": "mycontainer"
},
"dataChangeDetectionPolicy": null,
"dataDeletionDetectionPolicy": null
}
]
}
Expand Down
Loading