Skip to content

Comments

[Azure Search] General fixes to swagger#7751

Merged
sarangan12 merged 21 commits intoAzure:masterfrom
arv100kri:arv100kri/remove-obsolete
Nov 12, 2019
Merged

[Azure Search] General fixes to swagger#7751
sarangan12 merged 21 commits intoAzure:masterfrom
arv100kri:arv100kri/remove-obsolete

Conversation

@arv100kri
Copy link
Member

@arv100kri arv100kri commented Nov 10, 2019 •
edited
Loading

  1. Start using extensible enums where ever we don't need customizations. This is applied in both "track2" GA swagger (which has not shipped ever) and "track1" preview swagger (which we plan on shipping in December)
    • Also use it for those types that have customizations in the SDK repo (AnalyzerName, DataType, RegexFlags), so that model validation doesn't fail
  2. Remove NER skill from "track1" preview swagger as it was obsolete. It's also removed from the un-shippped "track2" "stable" swagger.
  3. To EntityRecognitionSkillLanguage add new languages that are supported (after making it an extensible enum as well)

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

  • I have reviewed the documentation for the workflow.
  • Validation tools were run on swagger spec(s) and have all been fixed in this PR.
  • The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

  • Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
  • adding/removing APIs.
  • adding/removing properties.
  • adding/removing API-version.
  • adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

  • If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
    Please follow the link to find more details on API review process.

@AutorestCI
Copy link

AutorestCI commented Nov 10, 2019 •
edited
Loading

Automation for azure-sdk-for-go

Nothing to generate for azure-sdk-for-go

@AutorestCI
Copy link

AutorestCI commented Nov 10, 2019 •
edited
Loading

Automation for azure-sdk-for-python

Nothing to generate for azure-sdk-for-python

@azuresdkci
Copy link
Contributor

azuresdkci commented Nov 10, 2019

Can one of the admins verify this patch?

brjohnstmsft
brjohnstmsft approved these changes Nov 11, 2019
View reviewed changes
Copy link
Member

@brjohnstmsft brjohnstmsft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Had some questions; Nothing blocking

@arv100kri arv100kri marked this pull request as ready for review November 11, 2019 19:57
@arv100kri arv100kri requested a review from bleroy November 11, 2019 20:12
@arv100kri
Copy link
Member Author

arv100kri commented Nov 11, 2019 •
edited
Loading

Note: Both the swaggers in this PR have not yet shipped.
track1 "preview" swagger is planned to be shipped in December.
track2 "stable" (i.e., the swagger that's not in the track1 directory structure) is planned for release next year...

@arv100kri arv100kri mentioned this pull request Nov 11, 2019
Merged
@sarangan12 sarangan12 merged commit 9e6ef73 into Azure:master Nov 12, 2019
solhaile pushed a commit to solhaile/azure-rest-api-specs that referenced this pull request Nov 13, 2019
@arv100kri
[Azure Search] General fixes to swagger (Azure#7751)
947b3b3 
* Remove references to CosmosDB and make data source type a generated enum

* Remove named entity skill and associated models

* Expand the list of EntityRecognitionSkillLanguage

* Trial using opt-in-extensible-enums

* Use extensible enum for language

* Use extensible enum for TokenizerName

* Use extensible enum for TokenFilterName

* Use extensible enum for CharFilterName

* Use extensible enum for RegexFlags

* Fix missing bool setting

* Remove RegexFlags

* Add description for language properties

* Add URL to description

* Apply x-ms-enum fixes to 2019-05-06 'track2' swagger

* Fix model validation spelling errors

* Actually fix model validation spelling errors via custom-words.txt

* Opt-in extensible enums globally

* Model failing validation enums as string (still customized in SDK side)

* Remove the example in swagger specs that cause validation error for data sources

* Remove NamedEntityRecognitionSkill from the yet to ship 'track2' SDK version of swagger

* Fix swapping of name and description
TalluriAnusha pushed a commit to AsrOneSdk/azure-rest-api-specs that referenced this pull request Dec 11, 2019
@arv100kri @AnuTalluri
[Azure Search] General fixes to swagger (Azure#7751)
da7b97c 
* Remove references to CosmosDB and make data source type a generated enum

* Remove named entity skill and associated models

* Expand the list of EntityRecognitionSkillLanguage

* Trial using opt-in-extensible-enums

* Use extensible enum for language

* Use extensible enum for TokenizerName

* Use extensible enum for TokenFilterName

* Use extensible enum for CharFilterName

* Use extensible enum for RegexFlags

* Fix missing bool setting

* Remove RegexFlags

* Add description for language properties

* Add URL to description

* Apply x-ms-enum fixes to 2019-05-06 'track2' swagger

* Fix model validation spelling errors

* Actually fix model validation spelling errors via custom-words.txt

* Opt-in extensible enums globally

* Model failing validation enums as string (still customized in SDK side)

* Remove the example in swagger specs that cause validation error for data sources

* Remove NamedEntityRecognitionSkill from the yet to ship 'track2' SDK version of swagger

* Fix swapping of name and description
@navalev navalev mentioned this pull request Feb 2, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

3 more reviewers

@sarangan12 sarangan12 sarangan12 approved these changes

@bleroy bleroy bleroy approved these changes

@brjohnstmsft brjohnstmsft brjohnstmsft approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@sarangan12 sarangan12

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@arv100kri @AutorestCI @azuresdkci @sarangan12 @bleroy @brjohnstmsft