Skip to content

Comments

Dev ApplicationInsights microsoft.insights 2019#7539

Merged
erich-wang merged 1 commit intoAzure:masterfrom
arolshan:dev-applicationinsights-Microsoft.Insights-2019
Dec 6, 2019
Merged

Dev ApplicationInsights microsoft.insights 2019#7539
erich-wang merged 1 commit intoAzure:masterfrom
arolshan:dev-applicationinsights-Microsoft.Insights-2019

Conversation

@arolshan
Copy link
Contributor

@arolshan arolshan commented Oct 17, 2019

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

  • I have reviewed the documentation for the workflow.
  • Validation tools were run on swagger spec(s) and have all been fixed in this PR.
  • The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

  • Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
  • adding/removing APIs.
  • adding/removing properties.
  • adding/removing API-version.
  • adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

  • If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
    Please follow the link to find more details on API review process.

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Oct 17, 2019

azure-sdk-for-go - Release

️✔️ succeeded [Logs] [Expand Details]
  • ️✔️ Generate from c839daa with merge commit 9310dd0. SDK Automation 13.0.17
    Failed to close the generation pull request at https://github.com/AzureSDKAutomation/azure-sdk-for-go/pull/952: HttpError: Reference does not exist, {"name":"HttpError","status":422,"headers":{"access-control-allow-origin":"*","access-control-expose-headers":"ETag, Link, Location, Retry-After, X-GitHub-OTP, X-RateLimit-Limit, X-RateLimit-Remaining, X-RateLimit-Reset, X-OAuth-Scopes, X-Accepted-OAuth-Scopes, X-Poll-Interval, X-GitHub-Media-Type","connection":"close","content-length":"121","content-security-policy":"default-src 'none'","content-type":"application/json; charset=utf-8","date":"Fri, 06 Dec 2019 02:29:35 GMT","referrer-policy":"origin-when-cross-origin, strict-origin-when-cross-origin","server":"GitHub.com","status":"422 Unprocessable Entity","strict-transport-security":"max-age=31536000; includeSubdomains; preload","x-content-type-options":"nosniff","x-frame-options":"deny","x-github-media-type":"github.machine-man-preview; format=json","x-github-request-id":"07C3:6EF3:4400D97:8C2FB06:5DE9BD0F","x-ratelimit-limit":"12500","x-ratelimit-remaining":"12357","x-ratelimit-reset":"1575602321","x-xss-protection":"1; mode=block"},"request":{"method":"DELETE","url":"https://api.github.com/repos/Azure/azure-sdk-for-go/git/refs/heads/sdkAutomationProdTest/appinsights/mgmt/2015-05-01@7539","headers":{"accept":"application/vnd.github.machine-man-preview+json","user-agent":"octokit.js/16.35.0 Node.js/10.17.0 (Linux 5.0; x64)","authorization":"token [REDACTED]","content-length":0},"request":{"validate":{"owner":{"required":true,"type":"string"},"ref":{"required":true,"type":"string"},"repo":{"required":true,"type":"string"}}}},"documentation_url":"https://developer.github.com/v3/git/refs/#delete-a-reference"}
  • ️✔️appinsights/mgmt/2015-05-01 [Logs]  [Release SDK Changes]

@AutorestCI
Copy link

AutorestCI commented Oct 17, 2019

Automation for azure-sdk-for-python

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-python#9020

@AutorestCI
Copy link

AutorestCI commented Oct 17, 2019

Automation for azure-sdk-for-go

A PR has been created for you:
Azure/azure-sdk-for-go#6073

@azuresdkci
Copy link
Contributor

Can one of the admins verify this patch?

Copy link
Contributor

@KrisBash KrisBash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Quite a few blocking issues in this PR. Please review comments and ARM documentation

@arolshan arolshan force-pushed the dev-applicationinsights-Microsoft.Insights-2019 branch from c449ce6 to c839daa Compare December 5, 2019 19:49
@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Dec 5, 2019

azure-sdk-for-js - Release

️✔️ succeeded [Logs] [Expand Details]
  • ️✔️ Generate from c839daa with merge commit 9310dd0. SDK Automation 13.0.17
  • ️✔️@azure/arm-appinsights [Logs]  [Release SDK Changes]
    [npmPack] loaded rollup.config.js with warnings
    [npmPack] (!) Unused external imports
    [npmPack] default imported from external module 'rollup' but never used
    [npmPack] 
    [npmPack] ./esm/applicationInsightsManagementClient.js → ./dist/arm-appinsights.js...
    [npmPack] created ./dist/arm-appinsights.js in 531ms

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Dec 5, 2019

azure-sdk-for-python - Release

️✔️ succeeded [Logs] [Expand Details]
  • ️✔️ Generate from c839daa with merge commit 9310dd0. SDK Automation 13.0.17
  • ️✔️azure-mgmt-applicationinsights [Logs]  [Release SDK Changes]
    [build_package] /usr/lib/python3.6/distutils/dist.py:261: UserWarning: Unknown distribution option: 'long_description_content_type'
    [build_package]   warnings.warn(msg)
    [build_package] warning: no files found matching '*.py' under directory 'tests'
    [build_package] warning: no files found matching '*.yaml' under directory 'tests'
    [build_package] /usr/lib/python3.6/distutils/dist.py:261: UserWarning: Unknown distribution option: 'long_description_content_type'
    [build_package]   warnings.warn(msg)
    [build_package] warning: no files found matching '*.py' under directory 'tests'
    [build_package] warning: no files found matching '*.yaml' under directory 'tests'

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Dec 5, 2019

azure-sdk-for-net - Release

️✔️ succeeded [Logs] [Expand Details]
  • ️✔️ Generate from c839daa with merge commit 9310dd0. SDK Automation 13.0.17
    [AutoRest] realpath(): Permission denied
    [AutoRest] realpath(): Permission denied
    [AutoRest] realpath(): Permission denied
    [AutoRest] realpath(): Permission denied
    [AutoRest] realpath(): Permission denied
    [AutoRest] realpath(): Permission denied
  • ️✔️Microsoft.Azure.ApplicationInsights [Logs]  [Release SDK Changes]
      No Artifact Generated.

    @openapi-sdkautomation
    Copy link

    openapi-sdkautomation bot commented Dec 5, 2019

    azure-sdk-for-java - Release

    ️✔️ succeeded [Logs] [Expand Details]

    Copy link
    Contributor

    @KrisBash KrisBash left a comment

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    Discussed GET->PUT pipeline in office hours. Signing off

    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

    Labels

    ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review

    Projects

    None yet

    Development

    Successfully merging this pull request may close these issues.

    5 participants