Skip to content

Comments

[Hub Generated] Review request for Microsoft.Insights to add version stable/2015-05-01#7455

Closed
arolshan wants to merge 7 commits intoAzure:masterfrom
arolshan:dev-applicationinsights-Microsoft.Insights-2015-05-01
Closed

[Hub Generated] Review request for Microsoft.Insights to add version stable/2015-05-01#7455
arolshan wants to merge 7 commits intoAzure:masterfrom
arolshan:dev-applicationinsights-Microsoft.Insights-2015-05-01

Conversation

@arolshan
Copy link
Contributor

@arolshan arolshan commented Oct 10, 2019 •
edited
Loading

If you are a MSFT employee you can view your work branch via this link.

Contribution checklist:

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Oct 10, 2019 •
edited
Loading

In Testing, Please Ignore

[Logs] (Generated from e7a9b8d, Iteration 6)

Failed .NET: test-repo-billy/azure-sdk-for-net [Logs] [Diff]
Succeeded Python: test-repo-billy/azure-sdk-for-python [Logs] [Diff]
Failed Java: test-repo-billy/azure-sdk-for-java [Logs] [Diff]
  • Failed applicationinsights/resource-manager/v2015_05_01 [Logs]
Succeeded Go: test-repo-billy/azure-sdk-for-go [Logs] [Diff]
In-Progress JavaScript: test-repo-billy/azure-sdk-for-js [Logs]
  • Package generation in progress.

@AutorestCI AutorestCI mentioned this pull request Oct 10, 2019
Closed
@AutorestCI
Copy link

AutorestCI commented Oct 10, 2019 •
edited
Loading

Automation for azure-sdk-for-python

Encountered an unknown error: (azure-sdk-for-python)

Traceback (most recent call last):
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 33, in exception_to_github
    yield context
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github.py", line 170, in rest_handle_action
    return rest_pull_close(body, restapi_repo, sdk_pr_target_repo, sdkbase, sdk_tag)
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github.py", line 185, in rest_pull_close
    rest_pr_management(rest_pr, sdk_pr_target_repo, sdk_tag, sdk_default_base)
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github_handler.py", line 151, in rest_pr_management
    sdk_tag=sdk_tag
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/SwaggerToSdkNewCLI.py", line 254, in generate_sdk_from_git_object
    with manage_git_folder(gh_token, Path(temp_dir) / Path("rest"), branched_rest_api_id, pr_number=pr_number) as restapi_git_folder, \
  File "/usr/lib/python3.6/contextlib.py", line 81, in __enter__
    return next(self.gen)
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 272, in manage_git_folder
    clone_to_path(gh_token, temp_dir, split_git_id[0], branch_or_commit=branch, pr_number=pr_number)
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 212, in clone_to_path
    repo.git.checkout(branch_or_commit)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 548, in <lambda>
    return lambda *args, **kwargs: self._call_process(name, *args, **kwargs)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 1014, in _call_process
    return self.execute(call, **exec_kwargs)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 825, in execute
    raise GitCommandError(command, status, stderr_value, stdout_value)
git.exc.GitCommandError: Cmd('git') failed due to: exit code(128)
  cmdline: git checkout 2e571c6dd8238e32dde744c53e98f46874b7f99e
  stderr: 'fatal: reference is not a tree: 2e571c6dd8238e32dde744c53e98f46874b7f99e'

@AutorestCI
Copy link

AutorestCI commented Oct 10, 2019 •
edited
Loading

Automation for azure-sdk-for-go

Encountered an unknown error: (azure-sdk-for-go)

Traceback (most recent call last):
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 33, in exception_to_github
    yield context
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github.py", line 170, in rest_handle_action
    return rest_pull_close(body, restapi_repo, sdk_pr_target_repo, sdkbase, sdk_tag)
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github.py", line 185, in rest_pull_close
    rest_pr_management(rest_pr, sdk_pr_target_repo, sdk_tag, sdk_default_base)
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github_handler.py", line 151, in rest_pr_management
    sdk_tag=sdk_tag
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/SwaggerToSdkNewCLI.py", line 254, in generate_sdk_from_git_object
    with manage_git_folder(gh_token, Path(temp_dir) / Path("rest"), branched_rest_api_id, pr_number=pr_number) as restapi_git_folder, \
  File "/usr/lib/python3.6/contextlib.py", line 81, in __enter__
    return next(self.gen)
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 272, in manage_git_folder
    clone_to_path(gh_token, temp_dir, split_git_id[0], branch_or_commit=branch, pr_number=pr_number)
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 212, in clone_to_path
    repo.git.checkout(branch_or_commit)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 548, in <lambda>
    return lambda *args, **kwargs: self._call_process(name, *args, **kwargs)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 1014, in _call_process
    return self.execute(call, **exec_kwargs)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 825, in execute
    raise GitCommandError(command, status, stderr_value, stdout_value)
git.exc.GitCommandError: Cmd('git') failed due to: exit code(128)
  cmdline: git checkout 2e571c6dd8238e32dde744c53e98f46874b7f99e
  stderr: 'fatal: reference is not a tree: 2e571c6dd8238e32dde744c53e98f46874b7f99e'

@AutorestCI AutorestCI mentioned this pull request Oct 10, 2019
Closed
This was referenced Oct 10, 2019
Closed
Closed
@azuresdkci
Copy link
Contributor

azuresdkci commented Oct 10, 2019

Can one of the admins verify this patch?

@ArcturusZhang ArcturusZhang added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Oct 11, 2019
@ArcturusZhang
Copy link
Member

ArcturusZhang commented Oct 11, 2019

Looks good to me, please wait for ARM team's response

@arolshan arolshan requested a review from yoramsinger October 16, 2019 10:37
@AutorestCI AutorestCI mentioned this pull request Oct 16, 2019
Closed
KrisBash
KrisBash suggested changes Oct 16, 2019
View reviewed changes
Copy link
Contributor

@KrisBash KrisBash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see comment

...pplicationinsights/resource-manager/Microsoft.Insights/stable/2015-05-01/components_API.json Outdated
"url": "https://aka.ms/sl0yqd"
}
},
"RetentionInDays": {
Copy link
Contributor

@KrisBash KrisBash Oct 16, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding a writeable property within an API version is considered a breaking change. Why is this not going in a new version?

Copy link
Contributor Author

@arolshan arolshan Oct 17, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Kris
please refer to my update PR. Created new one with suitable name.

#7539

@arolshan
Copy link
Contributor Author

arolshan commented Oct 16, 2019 via email

@arolshan
Copy link
Contributor Author

arolshan commented Oct 16, 2019 via email

@arolshan
Copy link
Contributor Author

arolshan commented Oct 16, 2019 via email

@arolshan arolshan closed this Oct 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ArcturusZhang ArcturusZhang Awaiting requested review from ArcturusZhang

@yoramsinger yoramsinger Awaiting requested review from yoramsinger

1 more reviewer

@KrisBash KrisBash KrisBash requested changes

Reviewers whose approvals may not affect merge requirements

Assignees

@ArcturusZhang ArcturusZhang

Labels

WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@arolshan @AutorestCI @azuresdkci @ArcturusZhang @KrisBash @yoramsinger