Skip to content

Minor Bug Fix in List api #7446

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lirenhe merged 12 commits into from
Oct 17, 2019
Merged

Minor Bug Fix in List api #7446

Changes from all commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
bf0926c
Add swagger specs for VirtualHubRouteTableV2
nagula-ritvika Oct 3, 2019
72c4811
fix errors
nagula-ritvika Oct 4, 2019
847a7c3
address PR comments
nagula-ritvika Oct 4, 2019
42fd243
minor changes
nagula-ritvika Oct 4, 2019
bcbe950
added tags for RTV2 Put op
nagula-ritvika Oct 4, 2019
e4c9497
added Wan type and Hub Sku
nagula-ritvika Oct 4, 2019
302692e
added type of resource in RtV2 ops examples
nagula-ritvika Oct 4, 2019
61abcde
fixed failures
nagula-ritvika Oct 4, 2019
acdceff
removing tags from example
nagula-ritvika Oct 4, 2019
cff1642
Merge branch 'network-october-release' of https://github.com/Azure/az…
nagula-ritvika Oct 8, 2019
db6ad6e
Merge branch 'network-october-release' of https://github.com/Azure/az…
nagula-ritvika Oct 10, 2019
f4fe3fe
minor fix
nagula-ritvika Oct 10, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 17 additions & 1 deletion specification/network/resource-manager/Microsoft.Network/stable/2019-09-01/virtualWan.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3122,7 +3122,7 @@
"200": {
"description": "Request successful. Returns the details of all the VirtualHubRouteTableV2s for the VirtualHub.",
"schema": {
"$ref": "#/definitions/ListHubVirtualNetworkConnectionsResult"
"$ref": "#/definitions/ListVirtualHubRouteTableV2sResult"

@lirenhe lirenhe Oct 10, 2019 •
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As you change the schema of the result, is this part of the effort to fix the problem in swagger spec?

@nagula-ritvika nagula-ritvika Oct 10, 2019

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, i just added the api yesterday and this did not catch my attention, so this commit is fixing the error.

}
},
"default": {
Expand Down Expand Up @@ -4542,6 +4542,22 @@
}
},
"description": "VirtualHubRouteTableV2 route."
},
"ListVirtualHubRouteTableV2sResult": {
"description": "List of VirtualHubRouteTableV2s and a URL nextLink to get the next set of results.",
"properties": {
"value": {
"type": "array",
"items": {
"$ref": "#/definitions/VirtualHubRouteTableV2"
},
"description": "List of VirtualHubRouteTableV2s."
},
"nextLink": {
"type": "string",
"description": "URL to get the next set of operation list results if there are any."
}
}
}
}
}