Minor Bug Fix in List api #7446
Merged
lirenhe merged 12 commits intoAzure:network-october-releasefrom Oct 17, 2019
Merged
Conversation
…ure-rest-api-specs into network-october-release
…ure-rest-api-specs into network-october-release
Automation for azure-sdk-for-pythonEncountered a Subprocess error: (azure-sdk-for-python)
Command: ['/usr/local/bin/autorest', '/tmp/tmpj659gqij/rest/specification/network/resource-manager/readme.md', '--keep-version-file', '--multiapi', '--no-async', '--python', '--python-mode=update', '--python-sdks-folder=/tmp/tmpj659gqij/sdk/sdk', '--use=@microsoft.azure/autorest.python@4.0.70', '--version=preview'] AutoRest code generation utility [version: 2.0.4283; node: v10.15.3]
(C) 2018 Microsoft Corporation.
https://aka.ms/autorest
Loading AutoRest core '/root/.autorest/@microsoft.azure_autorest-core@2.0.4405/node_modules/@microsoft.azure/autorest-core/dist' (2.0.4405)
Loading AutoRest extension '@microsoft.azure/autorest.python' (4.0.70->4.0.70)
Loading AutoRest extension '@microsoft.azure/autorest.modeler' (2.3.44->2.3.44)
Processing batch task - {"tag":"package-2019-09"} .
<--- Last few GCs --->
[7575:0x352fcc0] 107040 ms: Mark-sweep 1377.4 (1425.1) -> 1377.1 (1425.6) MB, 1487.6 / 0.0 ms (average mu = 0.114, current mu = 0.006) allocation failure scavenge might not succeed
[7575:0x352fcc0] 108682 ms: Mark-sweep 1378.0 (1425.6) -> 1377.7 (1426.1) MB, 1638.8 / 0.0 ms (average mu = 0.058, current mu = 0.002) allocation failure scavenge might not succeed
<--- JS stacktrace --->
==== JS stack trace =========================================
0: ExitFrame [pc: 0x3f8d275be1d]
Security context: 0x37dfff91e6e9 <JSObject>
1: ParseNodeInternal(aka ParseNodeInternal) [0x1f50904299] [/root/.autorest/@microsoft.azure_autorest-core@2.0.4405/node_modules/@microsoft.azure/autorest-core/dist/lib/ref/yaml.js:~86] [pc=0x3f8d2bbc861](this=0x04be730826f1 <undefined>,yamlRootNode=0x1667e4eb2949 <Object map = 0x87211145961>,yamlNode=0x1ed2311fa6f9 <Object map = 0x1d30550ee311>,onError=0...
FATAL ERROR: Ineffective mark-compacts near heap limit Allocation failed - JavaScript heap out of memory
1: 0x8dc510 node::Abort() [node]
2: 0x8dc55c [node]
3: 0xad9b5e v8::Utils::ReportOOMFailure(v8::internal::Isolate*, char const*, bool) [node]
4: 0xad9d94 v8::internal::V8::FatalProcessOutOfMemory(v8::internal::Isolate*, char const*, bool) [node]
5: 0xec7bf2 [node]
6: 0xec7cf8 v8::internal::Heap::CheckIneffectiveMarkCompact(unsigned long, double) [node]
7: 0xed3dd2 v8::internal::Heap::PerformGarbageCollection(v8::internal::GarbageCollector, v8::GCCallbackFlags) [node]
8: 0xed4704 v8::internal::Heap::CollectGarbage(v8::internal::AllocationSpace, v8::internal::GarbageCollectionReason, v8::GCCallbackFlags) [node]
9: 0xed7371 v8::internal::Heap::AllocateRawWithRetryOrFail(int, v8::internal::AllocationSpace, v8::internal::AllocationAlignment) [node]
10: 0xea07f4 v8::internal::Factory::NewFillerObject(int, bool, v8::internal::AllocationSpace) [node]
11: 0x114018e v8::internal::Runtime_AllocateInNewSpace(int, v8::internal::Object**, v8::internal::Isolate*) [node]
12: 0x3f8d275be1d |
Contributor
|
Can one of the admins verify this patch? |
Automation for azure-sdk-for-goA PR has been created for you: |
lirenhe
reviewed
Oct 10, 2019
| "description": "Request successful. Returns the details of all the VirtualHubRouteTableV2s for the VirtualHub.", | ||
| "schema": { | ||
| "$ref": "#/definitions/ListHubVirtualNetworkConnectionsResult" | ||
| "$ref": "#/definitions/ListVirtualHubRouteTableV2sResult" |
Member
There was a problem hiding this comment.
As you change the schema of the result, is this part of the effort to fix the problem in swagger spec?
Contributor
Author
There was a problem hiding this comment.
Yes, i just added the api yesterday and this did not catch my attention, so this commit is fixing the error.
anton-evseev
approved these changes
Oct 10, 2019
lirenhe
approved these changes
Oct 11, 2019
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Latest improvements:
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
Contribution checklist:
ARM API Review Checklist
Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.
Please follow the link to find more details on API review process.