Skip to content

some fixes for frontdoor readme #7424

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
yungezz merged 11 commits into from
Oct 9, 2019
Merged

some fixes for frontdoor readme #7424

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
75e3711
updated frontdoor readme
Oct 8, 2019
a933aa3
fixed invalid values
Oct 8, 2019
790a72e
fixing examples etc
Oct 8, 2019
d150a7b
further updates
Oct 8, 2019
7e50ace
fixed Enabled / Disabled
Oct 8, 2019
07eb2cb
removed readme.cli checked in by mistake
Oct 8, 2019
568318d
renamed ResourceState -> NetworkExperimenationResourceState
Oct 8, 2019
e5fa469
renamed aggregation intervals
Oct 8, 2019
729f342
Updated timeseriesType
Oct 9, 2019
9630e7a
scorecard -> scoreboard
Oct 9, 2019
3a7dbc7
network experiment resource state
Oct 9, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions ...nager/Microsoft.Network/stable/2019-11-01/examples/NetworkExperimentCreateExperiment.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@
"name": "endpoint B",
"endpoint": "endpointB.net"
},
"enabledState": "enabled"
"enabledState": "Enabled"
}
}
},
Expand All @@ -40,8 +40,8 @@
"name": "endpoint B",
"endpoint": "endpointB.net"
},
"enabledState": "enabled",
"resourceState": "creating",
"enabledState": "Enabled",
"resourceState": "Creating",
"status": "ongoing",
"scriptFileUri": "www.myScript.com"
}
Expand All @@ -66,8 +66,8 @@
"name": "endpoint B",
"endpoint": "endpointB.net"
},
"enabledState": "enabled",
"resourceState": "creating",
"enabledState": "Enabled",
"resourceState": "Creating",
"status": "ongoing",
"scriptFileUri": "www.myScript.com"
}
Expand All @@ -92,8 +92,8 @@
"name": "endpoint B",
"endpoint": "endpointB.net"
},
"enabledState": "enabled",
"resourceState": "creating",
"enabledState": "Enabled",
"resourceState": "Creating",
"status": "ongoing",
"scriptFileUri": "www.myScript.com"
}
Expand Down
14 changes: 7 additions & 7 deletions ...-manager/Microsoft.Network/stable/2019-11-01/examples/NetworkExperimentCreateProfile.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
"profileName": "Profile1",
"parameters": {
"properties": {
"enabledState": "enabled"
"enabledState": "Enabled"
}
}
},
Expand All @@ -22,8 +22,8 @@
},
"location": "WestUs",
"properties": {
"enabledState": "enabled",
"resourceState": "creating"
"enabledState": "Enabled",
"resourceState": "Creating"
}
}
},
Expand All @@ -38,8 +38,8 @@
},
"location": "WestUs",
"properties": {
"enabledState": "enabled",
"resourceState": "creating"
"enabledState": "Enabled",
"resourceState": "Creating"
}
}
},
Expand All @@ -54,8 +54,8 @@
},
"location": "WestUs",
"properties": {
"enabledState": "enabled",
"resourceState": "creating"
"enabledState": "Enabled",
"resourceState": "Creating"
}
}
}
Expand Down
4 changes: 2 additions & 2 deletions ...-manager/Microsoft.Network/stable/2019-11-01/examples/NetworkExperimentGetExperiment.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,8 +26,8 @@
"name": "endpoint B",
"endpoint": "endpointB.net"
},
"enabledState": "enabled",
"resourceState": "creating",
"enabledState": "Enabled",
"resourceState": "Creating",
"status": "ongoing",
"scriptFileUri": "www.myScript.com"
}
Expand Down
4 changes: 2 additions & 2 deletions ...rce-manager/Microsoft.Network/stable/2019-11-01/examples/NetworkExperimentGetProfile.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,8 +16,8 @@
},
"location": "WestUs",
"properties": {
"enabledState": "enabled",
"resourceState": "creating"
"enabledState": "Enabled",
"resourceState": "Creating"
}
}
}
Expand Down
4 changes: 2 additions & 2 deletions ...anager/Microsoft.Network/stable/2019-11-01/examples/NetworkExperimentListExperiments.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,8 +22,8 @@
"name": "endpoint B",
"endpoint": "endpointB.net"
},
"enabledState": "enabled",
"resourceState": "creating",
"enabledState": "Enabled",
"resourceState": "Creating",
"status": "ongoing",
"scriptFileUri": "www.myScript.com"
}
Expand Down
4 changes: 2 additions & 2 deletions ...e-manager/Microsoft.Network/stable/2019-11-01/examples/NetworkExperimentListProfiles.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,8 +18,8 @@
},
"location": "WestUs",
"properties": {
"enabledState": "enabled",
"resourceState": "creating"
"enabledState": "Enabled",
"resourceState": "Creating"
}
}
]
Expand Down
10 changes: 5 additions & 5 deletions ...nager/Microsoft.Network/stable/2019-11-01/examples/NetworkExperimentUpdateExperiment.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
"parameters": {
"properties": {
"description": "string",
"enabledState": "enabled"
"enabledState": "Enabled"
}
}
},
Expand All @@ -33,8 +33,8 @@
"name": "endpoint B",
"endpoint": "endpointB.net"
},
"enabledState": "enabled",
"resourceState": "creating",
"enabledState": "Enabled",
"resourceState": "Creating",
"status": "ongoing",
"scriptFileUri": "www.myScript.com"
}
Expand All @@ -60,8 +60,8 @@
"name": "endpoint B",
"endpoint": "endpointB.net"
},
"enabledState": "enabled",
"resourceState": "creating",
"enabledState": "Enabled",
"resourceState": "Creating",
"status": "ongoing",
"scriptFileUri": "www.myScript.com"
}
Expand Down
10 changes: 5 additions & 5 deletions ...-manager/Microsoft.Network/stable/2019-11-01/examples/NetworkExperimentUpdateProfile.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
"profileName": "Profile1",
"parameters": {
"properties": {
"enabledState": "enabled"
"enabledState": "Enabled"
},
"tags": {
"key1": "value1",
Expand All @@ -26,8 +26,8 @@
},
"location": "WestUs",
"properties": {
"enabledState": "enabled",
"resourceState": "creating"
"enabledState": "Enabled",
"resourceState": "Creating"
}
}
},
Expand All @@ -42,8 +42,8 @@
},
"location": "WestUs",
"properties": {
"enabledState": "enabled",
"resourceState": "creating"
"enabledState": "Enabled",
"resourceState": "Creating"
}
}
}
Expand Down
54 changes: 29 additions & 25 deletions ...ion/frontdoor/resource-manager/Microsoft.Network/stable/2019-11-01/networkexperiment.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -726,7 +726,7 @@
"Monthly"
],
"x-ms-enum": {
"name": "aggregationInterval",
"name": "latencyScorecardAggregationInterval",
"modelAsString": true
},
"required": true
Expand Down Expand Up @@ -805,7 +805,7 @@
"Daily"
],
"x-ms-enum": {
"name": "aggregationInterval",
"name": "timeseriesAggregationInterval",
"modelAsString": true
},
"required": true
Expand All @@ -817,10 +817,12 @@
"description": "The type of Timeseries",
"enum": [
"MeasurementCounts",
"LatencyP50"
"LatencyP50",
"LatencyP75",
"LatencyP95"
],
"x-ms-enum": {
"name": "timeseriesTypes",
"name": "timeseriesType",
"modelAsString": true
},
"required": true
Expand Down Expand Up @@ -868,14 +870,14 @@
"properties": {
"resourceState": {
"description": "Resource status.",
"$ref": "#/definitions/ResourceState"
"$ref": "#/definitions/NetworkExperimentResourceState"
},
"enabledState": {
"type": "string",
"description": "The state of the Experiment",
"enum": [
"enabled",
"disabled"
"Enabled",
"Disabled"
],
"x-ms-enum": {
"name": "state",
Expand Down Expand Up @@ -946,8 +948,8 @@
"type": "string",
"description": "The enabled state of the Profile",
"enum": [
"enabled",
"disabled"
"Enabled",
"Disabled"
],
"x-ms-enum": {
"name": "state",
Expand Down Expand Up @@ -986,8 +988,8 @@
"type": "string",
"description": "The state of the Experiment",
"enum": [
"enabled",
"disabled"
"Enabled",
"Disabled"
],
"x-ms-enum": {
"name": "state",
Expand Down Expand Up @@ -1034,8 +1036,8 @@
"type": "string",
"description": "The state of the Experiment",
"enum": [
"enabled",
"disabled"
"Enabled",
"Disabled"
],
"x-ms-enum": {
"name": "state",
Expand All @@ -1044,7 +1046,7 @@
},
"resourceState": {
"description": "Resource status.",
"$ref": "#/definitions/ResourceState"
"$ref": "#/definitions/NetworkExperimentResourceState"
},
"status": {
"description": "The description of Experiment status from the server side",
Expand Down Expand Up @@ -1110,20 +1112,20 @@
}
]
},
"ResourceState": {
"NetworkExperimentResourceState": {
"description": "Defines the server side resource status",
"readOnly": true,
"enum": [
"creating",
"enabling",
"enabled",
"disabling",
"disabled",
"deleting"
"Creating",
Copy link
Copy Markdown
Member

@yungezz yungezz Oct 9, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

again, breaking change

Copy link
Copy Markdown
Author

@zikalino zikalino Oct 9, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

discussed with service team, they will make sure RP is in sync (networkexperiment was not release yet)

Copy link
Copy Markdown
Contributor

@minechosoft minechosoft Oct 9, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes. it's not breaking-- we will make sure to have these changes reflected in our service.

"Enabling",
"Enabled",
"Disabling",
"Disabled",
"Deleting"
],
"type": "string",
"x-ms-enum": {
"name": "NetworkExperimentationResourceState",
"name": "NetworkExperimentResourceState",
"modelAsString": true
}
},
Expand Down Expand Up @@ -1286,10 +1288,12 @@
"description": "The type of Timeseries",
"enum": [
"MeasurementCounts",
"LatencyP50"
],
"LatencyP50",
"LatencyP75",
"LatencyP95"
],
"x-ms-enum": {
"name": "timeseriesTypes",
"name": "timeseriesType",
"modelAsString": true
}
},
Expand Down
22 changes: 12 additions & 10 deletions specification/frontdoor/resource-manager/readme.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,17 +28,18 @@ These are the global settings for the FrontDoor API.
title: FrontDoorManagementClient
description: FrontDoor Client
openapi-type: arm
tag: package-2019-10
tag: package-2019-11
Copy link
Copy Markdown
Member

@yungezz yungezz Oct 8, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is package-2019-10 released before?

Copy link
Copy Markdown
Author

@zikalino zikalino Oct 8, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no, package-2019-10 and package-2019-11 were for some reason both created just several days ago.
it anything was released using one of these tags, package would be invalid.

```

### Tag: package-2019-10
### Tag: package-2019-11

These settings apply only when `--tag=package-2019-10` is specified on the command line.
These settings apply only when `--tag=package-2019-11` is specified on the command line.

``` yaml $(tag) == 'package-2019-10'
``` yaml $(tag) == 'package-2019-11'
input-file:
- Microsoft.Network/stable/2019-11-01/network.json
- Microsoft.Network/stable/2019-11-01/networkexperiment.json
- Microsoft.Network/stable/2019-05-01/frontdoor.json
- Microsoft.Network/stable/2019-05-01/network.json
- Microsoft.Network/stable/2019-10-01/webapplicationfirewall.json
directive:
- where:
Expand All @@ -47,14 +48,15 @@ directive:
- OperationsAPIImplementation
```

### Tag: package-2019-11
### Tag: package-2019-10

These settings apply only when `--tag=package-2019-11` is specified on the command line.
These settings apply only when `--tag=package-2019-10` is specified on the command line.

``` yaml $(tag) == 'package-2019-11'
``` yaml $(tag) == 'package-2019-10'
input-file:
- Microsoft.Network/stable/2019-11-01/network.json
- Microsoft.Network/stable/2019-11-01/networkexperiment.json
- Microsoft.Network/stable/2019-05-01/frontdoor.json
- Microsoft.Network/stable/2019-05-01/network.json
- Microsoft.Network/stable/2019-10-01/webapplicationfirewall.json
directive:
- where:
- $.paths
Expand Down