Adding Pipelines RP in Microsoft.DevOps provider namespace by amaljg · Pull Request #6579 · Azure/azure-rest-api-specs

amaljg · 2019-07-10T10:30:16Z

Adding Pipelines resource in new provider namespace Microsoft.DevOps. This resource is actually a migration of existing resource Microsoft.VisualStudio/account/project. The APIs are already reviewed in the private repo - https://github.com/Azure/azure-rest-api-specs-pr/pull/788.

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

I have reviewed the documentation for the workflow.
Validation tools were run on swagger spec(s) and have all been fixed in this PR.
The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
adding/removing APIs.
adding/removing properties.
adding/removing API-version.
adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Please follow the link to find more details on API review process.

openapi-sdkautomation · 2019-07-10T10:30:18Z

SDK Automation [Logs] (Generated from 82904e8, Iteration 7)

Python: Azure/azure-sdk-for-python [Logs]

Package generation in progress.

Java: Azure/azure-sdk-for-java [Logs]

Package generation in progress.

Go: Azure/azure-sdk-for-go [Logs]

No packages generated.

JavaScript: Azure/azure-sdk-for-js [Logs]

Package generation in progress.

Ruby: Azure/azure-sdk-for-ruby [Logs]

No packages generated.

AutorestCI · 2019-07-10T10:30:57Z

Automation for azure-sdk-for-go

Encountered an unknown error: (azure-sdk-for-go)

Traceback (most recent call last):
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 33, in exception_to_github
    yield context
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github.py", line 170, in rest_handle_action
    return rest_pull_close(body, restapi_repo, sdk_pr_target_repo, sdkbase, sdk_tag)
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github.py", line 185, in rest_pull_close
    rest_pr_management(rest_pr, sdk_pr_target_repo, sdk_tag, sdk_default_base)
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github_handler.py", line 151, in rest_pr_management
    sdk_tag=sdk_tag
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/SwaggerToSdkNewCLI.py", line 254, in generate_sdk_from_git_object
    with manage_git_folder(gh_token, Path(temp_dir) / Path("rest"), branched_rest_api_id, pr_number=pr_number) as restapi_git_folder, \
  File "/usr/lib/python3.6/contextlib.py", line 81, in __enter__
    return next(self.gen)
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 272, in manage_git_folder
    clone_to_path(gh_token, temp_dir, split_git_id[0], branch_or_commit=branch, pr_number=pr_number)
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 212, in clone_to_path
    repo.git.checkout(branch_or_commit)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 548, in <lambda>
    return lambda *args, **kwargs: self._call_process(name, *args, **kwargs)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 1014, in _call_process
    return self.execute(call, **exec_kwargs)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 825, in execute
    raise GitCommandError(command, status, stderr_value, stdout_value)
git.exc.GitCommandError: Cmd('git') failed due to: exit code(128)
  cmdline: git checkout f3ef3dcfd879cbd934ec4e7ae0429bc16c791cae
  stderr: 'fatal: reference is not a tree: f3ef3dcfd879cbd934ec4e7ae0429bc16c791cae'

AutorestCI · 2019-07-10T10:31:30Z

Automation for azure-sdk-for-python

Encountered an unknown error: (azure-sdk-for-python)

Traceback (most recent call last):
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 33, in exception_to_github
    yield context
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github.py", line 170, in rest_handle_action
    return rest_pull_close(body, restapi_repo, sdk_pr_target_repo, sdkbase, sdk_tag)
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github.py", line 185, in rest_pull_close
    rest_pr_management(rest_pr, sdk_pr_target_repo, sdk_tag, sdk_default_base)
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github_handler.py", line 151, in rest_pr_management
    sdk_tag=sdk_tag
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/SwaggerToSdkNewCLI.py", line 254, in generate_sdk_from_git_object
    with manage_git_folder(gh_token, Path(temp_dir) / Path("rest"), branched_rest_api_id, pr_number=pr_number) as restapi_git_folder, \
  File "/usr/lib/python3.6/contextlib.py", line 81, in __enter__
    return next(self.gen)
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 272, in manage_git_folder
    clone_to_path(gh_token, temp_dir, split_git_id[0], branch_or_commit=branch, pr_number=pr_number)
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 212, in clone_to_path
    repo.git.checkout(branch_or_commit)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 548, in <lambda>
    return lambda *args, **kwargs: self._call_process(name, *args, **kwargs)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 1014, in _call_process
    return self.execute(call, **exec_kwargs)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 825, in execute
    raise GitCommandError(command, status, stderr_value, stdout_value)
git.exc.GitCommandError: Cmd('git') failed due to: exit code(128)
  cmdline: git checkout f3ef3dcfd879cbd934ec4e7ae0429bc16c791cae
  stderr: 'fatal: reference is not a tree: f3ef3dcfd879cbd934ec4e7ae0429bc16c791cae'

AutorestCI · 2019-07-10T10:31:58Z

Automation for azure-sdk-for-java

Encountered an unknown error: (azure-sdk-for-java)

Traceback (most recent call last):
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 33, in exception_to_github
    yield context
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github.py", line 170, in rest_handle_action
    return rest_pull_close(body, restapi_repo, sdk_pr_target_repo, sdkbase, sdk_tag)
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github.py", line 185, in rest_pull_close
    rest_pr_management(rest_pr, sdk_pr_target_repo, sdk_tag, sdk_default_base)
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github_handler.py", line 151, in rest_pr_management
    sdk_tag=sdk_tag
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/SwaggerToSdkNewCLI.py", line 254, in generate_sdk_from_git_object
    with manage_git_folder(gh_token, Path(temp_dir) / Path("rest"), branched_rest_api_id, pr_number=pr_number) as restapi_git_folder, \
  File "/usr/lib/python3.6/contextlib.py", line 81, in __enter__
    return next(self.gen)
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 272, in manage_git_folder
    clone_to_path(gh_token, temp_dir, split_git_id[0], branch_or_commit=branch, pr_number=pr_number)
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 212, in clone_to_path
    repo.git.checkout(branch_or_commit)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 548, in <lambda>
    return lambda *args, **kwargs: self._call_process(name, *args, **kwargs)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 1014, in _call_process
    return self.execute(call, **exec_kwargs)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 825, in execute
    raise GitCommandError(command, status, stderr_value, stdout_value)
git.exc.GitCommandError: Cmd('git') failed due to: exit code(128)
  cmdline: git checkout f3ef3dcfd879cbd934ec4e7ae0429bc16c791cae
  stderr: 'fatal: reference is not a tree: f3ef3dcfd879cbd934ec4e7ae0429bc16c791cae'

azuresdkci · 2019-07-10T11:00:38Z

Can one of the admins verify this patch?

amaljg · 2019-07-11T08:12:36Z

@praries880 - Did you get a chance to take a look at this? FYI, this is already reviewed and approved in the private repo - https://github.com/Azure/azure-rest-api-specs-pr/pull/788.

praries880 · 2019-07-11T16:44:13Z

@amaljg Kindly fix:

the linter issues : https://dev.azure.com/azure-sdk/public/_build/results?buildId=64881&view=logs&j=688669d0-441c-57c3-cf6d-f89a22ccfa5d&t=923b5a90-e462-5994-c166-86509c6bf5f2&l=140
model validation errors : https://dev.azure.com/azure-sdk/public/_build/results?buildId=64881&view=logs&j=8d2f9c49-cd83-5a9d-f3fe-2fd651afa742&t=43324f1f-6724-5d61-785f-f0ac9fd256a1&l=40
and
go sdk issues: https://dev.azure.com/azure-sdk/public/_build/results?buildId=64881&view=logs&j=ca30ae81-48c9-59ef-f3b5-00f8d328b667&t=c9bd2211-4c27-5895-a82d-bcc52dd2dab9&l=141
- Need to fix this : https://github.com/Azure/azure-rest-api-specs/pull/6579/files#diff-dd894d4f215d8a6aae8581a278a5a375R18, The SDK is preview, putput folder needs to be in preview folder as well.

ALso, I will need ARM approval for this. I see there was a comment at the very end. Since this is now moving into the public domain, I need to know that ARM is fine by the PR.

amaljg · 2019-07-14T12:56:31Z

@praries880 - By mistake, the forked repo got deleted. So I had to create a new PR with these changes. Hence I'm abandoning this PR. The new PR is here - #6615.

Adding Pipelines RP in Microsoft.DevOps provider namespace.

82904e8

AutorestCI mentioned this pull request Jul 10, 2019

[AutoPR devops/resource-manager] Adding Pipelines RP in Microsoft.DevOps provider namespace Azure/azure-sdk-for-python#6282

Closed

azuresdkci assigned praries880 Jul 10, 2019

azuresdkci requested a review from praries880 July 10, 2019 10:31

amaljg mentioned this pull request Jul 11, 2019

Deprecating Project RP #6581

Merged

5 tasks

praries880 added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Jul 11, 2019

amaljg closed this Jul 14, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Adding Pipelines RP in Microsoft.DevOps provider namespace#6579

Adding Pipelines RP in Microsoft.DevOps provider namespace#6579
amaljg wants to merge 1 commit intoAzure:masterfrom
amaljg:users/amaljg/addPipelinesRp

amaljg commented Jul 10, 2019 •

edited

Loading

Uh oh!

openapi-sdkautomation bot commented Jul 10, 2019 •

edited

Loading

Uh oh!

AutorestCI commented Jul 10, 2019 •

edited

Loading

Uh oh!

AutorestCI commented Jul 10, 2019 •

edited

Loading

Uh oh!

AutorestCI commented Jul 10, 2019 •

edited

Loading

Uh oh!

azuresdkci commented Jul 10, 2019

Uh oh!

amaljg commented Jul 11, 2019

Uh oh!

praries880 commented Jul 11, 2019 •

edited

Loading

Uh oh!

amaljg commented Jul 14, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

amaljg commented Jul 10, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Latest improvements:

Contribution checklist:

ARM API Review Checklist

Uh oh!

openapi-sdkautomation bot commented Jul 10, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

SDK Automation [Logs] (Generated from 82904e8, Iteration 7)

Uh oh!

AutorestCI commented Jul 10, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Automation for azure-sdk-for-go

Uh oh!

AutorestCI commented Jul 10, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Automation for azure-sdk-for-python

Uh oh!

AutorestCI commented Jul 10, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Automation for azure-sdk-for-java

Uh oh!

azuresdkci commented Jul 10, 2019

Uh oh!

amaljg commented Jul 11, 2019

Uh oh!

praries880 commented Jul 11, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

amaljg commented Jul 14, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

amaljg commented Jul 10, 2019 •

edited

Loading

openapi-sdkautomation bot commented Jul 10, 2019 •

edited

Loading

AutorestCI commented Jul 10, 2019 •

edited

Loading

AutorestCI commented Jul 10, 2019 •

edited

Loading

AutorestCI commented Jul 10, 2019 •

edited

Loading

praries880 commented Jul 11, 2019 •

edited

Loading