-
Notifications
You must be signed in to change notification settings - Fork 5.8k
Added SAP monitor resource type to HanaOnAzure RP #6409
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 4 commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
8038a19
Added new SAP Monitor resource
PakDLiu 5a77259
Added password field
PakDLiu d8bd927
fixed examples
PakDLiu ead3e7e
fixed more examples
PakDLiu cfe66f1
Added List, Patch, and Delete API
PakDLiu 67a5ae2
typo
PakDLiu ff217db
more typos
PakDLiu 290c601
added missing field
PakDLiu 26e22d0
updated subnet field to be not read only
PakDLiu File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
65 changes: 65 additions & 0 deletions
65
...manager/Microsoft.HanaOnAzure/preview/2017-11-03-preview/examples/SapMonitors_Create.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,65 @@ | ||
| { | ||
| "parameters": { | ||
| "api-version": "2017-11-03-preview", | ||
| "subscriptionId": "00000000-0000-0000-0000-000000000000", | ||
| "resourceGroupName": "myResourceGroup", | ||
| "sapMonitorName": "mySapMonitor", | ||
| "sapMonitorParameter": { | ||
| "id": "/subscriptions/00000000-0000-0000-0000-000000000000/resourceGroups/myResourceGroup/providers/Microsoft.HanaOnAzure/sapMonitors/mySapMonitor", | ||
| "name": "mySapMonitor", | ||
| "type": "Microsoft.HanaOnAzure/sapMonitors", | ||
| "location": "westus", | ||
| "tags": { | ||
| "key": "value" | ||
| }, | ||
| "properties": { | ||
| "hanaSubnet": "", | ||
| "hanaHostname": "", | ||
| "hanaDbName": "", | ||
| "hanaDbSqlPort": 1234, | ||
| "hanaDbUsername": "", | ||
| "provisioningState": "Succeeded" | ||
| } | ||
| } | ||
| }, | ||
| "responses": { | ||
| "200": { | ||
| "body": { | ||
| "id": "/subscriptions/00000000-0000-0000-0000-000000000000/resourceGroups/myResourceGroup/providers/Microsoft.HanaOnAzure/hanaInstances/myHanaInstance", | ||
| "name": "myHanaInstance", | ||
| "type": "Microsoft.HanaOnAzure/hanaInstances", | ||
| "location": "westus", | ||
| "tags": { | ||
| "key": "value" | ||
| }, | ||
| "properties": { | ||
| "hanaSubnet": "", | ||
| "hanaHostname": "", | ||
| "hanaDbName": "", | ||
| "hanaDbSqlPort": 1234, | ||
| "hanaDbUsername": "", | ||
| "provisioningState": "Succeeded" | ||
| } | ||
| } | ||
| }, | ||
| "201": { | ||
| "body": { | ||
| "id": "/subscriptions/00000000-0000-0000-0000-000000000000/resourceGroups/myResourceGroup/providers/Microsoft.HanaOnAzure/hanaInstances/myHanaInstance", | ||
| "name": "myHanaInstance", | ||
| "type": "Microsoft.HanaOnAzure/hanaInstances", | ||
| "location": "westus", | ||
| "tags": { | ||
| "key": "value" | ||
| }, | ||
| "properties": { | ||
| "hanaSubnet": "", | ||
| "hanaHostname": "", | ||
| "hanaDbName": "", | ||
| "hanaDbSqlPort": 1234, | ||
| "hanaDbUsername": "", | ||
| "provisioningState": "Accepted" | ||
| } | ||
| } | ||
| } | ||
| } | ||
| } |
29 changes: 29 additions & 0 deletions
29
...ce-manager/Microsoft.HanaOnAzure/preview/2017-11-03-preview/examples/SapMonitors_Get.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,29 @@ | ||
| { | ||
| "parameters": { | ||
| "api-version": "2017-11-03-preview", | ||
| "subscriptionId": "00000000-0000-0000-0000-000000000000", | ||
| "resourceGroupName": "myResourceGroup", | ||
| "sapMonitorName": "mySapMonitor" | ||
| }, | ||
| "responses": { | ||
| "200": { | ||
| "body": { | ||
| "id": "/subscriptions/00000000-0000-0000-0000-000000000000/resourceGroups/myResourceGroup/providers/Microsoft.HanaOnAzure/sapMonitors/mySapMonitor", | ||
| "name": "mySapMonitor", | ||
| "type": "Microsoft.HanaOnAzure/sapMonitors", | ||
| "location": "westus", | ||
| "tags": { | ||
| "key": "value" | ||
| }, | ||
| "properties": { | ||
| "hanaSubnet": "", | ||
| "hanaHostname": "", | ||
| "hanaDbName": "", | ||
| "hanaDbSqlPort": 1234, | ||
| "hanaDbUsername": "", | ||
| "provisioningState": "Succeeded" | ||
| } | ||
| } | ||
| } | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -426,6 +426,103 @@ | |
| } | ||
| } | ||
| } | ||
| }, | ||
| "/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.HanaOnAzure/sapMonitors/{sapMonitorName}": { | ||
| "get": { | ||
| "tags": [ | ||
| "HanaOnAzure" | ||
| ], | ||
| "operationId": "SapMonitors_Get", | ||
| "summary": "Gets properties of a SAP monitor.", | ||
| "description": "Gets properties of a SAP monitor for the specified subscription, resource group, and resource name.", | ||
| "x-ms-examples": { | ||
| "Get properties of a SAP monitor": { | ||
| "$ref": "./examples/SapMonitors_Get.json" | ||
| } | ||
| }, | ||
| "produces": [ | ||
| "application/json" | ||
| ], | ||
| "parameters": [ | ||
| { | ||
| "$ref": "#/parameters/ApiVersionParameter" | ||
| }, | ||
| { | ||
| "$ref": "#/parameters/SubscriptionIdParameter" | ||
| }, | ||
| { | ||
| "$ref": "#/parameters/ResourceGroupNameParameter" | ||
| }, | ||
| { | ||
| "$ref": "#/parameters/SapMonitorNameParameter" | ||
| } | ||
| ], | ||
| "responses": { | ||
| "200": { | ||
| "description": "OK", | ||
| "schema": { | ||
| "$ref": "#/definitions/SapMonitor" | ||
| } | ||
| }, | ||
| "default": { | ||
| "description": "Error response describing why the operation failed.", | ||
| "schema": { | ||
| "$ref": "#/definitions/ErrorResponse" | ||
| } | ||
| } | ||
| } | ||
| }, | ||
| "put": { | ||
|
PakDLiu marked this conversation as resolved.
|
||
| "tags": [ | ||
| "HanaOnAzure" | ||
| ], | ||
| "operationId": "SapMonitors_Create", | ||
| "x-ms-long-running-operation": true, | ||
| "summary": "Creates a SAP monitor.", | ||
| "description": "Creates a SAP monitor for the specified subscription, resource group, and resource name.", | ||
| "x-ms-examples": { | ||
| "Get properties of a HANA instance": { | ||
| "$ref": "./examples/SapMonitors_Create.json" | ||
| } | ||
| }, | ||
| "parameters": [ | ||
| { | ||
| "$ref": "#/parameters/ApiVersionParameter" | ||
| }, | ||
| { | ||
| "$ref": "#/parameters/SubscriptionIdParameter" | ||
| }, | ||
| { | ||
| "$ref": "#/parameters/ResourceGroupNameParameter" | ||
| }, | ||
| { | ||
| "$ref": "#/parameters/SapMonitorNameParameter" | ||
| }, | ||
| { | ||
| "$ref": "#/parameters/SapMonitorParameter" | ||
| } | ||
| ], | ||
| "responses": { | ||
| "200": { | ||
| "description": "Created SapMonitor", | ||
| "schema": { | ||
| "$ref": "#/definitions/SapMonitor" | ||
| } | ||
| }, | ||
| "201": { | ||
| "description": "Creating SapMonitor", | ||
| "schema": { | ||
| "$ref": "#/definitions/SapMonitor" | ||
| } | ||
| }, | ||
| "default": { | ||
| "description": "Error response describing why the operation failed.", | ||
| "schema": { | ||
| "$ref": "#/definitions/ErrorResponse" | ||
| } | ||
| } | ||
| } | ||
| } | ||
| } | ||
| }, | ||
| "definitions": { | ||
|
|
@@ -821,6 +918,69 @@ | |
| } | ||
| }, | ||
| "description": "Details needed to monitor a Hana Instance" | ||
| }, | ||
| "SapMonitor": { | ||
| "properties": { | ||
| "properties": { | ||
| "x-ms-client-flatten": true, | ||
| "$ref": "#/definitions/SapMonitorProperties", | ||
| "description": "SAP monitor properties" | ||
| } | ||
| }, | ||
| "allOf": [ | ||
| { | ||
| "$ref": "#/definitions/Resource" | ||
| } | ||
| ], | ||
| "description": "SAP monitor info on Azure (ARM properties and SAP monitor properties)" | ||
| }, | ||
| "SapMonitorProperties": { | ||
| "properties": { | ||
| "hanaSubnet": { | ||
| "readOnly": true, | ||
| "type": "string", | ||
| "description": "Specifies the SAP monitor unique ID." | ||
| }, | ||
| "hanaHostname": { | ||
| "type": "string", | ||
| "description": "Hostname of the HANA instance." | ||
| }, | ||
| "hanaDbName": { | ||
| "type": "string", | ||
| "description": "Database name of the HANA instance." | ||
| }, | ||
| "hanaDbSqlPort": { | ||
| "type": "integer", | ||
| "description": "Database port of the HANA instance." | ||
| }, | ||
| "hanaDbUsername": { | ||
| "type": "string", | ||
| "description": "Database username of the HANA instance." | ||
| }, | ||
| "hanaDbPassword": { | ||
| "type": "string", | ||
| "description": "Database password of the HANA instance." | ||
| }, | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Will this ever be returned on GET responses?
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. No, it won't. Is there a way to reuse the definition with slight changes? |
||
| "provisioningState": { | ||
| "readOnly": true, | ||
| "type": "string", | ||
| "enum": [ | ||
| "Accepted", | ||
| "Creating", | ||
| "Updating", | ||
| "Failed", | ||
| "Succeeded", | ||
| "Deleting", | ||
| "Migrating" | ||
| ], | ||
| "x-ms-enum": { | ||
| "name": "HanaProvisioningStatesEnum", | ||
| "modelAsString": true | ||
| }, | ||
| "description": "State of provisioning of the HanaInstance" | ||
| } | ||
| }, | ||
| "description": "Describes the properties of a SAP monitor." | ||
| } | ||
| }, | ||
| "parameters": { | ||
|
|
@@ -847,6 +1007,14 @@ | |
| "description": "Name of the SAP HANA on Azure instance.", | ||
| "x-ms-parameter-location": "method" | ||
| }, | ||
| "SapMonitorNameParameter": { | ||
| "name": "sapMonitorName", | ||
| "in": "path", | ||
| "required": true, | ||
| "type": "string", | ||
| "description": "Name of the SAP monitor resource.", | ||
| "x-ms-parameter-location": "method" | ||
| }, | ||
| "ApiVersionParameter": { | ||
| "name": "api-version", | ||
| "in": "query", | ||
|
|
@@ -883,6 +1051,16 @@ | |
| }, | ||
| "description": "Request body representing a HanaInstance", | ||
| "x-ms-parameter-location": "method" | ||
| }, | ||
| "SapMonitorParameter": { | ||
| "name": "sapMonitorParameter", | ||
| "in": "body", | ||
| "required": true, | ||
| "schema": { | ||
| "$ref": "#/definitions/SapMonitor" | ||
| }, | ||
| "description": "Request body representing a SAP Monitor", | ||
| "x-ms-parameter-location": "method" | ||
| } | ||
| } | ||
| } | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.