Skip to content

Added SAP monitor resource type to HanaOnAzure RP#6409

Merged
amarzavery merged 9 commits intoAzure:masterfrom
PakDLiu:donaliu/AddSapMonitor
Jun 26, 2019
Merged

Added SAP monitor resource type to HanaOnAzure RP#6409
amarzavery merged 9 commits intoAzure:masterfrom
PakDLiu:donaliu/AddSapMonitor

Conversation

@PakDLiu
Copy link
Copy Markdown
Contributor

@PakDLiu PakDLiu commented Jun 21, 2019

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

  • I have reviewed the documentation for the workflow.
  • Validation tools were run on swagger spec(s) and have all been fixed in this PR.
  • The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

  • Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
  • adding/removing APIs.
  • adding/removing properties.
  • adding/removing API-version.
  • adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

  • If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
    Please follow the link to find more details on API review process.

@openapi-sdkautomation
Copy link
Copy Markdown

openapi-sdkautomation Bot commented Jun 21, 2019 •
edited
Loading

SDK Automation [Logs] (Generated from 26e22d0)

Pending Python: Azure/azure-sdk-for-python
  • Package generation pending.
Pending Java: Azure/azure-sdk-for-java
  • Package generation pending.
Pending Go: Azure/azure-sdk-for-go
  • Package generation pending.
Pending JavaScript: Azure/azure-sdk-for-js
  • Package generation pending.

@AutorestCI
Copy link
Copy Markdown

AutorestCI commented Jun 21, 2019 •
edited
Loading

Automation for azure-sdk-for-ruby

Nothing to generate for azure-sdk-for-ruby

@azuresdkci azuresdkci requested a review from amarzavery June 21, 2019 21:19
@azuresdkci
Copy link
Copy Markdown
Contributor

azuresdkci commented Jun 21, 2019

Can one of the admins verify this patch?

@AutorestCI AutorestCI mentioned this pull request Jun 21, 2019
Closed
@AutorestCI
Copy link
Copy Markdown

AutorestCI commented Jun 21, 2019 •
edited
Loading

Automation for azure-sdk-for-python

A PR has been created for you based on this PR content.

Once this PR will be merged, content will be added to your service PR:
Azure/azure-sdk-for-python#6105

@AutorestCI AutorestCI mentioned this pull request Jun 21, 2019
Merged
@AutorestCI
Copy link
Copy Markdown

AutorestCI commented Jun 21, 2019 •
edited
Loading

Automation for azure-sdk-for-java

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-java#3252

@AutorestCI AutorestCI mentioned this pull request Jun 21, 2019
Closed
@AutorestCI
Copy link
Copy Markdown

AutorestCI commented Jun 21, 2019 •
edited
Loading

Automation for azure-sdk-for-go

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-go#5134

@amarzavery amarzavery added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Jun 21, 2019
@amarzavery
Copy link
Copy Markdown
Contributor

amarzavery commented Jun 21, 2019

LGTM. Will wait for ARM feedback, since new apis have been added

majastrz
majastrz reviewed Jun 24, 2019
View reviewed changes
Comment thread ...naonazure/resource-manager/Microsoft.HanaOnAzure/preview/2017-11-03-preview/hanaonazure.json
"hanaDbPassword": {
"type": "string",
"description": "Database password of the HANA instance."
},
Copy link
Copy Markdown
Member

@majastrz majastrz Jun 24, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will this ever be returned on GET responses?

Copy link
Copy Markdown
Contributor Author

@PakDLiu PakDLiu Jun 24, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, it won't.
On the GET, will not exist.

Is there a way to reuse the definition with slight changes?

majastrz
majastrz reviewed Jun 24, 2019
View reviewed changes
Copy link
Copy Markdown
Member

@majastrz majastrz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added comments. Please take a look. The current on-call will continue the review.

@PakDLiu
Copy link
Copy Markdown
Contributor Author

PakDLiu commented Jun 24, 2019

There seems to be a spell check test that is failing on a file I didn't edit...

@jhendrixMSFT
Copy link
Copy Markdown
Member

jhendrixMSFT commented Jun 26, 2019

@AutorestCI regenerate azure-sdk-for-go

@ravbhatnagar
Copy link
Copy Markdown
Contributor

ravbhatnagar commented Jun 26, 2019

Signing off from ARM side. Comments from previous review have been addressed.

@ravbhatnagar ravbhatnagar added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed ARMChangesRequested WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Jun 26, 2019
@AutorestCI AutorestCI mentioned this pull request Jun 26, 2019
Merged
@amarzavery amarzavery merged commit eb91619 into Azure:master Jun 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@majastrz majastrz majastrz left review comments

+1 more reviewer

@amarzavery amarzavery amarzavery approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@amarzavery amarzavery

Labels

ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@PakDLiu @AutorestCI @azuresdkci @amarzavery @jhendrixMSFT @ravbhatnagar @majastrz