Adding action rule preview version by roramc · Pull Request #5712 · Azure/azure-rest-api-specs

roramc · 2019-04-19T20:22:22Z

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

I have reviewed the documentation for the workflow.
Validation tools were run on swagger spec(s) and have all been fixed in this PR.
The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
adding/removing APIs.
adding/removing properties.
adding/removing API-version.
adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Please follow the link to find more details on API review process.

adding new resource type actionRules in AlertsManagement RP

Spelling correction and JSON update for delete example

fixed semantic error - added recurrenceType in suppression config

code review comments

Changed enabled flag to status enum

added location as mandatory parameter

changed "createdDateTime"/"createdUserName" to "createdAt"/"createdBy" changed "lastModifiedDateTime"/"lastModifiedUserName" to "lastModifiedAt"/"lastModifiedBy" Updated conditions to take in operator

new line at end of file

Action rules support with new preview version

AutorestCI · 2019-04-19T20:22:57Z

Automation for azure-sdk-for-js

Encountered an unknown error: (azure-sdk-for-js)

Traceback (most recent call last):
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 33, in exception_to_github
    yield context
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github.py", line 170, in rest_handle_action
    return rest_pull_close(body, restapi_repo, sdk_pr_target_repo, sdkbase, sdk_tag)
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github.py", line 185, in rest_pull_close
    rest_pr_management(rest_pr, sdk_pr_target_repo, sdk_tag, sdk_default_base)
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github_handler.py", line 151, in rest_pr_management
    sdk_tag=sdk_tag
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/SwaggerToSdkNewCLI.py", line 254, in generate_sdk_from_git_object
    with manage_git_folder(gh_token, Path(temp_dir) / Path("rest"), branched_rest_api_id, pr_number=pr_number) as restapi_git_folder, \
  File "/usr/lib/python3.6/contextlib.py", line 81, in __enter__
    return next(self.gen)
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 272, in manage_git_folder
    clone_to_path(gh_token, temp_dir, split_git_id[0], branch_or_commit=branch, pr_number=pr_number)
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 212, in clone_to_path
    repo.git.checkout(branch_or_commit)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 548, in <lambda>
    return lambda *args, **kwargs: self._call_process(name, *args, **kwargs)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 1014, in _call_process
    return self.execute(call, **exec_kwargs)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 825, in execute
    raise GitCommandError(command, status, stderr_value, stdout_value)
git.exc.GitCommandError: Cmd('git') failed due to: exit code(128)
  cmdline: git checkout 8620868a7e12253a33cb00f56361770dc314f06f
  stderr: 'fatal: reference is not a tree: 8620868a7e12253a33cb00f56361770dc314f06f'

AutorestCI · 2019-04-19T20:23:00Z

Automation for azure-sdk-for-ruby

Encountered an unknown error: (azure-sdk-for-ruby)

Traceback (most recent call last):
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 33, in exception_to_github
    yield context
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github.py", line 170, in rest_handle_action
    return rest_pull_close(body, restapi_repo, sdk_pr_target_repo, sdkbase, sdk_tag)
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github.py", line 185, in rest_pull_close
    rest_pr_management(rest_pr, sdk_pr_target_repo, sdk_tag, sdk_default_base)
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github_handler.py", line 151, in rest_pr_management
    sdk_tag=sdk_tag
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/SwaggerToSdkNewCLI.py", line 254, in generate_sdk_from_git_object
    with manage_git_folder(gh_token, Path(temp_dir) / Path("rest"), branched_rest_api_id, pr_number=pr_number) as restapi_git_folder, \
  File "/usr/lib/python3.6/contextlib.py", line 81, in __enter__
    return next(self.gen)
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 272, in manage_git_folder
    clone_to_path(gh_token, temp_dir, split_git_id[0], branch_or_commit=branch, pr_number=pr_number)
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 212, in clone_to_path
    repo.git.checkout(branch_or_commit)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 548, in <lambda>
    return lambda *args, **kwargs: self._call_process(name, *args, **kwargs)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 1014, in _call_process
    return self.execute(call, **exec_kwargs)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 825, in execute
    raise GitCommandError(command, status, stderr_value, stdout_value)
git.exc.GitCommandError: Cmd('git') failed due to: exit code(128)
  cmdline: git checkout 8620868a7e12253a33cb00f56361770dc314f06f
  stderr: 'fatal: reference is not a tree: 8620868a7e12253a33cb00f56361770dc314f06f'

AutorestCI · 2019-04-19T20:23:04Z

Automation for azure-sdk-for-python

Encountered an unknown error: (azure-sdk-for-python)

Traceback (most recent call last):
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 33, in exception_to_github
    yield context
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github.py", line 170, in rest_handle_action
    return rest_pull_close(body, restapi_repo, sdk_pr_target_repo, sdkbase, sdk_tag)
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github.py", line 185, in rest_pull_close
    rest_pr_management(rest_pr, sdk_pr_target_repo, sdk_tag, sdk_default_base)
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github_handler.py", line 151, in rest_pr_management
    sdk_tag=sdk_tag
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/SwaggerToSdkNewCLI.py", line 254, in generate_sdk_from_git_object
    with manage_git_folder(gh_token, Path(temp_dir) / Path("rest"), branched_rest_api_id, pr_number=pr_number) as restapi_git_folder, \
  File "/usr/lib/python3.6/contextlib.py", line 81, in __enter__
    return next(self.gen)
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 272, in manage_git_folder
    clone_to_path(gh_token, temp_dir, split_git_id[0], branch_or_commit=branch, pr_number=pr_number)
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 212, in clone_to_path
    repo.git.checkout(branch_or_commit)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 548, in <lambda>
    return lambda *args, **kwargs: self._call_process(name, *args, **kwargs)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 1014, in _call_process
    return self.execute(call, **exec_kwargs)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 825, in execute
    raise GitCommandError(command, status, stderr_value, stdout_value)
git.exc.GitCommandError: Cmd('git') failed due to: exit code(128)
  cmdline: git checkout 8620868a7e12253a33cb00f56361770dc314f06f
  stderr: 'fatal: reference is not a tree: 8620868a7e12253a33cb00f56361770dc314f06f'

AutorestCI · 2019-04-19T20:23:31Z

Automation for azure-sdk-for-java

Encountered an unknown error: (azure-sdk-for-java)

Traceback (most recent call last):
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 33, in exception_to_github
    yield context
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github.py", line 170, in rest_handle_action
    return rest_pull_close(body, restapi_repo, sdk_pr_target_repo, sdkbase, sdk_tag)
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github.py", line 185, in rest_pull_close
    rest_pr_management(rest_pr, sdk_pr_target_repo, sdk_tag, sdk_default_base)
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github_handler.py", line 151, in rest_pr_management
    sdk_tag=sdk_tag
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/SwaggerToSdkNewCLI.py", line 254, in generate_sdk_from_git_object
    with manage_git_folder(gh_token, Path(temp_dir) / Path("rest"), branched_rest_api_id, pr_number=pr_number) as restapi_git_folder, \
  File "/usr/lib/python3.6/contextlib.py", line 81, in __enter__
    return next(self.gen)
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 272, in manage_git_folder
    clone_to_path(gh_token, temp_dir, split_git_id[0], branch_or_commit=branch, pr_number=pr_number)
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 212, in clone_to_path
    repo.git.checkout(branch_or_commit)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 548, in <lambda>
    return lambda *args, **kwargs: self._call_process(name, *args, **kwargs)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 1014, in _call_process
    return self.execute(call, **exec_kwargs)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 825, in execute
    raise GitCommandError(command, status, stderr_value, stdout_value)
git.exc.GitCommandError: Cmd('git') failed due to: exit code(128)
  cmdline: git checkout 8620868a7e12253a33cb00f56361770dc314f06f
  stderr: 'fatal: reference is not a tree: 8620868a7e12253a33cb00f56361770dc314f06f'

AutorestCI · 2019-04-19T20:24:43Z

Automation for azure-sdk-for-go

Encountered an unknown error: (azure-sdk-for-go)

Traceback (most recent call last):
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 33, in exception_to_github
    yield context
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github.py", line 170, in rest_handle_action
    return rest_pull_close(body, restapi_repo, sdk_pr_target_repo, sdkbase, sdk_tag)
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github.py", line 185, in rest_pull_close
    rest_pr_management(rest_pr, sdk_pr_target_repo, sdk_tag, sdk_default_base)
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github_handler.py", line 151, in rest_pr_management
    sdk_tag=sdk_tag
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/SwaggerToSdkNewCLI.py", line 254, in generate_sdk_from_git_object
    with manage_git_folder(gh_token, Path(temp_dir) / Path("rest"), branched_rest_api_id, pr_number=pr_number) as restapi_git_folder, \
  File "/usr/lib/python3.6/contextlib.py", line 81, in __enter__
    return next(self.gen)
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 272, in manage_git_folder
    clone_to_path(gh_token, temp_dir, split_git_id[0], branch_or_commit=branch, pr_number=pr_number)
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 212, in clone_to_path
    repo.git.checkout(branch_or_commit)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 548, in <lambda>
    return lambda *args, **kwargs: self._call_process(name, *args, **kwargs)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 1014, in _call_process
    return self.execute(call, **exec_kwargs)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 825, in execute
    raise GitCommandError(command, status, stderr_value, stdout_value)
git.exc.GitCommandError: Cmd('git') failed due to: exit code(128)
  cmdline: git checkout 8620868a7e12253a33cb00f56361770dc314f06f
  stderr: 'fatal: reference is not a tree: 8620868a7e12253a33cb00f56361770dc314f06f'

azuresdkci · 2019-04-19T20:54:17Z

Can one of the admins verify this patch?

veronicagg

@roramc Since you mentioned this files were reviewed before, could you point to the previous PR where this was reviewed?
.Net failure in CI happens because that job does not support new RPs, so I will ignore that one.
There's a failure in syntax job, which was fixed by us in this commit, could you update your branch with the latest from master to get this change so CI can re-run?

roramc · 2019-04-23T04:25:14Z

@roramc Since you mentioned this files were reviewed before, could you point to the previous PR where this was reviewed?
.Net failure in CI happens because that job does not support new RPs, so I will ignore that one.
There's a failure in syntax job, which was fixed by us in this commit, could you update your branch with the latest from master to get this change so CI can re-run?

I have pulled the latest from master and updated the branch.
[https://github.com//pull/4955]- this is the previous PR. The new one is just adding a new version and addition of some more fields. Please look at the files changed section, those are the only new files added.

veronicagg

@roramc thanks for clarifying. Based on your comments it looks like you're copying from a previous API version 2018-11-02-privatepreview and making updates to it, is that correct? The diff is hard to see it'd be good if you could commit first the old api version and make the updates in the following commits. We provide a onboarding experience via http://aka.ms/openapihub that would help you make and update like this easier.
Since it's a new API version, I've requested ARM team to review. Have you reviewed these changes with them already?
I see that you're making parameter changes to existing APIs, removing a bunch of operations and adding discriminator type?

veronicagg · 2019-04-23T22:18:24Z

@roramc Please update https://github.com/Azure/azure-rest-api-specs/tree/13a53e71df342794e9cfeab21f6a2740be6300bf/specification/alertsmanagement/resource-manager/readme.md file to include this file in a new tag for SDK generation.

veronicagg · 2019-04-25T01:19:48Z

PR #5750 was opened instead of this one, so closing this one. Thanks!

roramcmsft added 11 commits December 21, 2018 00:45

actionRules - AlertsManagement

0317e67

adding new resource type actionRules in AlertsManagement RP

Code review spelling and JSON fix

6fad44a

Spelling correction and JSON update for delete example

Update AlertsManagement.json

1c05fd8

fixed semantic error - added recurrenceType in suppression config

Update AlertsManagement.json

b1f1443

code review comments

Changed enabled flag to status enum

72be070

Changed enabled flag to status enum

added location as mandatory parameter

db27395

added location as mandatory parameter

changed "createdDateTime"/"createdUserName" to "createdAt"/"createdBy"

95f5b3f

changed "createdDateTime"/"createdUserName" to "createdAt"/"createdBy" changed "lastModifiedDateTime"/"lastModifiedUserName" to "lastModifiedAt"/"lastModifiedBy" Updated conditions to take in operator

new line at end of file

de9cb88

new line at end of file

new line at end of file

01a19cd

new line at end of file

Action rules support with new preview version

01d7957

Action rules support with new preview version

merged

7747753

AutorestCI mentioned this pull request Apr 19, 2019

[AutoPR alertsmanagement/resource-manager] Adding action rule preview version Azure/azure-sdk-for-go#4590

Closed

azuresdkci assigned veronicagg Apr 19, 2019

azuresdkci requested a review from veronicagg April 19, 2019 20:55

veronicagg suggested changes Apr 22, 2019

View reviewed changes

Merge remote-tracking branch 'upstream/master'

13a53e7

veronicagg added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Apr 23, 2019

veronicagg suggested changes Apr 23, 2019

View reviewed changes

veronicagg closed this Apr 25, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Adding action rule preview version#5712

Adding action rule preview version#5712
roramc wants to merge 12 commits intoAzure:masterfrom
roramc:master

roramc commented Apr 19, 2019

Uh oh!

AutorestCI commented Apr 19, 2019 •

edited

Loading

Uh oh!

AutorestCI commented Apr 19, 2019 •

edited

Loading

Uh oh!

AutorestCI commented Apr 19, 2019 •

edited

Loading

Uh oh!

AutorestCI commented Apr 19, 2019 •

edited

Loading

Uh oh!

AutorestCI commented Apr 19, 2019 •

edited

Loading

Uh oh!

azuresdkci commented Apr 19, 2019

Uh oh!

veronicagg left a comment

Uh oh!

roramc commented Apr 23, 2019 •

edited

Loading

Uh oh!

veronicagg left a comment

Uh oh!

veronicagg commented Apr 23, 2019 •

edited

Loading

Uh oh!

veronicagg commented Apr 25, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Conversation

roramc commented Apr 19, 2019

Latest improvements:

Contribution checklist:

ARM API Review Checklist

Uh oh!

AutorestCI commented Apr 19, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Automation for azure-sdk-for-js

Uh oh!

AutorestCI commented Apr 19, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Automation for azure-sdk-for-ruby

Uh oh!

AutorestCI commented Apr 19, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Automation for azure-sdk-for-python

Uh oh!

AutorestCI commented Apr 19, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Automation for azure-sdk-for-java

Uh oh!

AutorestCI commented Apr 19, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Automation for azure-sdk-for-go

Uh oh!

azuresdkci commented Apr 19, 2019

Uh oh!

veronicagg left a comment

Choose a reason for hiding this comment

Uh oh!

roramc commented Apr 23, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

veronicagg left a comment

Choose a reason for hiding this comment

Uh oh!

veronicagg commented Apr 23, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

veronicagg commented Apr 25, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

AutorestCI commented Apr 19, 2019 •

edited

Loading

AutorestCI commented Apr 19, 2019 •

edited

Loading

AutorestCI commented Apr 19, 2019 •

edited

Loading

AutorestCI commented Apr 19, 2019 •

edited

Loading

AutorestCI commented Apr 19, 2019 •

edited

Loading

roramc commented Apr 23, 2019 •

edited

Loading

veronicagg commented Apr 23, 2019 •

edited

Loading