actionRules - AlertsManagement by roramc · Pull Request #4955 · Azure/azure-rest-api-specs

roramc · 2018-12-20T19:16:36Z

adding new resource type actionRules in AlertsManagement RP

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

I have reviewed the documentation for the workflow.
Validation tools were run on swagger spec(s) and have all been fixed in this PR.
The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
adding/removing APIs.
adding/removing properties.
adding/removing API-version.
adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Please follow the link to find more details on API review process.

adding new resource type actionRules in AlertsManagement RP

openapi-portal-comment · 2018-12-20T19:16:38Z

If you're a MSFT employee, click this link
to view this PR's validation status on our new OpenAPI Hub spec management tool.

azuresdkci · 2018-12-20T19:16:50Z

Hello!!

The Rest API Specs team wishes everyone a happy holiday and would like to kindly inform you that responses and review to Pull request will be delayed during the holiday period (now -> 2nds of January) to allow for Awesome reviewers to have an awesome time with their families during the holidays!

Thanks and Have a WONDERFUL HOLIDAY

AutorestCI · 2018-12-20T19:16:54Z

Automation for azure-sdk-for-js

Nothing to generate for azure-sdk-for-js

AutorestCI · 2018-12-20T19:17:06Z

Automation for azure-sdk-for-ruby

Nothing to generate for azure-sdk-for-ruby

AutorestCI · 2018-12-20T19:17:16Z

Automation for azure-sdk-for-python

Nothing to generate for azure-sdk-for-python

azuresdkci · 2018-12-20T19:18:27Z

Can one of the admins verify this patch?

AutorestCI · 2018-12-20T19:52:43Z

Automation for azure-sdk-for-go

Nothing to generate for azure-sdk-for-go

...icrosoft.AlertsManagement/preview/2018-11-02-privatepreview/examples/ActionRules_Delete.json

nschonni · 2018-12-20T20:37:46Z

...e-manager/Microsoft.AlertsManagement/preview/2018-11-02-privatepreview/AlertsManagement.json

+            "Monthly"
+          ],
+          "x-ms-enum": {
+            "name": "SupressionType",


SupressionType -> SuppressionType

resolved in latest commit

nschonni · 2018-12-20T20:38:35Z

...e-manager/Microsoft.AlertsManagement/preview/2018-11-02-privatepreview/AlertsManagement.json

+        },
+        "recurrenceValues": {
+          "type": "array",
+          "description": "Specifies the values for reccurrence pattern",


reccurrence -> recurrence

AutorestCI · 2018-12-20T20:39:35Z

Automation for azure-sdk-for-node

Nothing to generate for azure-sdk-for-node

AutorestCI · 2018-12-20T20:54:02Z

Automation for azure-sdk-for-java

Nothing to generate for azure-sdk-for-java

Spelling correction and JSON update for delete example

fixed semantic error - added recurrenceType in suppression config

praries880 · 2019-01-02T18:03:27Z

@roramc The name contains "privatepreview".. if this is indeed a private preview that why not use the private repo to drive this?

roramc · 2019-01-03T12:59:14Z

@roramc The name contains "privatepreview".. if this is indeed a private preview that why not use the private repo to drive this?

As per last discussion, we were asked to push everything into public repo unless it is something where customers should not know about this feature. And also, that way it would be easy to move it to stable version post preview.

...e-manager/Microsoft.AlertsManagement/preview/2018-11-02-privatepreview/AlertsManagement.json

code review comments

praries880 · 2019-01-09T20:36:53Z

@roramc waiting on ARM review before I can approve the PR.

ravbhatnagar

Only reviewed actionRule APIs since that seemed the new type that was added. Next time, please remember to make the first commit which is a copy of existing version. The new changes should come in the next commit onwards. It will make reviewing easier.

ravbhatnagar · 2019-01-09T22:59:24Z

...e-manager/Microsoft.AlertsManagement/preview/2018-11-02-privatepreview/AlertsManagement.json

+          "type": "string",
+          "description": "Description of action rule"
+        },
+        "resourceGroup": {


why is this needed? its already part of the URL?

The same object gets returned even when we make a GET call to list all action rules for a given subscription. At that point user would want to know what resource group this action rule is stored in. So we added this in the properties explicitly. If conveying it through Id is enough, we could remove this property as well. Not sure what is the convention.

...e-manager/Microsoft.AlertsManagement/preview/2018-11-02-privatepreview/AlertsManagement.json

ravbhatnagar · 2019-01-09T23:01:50Z

...e-manager/Microsoft.AlertsManagement/preview/2018-11-02-privatepreview/AlertsManagement.json

+          "description": "Last updated time of action rule. Date-Time in ISO-8601 format.",
+          "readOnly": true
+        },
+        "createdUserName": {


Not sure if this kind of PII is ok to have on the resource response. I will double check on my side.

Ideally we would want to show who created/updated the given resource. Aren't other RPs doing the same? Do let us know if there is any concern with this.

Changed enabled flag to status enum

added location as mandatory parameter

praries880 · 2019-01-14T18:18:28Z

@ravbhatnagar do the latest changess from @roramc address all the issues you raised?

ravbhatnagar · 2019-01-22T18:37:00Z

awaiting confirmation from service team. We recommended service team check with privacy since it contains potentially PII information.

changed "createdDateTime"/"createdUserName" to "createdAt"/"createdBy" changed "lastModifiedDateTime"/"lastModifiedUserName" to "lastModifiedAt"/"lastModifiedBy" Updated conditions to take in operator

KrisBash

Thanks for the changes. Signing off

new line at end of file

* Swagger Specs for SAP Virtual Instance Workload. * Updates. * Updates. * updates. * Updates. * Updates. * Updates. * Fixes. Co-authored-by: Ajay Gupta <ajgupt@microsoft.com>

actionRules - AlertsManagement

0317e67

adding new resource type actionRules in AlertsManagement RP

kpajdzik added the review label Dec 20, 2018

azuresdkci assigned praries880 Dec 20, 2018

azuresdkci requested a review from praries880 December 20, 2018 19:17

AutorestCI mentioned this pull request Dec 20, 2018

[AutoPR alertsmanagement/resource-manager] actionRules - AlertsManagement Azure/azure-sdk-for-go#3773

Closed

nschonni reviewed Dec 20, 2018

View reviewed changes

roramcmsft added 2 commits December 21, 2018 07:24

Code review spelling and JSON fix

6fad44a

Spelling correction and JSON update for delete example

Update AlertsManagement.json

1c05fd8

fixed semantic error - added recurrenceType in suppression config

praries880 suggested changes Jan 7, 2019

View reviewed changes

...e-manager/Microsoft.AlertsManagement/preview/2018-11-02-privatepreview/AlertsManagement.json Outdated Show resolved Hide resolved

...e-manager/Microsoft.AlertsManagement/preview/2018-11-02-privatepreview/AlertsManagement.json Outdated Show resolved Hide resolved

praries880 added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Jan 7, 2019

Update AlertsManagement.json

b1f1443

code review comments

ravbhatnagar reviewed Jan 9, 2019

View reviewed changes

ravbhatnagar added the ARMChangesRequested label Jan 9, 2019

roramcmsft added 2 commits January 11, 2019 00:46

Changed enabled flag to status enum

72be070

Changed enabled flag to status enum

added location as mandatory parameter

db27395

added location as mandatory parameter

changed "createdDateTime"/"createdUserName" to "createdAt"/"createdBy"

95f5b3f

changed "createdDateTime"/"createdUserName" to "createdAt"/"createdBy" changed "lastModifiedDateTime"/"lastModifiedUserName" to "lastModifiedAt"/"lastModifiedBy" Updated conditions to take in operator

KrisBash approved these changes Feb 6, 2019

View reviewed changes

KrisBash added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed ARMChangesRequested WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Feb 6, 2019

roramcmsft added 2 commits February 7, 2019 11:42

new line at end of file

de9cb88

new line at end of file

new line at end of file

01a19cd

new line at end of file

praries880 approved these changes Feb 7, 2019

View reviewed changes

praries880 merged commit 1e85a38 into Azure:master Feb 7, 2019

roramc mentioned this pull request Apr 23, 2019

Adding action rule preview version #5712

Closed

5 tasks

Conversation

roramc commented Dec 20, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Latest improvements:

Contribution checklist:

ARM API Review Checklist

Uh oh!

openapi-portal-comment bot commented Dec 20, 2018

Uh oh!

azuresdkci commented Dec 20, 2018

Uh oh!

AutorestCI commented Dec 20, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Automation for azure-sdk-for-js

Uh oh!

AutorestCI commented Dec 20, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Automation for azure-sdk-for-ruby

Uh oh!

AutorestCI commented Dec 20, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Automation for azure-sdk-for-python

Uh oh!

azuresdkci commented Dec 20, 2018

Uh oh!

AutorestCI commented Dec 20, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Automation for azure-sdk-for-go

Uh oh!

Uh oh!

nschonni Dec 20, 2018

Choose a reason for hiding this comment

Uh oh!

roramc Dec 21, 2018

Choose a reason for hiding this comment

Uh oh!

nschonni Dec 20, 2018

Choose a reason for hiding this comment

Uh oh!

AutorestCI commented Dec 20, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Automation for azure-sdk-for-node

Uh oh!

AutorestCI commented Dec 20, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Automation for azure-sdk-for-java

Uh oh!

praries880 commented Jan 2, 2019

Uh oh!

roramc commented Jan 3, 2019

Uh oh!

Uh oh!

Uh oh!

praries880 commented Jan 9, 2019

Uh oh!

ravbhatnagar left a comment

Choose a reason for hiding this comment

Uh oh!

ravbhatnagar Jan 9, 2019

Choose a reason for hiding this comment

Uh oh!

roramc Jan 10, 2019

Choose a reason for hiding this comment

Uh oh!

Uh oh!

ravbhatnagar Jan 9, 2019

Choose a reason for hiding this comment

Uh oh!

roramc Jan 10, 2019

Choose a reason for hiding this comment

Uh oh!

praries880 commented Jan 14, 2019

Uh oh!

ravbhatnagar commented Jan 22, 2019

Uh oh!

KrisBash left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

roramc commented Dec 20, 2018 •

edited

Loading

AutorestCI commented Dec 20, 2018 •

edited

Loading

AutorestCI commented Dec 20, 2018 •

edited

Loading

AutorestCI commented Dec 20, 2018 •

edited

Loading

AutorestCI commented Dec 20, 2018 •

edited

Loading

AutorestCI commented Dec 20, 2018 •

edited

Loading

AutorestCI commented Dec 20, 2018 •

edited

Loading