Skip to content

[Hub Generated] Review request for Microsoft.CognitiveServices to add version 2017-04-18 #5355

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
DavidLiCIG wants to merge 22 commits into from
Closed

[Hub Generated] Review request for Microsoft.CognitiveServices to add version 2017-04-18 #5355

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
22 commits
Select commit Hold shift + click to select a range
5e734a0
Adding data plane spec starting with Face
DavidLiCIG Jul 26, 2017
e8f1ee2
Move Spec to right folder
DavidLiCIG Jul 26, 2017
c56cc0e
Fixing validation issues.
DavidLiCIG Jul 27, 2017
e46c1ff
Fixing issues and adding a readme.md
DavidLiCIG Jul 28, 2017
53aff4a
Fixing examples by removing decimals.
DavidLiCIG Jul 28, 2017
c529bbb
Removing another decimal value
DavidLiCIG Jul 28, 2017
93cb8ef
Update readme.md
fearthecowboy Jul 28, 2017
95cac3a
Updating spec based on comments.
DavidLiCIG Aug 9, 2017
3de638b
Removing .gitignore.
DavidLiCIG Aug 11, 2017
16d9650
Changing namespace to include category.
DavidLiCIG Aug 20, 2017
b0bd08e
Adding ComputerVision jsopn
DavidLiCIG Aug 21, 2017
d10d86a
Merge from remote
DavidLiCIG Oct 16, 2017
dcbcfc9
Merge from main
DavidLiCIG Jan 2, 2019
22f9aa0
Merge branch 'master' of e:\code\azure-rest-api-specs into current
DavidLiCIG Mar 8, 2019
69c4aeb
Add checkdomain availability
DavidLiCIG Mar 11, 2019
676984a
Adding missing properties
DavidLiCIG Mar 11, 2019
1fad59a
Fix example error
DavidLiCIG Mar 11, 2019
f1c5785
Merge branch 'davl/AddCheckDomainAvailability' into dev-cognitiveserv…
DavidLiCIG Mar 11, 2019
21797ee
Changing operation id based on linter feedback
DavidLiCIG Mar 11, 2019
c69a621
Update operation Id based on linter requirements
DavidLiCIG Mar 11, 2019
30149a9
REmoved redundant cv json
DavidLiCIG Mar 12, 2019
14f19b5
Change account to locations
DavidLiCIG Mar 12, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
81 changes: 81 additions & 0 deletions ...ces/resource-manager/Microsoft.CognitiveServices/stable/2017-04-18/cognitiveservices.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -675,6 +675,49 @@
}
}
}
},
"/subscriptions/{subscriptionId}/providers/Microsoft.CognitiveServices/locations/{location}/checkDomainAvailability": {
"post": {
"tags": [
"CognitiveServicesAccounts"
],
"operationId": "Locations_CheckDomainAvailabilityPost",
Copy link
Member

@anuchandy anuchandy Mar 13, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it would be good if we can rename operation id to Locations_CheckDomainAvailability, no need to include underneath HTTP verb in the method name

"description": "Check available SKUs.",
Copy link
Member

@anuchandy anuchandy Mar 13, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the description correct? I thought this API is to check availability of domain name.

"x-ms-examples": {
"Check Domain Availability": {
"$ref": "./examples/CheckDomainAvailability.json"
}
},
"parameters": [
{
"$ref": "#/parameters/subscriptionIdParameter"
},
{
"$ref": "#/parameters/apiVersionParameter"
},
{
"$ref": "#/parameters/locationParameter"
},
{
"name": "parameters",
"in": "body",
"required": true,
"x-ms-client-flatten": true,
"schema": {
"$ref": "#/definitions/CheckDomainAvailabilityParameter"
},
"description": "Check Domain Availability POST body."
Copy link
Member

@anuchandy anuchandy Mar 13, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you could say "Check Domain Availability parameter."

}
],
"responses": {
"200": {
"description": "OK.",
"schema": {
"$ref": "#/definitions/CheckDomainAvailabilityResult"
}
}
}
}
}
},
"definitions": {
Expand Down Expand Up @@ -1130,6 +1173,23 @@
"type"
]
},
"CheckDomainAvailabilityParameter": {
"description": "Check Domain availability parameter.",
"properties": {
"subdomainName": {
"type": "string",
"description": "The subdomain name to use."
},
"type": {
"type": "string",
"description": "The Type of the resource."
}
},
"required": [
"subdomainName",
"type"
]
},
"CheckSkuAvailabilityResultList": {
"description": "Check SKU availability result list.",
"properties": {
Expand All @@ -1142,6 +1202,27 @@
}
}
},
"CheckDomainAvailabilityResult": {
"description": "Check Domain availability result.",
"properties": {
"isSubdomainAvailable": {
"type": "boolean",
"description": "Indicates the given SKU is available or not."
},
"reason": {
"type": "string",
"description": "Reason why the SKU is not available."
},
"subdomainName": {
"type": "string",
"description": "The subdomain name to use."
},
"type": {
"type": "string",
"description": "The Type of the resource."
}
}
},
"CheckSkuAvailabilityResult": {
"description": "Check SKU availability result.",
"properties": {
Expand Down
21 changes: 21 additions & 0 deletions ...nager/Microsoft.CognitiveServices/stable/2017-04-18/examples/CheckDomainAvailability.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,21 @@
{
"parameters": {
"api-version": "2017-04-18",
"subscriptionId": "f9b96b36-1f5e-4021-8959-51527e26e6d3",
"location": "westus",
"parameters": {
"subdomainName": "contosodemoapp1",
"type": "Microsoft.CognitiveServices/accounts"
}
},
"responses": {
"200": {
"body": {
"isSubdomainAvailable": false,
"reason": "Sub domain name 'contosodemoapp1' is not valid",
"subdomainName": "contosodemoapp1",
"type": "Microsoft.CognitiveServices/accounts"
}
}
}
}