[Hub Generated] Review request for Microsoft.CognitiveServices to add version 2017-04-18 by DavidLiCIG · Pull Request #5355 · Azure/azure-rest-api-specs

DavidLiCIG · 2019-03-11T07:20:07Z

If you are a MSFT employee you can view your work branch via this link.

Contribution checklist:

I have reviewed the documentation for the workflow.
Validation tools were run on swagger spec(s) and have all been fixed in this PR.

…ices-Microsoft.CognitiveServices-2017-04-18

azuresdkci · 2019-03-11T07:20:29Z

Can one of the admins verify this patch?

AutorestCI · 2019-03-11T07:20:56Z

Automation for azure-sdk-for-python

Encountered an unknown error: (azure-sdk-for-python)

Traceback (most recent call last):
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 33, in exception_to_github
    yield context
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github.py", line 170, in rest_handle_action
    return rest_pull_close(body, restapi_repo, sdk_pr_target_repo, sdkbase, sdk_tag)
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github.py", line 185, in rest_pull_close
    rest_pr_management(rest_pr, sdk_pr_target_repo, sdk_tag, sdk_default_base)
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github_handler.py", line 151, in rest_pr_management
    sdk_tag=sdk_tag
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/SwaggerToSdkNewCLI.py", line 254, in generate_sdk_from_git_object
    with manage_git_folder(gh_token, Path(temp_dir) / Path("rest"), branched_rest_api_id, pr_number=pr_number) as restapi_git_folder, \
  File "/usr/lib/python3.6/contextlib.py", line 81, in __enter__
    return next(self.gen)
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 272, in manage_git_folder
    clone_to_path(gh_token, temp_dir, split_git_id[0], branch_or_commit=branch, pr_number=pr_number)
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 212, in clone_to_path
    repo.git.checkout(branch_or_commit)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 548, in <lambda>
    return lambda *args, **kwargs: self._call_process(name, *args, **kwargs)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 1014, in _call_process
    return self.execute(call, **exec_kwargs)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 825, in execute
    raise GitCommandError(command, status, stderr_value, stdout_value)
git.exc.GitCommandError: Cmd('git') failed due to: exit code(128)
  cmdline: git checkout eb37417c33959ec52ef1d8bd79cf078b0241fd18
  stderr: 'fatal: reference is not a tree: eb37417c33959ec52ef1d8bd79cf078b0241fd18'

AutorestCI · 2019-03-11T07:21:16Z

Automation for azure-sdk-for-js

Encountered an unknown error: (azure-sdk-for-js)

Traceback (most recent call last):
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 33, in exception_to_github
    yield context
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github.py", line 170, in rest_handle_action
    return rest_pull_close(body, restapi_repo, sdk_pr_target_repo, sdkbase, sdk_tag)
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github.py", line 185, in rest_pull_close
    rest_pr_management(rest_pr, sdk_pr_target_repo, sdk_tag, sdk_default_base)
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github_handler.py", line 151, in rest_pr_management
    sdk_tag=sdk_tag
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/SwaggerToSdkNewCLI.py", line 254, in generate_sdk_from_git_object
    with manage_git_folder(gh_token, Path(temp_dir) / Path("rest"), branched_rest_api_id, pr_number=pr_number) as restapi_git_folder, \
  File "/usr/lib/python3.6/contextlib.py", line 81, in __enter__
    return next(self.gen)
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 272, in manage_git_folder
    clone_to_path(gh_token, temp_dir, split_git_id[0], branch_or_commit=branch, pr_number=pr_number)
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 212, in clone_to_path
    repo.git.checkout(branch_or_commit)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 548, in <lambda>
    return lambda *args, **kwargs: self._call_process(name, *args, **kwargs)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 1014, in _call_process
    return self.execute(call, **exec_kwargs)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 825, in execute
    raise GitCommandError(command, status, stderr_value, stdout_value)
git.exc.GitCommandError: Cmd('git') failed due to: exit code(128)
  cmdline: git checkout eb37417c33959ec52ef1d8bd79cf078b0241fd18
  stderr: 'fatal: reference is not a tree: eb37417c33959ec52ef1d8bd79cf078b0241fd18'

AutorestCI · 2019-03-11T07:21:22Z

Automation for azure-sdk-for-ruby

Encountered an unknown error: (azure-sdk-for-ruby)

Traceback (most recent call last):
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 33, in exception_to_github
    yield context
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github.py", line 170, in rest_handle_action
    return rest_pull_close(body, restapi_repo, sdk_pr_target_repo, sdkbase, sdk_tag)
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github.py", line 185, in rest_pull_close
    rest_pr_management(rest_pr, sdk_pr_target_repo, sdk_tag, sdk_default_base)
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github_handler.py", line 151, in rest_pr_management
    sdk_tag=sdk_tag
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/SwaggerToSdkNewCLI.py", line 254, in generate_sdk_from_git_object
    with manage_git_folder(gh_token, Path(temp_dir) / Path("rest"), branched_rest_api_id, pr_number=pr_number) as restapi_git_folder, \
  File "/usr/lib/python3.6/contextlib.py", line 81, in __enter__
    return next(self.gen)
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 272, in manage_git_folder
    clone_to_path(gh_token, temp_dir, split_git_id[0], branch_or_commit=branch, pr_number=pr_number)
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 212, in clone_to_path
    repo.git.checkout(branch_or_commit)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 548, in <lambda>
    return lambda *args, **kwargs: self._call_process(name, *args, **kwargs)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 1014, in _call_process
    return self.execute(call, **exec_kwargs)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 825, in execute
    raise GitCommandError(command, status, stderr_value, stdout_value)
git.exc.GitCommandError: Cmd('git') failed due to: exit code(128)
  cmdline: git checkout eb37417c33959ec52ef1d8bd79cf078b0241fd18
  stderr: 'fatal: reference is not a tree: eb37417c33959ec52ef1d8bd79cf078b0241fd18'

AutorestCI · 2019-03-11T07:21:27Z

Automation for azure-sdk-for-java

Encountered an unknown error: (azure-sdk-for-java)

Traceback (most recent call last):
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 33, in exception_to_github
    yield context
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github.py", line 170, in rest_handle_action
    return rest_pull_close(body, restapi_repo, sdk_pr_target_repo, sdkbase, sdk_tag)
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github.py", line 185, in rest_pull_close
    rest_pr_management(rest_pr, sdk_pr_target_repo, sdk_tag, sdk_default_base)
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github_handler.py", line 151, in rest_pr_management
    sdk_tag=sdk_tag
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/SwaggerToSdkNewCLI.py", line 254, in generate_sdk_from_git_object
    with manage_git_folder(gh_token, Path(temp_dir) / Path("rest"), branched_rest_api_id, pr_number=pr_number) as restapi_git_folder, \
  File "/usr/lib/python3.6/contextlib.py", line 81, in __enter__
    return next(self.gen)
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 272, in manage_git_folder
    clone_to_path(gh_token, temp_dir, split_git_id[0], branch_or_commit=branch, pr_number=pr_number)
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 212, in clone_to_path
    repo.git.checkout(branch_or_commit)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 548, in <lambda>
    return lambda *args, **kwargs: self._call_process(name, *args, **kwargs)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 1014, in _call_process
    return self.execute(call, **exec_kwargs)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 825, in execute
    raise GitCommandError(command, status, stderr_value, stdout_value)
git.exc.GitCommandError: Cmd('git') failed due to: exit code(128)
  cmdline: git checkout eb37417c33959ec52ef1d8bd79cf078b0241fd18
  stderr: 'fatal: reference is not a tree: eb37417c33959ec52ef1d8bd79cf078b0241fd18'

AutorestCI · 2019-03-11T07:21:54Z

Automation for azure-sdk-for-node

A PR has been created for you:
Azure/azure-sdk-for-node#4951

AutorestCI · 2019-03-11T07:22:53Z

Automation for azure-sdk-for-go

Encountered an unknown error: (azure-sdk-for-go)

Traceback (most recent call last):
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 33, in exception_to_github
    yield context
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github.py", line 170, in rest_handle_action
    return rest_pull_close(body, restapi_repo, sdk_pr_target_repo, sdkbase, sdk_tag)
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github.py", line 185, in rest_pull_close
    rest_pr_management(rest_pr, sdk_pr_target_repo, sdk_tag, sdk_default_base)
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github_handler.py", line 151, in rest_pr_management
    sdk_tag=sdk_tag
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/SwaggerToSdkNewCLI.py", line 254, in generate_sdk_from_git_object
    with manage_git_folder(gh_token, Path(temp_dir) / Path("rest"), branched_rest_api_id, pr_number=pr_number) as restapi_git_folder, \
  File "/usr/lib/python3.6/contextlib.py", line 81, in __enter__
    return next(self.gen)
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 272, in manage_git_folder
    clone_to_path(gh_token, temp_dir, split_git_id[0], branch_or_commit=branch, pr_number=pr_number)
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 212, in clone_to_path
    repo.git.checkout(branch_or_commit)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 548, in <lambda>
    return lambda *args, **kwargs: self._call_process(name, *args, **kwargs)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 1014, in _call_process
    return self.execute(call, **exec_kwargs)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 825, in execute
    raise GitCommandError(command, status, stderr_value, stdout_value)
git.exc.GitCommandError: Cmd('git') failed due to: exit code(128)
  cmdline: git checkout eb37417c33959ec52ef1d8bd79cf078b0241fd18
  stderr: 'fatal: reference is not a tree: eb37417c33959ec52ef1d8bd79cf078b0241fd18'

anuchandy · 2019-03-13T15:14:17Z

...rvices/resource-manager/Microsoft.CognitiveServices/stable/2017-04-18/cognitiveservices.json

+          "CognitiveServicesAccounts"
+        ],
+        "operationId": "Locations_CheckDomainAvailabilityPost",
+        "description": "Check available SKUs.",


Is the description correct? I thought this API is to check availability of domain name.

anuchandy · 2019-03-13T15:14:54Z

...rvices/resource-manager/Microsoft.CognitiveServices/stable/2017-04-18/cognitiveservices.json

+        "tags": [
+          "CognitiveServicesAccounts"
+        ],
+        "operationId": "Locations_CheckDomainAvailabilityPost",


it would be good if we can rename operation id to Locations_CheckDomainAvailability, no need to include underneath HTTP verb in the method name

anuchandy · 2019-03-13T15:18:44Z

...rvices/resource-manager/Microsoft.CognitiveServices/stable/2017-04-18/cognitiveservices.json

+            "schema": {
+              "$ref": "#/definitions/CheckDomainAvailabilityParameter"
+            },
+            "description": "Check Domain Availability POST body."


you could say "Check Domain Availability parameter."

dsgouda · 2019-03-18T18:33:48Z

@anuchandy Please disregard the default failures here
It is replaced with Automation for azure-sdk-for-net now

REST Spec PR 'Azure/azure-rest-api-specs#5355' REST Spec PR Author 'DavidLiCIG' REST Spec PR Last commit

adxsdknet · 2019-03-18T18:44:45Z

Automation for azure-sdk-for-net

A PR has been created for you:
Azure/azure-sdk-for-net#5493
.NET SDK Commits:
adxsdknet/azure-sdk-for-net@d0ff9da

anuchandy

@dsgouda thanks for the heads up. @DavidLiCIG can you make necessary updates based on our team discussion?

anuchandy · 2019-04-04T20:17:45Z

@DavidLiCIG could you please update the PR as we discussed?

anuchandy · 2019-04-09T00:49:25Z

Closing due to inactivity. @DavidLiCIG please open a new PR when you're ready. thanks!

* Move ProvisioningState * Update dstsServiceClientIdentity.json * Update CreateDstsServiceAccount.json * Update CreateDstsServiceClientIdentity.json * Update GetAllDstsServiceAccount.json * Update GetAllDstsServiceClientIdentity.json * Update GetDstsServiceAccount.json * Update GetDstsServiceAccountUnderResourceGroup.json * Update GetDstsServiceClientIdentity.json * Update GetDstsServiceClientIdentityUnderResourceGroup.json * Update PatchDstsServiceAccount.json * Update PatchDstsServiceClientIdentity.json

DavidLiCIG and others added 20 commits July 25, 2017 23:17

Adding data plane spec starting with Face

5e734a0

Move Spec to right folder

e8f1ee2

Fixing validation issues.

c56cc0e

Fixing issues and adding a readme.md

e46c1ff

Fixing examples by removing decimals.

53aff4a

Removing another decimal value

c529bbb

Update readme.md

93cb8ef

Updating spec based on comments.

95cac3a

Removing .gitignore.

3de638b

Changing namespace to include category.

16d9650

Adding ComputerVision jsopn

b0bd08e

Merge from remote

d10d86a

Merge from main

dcbcfc9

Merge branch 'master' of e:\code\azure-rest-api-specs into current

22f9aa0

Add checkdomain availability

69c4aeb

Adding missing properties

676984a

Fix example error

1fad59a

Merge branch 'davl/AddCheckDomainAvailability' into dev-cognitiveserv…

f1c5785

…ices-Microsoft.CognitiveServices-2017-04-18

Changing operation id based on linter feedback

21797ee

Update operation Id based on linter requirements

c69a621

DavidLiCIG requested a review from yangyuan as a code owner March 11, 2019 07:20

AutorestCI mentioned this pull request Mar 11, 2019

[AutoPR cognitiveservices/resource-manager] [Hub Generated] Review request for Microsoft.CognitiveServices to add version 2017-04-18 Azure/azure-sdk-for-python#4525

Closed

AutorestCI mentioned this pull request Mar 11, 2019

[AutoPR cognitiveservices/resource-manager] [Hub Generated] Review request for Microsoft.CognitiveServices to add version 2017-04-18 Azure/azure-sdk-for-js#1507

Closed

azuresdkci assigned anuchandy Mar 11, 2019

azuresdkci requested a review from anuchandy March 11, 2019 07:21

AutorestCI mentioned this pull request Mar 11, 2019

[AutoPR cognitiveservices/resource-manager] [Hub Generated] Review request for Microsoft.CognitiveServices to add version 2017-04-18 Azure/azure-sdk-for-ruby#2302

Closed

AutorestCI mentioned this pull request Mar 11, 2019

[AutoPR cognitiveservices/resource-manager] [Hub Generated] Review request for Microsoft.CognitiveServices to add version 2017-04-18 Azure/azure-sdk-for-node#4861

Closed

AutorestCI mentioned this pull request Mar 11, 2019

[AutoPR cognitiveservices/resource-manager] [Hub Generated] Review request for Microsoft.CognitiveServices to add version 2017-04-18 Azure/azure-sdk-for-go#4249

Closed

REmoved redundant cv json

30149a9

Change account to locations

14f19b5

AutorestCI mentioned this pull request Mar 12, 2019

[AutoPR cognitiveservices/resource-manager] [Hub Generated] Review request for Microsoft.CognitiveServices to add version 2017-04-18 Azure/azure-sdk-for-java#3088

Closed

anuchandy reviewed Mar 13, 2019

View reviewed changes

dsgouda closed this Mar 18, 2019

dsgouda reopened this Mar 18, 2019

adxsdknet added a commit to adxsdknet/azure-sdk-for-net that referenced this pull request Mar 18, 2019

.NET SDK Resource Provider:'CognitiveServices'

d0ff9da

REST Spec PR 'Azure/azure-rest-api-specs#5355' REST Spec PR Author 'DavidLiCIG' REST Spec PR Last commit

anuchandy requested changes Mar 21, 2019

View reviewed changes

anuchandy closed this Apr 9, 2019

Conversation

DavidLiCIG commented Mar 11, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Contribution checklist:

Uh oh!

azuresdkci commented Mar 11, 2019

Uh oh!

AutorestCI commented Mar 11, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Automation for azure-sdk-for-python

Uh oh!

AutorestCI commented Mar 11, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Automation for azure-sdk-for-js

Uh oh!

AutorestCI commented Mar 11, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Automation for azure-sdk-for-ruby

Uh oh!

AutorestCI commented Mar 11, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Automation for azure-sdk-for-java

Uh oh!

AutorestCI commented Mar 11, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Automation for azure-sdk-for-node

Uh oh!

AutorestCI commented Mar 11, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Automation for azure-sdk-for-go

Uh oh!

anuchandy Mar 13, 2019

Choose a reason for hiding this comment

Uh oh!

anuchandy Mar 13, 2019

Choose a reason for hiding this comment

Uh oh!

anuchandy Mar 13, 2019

Choose a reason for hiding this comment

Uh oh!

dsgouda commented Mar 18, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

adxsdknet commented Mar 18, 2019

Automation for azure-sdk-for-net

Uh oh!

anuchandy left a comment

Choose a reason for hiding this comment

Uh oh!

anuchandy commented Apr 4, 2019

Uh oh!

anuchandy commented Apr 9, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

DavidLiCIG commented Mar 11, 2019 •

edited

Loading

AutorestCI commented Mar 11, 2019 •

edited

Loading

AutorestCI commented Mar 11, 2019 •

edited

Loading

AutorestCI commented Mar 11, 2019 •

edited

Loading

AutorestCI commented Mar 11, 2019 •

edited

Loading

AutorestCI commented Mar 11, 2019 •

edited

Loading

AutorestCI commented Mar 11, 2019 •

edited

Loading

dsgouda commented Mar 18, 2019 •

edited

Loading