Merge Network release branch into master #5189
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…01 to version 2018-12-01
* Add ddosCustomPolicy.json to readme.md and fix spec errors (Azure#5008) * Update ddosCustomPolicy.json in 2018-12-01
…s under applicationGatewayProperties (Azure#5009)
* Added Prepare action documentation * Took carte of the errors from the validation tool * Error fixes from validation tool * Adding a typo and a missing property
* Changes in the existing APIs result format. * adding proxyresource to server variables APIs result * Updating applicationgateway.json * Update applicationGateway.json * add Go SDK build for 2018-12-01 * changes to pythonand ruby readme files * Update readme.ruby.md * adding jave readme changes * Minor Fix in spacing * Creating a new tag for 2018-12 version * Update readme.python.md * Update applicationGateway.json * fixing examples * examples
* Fixed issue: Azure#4721 * Reverted fixes in networkWatcher in previous versions. Left only fix in 2018-12-01
* Threat Intel changes for Azure Firewall * Move the property to the end of the list
# Conflicts: # specification/network/resource-manager/readme.go.md # specification/network/resource-manager/readme.python.md
Automation for azure-sdk-for-jsA PR has been created for you: |
Automation for azure-sdk-for-rubyA PR has been created for you: |
Automation for azure-sdk-for-pythonA PR has been created for you: |
Automation for azure-sdk-for-nodeA PR has been created for you: |
Automation for azure-sdk-for-javaEncountered an unknown error: (azure-sdk-for-java)
Traceback (most recent call last):
File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 33, in exception_to_github
yield context
File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github.py", line 170, in rest_handle_action
return rest_pull_close(body, restapi_repo, sdk_pr_target_repo, sdkbase, sdk_tag)
File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github.py", line 185, in rest_pull_close
rest_pr_management(rest_pr, sdk_pr_target_repo, sdk_tag, sdk_default_base)
File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github_handler.py", line 151, in rest_pr_management
sdk_tag=sdk_tag
File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/SwaggerToSdkNewCLI.py", line 310, in generate_sdk_from_git_object
sdk_repo.git.push('origin', branch_name, set_upstream=True)
File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 548, in <lambda>
return lambda *args, **kwargs: self._call_process(name, *args, **kwargs)
File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 1014, in _call_process
return self.execute(call, **exec_kwargs)
File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 825, in execute
raise GitCommandError(command, status, stderr_value, stdout_value)
git.exc.GitCommandError: Cmd('git') failed due to: exit code(128)
cmdline: git push --set-upstream origin restapi_auto_5189
stderr: 'remote: Permission to Azure/azure-sdk-for-java.git denied to AutorestCI.
fatal: unable to access 'https://AutorestCI:[email protected]/Azure/azure-sdk-for-java.git/': The requested URL returned error: 403' |
Automation for azure-sdk-for-goA PR has been created for you: |
anton-evseev
force-pushed
the
merge-network-release
branch
from
a7c6a1b to
eca9d58
Compare
Contributor
|
Can one of the admins verify this patch? |
anton-evseev
force-pushed
the
merge-network-release
branch
from
eca9d58 to
8ad6916
Compare
This was referenced Feb 12, 2019
5 tasks
This was referenced Feb 12, 2019
Contributor
Author
|
@dsgouda @sergey-shandar please take a look |
Contributor
|
LGTM @salameer please find any great guy from your team to merge it :) |
MikhailTryakhov
approved these changes
Feb 13, 2019
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
11 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since I don't have write access, I'm using my own fork.
This is branch
network-january-releaseplus merge conflict resolution (cf5b233) and fixes for typos found by @nschonni (8ad6916)Contribution checklist:
ARM API Review Checklist
Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.
Please follow the link to find more details on API review process.