Fix errors in ddosCustomPolicy.json#5013
Merged
sergey-shandar merged 2 commits intoAzure:network-january-releasefrom Jan 18, 2019
Merged
Fix errors in ddosCustomPolicy.json#5013sergey-shandar merged 2 commits intoAzure:network-january-releasefrom
sergey-shandar merged 2 commits intoAzure:network-january-releasefrom
Conversation
Contributor
|
Can one of the admins verify this patch? |
Automation for azure-sdk-for-jsA PR has been created for you: |
Automation for azure-sdk-for-rubyNothing to generate for azure-sdk-for-ruby |
Automation for azure-sdk-for-pythonNothing to generate for azure-sdk-for-python |
Automation for azure-sdk-for-goNothing to generate for azure-sdk-for-go |
Automation for azure-sdk-for-nodeA PR has been created for you: |
Automation for azure-sdk-for-javaNothing to generate for azure-sdk-for-java |
anton-evseev
force-pushed
the
ddos-policy-update
branch
from
93b82c2 to
18718e2
Compare
Contributor
Author
|
CI keeps failing with OutOfMemory error |
sergey-shandar
approved these changes
Jan 10, 2019
Contributor
|
@sarangan12 Could you have a look the lintdiff problem? |
5 tasks
anton-evseev
force-pushed
the
ddos-policy-update
branch
from
a7dca58 to
18718e2
Compare
5 tasks
Contributor
Author
|
@sergey-shandar @sarangan12 could you please take a look? We have other PRs blocked by this issue |
5 tasks
Contributor
|
@MikhailTryakhov could you review the PR please? |
Contributor
|
@sergey-shandar @number213 we don't need modifications for older api versions.. looks like changes merged are made for |
Contributor
Author
Contributor
|
@number213 but about versions are about |
sergey-shandar
pushed a commit
that referenced
this pull request
Feb 13, 2019
* Adds base for updating Microsoft.Network from version stable/2018-11-01 to version 2018-12-01 * Updates readme * Updates API version in new specs and examples * fixing invalid paths in frontdoor (#4991) * add max bound for application gateway autoscale config (#4996) * fixing location in network samples (#4992) * Fix duplicate path in old Network API versions (#5003) * missing location in route tables (#5024) * removed confusing readonly parameters from example (#5022) * Fix errors in ddosCustomPolicy.json (#5013) * Add ddosCustomPolicy.json to readme.md and fix spec errors (#5008) * Update ddosCustomPolicy.json in 2018-12-01 * Pick AppGw changes from 2018-11-01 (#5044) * Adding the structure of ruleSequence and conditions in rewriteRuleSets under applicationGatewayProperties (#5009) * Added Prepare action for subnet (#5058) * Added Prepare action documentation * Took carte of the errors from the validation tool * Error fixes from validation tool * Adding a typo and a missing property * updated the destination address description to also include service tags (#5112) * Update for Get Application Gateway Server Variables APIs (#5113) * Changes in the existing APIs result format. * adding proxyresource to server variables APIs result * Updating applicationgateway.json * Update applicationGateway.json * add Go SDK build for 2018-12-01 * changes to pythonand ruby readme files * Update readme.ruby.md * adding jave readme changes * Minor Fix in spacing * Creating a new tag for 2018-12 version * Update readme.python.md * Update applicationGateway.json * fixing examples * examples * Fixed issue: #4721 (#5087) * Fixed issue: #4721 * Reverted fixes in networkWatcher in previous versions. Left only fix in 2018-12-01 * Threat Intel changes for Azure Firewall (#5143) * Threat Intel changes for Azure Firewall * Move the property to the end of the list * Fix typos in Network 2018-12-01
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Porting #5008 to Network's release branch
Contribution checklist:
ARM API Review Checklist
Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.
Please follow the link to find more details on API review process.