Network December release

.github/PULL_REQUEST_TEMPLATE.md

@@ -5,13 +5,3 @@
 - [ ] I have reviewed the [documentation](https://github.com/Azure/azure-rest-api-specs#basics) for the workflow.
 - [ ] [Validation tools](https://github.com/Azure/azure-rest-api-specs/blob/master/documentation/swagger-checklist.md#validation-tools-for-swagger-checklist) were run on swagger spec(s) and have all been fixed in this PR.
 - [ ] The [OpenAPI Hub](https://aka.ms/openapiportal) was used for checking validation status and next steps.
-### ARM API Review Checklist
-- [ ] Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories. 
-- adding/removing APIs.
-- adding/removing properties.
-- adding/removing API-version. 
-- adding a new service in Azure.
-
-Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.
-- [ ] If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them. 
-Please follow the link to find more details on [API review process](https://armwiki.azurewebsites.net/rp_onboarding/ResourceProviderOnboardingAPIRevieworkflow.html).

arm-compute/quickstart-templates/aliases.json

@@ -14,7 +14,7 @@
           "CentOS":{
             "publisher":"OpenLogic",
             "offer":"CentOS",
-            "sku":"7.5",
+            "sku":"7.3",
             "version":"latest"
           },
           "CoreOS":{
@@ -38,7 +38,7 @@
           "RHEL":{
             "publisher":"RedHat",
             "offer":"RHEL",
-            "sku":"7-RAW",
+            "sku":"7.3",
             "version":"latest"
           },
           "SLES":{

azure-rest-api-specs.sln

@@ -0,0 +1,22 @@
+
+Microsoft Visual Studio Solution File, Format Version 12.00
+# Visual Studio 14
+VisualStudioVersion = 14.0.25420.1
+MinimumVisualStudioVersion = 10.0.40219.1
+Project("{9092AA53-FB77-4645-B42D-1CCCA6BD08BD}") = "azure-rest-api-specs", "azure-rest-api-specs.njsproj", "{4927D984-A20D-4F8B-AA4A-B1BAFD1896E6}"
+EndProject
+Global
+	GlobalSection(SolutionConfigurationPlatforms) = preSolution
+		Debug|Any CPU = Debug|Any CPU
+		Release|Any CPU = Release|Any CPU
+	EndGlobalSection
+	GlobalSection(ProjectConfigurationPlatforms) = postSolution
+		{4927D984-A20D-4F8B-AA4A-B1BAFD1896E6}.Debug|Any CPU.ActiveCfg = Debug|Any CPU
+		{4927D984-A20D-4F8B-AA4A-B1BAFD1896E6}.Debug|Any CPU.Build.0 = Debug|Any CPU
+		{4927D984-A20D-4F8B-AA4A-B1BAFD1896E6}.Release|Any CPU.ActiveCfg = Release|Any CPU
+		{4927D984-A20D-4F8B-AA4A-B1BAFD1896E6}.Release|Any CPU.Build.0 = Release|Any CPU
+	EndGlobalSection
+	GlobalSection(SolutionProperties) = preSolution
+		HideSolutionNode = FALSE
+	EndGlobalSection
+EndGlobal

package.json

@@ -13,17 +13,16 @@
     "@microsoft.azure/async-io": "^1.0.21",
     "@microsoft.azure/literate": "^1.0.21",
     "@microsoft.azure/polyfill": "^1.0.17",
-    "@ts-common/local-install": "^0.0.8",
     "fs-extra": "^3.0.1",
     "glob": "^5.0.14",
     "js-yaml": "^3.8.2",
     "json-schema-ref-parser": "^3.1.2",
     "mocha": "*",
     "oad": "^0.1.11",
-    "oav": "^0.9.6",
+    "oav": "^0.8.1",
     "request": "^2.61.0",
     "request-promise-native": "^1.0.5",
-    "z-schema": "^3.24.2"
+    "z-schema": "^3.16.1"
   },
   "dependencies": {
     "@octokit/rest": "^15.2.6"
@@ -37,8 +36,6 @@
     "url": "https://github.com/azure/azure-rest-api-specs/issues"
   },
   "scripts": {
-    "test": "mocha -t 500000 --reporter min",
-    "oav": "oav",
-    "li": "local-install"
+    "test": "mocha -t 500000 --reporter min"
   }
 }

scripts/semanticValidation.js

@@ -13,12 +13,7 @@ async function main() {
   //   return (item.match(/.*Microsoft.Logic.*2016-06-01.*/ig) !== null);
   // });
   for (const swagger of swaggersToProcess) {
-    try {
-      await oav.validateSpec(swagger, {consoleLogLevel: 'error', pretty: true});
-    } catch (e) {
-      console.error("error: ")
-      console.error(e)
-    }
+    await oav.validateSpec(swagger, {consoleLogLevel: 'error', pretty: true});
   }
 }
 

specification/adhybridhealthservice/resource-manager/Microsoft.ADHybridHealthService/stable/2014-01-01/ADHybridHealthService.json

@@ -3,7 +3,7 @@
   "info": {
     "version": "2014-01-01",
     "title": "ADHybridHealthService",
-    "description": "REST APIs for Azure Active Directory Connect Health"
+    "description": "REST APIs for Azure Active Drectory Connect Health"
   },
   "host": "management.azure.com",
   "schemes": [ "https" ],

specification/apimanagement/control-plane/Microsoft.ApiManagement/preview/2017-03-01/apimapis.json

@@ -77,7 +77,7 @@
         ],
         "responses": {
           "200": {
-            "description": "Paged Result response of Apis.",
+            "description": "Paged Result reponse of Apis.",
             "schema": {
               "$ref": "#/definitions/ApiCollection"
             }

specification/apimanagement/control-plane/Microsoft.ApiManagement/preview/2017-03-01/apimgroups.json

@@ -160,7 +160,7 @@
         ],
         "responses": {
           "201": {
-            "description": "Group was created successfully.",
+            "description": "Group was created succesfully.",
             "schema": {
               "$ref": "#/definitions/GroupContract"
             }

specification/apimanagement/control-plane/Microsoft.ApiManagement/preview/2017-03-01/apimproducts.json

@@ -226,7 +226,7 @@
         ],
         "responses": {
           "204": {
-            "description": "No Content in case of Update Successful."
+            "description": "No Content in case of Update Successfull."
           },
           "default": {
             "description": "Error response describing why the operation failed.",

specification/apimanagement/control-plane/Microsoft.ApiManagement/preview/2017-03-01/apimproperties.json

@@ -231,7 +231,7 @@
           "Property"
         ],
         "operationId": "Property_Delete",
-        "description": "Deletes specific property from the API Management service instance.",
+        "description": "Deletes specific property from the the API Management service instance.",
         "x-ms-examples": {
           "ApiManagementDeleteProperties": {
             "$ref": "./examples/ApiManagementDeleteProperties.json"

specification/apimanagement/control-plane/Microsoft.ApiManagement/preview/2017-03-01/apimreports.json

@@ -224,7 +224,7 @@
           "Reports"
         ],
         "operationId": "Reports_ListByGeo",
-        "description": "Lists report records by geography.",
+        "description": "Lists report records by GeoGraphy.",
         "x-ms-examples": {
           "ApiManagementGetReportsByGeo": {
             "$ref": "./examples/ApiManagementGetReportsByGeo.json"
@@ -338,7 +338,7 @@
             "required": true,
             "type": "string",
             "format": "duration",
-            "description": "By time interval. Interval must be multiple of 15 minutes and may not be zero. The value should be in ISO  8601 format (http://en.wikipedia.org/wiki/ISO_8601#Durations).This code can be used to convert TimeSpan to a valid interval string: XmlConvert.ToString(new TimeSpan(hours, minutes, seconds))"
+            "description": "By time interval. Interval must be multiple of 15 minutes and may not be zero. The value should be in ISO  8601 format (http://en.wikipedia.org/wiki/ISO_8601#Durations).This code can be used to convert TimeSpan to a valid interval string: XmlConvert.ToString(new TimeSpan(hours, minutes, secconds))"
           },
           {
             "$ref": "./apimanagement.json#/parameters/ApiVersionParameter"
@@ -438,7 +438,7 @@
         },
         "interval": {
           "type": "string",
-          "description": "Length of aggregation period.  Interval must be multiple of 15 minutes and may not be zero. The value should be in ISO 8601 format (http://en.wikipedia.org/wiki/ISO_8601#Durations)."
+          "description": "Length of agregation period.  Interval must be multiple of 15 minutes and may not be zero. The value should be in ISO 8601 format (http://en.wikipedia.org/wiki/ISO_8601#Durations)."
         },
         "country": {
           "type": "string",
@@ -481,12 +481,12 @@
         "callCountSuccess": {
           "type": "integer",
           "format": "int32",
-          "description": "Number of successful calls. This includes calls returning HttpStatusCode <= 301 and HttpStatusCode.NotModified and HttpStatusCode.TemporaryRedirect"
+          "description": "Number of succesful calls. This includes calls returning HttpStatusCode <= 301 and HttpStatusCode.NotModified and HttpStatusCode.TemporaryRedirect"
         },
         "callCountBlocked": {
           "type": "integer",
           "format": "int32",
-          "description": "Number of calls blocked due to invalid credentials. This includes calls returning HttpStatusCode.Unauthorized and HttpStatusCode.Forbidden and HttpStatusCode.TooManyRequests"
+          "description": "Number of calls blocked due to invalid credentials. This includes calls returning HttpStatusCode.Unauthorize and HttpStatusCode.Forbidden and HttpStatusCode.TooManyRequests"
         },
         "callCountFailed": {
           "type": "integer",
@@ -621,7 +621,7 @@
         },
         "cache": {
           "type": "string",
-          "description": "Specifies if response cache was involved in generating the response. If the value is none, the cache was not used. If the value is hit, cached response was returned. If the value is miss, the cache was used but lookup resulted in a miss and request was fulfilled by the backend."
+          "description": "Specifies if response cache was involved in generating the response. If the value is none, the cache was not used. If the value is hit, cached response was returned. If the value is miss, the cache was used but lookup resulted in a miss and request was fullfilled by the backend."
         },
         "apiTime": {
           "type": "number",

specification/apimanagement/control-plane/Microsoft.ApiManagement/preview/2017-03-01/apimsubscriptions.json

@@ -199,7 +199,7 @@
           "Subscriptions"
         ],
         "operationId": "Subscription_Update",
-        "description": "Updates the details of a subscription specified by its identifier.",
+        "description": "Updates the details of a subscription specificied by its identifier.",
         "x-ms-examples": {
           "ApiManagementPatchSubscriptions": {
             "$ref": "./examples/ApiManagementPatchSubscriptions.json"
@@ -486,7 +486,7 @@
         },
         "productId": {
           "type": "string",
-          "description": "Product (product id path) for which subscription is being created in form /products/{productId}"
+          "description": "Product (product id path) for which subscription is being created in form /products/{productid}"
         },
         "name": {
           "type": "string",

specification/apimanagement/control-plane/Microsoft.ApiManagement/preview/2017-03-01/apimtenant.json

@@ -338,7 +338,7 @@
             "description": "Accepted: Location header contains the URL where the status of the long running operation can be checked."
           },
           "200": {
-            "description": "Result of applying changes from Git branch to database.",
+            "description": "Result of appplying changes from Git branch to database.",
             "schema": {
               "$ref": "#/definitions/OperationResultContract"
             }

specification/apimanagement/resource-manager/Microsoft.ApiManagement/preview/2018-06-01-preview/apimapis.json

@@ -919,9 +919,6 @@
         "x-ms-examples": {
           "ApiManagementGetApiOperation": {
             "$ref": "./examples/ApiManagementGetApiOperation.json"
-          },
-          "ApiManagementGetApiOperationPetstore": {
-            "$ref": "./examples/ApiManagementGetApiOperationPetstore.json"
           }
         },
         "parameters": [
@@ -2127,7 +2124,7 @@
         ],
         "responses": {
           "200": {
-            "description": "Paged Result response of diagnostics for an API.",
+            "description": "Paged Result reponse of diagnostics for an API.",
             "schema": {
               "$ref": "./apimdiagnostics.json#/definitions/DiagnosticCollection"
             }
@@ -2422,7 +2419,7 @@
           "ApiIssues"
         ],
         "operationId": "ApiIssue_ListByService",
-        "description": "Lists all issues associated with the specified API.",
+        "description": "Lists all issues assosiated with the specified API.",
         "x-ms-examples": {
           "ApiManagementListApiIssues": {
             "$ref": "./examples/ApiManagementListApiIssues.json"
@@ -2460,7 +2457,7 @@
         ],
         "responses": {
           "200": {
-            "description": "Paged Result response of issues for the API.",
+            "description": "Paged Result reponse of issues for the API.",
             "schema": {
               "$ref": "#/definitions/IssueCollection"
             }
@@ -2767,7 +2764,7 @@
           "ApiIssueComments"
         ],
         "operationId": "ApiIssueComment_ListByService",
-        "description": "Lists all comments for the Issue associated with the specified API.",
+        "description": "Lists all comments for the Issue assosiated with the specified API.",
         "x-ms-examples": {
           "ApiManagementListApiIssueComments": {
             "$ref": "./examples/ApiManagementListApiIssueComments.json"
@@ -2808,7 +2805,7 @@
         ],
         "responses": {
           "200": {
-            "description": "Paged Result response of issue comments for the API.",
+            "description": "Paged Result reponse of issue comments for the API.",
             "schema": {
               "$ref": "#/definitions/IssueCommentCollection"
             }
@@ -3068,7 +3065,7 @@
           "ApiIssueAttachments"
         ],
         "operationId": "ApiIssueAttachment_ListByService",
-        "description": "Lists all comments for the Issue associated with the specified API.",
+        "description": "Lists all comments for the Issue assosiated with the specified API.",
         "x-ms-examples": {
           "ApiManagementListApiIssueAttachments": {
             "$ref": "./examples/ApiManagementListApiIssueAttachments.json"
@@ -3109,7 +3106,7 @@
         ],
         "responses": {
           "200": {
-            "description": "Paged Result response of issue comments for the API.",
+            "description": "Paged Result reponse of issue comments for the API.",
             "schema": {
               "$ref": "#/definitions/IssueAttachmentCollection"
             }