Network December release by seyedfayaz · Pull Request #4605 · Azure/azure-rest-api-specs

seyedfayaz · 2018-11-29T00:18:35Z

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

I have reviewed the documentation for the workflow.
Validation tools were run on swagger spec(s) and have all been fixed in this PR.
The OpenAPI Hub was used for checking validation status and next steps.

…01 to version 2018-10-01

* Update specification/network/resource-manager/Microsoft.Network/stable/2018-08-01/networkWatcher.json [Networkwatcher] add a new field "Format" with new type"FlowLogFormat" to FlowLogProperties * Revert "Update specification/network/resource-manager/Microsoft.Network/stable/2018-08-01/networkWatcher.json" This reverts commit f4f438a. * Update specification/network/resource-manager/Microsoft.Network/stable/2018-10-01/networkWatcher.json [networkwatcer] add FlowLogFormatParameters

…ure#4420)

…ddos policy customization

…ceid (Azure#4459)

* Adds base for updating Microsoft.Network from version stable/2018-08-01 to version 2018-10-01 * Updates readme * Updates API version in new specs and examples * Adds Rewrite rule set for Header CRUD Adds the structure of rewriteRuleSets in the applicationGatewayProperties. Adds recursively the sub structures in the rewriteRuleSet. Adds the reference to rewriteRuleSet in the requestRoutingRule for both Basic rule and Path based rule. * Adds examples for the Header CRUD in application gateway * Fix the examples; replacing rules with rewriteRules. * Fixing the properties of application Gateway rewriteRule * Revert "Fixing the properties of application Gateway rewriteRule" This reverts commit 05c9c91. * Fixing the properties of application Gateway rewriteRule * Mark the provisioning state as readOnly * Mark etag as readOnly

…rces" (Azure#4467) * Revert "Application Gateway - Adds Rewrite rule set for Header CRUD (Azure#4331)" This reverts commit 633d12d. * Revert "Port fix from PR 4459 to 2018-10-01 (Azure#4463)" This reverts commit 5ea0c7b. * Revert "change container nics property type on container nic config to resourceid (Azure#4459)" This reverts commit baf31d9.

* identity and keyvault * Capitalization comment

…zure-rest-api-specs into network-november-release

…licy

sergey-shandar · 2018-12-06T22:34:56Z

@MikhailTryakhov is there anything else has to be addressed?

sergey-shandar

Please, check model validation errors: https://travis-ci.org/Azure/azure-rest-api-specs/jobs/464638112

specification/network/resource-manager/Microsoft.Network/stable/2018-11-01/publicIpAddress.json

...ification/network/resource-manager/Microsoft.Network/stable/2018-11-01/ddosCustomPolicy.json

specification/network/resource-manager/Microsoft.Network/stable/2018-11-01/publicIpAddress.json

ravbhatnagar

Just a couple of minor notes. else looks fine

...ification/network/resource-manager/Microsoft.Network/stable/2018-11-01/ddosCustomPolicy.json

nschonni · 2018-12-11T22:51:53Z

It looks like there was a bad merge somewhere and a bunch of files are being reverted and removed

ravbhatnagar · 2018-12-12T08:27:46Z

Signing off from ARM side.

hovsepm · 2018-12-14T00:02:57Z

@seyedfayaz please rebase this PR and fix merge conflicts.

MikhailTryakhov · 2018-12-14T00:33:02Z

@seyedfayaz you pushed us hard with all the team, but no actions visible now...

jianghaolu

Other reviews are not available until syntax issues are fixed. At this moment errors from other tools don't make sense.

jianghaolu · 2018-12-17T18:24:12Z

...ification/network/resource-manager/Microsoft.Network/stable/2018-11-01/ddosCustomPolicy.json

+            "description": "The name of the DDoS custom policy."
+          },
+          {
+            "$ref": "./network.json#/parameters/ApiVersionParameter"


There's no 'network.json' under 2018-11-01 folder.

jianghaolu · 2018-12-17T18:24:55Z

specification/network/resource-manager/Microsoft.Network/stable/2018-11-01/publicIpAddress.json

@@ -3,7 +3,7 @@
  "info": {
    "title": "NetworkManagementClient",
    "description": "The Microsoft Azure Network management API provides a RESTful set of web services that interact with Microsoft Azure Networks service to manage your network resources. The API has entities that capture the relationship between an end user and the Microsoft Azure Networks service.",
-    "version": "2018-11-01"
+    "version": "2018-12-01"


Should this file be moved to 2018-12-01?

AFAIK there is no 2018-12-01, the last NRP version this year is going to be 2018-11-01
@MikhailTryakhov please take a look

Okay we have a 2018-12-01 folder and a bunch of specs with version=2018-12-01. They should be reverted to 2018-11-01?

ping @MikhailTryakhov

@jianghaolu @seyedfayaz @number213 of cause they should be reverted to 2018-11-01

jianghaolu · 2019-01-04T01:10:53Z

Please reopen and target january-network-release.

MikhailTryakhov and others added 30 commits October 30, 2018 12:42

Adds base for updating Microsoft.Network from version stable/2018-08-…

a656032

…01 to version 2018-10-01

Updates readme

c3cd206

Updates API version in new specs and examples

1c4c949

[Network wathcer] add a new field trafficAnalyticsInterval for TA (Az…

66d8777

…ure#4420)

Make NIC VM ref readonly (Azure#4443)

92d2e0a

Mark private IP address read-only (Azure#4447)

5a95c8f

partial commit

ad231a9

tmp

b085e99

ddosPolicyCustomization swagger swagger -- no examples

36663fe

swagger spec for pulic ip resource and ddos custom policy to support …

fef85a8

…ddos policy customization

examples added for ddos custom policy swagger spec

2255e50

swagger spec for ddos policy customization

193e9b1

change container nics property type on container nic config to resour…

baf31d9

…ceid (Azure#4459)

updating 2018-10-01 for ddos policy customization

28471e0

Port fix from PR 4459 to 2018-10-01 (Azure#4463)

5ea0c7b

removing changes made in 2018-08-01/

ff0455d

temp commit

d6a9233

fixing ip resource references to ddos custom policies

eb4a73a

minor fixes

63d73ae

Fixes the missing array for the header actions (Azure#4497)

f321a6c

Network py 2018-10

8f92958

add package-2018-10 to Go SDK codegen

d5e3525

Application gateway Identity and Keyvault support (Azure#4387)

e582297

* identity and keyvault * Capitalization comment

Ported fix from master branch (Azure#4547)

89199d6

Merge branch 'network-november-release' of https://github.com/Azure/a…

6061438

…zure-rest-api-specs into network-november-release

fixing ddossetting definition in public ip address json

c51e9d3

1) misc fixes, 2) added pulic ip address creation with ddos custom po…

c72003b

…licy

This was referenced Dec 6, 2018

[AutoPR network/resource-manager] Network December release Azure/azure-sdk-for-node#4377

Closed

[AutoPR network/resource-manager] Network December release Azure/azure-sdk-for-java#2748

Closed

seyedfayaz force-pushed the network-november-release branch from 496b147 to 312452a Compare December 6, 2018 20:32

sergey-shandar added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Dec 6, 2018

sergey-shandar suggested changes Dec 6, 2018

View reviewed changes

specification/network/resource-manager/Microsoft.Network/stable/2018-11-01/publicIpAddress.json Show resolved Hide resolved

KrisBash added the ARMChangesRequested label Dec 7, 2018

anton-evseev reviewed Dec 7, 2018

View reviewed changes

sergey-shandar added the Reassign label Dec 7, 2018

azuresdkci removed the Reassign label Dec 7, 2018

azuresdkci assigned jianghaolu and unassigned sergey-shandar Dec 7, 2018

azuresdkci requested a review from jianghaolu December 7, 2018 23:33

ravbhatnagar reviewed Dec 10, 2018

View reviewed changes

...ification/network/resource-manager/Microsoft.Network/stable/2018-11-01/ddosCustomPolicy.json Outdated Show resolved Hide resolved

...ification/network/resource-manager/Microsoft.Network/stable/2018-11-01/ddosCustomPolicy.json Outdated Show resolved Hide resolved

seyedfayaz force-pushed the network-november-release branch from ad6d1e9 to 496b147 Compare December 11, 2018 22:31

seyedfayaz requested review from hitenjava, naveedaz, schaabs, solankisamir and yangyuan as code owners December 11, 2018 22:31

ravbhatnagar added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed ARMChangesRequested WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Dec 12, 2018

jianghaolu suggested changes Dec 17, 2018

View reviewed changes

jianghaolu closed this Jan 4, 2019

Conversation

seyedfayaz commented Nov 29, 2018

Latest improvements:

Contribution checklist:

Uh oh!

sergey-shandar commented Dec 6, 2018

Uh oh!

sergey-shandar left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ravbhatnagar left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

nschonni commented Dec 11, 2018

Uh oh!

ravbhatnagar commented Dec 12, 2018

Uh oh!

hovsepm commented Dec 14, 2018

Uh oh!

MikhailTryakhov commented Dec 14, 2018

Uh oh!

jianghaolu left a comment

Choose a reason for hiding this comment

Uh oh!

jianghaolu Dec 17, 2018

Choose a reason for hiding this comment

Uh oh!

jianghaolu Dec 17, 2018

Choose a reason for hiding this comment

Uh oh!

anton-evseev Dec 18, 2018

Choose a reason for hiding this comment

Uh oh!

jianghaolu Dec 19, 2018

Choose a reason for hiding this comment

Uh oh!

anton-evseev Dec 25, 2018

Choose a reason for hiding this comment

Uh oh!

MikhailTryakhov Dec 26, 2018

Choose a reason for hiding this comment

Uh oh!

jianghaolu commented Jan 4, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

20 participants