Skip to content

Fix Go SDK codegen for some RPs #4128

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jhendrixMSFT merged 1 commit into from
Oct 10, 2018
Merged

Fix Go SDK codegen for some RPs #4128

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 1 addition & 11 deletions specification/analysisservices/resource-manager/readme.go.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,6 @@ go:
``` yaml $(go) && $(multiapi)
batch:
- tag: package-2017-08
- tag: package-2017-08-beta
- tag: package-2017-07
- tag: package-2016-05
```
Expand All @@ -28,15 +27,6 @@ Please also specify `--go-sdk-folder=<path to the root directory of your azure-s
output-folder: $(go-sdk-folder)/services/analysisservices/mgmt/2017-08-01/analysisservices
```

### Tag: package-2017-08-beta and go

Copy link
Copy Markdown

@vladbarosan vladbarosan Oct 10, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why are we removing this ?

Copy link
Copy Markdown
Member Author

@jhendrixMSFT jhendrixMSFT Oct 10, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was replaced by a stable version.

Copy link
Copy Markdown

@vladbarosan vladbarosan Oct 10, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so this one actually doesnt exist ?

These settings apply only when `--tag=package-2017-08-beta --go` is specifined on the command line.
Please also specify `--go-sdk-folder=<path to the root directory of your azure-sdk-for-go clone>`.

``` yaml $(tag) == 'package-2017-08-beta' && $(go)
output-folder: $(go-sdk-folder)/services/preview/analysisservices/preview/mgmt/2017-08-01-beta/analysisservices
```

### Tag: package-2017-07 and go

These settings apply only when `--tag=package-2017-07 --go` is specified on the command line.
Expand All @@ -53,4 +43,4 @@ Please also specify `--go-sdk-folder=<path to the root directory of your azure-s

``` yaml $(tag) == 'package-2016-05' && $(go)
output-folder: $(go-sdk-folder)/services/analysisservices/mgmt/2016-05-16/analysisservices
```
```
4 changes: 2 additions & 2 deletions specification/automation/resource-manager/readme.go.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ These settings apply only when `--tag=package-2018-01-preview --go` is specified
Please also specify `--go-sdk-folder=<path to the root directory of your azure-sdk-for-go clone>`.

``` yaml $(tag) == 'package-2018-01-preview' && $(go)
output-folder: $(go-sdk-folder)/services/preview/automation/mgmt/2018-01-preview/automation
output-folder: $(go-sdk-folder)/services/preview/automation/mgmt/2018-01-15-preview/automation
```

### Tag: package-2018-06-preview and go
Expand All @@ -52,5 +52,5 @@ These settings apply only when `--tag=package-2018-06-preview --go` is specified
Please also specify `--go-sdk-folder=<path to the root directory of your azure-sdk-for-go clone>`.

``` yaml $(tag) == 'package-2018-06-preview' && $(go)
output-folder: $(go-sdk-folder)/services/preview/automation/mgmt/2018-06-preview/automation
output-folder: $(go-sdk-folder)/services/preview/automation/mgmt/2018-06-30-preview/automation
```
2 changes: 1 addition & 1 deletion specification/batchai/resource-manager/readme.go.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ These settings apply only when `--tag=package-2017-09-preview --go` is specified
Please also specify `--go-sdk-folder=<path to the root directory of your azure-sdk-for-go clone>`.

``` yaml $(tag)=='package-2017-09-preview' && $(go)
output-folder: $(go-sdk-folder)/services/preview/batchai/mgmt/2017-09-preview/batchai
output-folder: $(go-sdk-folder)/services/preview/batchai/mgmt/2017-09-01-preview/batchai
```

### Tag: package-2018-03 and go
Expand Down
2 changes: 1 addition & 1 deletion specification/cognitiveservices/resource-manager/readme.go.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,5 +32,5 @@ These settings apply only when `--tag=package-2016-02-preview --go` is specified
Please also specify `--go-sdk-folder=<path to the root directory of your azure-sdk-for-go clone>`.

``` yaml $(tag) == 'package-2016-02-preview' && $(go)
output-folder: $(go-sdk-folder)/services/preview/cognitiveservices/preview/mgmt/2016-02-01-preview/cognitiveservices
output-folder: $(go-sdk-folder)/services/preview/cognitiveservices/mgmt/2016-02-01-preview/cognitiveservices
```
2 changes: 1 addition & 1 deletion specification/deviceprovisioningservices/resource-manager/readme.go.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,5 +43,5 @@ These settings apply only when `--tag=package-2017-08 --go` is specified on the
Please also specify `--go-sdk-folder=<path to the root directory of your azure-sdk-for-go clone>`.

``` yaml $(tag)=='package-2017-08' && $(go)
output-folder: $(go-sdk-folder)/services/preview/provisioningservices/preview/mgmt/2017-08-21-preview/iothub
output-folder: $(go-sdk-folder)/services/preview/provisioningservices/mgmt/2017-08-21-preview/iothub
```
2 changes: 1 addition & 1 deletion specification/web/resource-manager/readme.go.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,5 +42,5 @@ These settings apply only when `--tag=package-2015-08-preview --go` is specified
Please also specify `--go-sdk-folder=<path to the root directory of your azure-sdk-for-go clone>`.

``` yaml $(tag) == 'package-2015-08-preview' && $(go)
output-folder: $(go-sdk-folder)/services/preview/web/mgmt/2015-08-preview/web
output-folder: $(go-sdk-folder)/services/preview/web/mgmt/2015-08-01-preview/web
```