Skip to content

Fix Go SDK codegen for some RPs#4128

Merged
jhendrixMSFT merged 1 commit intoAzure:masterfrom
jhendrixMSFT:gosdkcleanup
Oct 10, 2018
Merged

Fix Go SDK codegen for some RPs#4128
jhendrixMSFT merged 1 commit intoAzure:masterfrom
jhendrixMSFT:gosdkcleanup

Conversation

@jhendrixMSFT
Copy link
Copy Markdown
Member

Fixed bad output-folder paths.
Removed beta package that was replaced by stable one.

This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.

PR information

  • The title of the PR is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
  • Except for special cases involving multiple contributors, the PR is started from a fork of the main repository, not a branch.
  • If applicable, the PR references the bug/issue that it fixes.
  • Swagger files are correctly named (e.g. the api-version in the path should match the api-version in the spec).

Quality of Swagger

Fixed bad output-folder paths.
Removed beta package that was replaced by stable one.
@jhendrixMSFT jhendrixMSFT self-assigned this Oct 10, 2018
@AutorestCI
Copy link
Copy Markdown

AutorestCI commented Oct 10, 2018

Automation for azure-sdk-for-python

This PR contains more than 3 context, SDK generation is not enabled. Contexts found:

  • analysisservices/resource-manager
  • deviceprovisioningservices/resource-manager
  • web/resource-manager
  • automation/resource-manager
  • cognitiveservices/resource-manager
  • batchai/resource-manager

```

### Tag: package-2017-08-beta and go

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why are we removing this ?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was replaced by a stable version.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so this one actually doesnt exist ?

@azuresdkci
Copy link
Copy Markdown
Contributor

Can one of the admins verify this patch?

@jhendrixMSFT jhendrixMSFT merged commit 2a694ef into Azure:master Oct 10, 2018
@jhendrixMSFT jhendrixMSFT deleted the gosdkcleanup branch October 10, 2018 17:11
@AutorestCI
Copy link
Copy Markdown

AutorestCI commented Oct 10, 2018

Automation for azure-sdk-for-js

This PR contains more than 3 context, SDK generation is not enabled. Contexts found:

  • cognitiveservices/resource-manager
  • batchai/resource-manager
  • deviceprovisioningservices/resource-manager
  • web/resource-manager
  • automation/resource-manager
  • analysisservices/resource-manager

@AutorestCI
Copy link
Copy Markdown

AutorestCI commented Oct 10, 2018

Automation for azure-sdk-for-java

This PR contains more than 3 context, SDK generation is not enabled. Contexts found:

  • cognitiveservices/resource-manager
  • web/resource-manager
  • analysisservices/resource-manager
  • batchai/resource-manager
  • deviceprovisioningservices/resource-manager
  • automation/resource-manager

@AutorestCI
Copy link
Copy Markdown

AutorestCI commented Oct 10, 2018

Automation for azure-sdk-for-ruby

This PR contains more than 3 context, SDK generation is not enabled. Contexts found:

  • automation/resource-manager
  • analysisservices/resource-manager
  • deviceprovisioningservices/resource-manager
  • batchai/resource-manager
  • web/resource-manager
  • cognitiveservices/resource-manager

@AutorestCI
Copy link
Copy Markdown

AutorestCI commented Oct 10, 2018

Automation for azure-sdk-for-node

This PR contains more than 3 context, SDK generation is not enabled. Contexts found:

  • web/resource-manager
  • analysisservices/resource-manager
  • automation/resource-manager
  • cognitiveservices/resource-manager
  • deviceprovisioningservices/resource-manager
  • batchai/resource-manager

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants