Update the AppGW WAF spec with CAPTCHA action and Cookie expiary #39362
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
microsoft-github-policy-service
bot
added
the
customer-reported
github-actions
bot
added
ARMReview
resource-manager
WaitForARMFeedback
Next Steps to Merge✅ All automated merging requirements have been met! To get your PR merged, see aka.ms/azsdk/specreview/merge.Comment generated by summarize-checks workflow run. |
API Change CheckAPIView identified API level changes in this PR and created the following API reviews
|
yanivsag
changed the title
…add-captcha-properties
github-actions
bot
added
BreakingChange-Go-Sdk
BreakingChange-JavaScript-Sdk
brownfield
ravimeda
added
the
ARMSignedOff
github-actions
bot
removed
the
WaitForARMFeedback
Member
|
Please address the failing checks (Swagger Avacado, LintDiff). |
kamboj-prjwl
merged commit 9b11ee2
into
Azure:release-microsoft-network-2025-05-01
80 checks passed
9 tasks
9 tasks
kamboj-prjwl
added a commit
that referenced
this pull request
Jan 7, 2026
* Copy files from stable/2025-03-01 Copied the files in a separate commit. This allows reviewers to easily diff subsequent changes against the previous spec. * Update version to stable/2025-05-01 Updated the API version from stable/2025-03-01 to stable/2025-05-01. * Added tag for 2025-05-01 in readme file * Update Suppression and directives from previous verison * Update version to stable 2025-05-01 (#39294) Co-authored-by: Santosh Lokarapu <[email protected]> * Service Gateway Swagger changes (#39221) * Sgw change * ModelFix * Model issue fix * Fix * Model fix * Fixed comment * Updated description for zone * Azure Firewall Policy: Add New IDPS Profiles (#36855) * Update IDPS Profile names * Add examples for IDPS profile * Update Firewall Policy PUT example IDPS profile * Update profile name and enum order * Remove delete example * Update profile names to emerging, extended and core * Add Off as default profile * Move changes to latest release * Revert PUT example change on older version * Move changes to release 2025-05-01 * Update examples release version * Update profile order * Update profiles description * Add vna top level resource 2025-05-01 (#39341) * Add a new top level resource for VNA * add suppression for a known issue. * add 1 more suppression due to known issue * added x-ms-parameter-location as per go sdk team suggestion * one more place to add for x-ms-parameter-location attribute --------- Co-authored-by: Prajjwal Kamboj <[email protected]> * Update the AppGW WAF spec with CAPTCHA action and Cookie expiary (#39362) * update the spec with CAPTCHA action and cookies expiary * whitespace issue * Fix description for CAPTCHA cookie expiration * Lint error fix (#39410) * Lint error fix * Response Change --------- Co-authored-by: Prajjwal Kamboj <[email protected]> Co-authored-by: santoshgh317 <[email protected]> Co-authored-by: Santosh Lokarapu <[email protected]> Co-authored-by: anjbal <[email protected]> Co-authored-by: Saloni Rajeev Kumar <[email protected]> Co-authored-by: Arjun Patel <[email protected]> Co-authored-by: Yaniv Sagron <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ARM (Control Plane) API Specification Update Pull Request
Tip
Overwhelmed by all this guidance? See the
Getting helpsection at the bottom of this PR description.PR review workflow diagram
Please understand this diagram before proceeding. It explains how to get your PR approved & merged.
Purpose of this PR
What's the purpose of this PR? Check the specific option that applies. This is mandatory!
Due diligence checklist
To merge this PR, you must go through the following checklist and confirm you understood
and followed the instructions by checking all the boxes:
ARM resource provider contract and
REST guidelines (estimated time: 4 hours).
I understand this is required before I can proceed to the diagram Step 2, "ARM API changes review", for this PR.
Additional information
Viewing API changes
For convenient view of the API changes made by this PR, refer to the URLs provided in the table
in the
Generated ApiViewcomment added to this PR. You can use ApiView to show API versions diff.Suppressing failures
If one or multiple validation error/warning suppression(s) is detected in your PR, please follow the
suppressions guide to get approval.
Getting help
Purpose of this PRandDue diligence checklist.write accessper aka.ms/azsdk/access#request-access-to-rest-api-or-sdk-repositoriesNext Steps to Mergecomment. It will appear within few minutes of submitting this PR and will continue to be up-to-date with current PR state.and https://aka.ms/ci-fix.
queuedstate, please add a comment with contents/azp run.This should result in a new comment denoting a
PR validation pipelinehas started and the checks should be updated after few minutes.