Skip to content

Azure Firewall Policy: Add New IDPS Profiles #36855

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
kamboj-prjwl merged 13 commits into from
Dec 22, 2025
Merged

Azure Firewall Policy: Add New IDPS Profiles #36855

kamboj-prjwl merged 13 commits into from
Dec 22, 2025
+475 −7

Conversation

@salonirk11
Copy link
Contributor

@salonirk11 salonirk11 commented Aug 21, 2025

ARM (Control Plane) API Specification Update Pull Request

Tip

Overwhelmed by all this guidance? See the Getting help section at the bottom of this PR description.

PR review workflow diagram

Please understand this diagram before proceeding. It explains how to get your PR approved & merged.

spec_pr_review_workflow_diagram

Purpose of this PR

What's the purpose of this PR? Check the specific option that applies. This is mandatory!

  • New resource provider.
  • New API version for an existing resource provider. (If API spec is not defined in TypeSpec, the PR should have been created in adherence to OpenAPI specs PR creation guidance).
  • Update existing version for a new feature. (This is applicable only when you are revising a private preview API version.)
  • Update existing version to fix OpenAPI spec quality issues in S360.
  • Convert existing OpenAPI spec to TypeSpec spec (do not combine this with implementing changes for a new API version).
  • Other, please clarify:
    • Updated Profiled for Azure Firewall Intrusion Detection

Due diligence checklist

To merge this PR, you must go through the following checklist and confirm you understood
and followed the instructions by checking all the boxes:

  • I confirm this PR is modifying Azure Resource Manager (ARM) related specifications, and not data plane related specifications.
  • I have reviewed following Resource Provider guidelines, including
    ARM resource provider contract and
    REST guidelines (estimated time: 4 hours).
    I understand this is required before I can proceed to the diagram Step 2, "ARM API changes review", for this PR.
  • A release plan has been created. If not, please create one as it will help guide you through the REST API and SDK creation process.

Additional information

Viewing API changes

For convenient view of the API changes made by this PR, refer to the URLs provided in the table
in the Generated ApiView comment added to this PR. You can use ApiView to show API versions diff.

Suppressing failures

If one or multiple validation error/warning suppression(s) is detected in your PR, please follow the
suppressions guide to get approval.

Getting help

  • First, please carefully read through this PR description, from top to bottom. Please fill out the Purpose of this PR and Due diligence checklist.
  • If you don't have permissions to remove or add labels to the PR, request write access per aka.ms/azsdk/access#request-access-to-rest-api-or-sdk-repositories
  • To understand what you must do next to merge this PR, see the Next Steps to Merge comment. It will appear within few minutes of submitting this PR and will continue to be up-to-date with current PR state.
  • For guidance on fixing this PR CI check failures, see the hyperlinks provided in given failure
    and https://aka.ms/ci-fix.
  • For help with ARM review (PR workflow diagram Step 2), see https://aka.ms/azsdk/pr-arm-review.
  • If the PR CI checks appear to be stuck in queued state, please add a comment with contents /azp run.
    This should result in a new comment denoting a PR validation pipeline has started and the checks should be updated after few minutes.
  • If the help provided by the previous points is not enough, post to https://aka.ms/azsdk/support/specreview-channel and link to this PR.
  • For guidance on SDK breaking change review, refer to https://aka.ms/ci-fix.

@github-actions
Copy link

github-actions bot commented Aug 21, 2025 •
edited
Loading

Next Steps to Merge

✅ All automated merging requirements have been met! To get your PR merged, see aka.ms/azsdk/specreview/merge.

Comment generated by summarize-checks workflow run.

@microsoft-github-policy-service microsoft-github-policy-service bot added customer-reported Issues that are reported by GitHub users external to the Azure organization. Network labels Aug 21, 2025
@salonirk11 salonirk11 force-pushed the firewall_policy/idps_profiles branch from b4e726a to 82fbb5f Compare August 21, 2025 09:17
@salonirk11
Copy link
Contributor Author

salonirk11 commented Aug 21, 2025

@microsoft-github-policy-service agree company="Microsoft"

@github-actions
Copy link

github-actions bot commented Aug 21, 2025 •
edited
Loading

API Change Check

APIView identified API level changes in this PR and created the following API reviews

Language API Review for Package
Go sdk/resourcemanager/network/armnetwork
Java com.azure.resourcemanager:azure-resourcemanager-network-generated
JavaScript @azure/arm-network

@github-actions github-actions bot added brownfield Brownfield services will soon be required to convert to TypeSpec. See https://aka.ms/azsdk/typespec. ARMReview resource-manager WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required BreakingChangeReviewRequired <valid label in PR review process>add this label when breaking change review is required NotReadyForARMReview and removed BreakingChange-Go-Sdk WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required BreakingChange-JavaScript-Sdk labels Sep 3, 2025
@salonirk11 salonirk11 force-pushed the firewall_policy/idps_profiles branch from bde5710 to faac972 Compare September 24, 2025 15:59
@salonirk11 salonirk11 force-pushed the firewall_policy/idps_profiles branch from faac972 to 6b1f1a0 Compare November 4, 2025 06:00
@mikekistler mikekistler added the BreakingChange-Approved-BranchPolicyException Changes violate the branch policy but exception has been granted. aka.ms/azsdk/pr-brch-deep label Nov 4, 2025
@salonirk11 salonirk11 force-pushed the firewall_policy/idps_profiles branch from 6b1f1a0 to ad30614 Compare November 12, 2025 06:31
@salonirk11 salonirk11 changed the base branch from main to release-microsoft-network-2025-05-01 December 16, 2025 05:41
@salonirk11 salonirk11 force-pushed the firewall_policy/idps_profiles branch from e0b9c7f to 74056a6 Compare December 18, 2025 07:28
@salonirk11
Copy link
Contributor Author

salonirk11 commented Dec 18, 2025

/azp run

@salonirk11 salonirk11 force-pushed the firewall_policy/idps_profiles branch from 223098f to 675e947 Compare December 19, 2025 09:02
@salonirk11
Copy link
Contributor Author

salonirk11 commented Dec 19, 2025

@razvanbadea-msft rebased the branch and pushed the update

@github-actions github-actions bot removed the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Dec 19, 2025
@cshahra cshahra added WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required and removed ARMChangesRequested labels Dec 19, 2025
@razvanbadea-msft razvanbadea-msft added the ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review label Dec 21, 2025
@github-actions github-actions bot removed the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Dec 21, 2025
@kamboj-prjwl kamboj-prjwl merged commit a8eee5a into Azure:release-microsoft-network-2025-05-01 Dec 22, 2025
82 of 83 checks passed
@mikekistler mikekistler mentioned this pull request Dec 29, 2025
Closed
9 tasks
@kamboj-prjwl kamboj-prjwl mentioned this pull request Jan 6, 2026
Merged
9 tasks
kamboj-prjwl added a commit that referenced this pull request Jan 7, 2026
@kamboj-prjwl @santoshgh317
@anjbal @salonirk11 @arjun-d-patel @yanivsag
Release Microsoft.Network API Version 2025-05-01 (#39468)
b6d0dc8 
* Copy files from stable/2025-03-01

Copied the files in a separate commit.
This allows reviewers to easily diff subsequent changes against the previous spec.

* Update version to stable/2025-05-01

Updated the API version from stable/2025-03-01 to stable/2025-05-01.

* Added tag for 2025-05-01 in readme file

* Update Suppression and directives from previous verison

* Update version to stable 2025-05-01 (#39294)

Co-authored-by: Santosh Lokarapu <[email protected]>

* Service Gateway Swagger changes (#39221)

* Sgw change

* ModelFix

* Model issue fix

* Fix

* Model fix

* Fixed comment

* Updated description for zone

* Azure Firewall Policy: Add New IDPS Profiles (#36855)

* Update IDPS Profile names

* Add examples for IDPS profile

* Update Firewall Policy PUT example IDPS profile

* Update profile name and enum order

* Remove delete example

* Update profile names to emerging, extended and core

* Add Off as default profile

* Move changes to latest release

* Revert PUT example change on older version

* Move changes to release 2025-05-01

* Update examples release version

* Update profile order

* Update profiles description

* Add vna top level resource 2025-05-01 (#39341)

* Add a new top level resource for VNA

* add suppression for a known issue.

* add 1 more suppression due to known issue

* added x-ms-parameter-location as per go sdk team suggestion

* one more place to add for x-ms-parameter-location attribute

---------

Co-authored-by: Prajjwal Kamboj <[email protected]>

* Update the AppGW WAF spec with CAPTCHA action and Cookie expiary (#39362)

* update the spec with CAPTCHA action and cookies expiary

* whitespace issue

* Fix description for CAPTCHA cookie expiration

* Lint error fix (#39410)

* Lint error fix

* Response Change

---------

Co-authored-by: Prajjwal Kamboj <[email protected]>
Co-authored-by: santoshgh317 <[email protected]>
Co-authored-by: Santosh Lokarapu <[email protected]>
Co-authored-by: anjbal <[email protected]>
Co-authored-by: Saloni Rajeev Kumar <[email protected]>
Co-authored-by: Arjun Patel <[email protected]>
Co-authored-by: Yaniv Sagron <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kamboj-prjwl kamboj-prjwl kamboj-prjwl approved these changes

@razvanbadea-msft razvanbadea-msft Awaiting requested review from razvanbadea-msft

Assignees

No one assigned

Labels

ARMReview ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review BreakingChange-Approved-BranchPolicyException Changes violate the branch policy but exception has been granted. aka.ms/azsdk/pr-brch-deep BreakingChange-Go-Sdk BreakingChange-Go-Sdk-Approved BreakingChange-JavaScript-Sdk BreakingChange-JavaScript-Sdk-Approved brownfield Brownfield services will soon be required to convert to TypeSpec. See https://aka.ms/azsdk/typespec. customer-reported Issues that are reported by GitHub users external to the Azure organization. Network resource-manager

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@salonirk11 @kamboj-prjwl @razvanbadea-msft @tadelesh @mikekistler @kazrael2119 @cshahra