Add logic to Auto-Signoff open-api-specs with trivial changes

.github/shared/src/changed-files.js

@@ -1,3 +1,3 @@
 import debug from "debug";
 import { simpleGit } from "simple-git";
 import { includesSegment } from "./path.js";
@@ -179,6 +179,15 @@
   return typeof file === "string" && file.toLowerCase().endsWith("readme.md");
 }
 
+/**
+ * @param {string} [file]
+ * @returns {boolean}
+ */
+export function markdown(file) {
+  // Extension ".md" with any case is a valid markdown file
+  return typeof file === "string" && file.toLowerCase().endsWith(".md");
+}
+
 /**
  * @param {string} [file]
  * @returns {boolean}

.github/shared/src/pr-changes.js

@@ -0,0 +1,86 @@
+/**
+ * Represents the types of changes present in a pull request.
+ * 
+ * All properties are boolean flags that indicate presence of a change type.
+ * An empty PR would have all properties set to false.
+ * 
+ * @typedef {Object} PullRequestChanges
+ * @property {boolean} documentation - True if PR contains documentation (.md) file changes
+ * @property {boolean} examples - True if PR contains example file changes (/examples/*.json)
+ * @property {boolean} functional - True if PR contains functional spec changes (API-impacting)
+ * @property {boolean} nonFunctional - True if PR contains non-functional spec changes (metadata only)
+ * @property {boolean} other - True if PR contains other file types (config, scripts, etc.)
+ */
+
+/**
+ * Creates a PullRequestChanges object with all flags set to false
+ * @returns {PullRequestChanges}
+ */
+export function createEmptyPullRequestChanges() {
+  return {
+    documentation: false,
+    examples: false,
+    functional: false,
+    nonFunctional: false,
+    other: false,
+  };
+}
+
+/**
+ * Checks if a PR qualifies as trivial based on its changes
+ * A PR is trivial if it contains only:
+ * - Documentation changes
+ * - Example changes
+ * - Non-functional spec changes
+ * And does NOT contain:
+ * - Functional spec changes
+ * - Other file types
+ * 
+ * @param {PullRequestChanges} changes - The PR changes object
+ * @returns {boolean} - True if PR is trivial
+ */
+export function isTrivialPullRequest(changes) {
+  // Trivial if no functional changes and no other files
+  // Must have at least one of: documentation, examples, or nonFunctional
+  const hasNoBlockingChanges = !changes.functional && !changes.other;
+  const hasTrivialChanges = changes.documentation || changes.examples || changes.nonFunctional;
+
+  return hasNoBlockingChanges && hasTrivialChanges;
+}
+
+/**
+ * Checks if a PR contains only documentation changes
+ * @param {PullRequestChanges} changes - The PR changes object
+ * @returns {boolean} - True if only documentation changed
+ */
+export function isDocumentationOnly(changes) {
+  return changes.documentation && 
+    !changes.examples && 
+    !changes.functional && 
+    !changes.nonFunctional && 
+    !changes.other;
+}
+
+/**
+ * Checks if a PR contains only example changes
+ * @param {PullRequestChanges} changes - The PR changes object
+ * @returns {boolean} - True if only examples changed
+ */
+export function isExamplesOnly(changes) {
+  return !changes.documentation && 
+    changes.examples && 
+    !changes.functional && 
+    !changes.nonFunctional && 
+    !changes.other;
+}
+
+/**
+ * Checks if a PR contains only non-functional spec changes (with optional docs/examples)
+ * @param {PullRequestChanges} changes - The PR changes object
+ * @returns {boolean} - True if only non-functional changes (+ optional docs/examples)
+ */
+export function isNonFunctionalOnly(changes) {
+  return changes.nonFunctional && 
+    !changes.functional && 
+    !changes.other;
+}

.github/workflows/arm-incremental-typespec.yaml → .github/workflows/arm-auto-signoff-code.yaml

@@ -1,4 +1,4 @@
-name: ARM Incremental TypeSpec
+name: ARM Auto-SignOff - Analyze Code
 
 on:
   pull_request:
@@ -20,16 +20,18 @@
   contents: read
 
 jobs:
-  arm-incremental-typespec:
-    name: ARM Incremental TypeSpec
+  arm-auto-signoff-code:
+    name: ARM Auto-SignOff - Analyze Code
 
     runs-on: ubuntu-24.04
 
     steps:
       - uses: actions/checkout@v4
         with:
-          # Required to detect changed files in PR
-          fetch-depth: 2
+          # Fetch full PR history including base branch for proper diff comparison
+          fetch-depth: 0
+          # Fetch base branch to compare against
+          ref: ${{ github.event.pull_request.head.sha }}
           # Check only needs to view contents of changed files as a string, so can use
           # "git show" on specific files instead of cloning whole repo
           sparse-checkout: |
@@ -45,19 +47,20 @@
           install-command: "npm ci --no-audit --omit dev"
           working-directory: ./.github
 
-      # Output is "true" if PR contains only incremental changes to an existing TypeSpec RP
-      - id: incremental-typespec
-        name: ARM Incremental TypeSpec
+      # Run ARM Auto-SignOff Code analysis
+      - id: arm-auto-signoff-code
+        name: ARM Auto-SignOff Code
         uses: actions/github-script@v7
         with:
           result-encoding: string
           script: |
-            const { default: incrementalTypeSpec } =
-              await import('${{ github.workspace }}/.github/workflows/src/arm-incremental-typespec.js');
-            return await incrementalTypeSpec({ github, context, core });
+            const { default: armAutoSignOffCode } =
+              await import('${{ github.workspace }}/.github/workflows/src/arm-auto-signoff/arm-auto-signoff-code.js');
+            return await armAutoSignOffCode({ github, context, core });
 
-      - name: Upload artifact with results
+      # Upload artifact with all results
+      - name: Upload artifact - ARM Auto-SignOff Code Results
         uses: ./.github/actions/add-empty-artifact
         with:
-          name: "incremental-typespec"
-          value: ${{ steps.incremental-typespec.outputs.result }}
+          name: "arm-auto-signoff-code-results"
+          value: ${{ steps.arm-auto-signoff-code.outputs.result }}

.github/workflows/arm-auto-signoff.yaml → .github/workflows/arm-auto-signoff-status.yaml

@@ -1,4 +1,4 @@
-name: ARM Auto SignOff
+name: ARM Auto SignOff - Set Status
 
 on:
   # Must run on pull_request_target instead of pull_request, since the latter cannot trigger on
@@ -12,7 +12,7 @@
       - unlabeled
   workflow_run:
     workflows:
-      ["ARM Incremental TypeSpec", "Swagger Avocado - Set Status", "Swagger LintDiff - Set Status"]
+      ["ARM Auto-SignOff - Analyze Code", "Swagger Avocado - Set Status", "Swagger LintDiff - Set Status"]
     types: [completed]
 
 permissions:
@@ -30,7 +30,7 @@
 
 jobs:
   arm-auto-signoff:
-    name: ARM Auto SignOff
+    name: ARM Auto SignOff - Set Status
 
     # workflow_run - already filtered by triggers above
     # pull_request_target:labeled - filter to only the input and output labels
@@ -40,7 +40,8 @@
        (github.event.action == 'labeled' ||
         github.event.action == 'unlabeled') &&
        (github.event.label.name == 'Approved-Suppression' ||
-        github.event.label.name == 'ARMAutoSignedOff' ||
+        github.event.label.name == 'ARMAutoSignedOff-IncrementalTSP' ||
+        github.event.label.name == 'ARMAutoSignedOff-Trivial' ||
         github.event.label.name == 'ARMReview' ||
         github.event.label.name == 'ARMSignedOff' ||
         github.event.label.name == 'NotReadyForARMReview' ||
@@ -69,33 +70,36 @@
       #   issueNumber: number
       # }
       - id: get-label-action
-        name: ARM Auto SignOff
+        name: ARM Auto SignOff 
         uses: actions/github-script@v7
         with:
           script: |
             const { default: getLabelAction } =
-              await import('${{ github.workspace }}/.github/workflows/src/arm-auto-signoff.js');
+              await import('${{ github.workspace }}/.github/workflows/src/arm-auto-signoff/arm-auto-signoff-status.js');
             return await getLabelAction({ github, context, core });
 
-      - if: |
-          fromJson(steps.get-label-action.outputs.result).labelAction == 'add' ||
-          fromJson(steps.get-label-action.outputs.result).labelAction == 'remove'
-        name: Upload artifact with results
+      # Add/remove specific auto sign-off labels based on analysis results
+      # Only upload label artifacts if we have autoSignOffLabels defined (not undefined)
+      - if: fromJson(steps.get-label-action.outputs.result).autoSignOffLabels != null
+        name: Upload artifact for ARMSignedOff label
         uses: ./.github/actions/add-label-artifact
         with:
-          name: "ARMAutoSignedOff"
-          # Convert "add/remove" to "true/false"
-          value: "${{ fromJson(steps.get-label-action.outputs.result).labelAction == 'add' }}"
+          name: "ARMSignedOff"
+          value: "${{ fromJson(steps.get-label-action.outputs.result).autoSignOffLabels && (contains(fromJson(steps.get-label-action.outputs.result).autoSignOffLabels, 'ARMAutoSignedOff-IncrementalTSP') || contains(fromJson(steps.get-label-action.outputs.result).autoSignOffLabels, 'ARMAutoSignedOff-Trivial')) }}"
 
-      - if: |
-          fromJson(steps.get-label-action.outputs.result).labelAction == 'add' ||
-          fromJson(steps.get-label-action.outputs.result).labelAction == 'remove'
-        name: Upload artifact with results
+      - if: fromJson(steps.get-label-action.outputs.result).autoSignOffLabels != null
+        name: Upload artifact for ARMAutoSignedOff-IncrementalTSP label
         uses: ./.github/actions/add-label-artifact
         with:
-          name: "ARMSignedOff"
-          # Convert "add/remove" to "true/false"
-          value: "${{ fromJson(steps.get-label-action.outputs.result).labelAction == 'add' }}"
+          name: "ARMAutoSignedOff-IncrementalTSP"
+          value: "${{ fromJson(steps.get-label-action.outputs.result).autoSignOffLabels && contains(fromJson(steps.get-label-action.outputs.result).autoSignOffLabels, 'ARMAutoSignedOff-IncrementalTSP') }}"
+
+      - if: fromJson(steps.get-label-action.outputs.result).autoSignOffLabels != null
+        name: Upload artifact for ARMAutoSignedOff-Trivial label
+        uses: ./.github/actions/add-label-artifact
+        with:
+          name: "ARMAutoSignedOff-Trivial"
+          value: "${{ fromJson(steps.get-label-action.outputs.result).autoSignOffLabels && contains(fromJson(steps.get-label-action.outputs.result).autoSignOffLabels, 'ARMAutoSignedOff-Trivial') }}"
 
       # Required for consumers to identify the head SHA associated with this workflow run.
       # Output can be trusted, because it was uploaded from a workflow that is trusted,