Add logic to Auto-Signoff open-api-specs with trivial changes

.github/workflows/arm-auto-signoff-code.yaml

@@ -1,3 +1,3 @@
 name: ARM Auto SignOff - Analyze Code
 
 on:
@@ -28,7 +28,8 @@
     steps:
       - uses: actions/checkout@v6
         with:
-          # Required to detect changed files in PR
+          # We compare HEAD (PR merge commit) against HEAD^ (base) via git diff,
+          # so we only need enough history to include the merge commit and its parent.
           fetch-depth: 2
           # Check only needs to view contents of changed files as a string, so can use
           # "git show" on specific files instead of cloning whole repo
@@ -38,19 +39,25 @@
       - name: Install dependencies for github-script actions
         uses: ./.github/actions/install-deps-github-script
 
-      # Output is "true" if PR contains only incremental changes to an existing TypeSpec RP
-      - id: incremental-typespec
+      - id: arm-auto-signoff-code
         name: ARM Auto SignOff - Analyze Code
         uses: actions/github-script@v8
         with:
-          result-encoding: string
+          result-encoding: json
           script: |
-            const { default: incrementalTypeSpec } =
-              await import('${{ github.workspace }}/.github/workflows/src/arm-auto-signoff/arm-incremental-typespec.js');
-            return await incrementalTypeSpec({ github, context, core });
+            const { default: armAutoSignoffCode } =
+              await import('${{ github.workspace }}/.github/workflows/src/arm-auto-signoff/arm-auto-signoff-code.js');
+            return await armAutoSignoffCode({ github, context, core });
 
-      - name: Upload artifact with results
+      # Upload artifacts with individual results
+      - name: Upload artifact - ARM Auto Signoff Code Result (incremental)
         uses: ./.github/actions/add-empty-artifact
         with:
           name: "incremental-typespec"
-          value: ${{ steps.incremental-typespec.outputs.result }}
+          value: ${{ fromJSON(steps.arm-auto-signoff-code.outputs.result).incremental }}
+
+      - name: Upload artifact - ARM Auto Signoff Code Result (trivial)
+        uses: ./.github/actions/add-empty-artifact
+        with:
+          name: "trivial-changes"
+          value: ${{ fromJSON(steps.arm-auto-signoff-code.outputs.result).trivial }}

.github/workflows/arm-auto-signoff-status.yaml

@@ -1,3 +1,3 @@
 name: ARM Auto SignOff - Set Status
 
 on:
@@ -45,6 +45,8 @@
         github.event.action == 'unlabeled') &&
        (github.event.label.name == 'Approved-Suppression' ||
         github.event.label.name == 'ARMAutoSignedOff' ||
+        github.event.label.name == 'ARMAutoSignedOff-IncrementalTSP' ||
+        github.event.label.name == 'ARMAutoSignedOff-Trivial-Test' ||
         github.event.label.name == 'ARMReview' ||
         github.event.label.name == 'ARMSignedOff' ||
         github.event.label.name == 'NotReadyForARMReview' ||
@@ -69,8 +71,13 @@
 
       # Output:
       # {
-      #   labelAction: LabelAction, ("none" for no-op, "add" to add label, and "remove" to remove label)
-      #   issueNumber: number
+      #   headSha: string,
+      #   issueNumber: number,
+      #   labelActions: {
+      #     'ARMSignedOff': 'none'|'add'|'remove',
+      #     'ARMAutoSignedOff-IncrementalTSP': 'none'|'add'|'remove',
+      #     'ARMAutoSignedOff-Trivial-Test': 'none'|'add'|'remove'
+      #   }
       # }
       - id: get-label-action
         name: ARM Auto SignOff - Set Status
@@ -81,25 +88,28 @@
               await import('${{ github.workspace }}/.github/workflows/src/arm-auto-signoff/arm-auto-signoff-status.js');
             return await getLabelAction({ github, context, core });
 
-      - if: |
-          fromJson(steps.get-label-action.outputs.result).labelAction == 'add' ||
-          fromJson(steps.get-label-action.outputs.result).labelAction == 'remove'
-        name: Upload artifact with results
+        # Add/remove specific auto sign-off labels based on analysis results.
+        # The action is explicit: 'add' | 'remove' | 'none'.
+      - if: fromJson(steps.get-label-action.outputs.result).labelActions['ARMSignedOff'] != 'none'
+        name: Upload artifact for ARMSignedOff label
         uses: ./.github/actions/add-label-artifact
         with:
-          name: "ARMAutoSignedOff"
-          # Convert "add/remove" to "true/false"
-          value: "${{ fromJson(steps.get-label-action.outputs.result).labelAction == 'add' }}"
+          name: "ARMSignedOff"
+          value: "${{ fromJson(steps.get-label-action.outputs.result).labelActions['ARMSignedOff'] == 'add' }}"
 
-      - if: |
-          fromJson(steps.get-label-action.outputs.result).labelAction == 'add' ||
-          fromJson(steps.get-label-action.outputs.result).labelAction == 'remove'
-        name: Upload artifact with results
+      - if: fromJson(steps.get-label-action.outputs.result).labelActions['ARMAutoSignedOff-IncrementalTSP'] != 'none'
+        name: Upload artifact for ARMAutoSignedOff-IncrementalTSP label
         uses: ./.github/actions/add-label-artifact
         with:
-          name: "ARMSignedOff"
-          # Convert "add/remove" to "true/false"
-          value: "${{ fromJson(steps.get-label-action.outputs.result).labelAction == 'add' }}"
+          name: "ARMAutoSignedOff-IncrementalTSP"
+          value: "${{ fromJson(steps.get-label-action.outputs.result).labelActions['ARMAutoSignedOff-IncrementalTSP'] == 'add' }}"
+
+      - if: fromJson(steps.get-label-action.outputs.result).labelActions['ARMAutoSignedOff-Trivial-Test'] != 'none'
+        name: Upload artifact for ARMAutoSignedOff-Trivial-Test label
+        uses: ./.github/actions/add-label-artifact
+        with:
+          name: "ARMAutoSignedOff-Trivial-Test"
+          value: "${{ fromJson(steps.get-label-action.outputs.result).labelActions['ARMAutoSignedOff-Trivial-Test'] == 'add' }}"
 
       # Required for consumers to identify the head SHA associated with this workflow run.
       # Output can be trusted, because it was uploaded from a workflow that is trusted,

.github/workflows/src/arm-auto-signoff/arm-auto-signoff-code.js

@@ -0,0 +1,46 @@
+import { incrementalTypeSpec } from "./arm-incremental-typespec.js";
+import { checkTrivialChanges } from "./trivial-changes-check.js";
+
+/** @typedef {import("./pr-changes.js").PullRequestChanges} PullRequestChanges */
+
+/**
+ * Main entry point for ARM Auto Signoff Code workflow.
+ *
+ * This module orchestrates all checks to determine if a PR qualifies for auto sign-off.
+ * It combines results from:
+ * - Incremental TypeSpec check
+ * - Trivial changes check
+ *
+ * @param {import("@actions/github-script").AsyncFunctionArguments} args
+ * @returns {Promise<{ incremental: boolean, trivial: boolean }>}
+ */
+export default async function armAutoSignoffCode({ core }) {
+  core.info("Starting ARM Auto Signoff Code analysis.");
+
+  // Run incremental TypeSpec check
+  core.startGroup("Checking for incremental TypeSpec changes");
+  const incrementalTypeSpecResult = await incrementalTypeSpec(core);
+  core.info(`Incremental TypeSpec result: ${incrementalTypeSpecResult}`);
+  core.endGroup();
+
+  // Run trivial changes check
+  core.startGroup("Checking for trivial changes");
+  const trivialChangesResult = await checkTrivialChanges(core);
+  core.endGroup();
+
+  const isTrivial = trivialChangesResult.isTrivial();
+
+  // Combine results
+  const combined = {
+    incrementalTypeSpec: incrementalTypeSpecResult,
+    trivialChanges: trivialChangesResult,
+  };
+
+  core.info(`Combined result: ${JSON.stringify(combined, null, 2)}`);
+
+  // Return a JSON object for downstream workflow logic.
+  return {
+    incremental: incrementalTypeSpecResult,
+    trivial: isTrivial,
+  };
+}

.github/workflows/src/arm-auto-signoff/arm-auto-signoff-labels.js

@@ -0,0 +1,11 @@
+/**
+ * ARM auto-signoff label names.
+ * @readonly
+ * @enum {string}
+ */
+export const ArmAutoSignoffLabel = Object.freeze({
+  ArmSignedOff: "ARMSignedOff",
+  ArmAutoSignedOff: "ARMAutoSignedOff",
+  ArmAutoSignedOffIncrementalTSP: "ARMAutoSignedOff-IncrementalTSP",
+  ArmAutoSignedOffTrivialTest: "ARMAutoSignedOff-Trivial-Test",
+});