Adding swagger for new api-version consumption 2018-08-31 by ncalagar · Pull Request #3725 · Azure/azure-rest-api-specs

ncalagar · 2018-08-25T19:21:35Z

This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.

PR information

The title of the PR is clear and informative.
There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
Except for special cases involving multiple contributors, the PR is started from a fork of the main repository, not a branch.
If applicable, the PR references the bug/issue that it fixes.
Swagger files are correctly named (e.g. the api-version in the path should match the api-version in the spec).

Quality of Swagger

I have read the contribution guidelines.
My spec meets the review criteria:
- The spec conforms to the Swagger 2.0 specification.
- The spec follows the guidelines described in the Swagger checklist document.
- Validation tools were run on swagger spec(s) and have all been fixed in this PR.

azuresdkci · 2018-08-25T19:22:00Z

Can one of the admins verify this patch?

AutorestCI · 2018-08-25T19:22:18Z

Automation for azure-sdk-for-python

A PR has been created for you based on this PR content.

Once this PR will be merged, content will be added to your service PR:
Azure/azure-sdk-for-python#2158

AutorestCI · 2018-08-25T19:22:46Z

Automation for azure-sdk-for-java

Nothing to generate for azure-sdk-for-java

AutorestCI · 2018-08-25T19:23:21Z

Automation for azure-sdk-for-ruby

Nothing to generate for azure-sdk-for-ruby

AutorestCI · 2018-08-25T19:24:09Z

Automation for azure-sdk-for-node

A PR has been created for you based on this PR content.

Once this PR will be merged, content will be added to your service PR:
Azure/azure-sdk-for-node#3319

AutorestCI · 2018-08-25T19:25:40Z

Automation for azure-sdk-for-go

A PR has been created for you:
Azure/azure-sdk-for-go#2542

sergey-shandar · 2018-08-27T21:10:03Z

@ncalagar Is there a commit where we can see all the changes between old and new API?

* Remove TrackedResource from Swagger spec "$ref": "../../common/v1/definitions.json#/definitions/TrackedResource" * More updates on referring common types More updates on referring common types * Add UpdateParameters and Updateproperties * Update example * updated example * update examples Introducing new API for Azure Security Center Settings (Azure#3511) * Add new API for Azure Security Center Settings * Changed SettingsPUT API to receive parameter and not definition. * - changed settings parameter name in example and in security parameter definition - changes typo comment on settings get all example reference * changes settings to setting in Settings API * settings kind to setting kind in settings CSM API Update batch resource-manager Node.js package version to 3.1.2 (Azure#3732) IoTHub conf py (Azure#3733) Reports API moved from stable to preview version with addition of documentation of a couple of new APIs (Azure#3640) * Consumption specifications for cost insights and reporting operations * Fixed $ref for ReportConfigDelete * Silly me!! Fixed bad reference again * Fixed schema validation issues * Fixing validation errors around datetime and dynamic respones * Fixed parameters in examples * Fixed parameter name in example * Removed x-ms-odata method for POST op * Fixed ARM review comments * Moved reports and usage analysis from microsoft.consumption to microsoft.costmanagament * Merged with master again * Updated reports api documentation * Undo remove of API from stable version providing description for new introduced property isRecurringCharge fix example issues Microsoft.ResourceGraph public preview spec (Azure#3716) Add new microsoft.logic version (Azure#3683) * Copy of the source version (2016-06-01) to seed the new version (2018-07-01-preview) * Update Microsoft.Logic from 2016-06-01 to 2018-07-01-preview * Remove extra prep files, update the readme Fix Go SDK codegen for containerinstance (Azure#3735) The package-2018-06 tag was incorrecly using the 2018-04 tag. Moved Go SDK config section to its own config file. Microsoft.NetApp first version (Azure#3639) * Microsoft.NetApp first version * Addressing pullrequest comments added back billingperiod

…pecs

ncalagar · 2018-08-28T00:43:43Z

@sergey-shandar Here is list of new changes to this new version:

Adding new property "isRecurringCharge" to MarketplaceProperties
Adding charges apis and their associated changes and examples
Adding two new properties “usageStart” and “usageEnd” to ManagementGroupAggregatedCostProperties and addin usageStart and usageEnd filter to ManangmentGroupAggregatedCost and examples
Removing CostTags API and its examples

ms-premp · 2018-08-28T18:19:03Z

@ms-premp fyi

sergey-shandar

@ncalagar we need two commits, the first one should be a copy from previous API version (with API-VERSION changes) and the second one is the changes. https://github.com/Azure/azure-rest-api-specs/blob/master/.github/CONTRIBUTING.md#filenames-and-folder-structure

Or use the portal https://portal.azure-devex-tools.com/app (preferred).

ncalagar · 2018-08-29T22:05:24Z

@sergey-shandar Sure, in order to do that, I'm going to close this pull request and create a new one with mentioned 2 commits.

ncalagar · 2018-08-30T00:02:16Z

@sergey-shandar This is the link to new PR : #3766

Adding swagger for new Api version

1bc6638

AutorestCI mentioned this pull request Aug 25, 2018

[AutoPR consumption/resource-manager] Adding swagger for new api-version consumption 2018-08-31 Azure/azure-sdk-for-python#3197

Closed

azuresdkci assigned sergey-shandar Aug 25, 2018

azuresdkci requested a review from sergey-shandar August 25, 2018 19:22

AutorestCI mentioned this pull request Aug 25, 2018

[AutoPR consumption/resource-manager] Adding swagger for new api-version consumption 2018-08-31 Azure/azure-sdk-for-node#3422

Closed

AutorestCI mentioned this pull request Aug 25, 2018

[AutoPR consumption/resource-manager] Adding swagger for new api-version consumption 2018-08-31 Azure/azure-sdk-for-go#2542

Closed

ncalagar added 3 commits August 27, 2018 11:32

Merge branch 'master' of https://github.com/Azure/azure-rest-api-specs

9617565

charges api date properties name change

be4ee83

Merge branch 'master' of https://github.com/Azure/azure-rest-api-specs

d8e65e4

ncalagar and others added 7 commits August 27, 2018 14:18

Merge branch 'master' of https://github.com/Azure/azure-rest-api-specs

d67175f

providing description for new introduced property isRecurringCharge

ca6b7be

fix example issues

9fdf36e

Merge branch 'master' of https://github.com/ncalagar/azure-rest-api-s…

d2b5eb7

…pecs

merged with master

4dc0638

removing costtags example

58128e2

sergey-shandar reviewed Aug 29, 2018

View reviewed changes

ncalagar closed this Aug 29, 2018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Adding swagger for new api-version consumption 2018-08-31#3725

Adding swagger for new api-version consumption 2018-08-31#3725
ncalagar wants to merge 11 commits intoAzure:masterfrom
ncalagar:master

ncalagar commented Aug 25, 2018 •

edited

Loading

Uh oh!

azuresdkci commented Aug 25, 2018

Uh oh!

AutorestCI commented Aug 25, 2018 •

edited

Loading

Uh oh!

AutorestCI commented Aug 25, 2018 •

edited

Loading

Uh oh!

AutorestCI commented Aug 25, 2018 •

edited

Loading

Uh oh!

AutorestCI commented Aug 25, 2018 •

edited

Loading

Uh oh!

AutorestCI commented Aug 25, 2018 •

edited

Loading

Uh oh!

sergey-shandar commented Aug 27, 2018

Uh oh!

ncalagar commented Aug 28, 2018 •

edited

Loading

Uh oh!

ms-premp commented Aug 28, 2018

Uh oh!

sergey-shandar left a comment •

edited

Loading

Uh oh!

ncalagar commented Aug 29, 2018

Uh oh!

ncalagar commented Aug 30, 2018

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Conversation

ncalagar commented Aug 25, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR information

Quality of Swagger

Uh oh!

azuresdkci commented Aug 25, 2018

Uh oh!

AutorestCI commented Aug 25, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Automation for azure-sdk-for-python

Uh oh!

AutorestCI commented Aug 25, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Automation for azure-sdk-for-java

Uh oh!

AutorestCI commented Aug 25, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Automation for azure-sdk-for-ruby

Uh oh!

AutorestCI commented Aug 25, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Automation for azure-sdk-for-node

Uh oh!

AutorestCI commented Aug 25, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Automation for azure-sdk-for-go

Uh oh!

sergey-shandar commented Aug 27, 2018

Uh oh!

ncalagar commented Aug 28, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ms-premp commented Aug 28, 2018

Uh oh!

sergey-shandar left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ncalagar commented Aug 29, 2018

Uh oh!

ncalagar commented Aug 30, 2018

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

ncalagar commented Aug 25, 2018 •

edited

Loading

AutorestCI commented Aug 25, 2018 •

edited

Loading

AutorestCI commented Aug 25, 2018 •

edited

Loading

AutorestCI commented Aug 25, 2018 •

edited

Loading

AutorestCI commented Aug 25, 2018 •

edited

Loading

AutorestCI commented Aug 25, 2018 •

edited

Loading

ncalagar commented Aug 28, 2018 •

edited

Loading

sergey-shandar left a comment •

edited

Loading