Introducing new API for Azure Security Center Settings · Pull Request #3511 · Azure/azure-rest-api-specs

ghost · 2018-07-26T13:13:02Z

This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.

PR information

The title of the PR is clear and informative.
There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
Except for special cases involving multiple contributors, the PR is started from a fork of the main repository, not a branch.
If applicable, the PR references the bug/issue that it fixes.
Swagger files are correctly named (e.g. the api-version in the path should match the api-version in the spec).

Quality of Swagger

I have read the contribution guidelines.
My spec meets the review criteria:
- The spec conforms to the Swagger 2.0 specification.
- The spec follows the guidelines described in the Swagger checklist document.
- Validation tools were run on swagger spec(s) and have all been fixed in this PR.

AutorestCI · 2018-07-26T13:13:28Z

Automation for azure-sdk-for-python

Nothing to generate for azure-sdk-for-python

AutorestCI · 2018-07-26T13:14:10Z

Automation for azure-sdk-for-ruby

Nothing to generate for azure-sdk-for-ruby

AutorestCI · 2018-07-26T13:14:44Z

Automation for azure-sdk-for-node

Nothing to generate for azure-sdk-for-node

AutorestCI · 2018-07-26T13:14:44Z

Automation for azure-sdk-for-java

Nothing to generate for azure-sdk-for-java

AutorestCI · 2018-07-26T13:16:01Z

Automation for azure-sdk-for-go

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-go#2545

jianghaolu · 2018-07-26T18:27:18Z

...r/Microsoft.Security/preview/2017-08-01-preview/examples/Settings/UpdateSetting_example.json

+        "api-version": "2017-08-01-preview",
+        "subscriptionId": "20ff7fc3-e762-44dd-bd96-b71116dcdc23",
+        "settingName": "MCAS",
+        "setting": {


should be "settings"?

You are right changed parameter in example and in parameter definition to match.

…r definition - changes typo comment on settings get all example reference

chlahav · 2018-07-30T06:59:14Z

...cation/security/resource-manager/Microsoft.Security/preview/2017-08-01-preview/security.json

+                }
+            }
+        },
+        "Settings": {


Settings [](start = 9, length = 8)

Setting

Changes all single settings to setting

chlahav · 2018-07-30T07:00:36Z

...cation/security/resource-manager/Microsoft.Security/preview/2017-08-01-preview/security.json

+                        "modelAsString": true,
+                        "values": [
+                            {
+                                "value": "DataExportSettings"


DataExportSettings [](start = 42, length = 18)

can also be DataExport since you are in the context of a setting

Changes all single settings to setting

chlahav · 2018-07-30T07:04:32Z

...cation/security/resource-manager/Microsoft.Security/preview/2017-08-01-preview/security.json

+                        "$ref": "#/parameters/SettingName"
+                    },
+                    {
+                        "$ref": "#/definitions/Settings"


definitions [](start = 35, length = 11)

create a parameter and reference it here instead of the definition

chlahav

🕐

chlahav

azuresdkci · 2018-08-02T15:30:24Z

Can one of the admins verify this patch?

ghost · 2018-08-27T12:56:59Z

@jianghaolu , we would like to merge our PR.

(@chlahav, @orparnes)

* Remove TrackedResource from Swagger spec "$ref": "../../common/v1/definitions.json#/definitions/TrackedResource" * More updates on referring common types More updates on referring common types * Add UpdateParameters and Updateproperties * Update example * updated example * update examples Introducing new API for Azure Security Center Settings (Azure#3511) * Add new API for Azure Security Center Settings * Changed SettingsPUT API to receive parameter and not definition. * - changed settings parameter name in example and in security parameter definition - changes typo comment on settings get all example reference * changes settings to setting in Settings API * settings kind to setting kind in settings CSM API Update batch resource-manager Node.js package version to 3.1.2 (Azure#3732) IoTHub conf py (Azure#3733) Reports API moved from stable to preview version with addition of documentation of a couple of new APIs (Azure#3640) * Consumption specifications for cost insights and reporting operations * Fixed $ref for ReportConfigDelete * Silly me!! Fixed bad reference again * Fixed schema validation issues * Fixing validation errors around datetime and dynamic respones * Fixed parameters in examples * Fixed parameter name in example * Removed x-ms-odata method for POST op * Fixed ARM review comments * Moved reports and usage analysis from microsoft.consumption to microsoft.costmanagament * Merged with master again * Updated reports api documentation * Undo remove of API from stable version providing description for new introduced property isRecurringCharge fix example issues Microsoft.ResourceGraph public preview spec (Azure#3716) Add new microsoft.logic version (Azure#3683) * Copy of the source version (2016-06-01) to seed the new version (2018-07-01-preview) * Update Microsoft.Logic from 2016-06-01 to 2018-07-01-preview * Remove extra prep files, update the readme Fix Go SDK codegen for containerinstance (Azure#3735) The package-2018-06 tag was incorrecly using the 2018-04 tag. Moved Go SDK config section to its own config file. Microsoft.NetApp first version (Azure#3639) * Microsoft.NetApp first version * Addressing pullrequest comments added back billingperiod

Add new API for Azure Security Center Settings

d54953d

azuresdkci assigned jianghaolu Jul 26, 2018

azuresdkci requested a review from jianghaolu July 26, 2018 13:14

AutorestCI mentioned this pull request Jul 26, 2018

[AutoPR security/resource-manager] [Do Not Merge] Introducing new API for Azure Security Center Settings Azure/azure-sdk-for-go#2320

Merged

chlahav added the DoNotMerge <valid label in PR review process> use to hold merge after approval label Jul 26, 2018

chlahav self-requested a review July 26, 2018 14:18

Changed SettingsPUT API to receive parameter and not definition.

1efe8f5

jianghaolu suggested changes Jul 26, 2018

View reviewed changes

- changed settings parameter name in example and in security paramete…

41e9a4f

…r definition - changes typo comment on settings get all example reference

chlahav reviewed Jul 30, 2018

View reviewed changes

chlahav suggested changes Jul 30, 2018

View reviewed changes

tomer-weinberger added 2 commits July 30, 2018 10:54

changes settings to setting in Settings API

caeaaa8

settings kind to setting kind in settings CSM API

ee991b7

jianghaolu approved these changes Jul 30, 2018

View reviewed changes

chlahav approved these changes Aug 1, 2018

View reviewed changes

ravbhatnagar added the ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review label Aug 3, 2018

ghost changed the title ~~[Do Not Merge] Introducing new API for Azure Security Center Settings~~ Introducing new API for Azure Security Center Settings Aug 27, 2018

jianghaolu merged commit f92a8fa into Azure:master Aug 27, 2018

Conversation

ghost commented Jul 26, 2018 • edited by azuresdkci Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR information

Quality of Swagger

Uh oh!

AutorestCI commented Jul 26, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Automation for azure-sdk-for-python

Uh oh!

AutorestCI commented Jul 26, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Automation for azure-sdk-for-ruby

Uh oh!

AutorestCI commented Jul 26, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Automation for azure-sdk-for-node

Uh oh!

AutorestCI commented Jul 26, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Automation for azure-sdk-for-java

Uh oh!

AutorestCI commented Jul 26, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Automation for azure-sdk-for-go

Uh oh!

jianghaolu Jul 26, 2018

Choose a reason for hiding this comment

Uh oh!

ghost Jul 29, 2018

Choose a reason for hiding this comment

Uh oh!

chlahav Jul 30, 2018

Choose a reason for hiding this comment

Uh oh!

ghost Jul 30, 2018

Choose a reason for hiding this comment

Uh oh!

chlahav Jul 30, 2018

Choose a reason for hiding this comment

Uh oh!

ghost Jul 30, 2018

Choose a reason for hiding this comment

Uh oh!

chlahav Jul 30, 2018

Choose a reason for hiding this comment

Uh oh!

chlahav left a comment

Choose a reason for hiding this comment

Uh oh!

chlahav left a comment

Choose a reason for hiding this comment

Uh oh!

azuresdkci commented Aug 2, 2018

Uh oh!

ghost commented Aug 27, 2018

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Comments

ghost commented Jul 26, 2018 •

edited by azuresdkci

Loading

AutorestCI commented Jul 26, 2018 •

edited

Loading

AutorestCI commented Jul 26, 2018 •

edited

Loading

AutorestCI commented Jul 26, 2018 •

edited

Loading

AutorestCI commented Jul 26, 2018 •

edited

Loading

AutorestCI commented Jul 26, 2018 •

edited

Loading