Skip to content

Conversation

@pshao25
Copy link
Member

@pshao25 pshao25 commented Jul 25, 2025

This PR migrates your latest version (identified by the tag in your readme.md) of swagger to TypeSpec. We already tried our best to make sure the TypeSpec represents same as previous swagger. Since we lack the business knowledge, please validate this PR again to make sure it's functional equivalent as before. The local validation step is at Getting started | TypeSpec Azure

Besides, TypeSpec encourages to follow ARM guidelines. Therefore, some representations in your previous swagger will be fixed to follow these guidelines. When you see differences in your local validation, please keep this note in mind. Here is the list you need to pay attention:

  • You are referring to different versions of common type. We unified the common type version to v4.

Please reach out to TypeSpec Discussions Channel if there is any help needed.

@openapi-pipeline-app
Copy link

openapi-pipeline-app bot commented Jul 25, 2025

Next Steps to Merge

Next steps that must be taken to merge this PR:
  • ❌ This PR targets either the main branch of the public specs repo or the RPSaaSMaster branch of the private specs repo. These branches are not intended for iterative development. Therefore, you must acknowledge you understand that after this PR is merged, the APIs are considered shipped to Azure customers. Any further attempts at in-place modifications to the APIs will be subject to Azure's versioning and breaking change policies. Additionally, for control plane APIs, you must acknowledge that you are following all the best practices documented by ARM at aka.ms/armapibestpractices. If you do intend to release the APIs to your customers by merging this PR, add the PublishToCustomers label to your PR in acknowledgement of the above. Otherwise, retarget this PR onto a feature branch, i.e. with prefix release- (see aka.ms/azsdk/api-versions#release--branches).
  • ❌ This PR is in purview of the ARM review (label: ARMReview). This PR must get ARMSignedOff label from an ARM reviewer.
    This PR is not ready for ARM review (label: NotReadyForARMReview). This PR will not be reviewed by ARM until relevant problems are fixed. Consult the rest of this Next Steps to Merge comment for details.
    Once the blocking problems are addressed, add to the PR a comment with contents /azp run. Automation will re-evaluate this PR and if everything looks good, it will add WaitForARMFeedback label which will put this PR on the ARM review queue.
    For details of the ARM review, see aka.ms/azsdk/pr-arm-review
  • ❌ This PR is NotReadyForARMReview because it has the VersioningReviewRequired label.
  • ❌ This PR has at least one change violating Azure versioning policy (label: VersioningReviewRequired).
    To unblock this PR, either a) introduce a new API version with these changes instead of modifying an existing API version, or b) follow the process at aka.ms/brch.
  • ❌ The required check named Automated merging requirements met has failed. This is the final check that must pass. Refer to the check in the PR's 'Checks' tab for details on how to fix it and consult the aka.ms/ci-fix guide. In addition, refer to step 4 in the PR workflow diagram

@openapi-pipeline-app
Copy link

openapi-pipeline-app bot commented Jul 25, 2025

PR validation pipeline restarted successfully. If there is ApiView generated, it will be updated in this comment.

@github-actions
Copy link

github-actions bot commented Jul 25, 2025

API Change Check

APIView identified API level changes in this PR and created the following API reviews

Language API Review for Package
Swagger Microsoft.DevCenter
TypeSpec Microsoft.DevCenter
Go sdk/resourcemanager/devcenter/armdevcenter
JavaScript @azure/arm-devcenter
Java com.azure.resourcemanager:azure-resourcemanager-devcenter

@ArberH
Copy link
Contributor

ArberH commented Sep 12, 2025

i still see lots of validation errors. please fix them.

Besides the PatchBodyParametersSchema that I may just have to use a global suppression for (see ongoing discussion), what other errors are you referring to?

@github-actions github-actions bot added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Sep 12, 2025
@gary-x-li gary-x-li added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Sep 16, 2025
Copy link
Member

@snehanagendra snehanagendra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ArberH ArberH enabled auto-merge (squash) September 16, 2025 22:00
@ArberH ArberH merged commit 358a4ad into main Sep 16, 2025
38 of 41 checks passed
@ArberH ArberH deleted the migration/devcenter branch September 16, 2025 22:07
markcowl pushed a commit to markcowl/azure-rest-api-specs that referenced this pull request Sep 18, 2025
DevCenter TypeSpec conversion

---------

Co-authored-by: Pan Shao <[email protected]>
Co-authored-by: mcgallan <[email protected]>
Co-authored-by: tadelesh <[email protected]>
Co-authored-by: Yuchao Yan <[email protected]>
Co-authored-by: Arber Hila <[email protected]>
Co-authored-by: xiaofeicao <[email protected]>
Co-authored-by: Arber Hila <[email protected]>
Co-authored-by: mcgallan <[email protected]>
Co-authored-by: Mike Harder <[email protected]>
Co-authored-by: Jiao Di (MSFT) <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Approved-Suppression ARMReview ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review PipelineBotTrigger PublishToCustomers Acknowledgement the changes will be published to Azure customers. resource-manager RPaaS rpaas-tsp-conversion SuppressionReviewRequired TypeSpec Authored with TypeSpec typespec-conversion-w2 Versioning-Approved-Benign https://github.com/Azure/azure-sdk-tools/issues/6374 VersioningReviewRequired <valid label in PR review process>add this label when versioning review is required

Projects

None yet

Development

Successfully merging this pull request may close these issues.