Skip to content

Conversation

@mzhongl524
Copy link
Member

@mzhongl524 mzhongl524 commented Sep 17, 2025

This is the SDK validation for DevCenter.
TSP link: Azure/azure-rest-api-specs#36201.

Changes:

  • Add renaming, resource name and directive in the autorest file
  • Add custom code

Contributing to the Azure SDK

Please see our CONTRIBUTING.md if you are not familiar with contributing to this repository or have questions.

For specific information about pull request etiquette and best practices, see this section.

@mzhongl524 mzhongl524 added the Mgmt This issue is related to a management package. label Sep 17, 2025
@github-actions
Copy link

github-actions bot commented Sep 22, 2025

API Change Check

APIView identified API level changes in this PR and created the following API reviews

Azure.ResourceManager.DevCenter

@mzhongl524 mzhongl524 marked this pull request as ready for review September 25, 2025 02:09
Copilot AI review requested due to automatic review settings September 25, 2025 02:09
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR implements custom code additions for the Azure DevCenter Resource Manager SDK to handle missing parameters and breaking changes from TypeSpec swagger validation. The primary purpose is to maintain backward compatibility by providing deprecated method overloads that include the top parameter, and to restore functionality for image listing that had breaking changes.

  • Add deprecated method overloads with top parameter for schedule-related operations
  • Restore GetImages methods for DevCenterResource due to breaking changes in return type
  • Add deprecated factory methods for backward compatibility in the model factory

Reviewed Changes

Copilot reviewed 5 out of 393 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
DevCenterScheduleResource.cs Adds deprecated Get method overloads that accept top parameter but delegate to parameterless versions
DevCenterScheduleCollection.cs Adds deprecated method overloads for Get, Exists, and GetIfExists operations with top parameter
DevCenterResource.cs Restores GetImages methods that return DevCenterImageResource collections due to breaking changes
DevCenterPoolResource.cs Adds deprecated GetDevCenterSchedule method overloads with top parameter
ArmDevCenterModelFactory.cs Adds deprecated factory method overloads for backward compatibility with older parameter sets

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Mgmt This issue is related to a management package.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants