-
Notifications
You must be signed in to change notification settings - Fork 5.1k
[DevCenter] SDK validation for TypeSpec swagger #52664
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
sdk/devcenter/Azure.ResourceManager.DevCenter/api/Azure.ResourceManager.DevCenter.net8.0.cs
Outdated
Show resolved
Hide resolved
API Change CheckAPIView identified API level changes in this PR and created the following API reviews |
sdk/devcenter/Azure.ResourceManager.DevCenter/api/Azure.ResourceManager.DevCenter.net8.0.cs
Show resolved
Hide resolved
sdk/devcenter/Azure.ResourceManager.DevCenter/api/Azure.ResourceManager.DevCenter.net8.0.cs
Outdated
Show resolved
Hide resolved
sdk/devcenter/Azure.ResourceManager.DevCenter/api/Azure.ResourceManager.DevCenter.net8.0.cs
Outdated
Show resolved
Hide resolved
sdk/devcenter/Azure.ResourceManager.DevCenter/api/Azure.ResourceManager.DevCenter.net8.0.cs
Outdated
Show resolved
Hide resolved
sdk/devcenter/Azure.ResourceManager.DevCenter/api/Azure.ResourceManager.DevCenter.net8.0.cs
Outdated
Show resolved
Hide resolved
sdk/devcenter/Azure.ResourceManager.DevCenter/src/Custom/DevCenterPoolResource.cs
Outdated
Show resolved
Hide resolved
sdk/devcenter/Azure.ResourceManager.DevCenter/src/Custom/DevCenterPoolResource.cs
Outdated
Show resolved
Hide resolved
sdk/devcenter/Azure.ResourceManager.DevCenter/src/Custom/DevCenterScheduleCollection.cs
Show resolved
Hide resolved
sdk/devcenter/Azure.ResourceManager.DevCenter/src/Custom/DevCenterResource.cs
Show resolved
Hide resolved
sdk/devcenter/Azure.ResourceManager.DevCenter/src/Custom/DevCenterScheduleResource.cs
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR implements custom code additions for the Azure DevCenter Resource Manager SDK to handle missing parameters and breaking changes from TypeSpec swagger validation. The primary purpose is to maintain backward compatibility by providing deprecated method overloads that include the top parameter, and to restore functionality for image listing that had breaking changes.
- Add deprecated method overloads with
topparameter for schedule-related operations - Restore
GetImagesmethods for DevCenterResource due to breaking changes in return type - Add deprecated factory methods for backward compatibility in the model factory
Reviewed Changes
Copilot reviewed 5 out of 393 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| DevCenterScheduleResource.cs | Adds deprecated Get method overloads that accept top parameter but delegate to parameterless versions |
| DevCenterScheduleCollection.cs | Adds deprecated method overloads for Get, Exists, and GetIfExists operations with top parameter |
| DevCenterResource.cs | Restores GetImages methods that return DevCenterImageResource collections due to breaking changes |
| DevCenterPoolResource.cs | Adds deprecated GetDevCenterSchedule method overloads with top parameter |
| ArmDevCenterModelFactory.cs | Adds deprecated factory method overloads for backward compatibility with older parameter sets |
This is the SDK validation for DevCenter.
TSP link: Azure/azure-rest-api-specs#36201.
Changes:
autorestfileContributing to the Azure SDK
Please see our CONTRIBUTING.md if you are not familiar with contributing to this repository or have questions.
For specific information about pull request etiquette and best practices, see this section.