SpotPlacementScore restructuring to RecommenderRP subdirectory - init… by Elina-L · Pull Request #36075 · Azure/azure-rest-api-specs

Elina-L · 2025-07-21T18:51:19Z

…ial commit

ARM (Control Plane) API Specification Update Pull Request

Tip

Overwhelmed by all this guidance? See the Getting help section at the bottom of this PR description.

PR review workflow diagram

Please understand this diagram before proceeding. It explains how to get your PR approved & merged.

Purpose of this PR

What's the purpose of this PR? Check the specific option that applies. This is mandatory!

New resource provider.
New API version for an existing resource provider. (If API spec is not defined in TypeSpec, the PR should have been created in adherence to OpenAPI specs PR creation guidance).
Update existing version for a new feature. (This is applicable only when you are revising a private preview API version.)
Update existing version to fix OpenAPI spec quality issues in S360.
Convert existing OpenAPI spec to TypeSpec spec (do not combine this with implementing changes for a new API version).
Other, please clarify:
Moved SpotPlacementScore APIs to new RecommenderRP subdirectory under Microsoft.Compute - this is to split off Recommender APIs from Diagnostic APIs that our team owns.

Due diligence checklist

To merge this PR, you must go through the following checklist and confirm you understood
and followed the instructions by checking all the boxes:

I confirm this PR is modifying Azure Resource Manager (ARM) related specifications, and not data plane related specifications.
I have reviewed following Resource Provider guidelines, including
ARM resource provider contract and
REST guidelines (estimated time: 4 hours).
I understand this is required before I can proceed to the diagram Step 2, "ARM API changes review", for this PR.
A release plan has been created. If not, please create one as it will help guide you through the REST API and SDK creation process.

Additional information

Viewing API changes

For convenient view of the API changes made by this PR, refer to the URLs provided in the table
in the Generated ApiView comment added to this PR. You can use ApiView to show API versions diff.

Suppressing failures

If one or multiple validation error/warning suppression(s) is detected in your PR, please follow the
suppressions guide to get approval.

Getting help

First, please carefully read through this PR description, from top to bottom. Please fill out the Purpose of this PR and Due diligence checklist.
If you don't have permissions to remove or add labels to the PR, request write access per aka.ms/azsdk/access#request-access-to-rest-api-or-sdk-repositories
To understand what you must do next to merge this PR, see the Next Steps to Merge comment. It will appear within few minutes of submitting this PR and will continue to be up-to-date with current PR state.
For guidance on fixing this PR CI check failures, see the hyperlinks provided in given failure
and https://aka.ms/ci-fix.
For help with ARM review (PR workflow diagram Step 2), see https://aka.ms/azsdk/pr-arm-review.
If the PR CI checks appear to be stuck in queued state, please add a comment with contents /azp run.
This should result in a new comment denoting a PR validation pipeline has started and the checks should be updated after few minutes.
If the help provided by the previous points is not enough, post to https://aka.ms/azsdk/support/specreview-channel and link to this PR.
For guidance on SDK breaking change review, refer to https://aka.ms/ci-fix.

…ial commit

openapi-pipeline-app · 2025-07-21T18:51:23Z

Next Steps to Merge

✅ All automated merging requirements have been met! To get your PR merged, see aka.ms/azsdk/specreview/merge.

openapi-pipeline-app · 2025-07-21T18:51:24Z

PR validation pipeline restarted successfully. If there is ApiView generated, it will be updated in this comment.

…ecommenderRP

github-actions · 2025-07-21T18:53:59Z

API Change Check

APIView identified API level changes in this PR and created the following API reviews

Language	API Review for Package
Swagger	Microsoft.Compute-RecommenderRP
Java	com.azure.resourcemanager:azure-resourcemanager-compute-generated
JavaScript	@azure/arm-compute

…cementScore APIs, remove unref'd example files

…ecommenderRP

Elina-L · 2025-07-21T20:45:31Z

This is the first in a three part PR series that aims to do the same as the following PR: #36039

I am breaking the PR linked above into three parts to make the PR more understandable and easy to review. I will work on and merge each PR in sequence.

PR order after discussion with Gary:
1. Move the (two) Spot Placement Score APIs to a new swagger file RecommenderRP.json under a new RecommenderRP subdirectory. Keep the API version as is: 2025-02-01-preview version
2. Add 2025-06-05 stable API version of the RecommenderRP.json swagger file in the RecommenderRP subdirectory
3. Add TypeSpec conversion of the swagger file in the 2025-06-05 stable API version subdirectory

gary-x-li · 2025-07-21T21:21:06Z

specification/compute/resource-manager/Microsoft.Compute/RecommenderRP/readme.md

+  - code: DefinitionsPropertiesNamesCamelCase
+    reason: The property name contains abbreviations and need to keep it as upper case.
+    from: RecommenderRP.json
+  - code: BodyTopLevelProperties


Can you add a where clause to indicate which property you are suppressing? Add more entries if there're multiple instances.

Removed BodyTopLevelProperties suppression

gary-x-li · 2025-07-21T21:23:25Z

specification/compute/resource-manager/Microsoft.Compute/RecommenderRP/readme.md

+  - code: OperationsAPIImplementation
+    reason: The operations API is defined in a separate file.
+    from: RecommenderRP.json
+  - code: PathForResourceAction


Can you add a where clause to indicate which property you are suppressing? Add more entries if there're multiple instances.

Added where clause

gary-x-li · 2025-07-21T21:23:35Z

specification/compute/resource-manager/Microsoft.Compute/RecommenderRP/readme.md

+  - code: PathForResourceAction
+    reason: This is not a valid scenario for the diskInspection and spotPlacementRecommender API as API Path does not match ARM Lint check formatting, requesting to suppress due to approval from reviewer.
+    from: RecommenderRP.json
+  - code: PathForNestedResource


Can you add a where clause to indicate which property you are suppressing? Add more entries if there're multiple instances.

Added where clause

…P' of https://github.com/Elina-L/azure-rest-api-specs into wenxliu/Part1SplitSpotPlacementScoreAPIIntoRecommenderRP

…ecommenderRP

…re clause

…ecommenderRP

qiaozha · 2025-07-22T01:24:46Z

Add suppression for avocado as MULTIPLE_API_VERSION issue has already been aware by compute team.

…ecommenderRP

tadelesh · 2025-07-23T03:16:11Z

/azp run SDK Validation - Go

azure-pipelines · 2025-07-23T03:16:22Z

Azure Pipelines successfully started running 1 pipeline(s).

SpotPlacementScore restructuring to RecommenderRP subdirectory - init…

951848a

…ial commit

Elina-L requested review from MS-syh2qs, dkulkarni-ms, grizzlytheodore and haagha as code owners July 21, 2025 18:51

Merge branch 'main' into wenxliu/Part1SplitSpotPlacementScoreAPIIntoR…

e27e489

…ecommenderRP

microsoft-github-policy-service bot added the Compute label Jul 21, 2025

Adding readme.md in RecommenderRP, default tag is 2025-02-01-preview

0d26ffd

github-actions bot added the BreakingChange-Go-Sdk label Jul 21, 2025

AzureRestAPISpecReview added ARMReview resource-manager WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Jul 21, 2025

Update RecommenderRP.json to only have the latest versions of SpotPla…

cceb1db

…cementScore APIs, remove unref'd example files

AzureRestAPISpecReview added the SuppressionReviewRequired label Jul 21, 2025

github-actions bot added the BreakingChange-JavaScript-Sdk label Jul 21, 2025

Elina-L added 2 commits July 21, 2025 13:26

Adding missing required property

a8b20c5

Merge branch 'main' into wenxliu/Part1SplitSpotPlacementScoreAPIIntoR…

191d993

…ecommenderRP

gary-x-li reviewed Jul 21, 2025

View reviewed changes

Elina-L added 2 commits July 21, 2025 15:15

Change API version to 2025-06-05, remove all suppressions

2b66bfc

Merge branch 'wenxliu/Part1SplitSpotPlacementScoreAPIIntoRecommenderR…

d2290bd

…P' of https://github.com/Elina-L/azure-rest-api-specs into wenxliu/Part1SplitSpotPlacementScoreAPIIntoRecommenderRP

AzureRestAPISpecReview added new-api-version and removed SuppressionReviewRequired labels Jul 21, 2025

Elina-L added 2 commits July 21, 2025 15:39

Clean up unused class definitions, use latest v6 types.json file

dc3ba2b

Merge branch 'main' into wenxliu/Part1SplitSpotPlacementScoreAPIIntoR…

28a1f31

…ecommenderRP

Adding partial suppressions back

faa74d6

AzureRestAPISpecReview added the SuppressionReviewRequired label Jul 21, 2025

Elina-L added 3 commits July 21, 2025 16:36

Add back OperationsAPIImplementation suppression and add paths in whe…

8b9e982

…re clause

Merge branch 'main' into wenxliu/Part1SplitSpotPlacementScoreAPIIntoR…

1918529

…ecommenderRP

Update suppressions yaml for 2025-06-05 version

d6b9f54

qiaozha added the Approved-Avocado label Jul 22, 2025

qiaozha added the BreakingChange-JavaScript-Sdk-Approved label Jul 22, 2025

gary-x-li added the ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review label Jul 22, 2025

openapi-pipeline-app bot removed the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Jul 22, 2025

gary-x-li added WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required Approved-Suppression and removed WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Jul 22, 2025

tadelesh added the BreakingChange-Go-Sdk-Approved label Jul 22, 2025

Elina-L enabled auto-merge (squash) July 22, 2025 03:22

Merge branch 'main' into wenxliu/Part1SplitSpotPlacementScoreAPIIntoR…

e2d2d4e

…ecommenderRP

Elina-L added the PublishToCustomers Acknowledgement the changes will be published to Azure customers. label Jul 22, 2025

Elina-L requested a review from gary-x-li July 22, 2025 03:36

Merge branch 'main' into wenxliu/Part1SplitSpotPlacementScoreAPIIntoR…

af08905

…ecommenderRP

github-actions bot removed the BreakingChange-Go-Sdk label Jul 22, 2025

grizzlytheodore approved these changes Jul 22, 2025

View reviewed changes

Merge branch 'main' into wenxliu/Part1SplitSpotPlacementScoreAPIIntoR…

94b3750

…ecommenderRP

Elina-L merged commit a539c8d into Azure:main Jul 23, 2025
44 of 46 checks passed

github-actions bot added the BreakingChange-Go-Sdk label Jul 23, 2025

jefpa-microsoft mentioned this pull request Aug 5, 2025

Add swagger for CapacityBlocks API #35543

Open

9 tasks

Elina-L mentioned this pull request Aug 8, 2025

RecommenderRP TypeSpec Conversion for version 20250605 #36039

Merged

9 tasks

Conversation

Elina-L commented Jul 21, 2025 • edited by grizzlytheodore Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

ARM (Control Plane) API Specification Update Pull Request

PR review workflow diagram

Purpose of this PR

Due diligence checklist

Additional information

Getting help

Uh oh!

openapi-pipeline-app bot commented Jul 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Next Steps to Merge

Uh oh!

openapi-pipeline-app bot commented Jul 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Jul 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

API Change Check

Uh oh!

Elina-L commented Jul 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

gary-x-li Jul 21, 2025

Choose a reason for hiding this comment

Uh oh!

Elina-L Jul 21, 2025

Choose a reason for hiding this comment

Uh oh!

gary-x-li Jul 21, 2025

Choose a reason for hiding this comment

Uh oh!

Elina-L Jul 21, 2025

Choose a reason for hiding this comment

Uh oh!

gary-x-li Jul 21, 2025

Choose a reason for hiding this comment

Uh oh!

Elina-L Jul 21, 2025

Choose a reason for hiding this comment

Uh oh!

qiaozha commented Jul 22, 2025

Uh oh!

tadelesh commented Jul 23, 2025

Uh oh!

azure-pipelines bot commented Jul 23, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

Comments

Elina-L commented Jul 21, 2025 •

edited by grizzlytheodore

Loading

openapi-pipeline-app bot commented Jul 21, 2025 •

edited

Loading

openapi-pipeline-app bot commented Jul 21, 2025 •

edited

Loading

github-actions bot commented Jul 21, 2025 •

edited

Loading

Elina-L commented Jul 21, 2025 •

edited

Loading