Skip to content

Update databox readme.nodejs.md file #3557

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
1 commit merged into from
Jul 31, 2018
Merged

Update databox readme.nodejs.md file #3557

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions specification/databox/resource-manager/readme.nodejs.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,5 +7,9 @@ Please also specify `--node-sdks-folder=<path to root folder of your azure-sdk-f
nodejs:
azure-arm: true
package-name: azure-arm-databox
output-folder: $(node-sdks-folder)/lib/services/databox/lib
```
package-version: 1.0.0-preview
output-folder: $(node-sdks-folder)/lib/services/databox
Copy link
Copy Markdown
Member

@RikkiGibson RikkiGibson Jul 31, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is taking off the trailing /lib the right thing to do here? Thought our generate-metadata settings want to put them in ../.

Copy link
Copy Markdown
Author

@ghost ghost Jul 31, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, I changed that a while ago in the autorest.nodejs generator. The output-folder points at the root folder and we generate files inside their folders with respect to the base folder.

generate-license-txt: true
generate-package-json: true
generate-readme-md: true
```