Skip to content

Comments

Update databox readme.nodejs.md file#3557

Merged
1 commit merged intomasterfrom
daschult/databox
Jul 31, 2018
Merged

Update databox readme.nodejs.md file#3557
1 commit merged intomasterfrom
daschult/databox

Conversation

@ghost
Copy link

@ghost ghost commented Jul 31, 2018

This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.

PR information

  • The title of the PR is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
  • Except for special cases involving multiple contributors, the PR is started from a fork of the main repository, not a branch.
  • If applicable, the PR references the bug/issue that it fixes.
  • Swagger files are correctly named (e.g. the api-version in the path should match the api-version in the spec).

Quality of Swagger

@ghost ghost self-assigned this Jul 31, 2018
@ghost ghost requested review from RikkiGibson, amarzavery and kushalvms July 31, 2018 19:21
@azuresdkci
Copy link
Contributor

Can one of the admins verify this patch?

@AutorestCI
Copy link

AutorestCI commented Jul 31, 2018

Automation for azure-sdk-for-go

Nothing to generate for azure-sdk-for-go

@AutorestCI
Copy link

AutorestCI commented Jul 31, 2018

Automation for azure-sdk-for-ruby

Nothing to generate for azure-sdk-for-ruby

@AutorestCI
Copy link

AutorestCI commented Jul 31, 2018

Automation for azure-sdk-for-java

Nothing to generate for azure-sdk-for-java

@AutorestCI
Copy link

AutorestCI commented Jul 31, 2018

Automation for azure-sdk-for-python

Nothing to generate for azure-sdk-for-python

@AutorestCI
Copy link

AutorestCI commented Jul 31, 2018

Automation for azure-sdk-for-node

A PR has been created for you:
Azure/azure-sdk-for-node#3271

output-folder: $(node-sdks-folder)/lib/services/databox/lib
```
package-version: 1.0.0-preview
output-folder: $(node-sdks-folder)/lib/services/databox
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is taking off the trailing /lib the right thing to do here? Thought our generate-metadata settings want to put them in ../.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, I changed that a while ago in the autorest.nodejs generator. The output-folder points at the root folder and we generate files inside their folders with respect to the base folder.

@ghost ghost merged commit 5fbd95b into master Jul 31, 2018
@ghost ghost deleted the daschult/databox branch July 31, 2018 20:23
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants