Skip to content

Dev sentinel securityinsights microsoft.security insights 2025 06 01#34886

Merged
xuhumsft merged 11 commits intomainfrom
dev-Sentinel-securityinsights-Microsoft.SecurityInsights-2025-06-01
Jun 20, 2025
Merged

Dev sentinel securityinsights microsoft.security insights 2025 06 01#34886
xuhumsft merged 11 commits intomainfrom
dev-Sentinel-securityinsights-Microsoft.SecurityInsights-2025-06-01

Conversation

@xuhumsft
Copy link
Member

@xuhumsft xuhumsft commented May 23, 2025

ARM (Control Plane) API Specification Update Pull Request

Tip

Overwhelmed by all this guidance? See the Getting help section at the bottom of this PR description.

PR review workflow diagram

Please understand this diagram before proceeding. It explains how to get your PR approved & merged.

spec_pr_review_workflow_diagram

Purpose of this PR

What's the purpose of this PR? Check the specific option that applies. This is mandatory!

  • New resource provider.
  • New API version for an existing resource provider. (If API spec is not defined in TypeSpec, the PR should have been created in adherence to OpenAPI specs PR creation guidance).
  • Update existing version for a new feature. (This is applicable only when you are revising a private preview API version.)
  • Update existing version to fix OpenAPI spec quality issues in S360.
  • Convert existing OpenAPI spec to TypeSpec spec (do not combine this with implementing changes for a new API version).
  • Other, please clarify:
    • edit this with your clarification

Due diligence checklist

To merge this PR, you must go through the following checklist and confirm you understood
and followed the instructions by checking all the boxes:

  • I confirm this PR is modifying Azure Resource Manager (ARM) related specifications, and not data plane related specifications.
  • I have reviewed following Resource Provider guidelines, including
    ARM resource provider contract and
    REST guidelines (estimated time: 4 hours).
    I understand this is required before I can proceed to the diagram Step 2, "ARM API changes review", for this PR.
  • A release plan has been created. If not, please create one as it will help guide you through the REST API and SDK creation process.

Additional information

Viewing API changes

For convenient view of the API changes made by this PR, refer to the URLs provided in the table
in the Generated ApiView comment added to this PR. You can use ApiView to show API versions diff.

Suppressing failures

If one or multiple validation error/warning suppression(s) is detected in your PR, please follow the
suppressions guide to get approval.

Getting help

  • First, please carefully read through this PR description, from top to bottom. Please fill out the Purpose of this PR and Due diligence checklist.
  • If you don't have permissions to remove or add labels to the PR, request write access per aka.ms/azsdk/access#request-access-to-rest-api-or-sdk-repositories
  • To understand what you must do next to merge this PR, see the Next Steps to Merge comment. It will appear within few minutes of submitting this PR and will continue to be up-to-date with current PR state.
  • For guidance on fixing this PR CI check failures, see the hyperlinks provided in given failure
    and https://aka.ms/ci-fix.
  • For help with ARM review (PR workflow diagram Step 2), see https://aka.ms/azsdk/pr-arm-review.
  • If the PR CI checks appear to be stuck in queued state, please add a comment with contents /azp run.
    This should result in a new comment denoting a PR validation pipeline has started and the checks should be updated after few minutes.
  • If the help provided by the previous points is not enough, post to https://aka.ms/azsdk/support/specreview-channel and link to this PR.

xuhumsft added 4 commits May 5, 2025 11:22
Copied the files in a separate commit.
This allows reviewers to easily diff subsequent changes against the previous spec.
Updated the API version from stable/2025-03-01 to stable/2025-06-01.
@openapi-pipeline-app
Copy link

openapi-pipeline-app bot commented May 23, 2025

Next Steps to Merge

✅ All automated merging requirements have been met! To get your PR merged, see aka.ms/azsdk/specreview/merge.

@openapi-pipeline-app
Copy link

openapi-pipeline-app bot commented May 23, 2025

PR validation pipeline restarted successfully. If there is ApiView generated, it will be updated in this comment.

@github-actions github-actions bot added the brownfield Brownfield services will soon be required to convert to TypeSpec. See https://aka.ms/azsdk/typespec. label May 23, 2025
@github-actions
Copy link

github-actions bot commented May 23, 2025

API Change Check

APIView identified API level changes in this PR and created the following API reviews

Language API Review for Package
Swagger common
Go sdk/resourcemanager/securityinsights/armsecurityinsights
Python azure-mgmt-securityinsight
Java com.azure.resourcemanager:azure-resourcemanager-securityinsights
JavaScript @azure/arm-securityinsight

@AzureRestAPISpecReview AzureRestAPISpecReview added ARMReview new-api-version resource-manager WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels May 23, 2025
@razvanbadea-msft
Copy link
Member

Fix errors from the required avocado, lintdiff checks

@razvanbadea-msft
Copy link
Member

/azp run

@azure-pipelines
Copy link

You have several pipelines (over 10) configured to build pull requests in this repository. Specify which pipelines you would like to run by using /azp run [pipelines] command. You can specify multiple pipelines using a comma separated list.

@openapi-pipeline-app openapi-pipeline-app bot added PipelineBotTrigger and removed WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required PipelineBotTrigger labels May 23, 2025
@xuhumsft
Copy link
Member Author

xuhumsft commented Jun 3, 2025

/azp run

@azure-pipelines
Copy link

You have several pipelines (over 10) configured to build pull requests in this repository. Specify which pipelines you would like to run by using /azp run [pipelines] command. You can specify multiple pipelines using a comma separated list.

@xuhumsft
Copy link
Member Author

xuhumsft commented Jun 6, 2025

I tried to add the where clause in suppression. However it does not work. After attending the office hour, I got approval to not include where clause in this release. For Swagger Avocado, please check my previous comments.

For Avocado, please check #33317. During the investigation in the last release, it was caused by versions before 2022, specify a route parameter, which is determined to be fixed. Those are in the old API. I tried to fix them, it causes more errors.

@@ -0,0 +1,1856 @@
{
"swagger": "2.0",
Copy link
Member

@kazrael2119 kazrael2119 Jun 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just want to confirm if the name DataConnectors.jso is correct? Will this name be used in the future? Because in the past, the name of this file was dataConnectors.json
image

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sagamzu ,

Could you please take a look at this comment?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@xuhumsft , @kazrael2119 it looks the same name for me. Start with capital\lower letter.
All the files in start with capital letter, i am not sure why only data connector start with lower.

I dont see any issue with using capital letter for this file..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Approved-Avocado ARMReview ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review brownfield Brownfield services will soon be required to convert to TypeSpec. See https://aka.ms/azsdk/typespec. new-api-version PipelineBotTrigger PublishToCustomers Acknowledgement the changes will be published to Azure customers. resource-manager

Projects

None yet

Development

Successfully merging this pull request may close these issues.

10 participants