Skip to content

Microsoft.App 2025-01-01 remove deduplication config for go sdk#32111

Merged
sonwan2020 merged 1 commit intoAzure:release-app-Microsoft.app-2025-01-01from
sonwan2020:sonwan/remove-dedup-config
Jan 14, 2025
Merged

Microsoft.App 2025-01-01 remove deduplication config for go sdk#32111
sonwan2020 merged 1 commit intoAzure:release-app-Microsoft.app-2025-01-01from
sonwan2020:sonwan/remove-dedup-config

Conversation

@sonwan2020
Copy link
Contributor

@sonwan2020 sonwan2020 commented Jan 13, 2025 •
edited
Loading

SDK configuration pull request

Purpose of this PR

  • Make changes to the SDK configuration only when there are no modifications to the API specification, eliminating the need for an ARM or Stewardship Board API review.

Due diligence checklist

To merge this PR, you must go through the following checklist and confirm you understood
and followed the instructions by checking all the boxes:

Getting help

  • First, carefully read through this PR description, from top to bottom. Fill out the Purpose of this PR and Due diligence checklist.
  • If you don't have permissions to remove or add labels to the PR, request write access per aka.ms/azsdk/access#request-access-to-rest-api-or-sdk-repositories
  • To understand what you must do next to merge this PR, see the Next Steps to Merge comment. It will appear within few minutes of submitting this PR and will continue to be up-to-date with current PR state.
  • For guidance on fixing this PR CI check failures, see the hyperlinks provided in given failure and https://aka.ms/ci-fix.
  • If the PR CI checks appear to be stuck in queued state, please add a comment with contents /azp run.
    This should result in a new comment denoting a PR validation pipeline has started and the checks should be updated after few minutes.
  • If the help provided by the previous points is not enough, post to https://aka.ms/azsdk/support/specreview-channel and link to this PR.

@sonwan2020 sonwan2020 requested a review from tadelesh as a code owner January 13, 2025 01:49
@openapi-pipeline-app
Copy link

openapi-pipeline-app bot commented Jan 13, 2025 •
edited
Loading

Next Steps to Merge

✅ All automated merging requirements have been met! To get your PR merged, see aka.ms/azsdk/specreview/merge.

@openapi-pipeline-app
Copy link

openapi-pipeline-app bot commented Jan 13, 2025 •
edited
Loading

Generated ApiView

Language Package Name ApiView Link
Go sdk/resourcemanager/appcontainers/armappcontainers There is no API change compared with the previous version
JavaScript @azure/arm-appcontainers https://apiview.dev/Assemblies/Review/ba41cd9978b542efb0688a072b2319a1?revisionId=1cd71dc67855429faf8b63129e64a5a0
Java azure-resourcemanager-appcontainers https://apiview.dev/Assemblies/Review/7da9ac1e2db64477ada2ba8bbb71169b?revisionId=bd73453a5596425fb2367e750652964f
Python azure-mgmt-appcontainers https://apiview.dev/Assemblies/Review/1693ff33eb9c4a86a7684539954c49cf?revisionId=ae53b28cd331409f8143591482e45229

@sonwan2020
Copy link
Contributor Author

sonwan2020 commented Jan 13, 2025

This is imported by PR: #31958

@AzureRestAPISpecReview AzureRestAPISpecReview added ARMReview resource-manager WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Jan 13, 2025
This was referenced Jan 13, 2025
Closed
Closed
Closed
Closed
Closed
@sonwan2020 sonwan2020 changed the title remove deduplication config for go sdk Microsoft.App 2025-01-01 remove deduplication config for go sdk Jan 13, 2025
@ms-bogdan-rotaru ms-bogdan-rotaru added the ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review label Jan 13, 2025
@openapi-pipeline-app openapi-pipeline-app bot removed the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Jan 13, 2025
@sonwan2020 sonwan2020 merged commit f24f5be into Azure:release-app-Microsoft.app-2025-01-01 Jan 14, 2025
25 checks passed
@sonwan2020 sonwan2020 deleted the sonwan/remove-dedup-config branch January 14, 2025 01:58
najian added a commit that referenced this pull request Mar 25, 2025
@najian @njuCZ
@Juliehzl @LaylaLiu-gmail @LaylaLiu @zhenqxuMSFT @sonwan2020 @tadelesh @yitaopan @mikeharder @vturecek
Release app microsoft.app 2025 01 01 (#32578)
24b224b 
* Copy files from stable/2024-03-01

Copied the files in a separate commit.
This allows reviewers to easily diff subsequent changes against the previous spec.

* Update version to stable/2025-01-01

Updated the API version from stable/2024-03-01 to stable/2025-01-01.

* Added tag for 2025-01-01 in readme file

* Support keda scaler auth using MSI (#31893)

* Support keda scaler auth using MSI

* fix lint

* fix lint

* update

* Add KEDA cooldownPeriod/pollingInterval property for Container App & Jobs (#31891)

* add keda propety

* fix prettier

* fix comment

* Enable BYO NFS Storage in 2025-01-01 (#31850)

* Enable BYO NFS Storage in 2025-01-01

* Fix code style

* Fix

---------

Co-authored-by: Layla Liu <layliu@microsoft.com>

* Add RunningStatus for ContainerApp (#31984)

* Enable Java Runtime in Microsoft.App 2025-01-01 (#31957)

* Enable Java Runtime in 2025-01-01
---------

Co-authored-by: najian <jiangnan8924@gmail.com>

* Support env msi and cert from key vault (#31875)

* Support env msi and cert from key vault

* add spell check ci

* Support Java Components in Microsoft.App version 2025-01-01 (#31958)

* add java components support in version 2025-01-01

* enable lenient model deduplication in go

---------

Co-authored-by: Chenjie Shi <tadelesh.shi@live.cn>

* Update proxy resource type to v5 (#31997)

* update proxy resource type to v5

---------

Co-authored-by: Nan Jiang <naji@microsoft.com>

* remove deduplication config for go sdk (#32111)

* Azure Container Apps SessionPool Api Version 2025-01-01 (#31985)

* SessionPool Api Version 2025-01-01

* Fix example

* DynamicPoolConfiguration.LifecycleConfiguration

* Fix

* Test

* Test

* Test

* test

* Test

* Test

* Test

* Test

* Test

* Test

* Restore

* Test

* Test

* Test

* Restore

* Use TrackedResource for SessionPool patch

* Remove tracked resource and only support tags for patch

* Fix lintdiff

* Update lifecycle type

* Add supress

* fix

* Fix LintDiff failed in Release app microsoft.app 2025 01 01 (#33078)

* Fix LintDiff failed
---------

Co-authored-by: Nan Jiang <naji@microsoft.com>

* Adding managed identity settings (#32009)

* Don't add 201 according to breaking change review comments (#33094)

* Revert "Fix LintDiff failed in Release app microsoft.app 2025 01 01 (#33078)"

This reverts commit 58c987f.

* Fix example

* suppression PutResponseCodes per Breaking change review comments

---------

Co-authored-by: Nan Jiang <naji@microsoft.com>

---------

Co-authored-by: Nan Jiang <naji@microsoft.com>
Co-authored-by: njucz <740360112@qq.com>
Co-authored-by: Zunli Hu <zuh@microsoft.com>
Co-authored-by: LaylaLiu-gmail <38268900+LaylaLiu-gmail@users.noreply.github.com>
Co-authored-by: Layla Liu <layliu@microsoft.com>
Co-authored-by: zhenqxuMSFT <zhenqxu@microsoft.com>
Co-authored-by: Songbo Wang <sonwan@microsoft.com>
Co-authored-by: Chenjie Shi <tadelesh.shi@live.cn>
Co-authored-by: Yitao Pan <yitaopan@microsoft.com>
Co-authored-by: Mike Harder <mharder@microsoft.com>
Co-authored-by: Vaclav Turecek <vturecek@microsoft.com>
pjpatel12 pushed a commit to pjpatel12/azure-rest-api-specs that referenced this pull request Apr 29, 2025
@najian @njuCZ
@Juliehzl @LaylaLiu-gmail @LaylaLiu @zhenqxuMSFT @sonwan2020 @tadelesh @yitaopan @mikeharder @vturecek @pjpatel12
Release app microsoft.app 2025 01 01 (Azure#32578)
f489ea9 
* Copy files from stable/2024-03-01

Copied the files in a separate commit.
This allows reviewers to easily diff subsequent changes against the previous spec.

* Update version to stable/2025-01-01

Updated the API version from stable/2024-03-01 to stable/2025-01-01.

* Added tag for 2025-01-01 in readme file

* Support keda scaler auth using MSI (Azure#31893)

* Support keda scaler auth using MSI

* fix lint

* fix lint

* update

* Add KEDA cooldownPeriod/pollingInterval property for Container App & Jobs (Azure#31891)

* add keda propety

* fix prettier

* fix comment

* Enable BYO NFS Storage in 2025-01-01 (Azure#31850)

* Enable BYO NFS Storage in 2025-01-01

* Fix code style

* Fix

---------

Co-authored-by: Layla Liu <layliu@microsoft.com>

* Add RunningStatus for ContainerApp (Azure#31984)

* Enable Java Runtime in Microsoft.App 2025-01-01 (Azure#31957)

* Enable Java Runtime in 2025-01-01
---------

Co-authored-by: najian <jiangnan8924@gmail.com>

* Support env msi and cert from key vault (Azure#31875)

* Support env msi and cert from key vault

* add spell check ci

* Support Java Components in Microsoft.App version 2025-01-01 (Azure#31958)

* add java components support in version 2025-01-01

* enable lenient model deduplication in go

---------

Co-authored-by: Chenjie Shi <tadelesh.shi@live.cn>

* Update proxy resource type to v5 (Azure#31997)

* update proxy resource type to v5

---------

Co-authored-by: Nan Jiang <naji@microsoft.com>

* remove deduplication config for go sdk (Azure#32111)

* Azure Container Apps SessionPool Api Version 2025-01-01 (Azure#31985)

* SessionPool Api Version 2025-01-01

* Fix example

* DynamicPoolConfiguration.LifecycleConfiguration

* Fix

* Test

* Test

* Test

* test

* Test

* Test

* Test

* Test

* Test

* Test

* Restore

* Test

* Test

* Test

* Restore

* Use TrackedResource for SessionPool patch

* Remove tracked resource and only support tags for patch

* Fix lintdiff

* Update lifecycle type

* Add supress

* fix

* Fix LintDiff failed in Release app microsoft.app 2025 01 01 (Azure#33078)

* Fix LintDiff failed
---------

Co-authored-by: Nan Jiang <naji@microsoft.com>

* Adding managed identity settings (Azure#32009)

* Don't add 201 according to breaking change review comments (Azure#33094)

* Revert "Fix LintDiff failed in Release app microsoft.app 2025 01 01 (Azure#33078)"

This reverts commit 58c987f.

* Fix example

* suppression PutResponseCodes per Breaking change review comments

---------

Co-authored-by: Nan Jiang <naji@microsoft.com>

---------

Co-authored-by: Nan Jiang <naji@microsoft.com>
Co-authored-by: njucz <740360112@qq.com>
Co-authored-by: Zunli Hu <zuh@microsoft.com>
Co-authored-by: LaylaLiu-gmail <38268900+LaylaLiu-gmail@users.noreply.github.com>
Co-authored-by: Layla Liu <layliu@microsoft.com>
Co-authored-by: zhenqxuMSFT <zhenqxu@microsoft.com>
Co-authored-by: Songbo Wang <sonwan@microsoft.com>
Co-authored-by: Chenjie Shi <tadelesh.shi@live.cn>
Co-authored-by: Yitao Pan <yitaopan@microsoft.com>
Co-authored-by: Mike Harder <mharder@microsoft.com>
Co-authored-by: Vaclav Turecek <vturecek@microsoft.com>
nwnt pushed a commit to nwnt/azure-rest-api-specs that referenced this pull request Jun 10, 2025
@najian @njuCZ
@Juliehzl @LaylaLiu-gmail @LaylaLiu @zhenqxuMSFT @sonwan2020 @tadelesh @yitaopan @mikeharder @vturecek
Release app microsoft.app 2025 01 01 (Azure#32578)
7cbc260 
* Copy files from stable/2024-03-01

Copied the files in a separate commit.
This allows reviewers to easily diff subsequent changes against the previous spec.

* Update version to stable/2025-01-01

Updated the API version from stable/2024-03-01 to stable/2025-01-01.

* Added tag for 2025-01-01 in readme file

* Support keda scaler auth using MSI (Azure#31893)

* Support keda scaler auth using MSI

* fix lint

* fix lint

* update

* Add KEDA cooldownPeriod/pollingInterval property for Container App & Jobs (Azure#31891)

* add keda propety

* fix prettier

* fix comment

* Enable BYO NFS Storage in 2025-01-01 (Azure#31850)

* Enable BYO NFS Storage in 2025-01-01

* Fix code style

* Fix

---------

Co-authored-by: Layla Liu <layliu@microsoft.com>

* Add RunningStatus for ContainerApp (Azure#31984)

* Enable Java Runtime in Microsoft.App 2025-01-01 (Azure#31957)

* Enable Java Runtime in 2025-01-01
---------

Co-authored-by: najian <jiangnan8924@gmail.com>

* Support env msi and cert from key vault (Azure#31875)

* Support env msi and cert from key vault

* add spell check ci

* Support Java Components in Microsoft.App version 2025-01-01 (Azure#31958)

* add java components support in version 2025-01-01

* enable lenient model deduplication in go

---------

Co-authored-by: Chenjie Shi <tadelesh.shi@live.cn>

* Update proxy resource type to v5 (Azure#31997)

* update proxy resource type to v5

---------

Co-authored-by: Nan Jiang <naji@microsoft.com>

* remove deduplication config for go sdk (Azure#32111)

* Azure Container Apps SessionPool Api Version 2025-01-01 (Azure#31985)

* SessionPool Api Version 2025-01-01

* Fix example

* DynamicPoolConfiguration.LifecycleConfiguration

* Fix

* Test

* Test

* Test

* test

* Test

* Test

* Test

* Test

* Test

* Test

* Restore

* Test

* Test

* Test

* Restore

* Use TrackedResource for SessionPool patch

* Remove tracked resource and only support tags for patch

* Fix lintdiff

* Update lifecycle type

* Add supress

* fix

* Fix LintDiff failed in Release app microsoft.app 2025 01 01 (Azure#33078)

* Fix LintDiff failed
---------

Co-authored-by: Nan Jiang <naji@microsoft.com>

* Adding managed identity settings (Azure#32009)

* Don't add 201 according to breaking change review comments (Azure#33094)

* Revert "Fix LintDiff failed in Release app microsoft.app 2025 01 01 (Azure#33078)"

This reverts commit 58c987f.

* Fix example

* suppression PutResponseCodes per Breaking change review comments

---------

Co-authored-by: Nan Jiang <naji@microsoft.com>

---------

Co-authored-by: Nan Jiang <naji@microsoft.com>
Co-authored-by: njucz <740360112@qq.com>
Co-authored-by: Zunli Hu <zuh@microsoft.com>
Co-authored-by: LaylaLiu-gmail <38268900+LaylaLiu-gmail@users.noreply.github.com>
Co-authored-by: Layla Liu <layliu@microsoft.com>
Co-authored-by: zhenqxuMSFT <zhenqxu@microsoft.com>
Co-authored-by: Songbo Wang <sonwan@microsoft.com>
Co-authored-by: Chenjie Shi <tadelesh.shi@live.cn>
Co-authored-by: Yitao Pan <yitaopan@microsoft.com>
Co-authored-by: Mike Harder <mharder@microsoft.com>
Co-authored-by: Vaclav Turecek <vturecek@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@najian najian najian approved these changes

@tadelesh tadelesh Awaiting requested review from tadelesh

Assignees

No one assigned

Labels

ARMReview ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review resource-manager

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@sonwan2020 @najian @AzureRestAPISpecReview @ms-bogdan-rotaru