Skip to content

Azure Container Apps SessionPool Api Version 2025-01-01#31985

Merged
yitaopan merged 26 commits intoAzure:release-app-Microsoft.app-2025-01-01from
yitaopan:release-app-Microsoft.app-2025-01-01-sessionpool
Feb 5, 2025
Merged

Azure Container Apps SessionPool Api Version 2025-01-01#31985
yitaopan merged 26 commits intoAzure:release-app-Microsoft.app-2025-01-01from
yitaopan:release-app-Microsoft.app-2025-01-01-sessionpool

Conversation

@yitaopan
Copy link
Member

@yitaopan yitaopan commented Jan 2, 2025

ARM (Control Plane) API Specification Update Pull Request

Tip

Overwhelmed by all this guidance? See the Getting help section at the bottom of this PR description.

PR review workflow diagram

Please understand this diagram before proceeding. It explains how to get your PR approved & merged.

spec_pr_review_workflow_diagram

Purpose of this PR

What's the purpose of this PR? Check the specific option that applies. This is mandatory!

  • New resource provider.
  • New API version for an existing resource provider. (If API spec is not defined in TypeSpec, the PR should have been created in adherence to OpenAPI specs PR creation guidance).
  • Update existing version for a new feature. (This is applicable only when you are revising a private preview API version.)
  • Update existing version to fix OpenAPI spec quality issues in S360.
  • Convert existing OpenAPI spec to TypeSpec spec (do not combine this with implementing changes for a new API version).
  • Other, please clarify:
    • edit this with your clarification

Due diligence checklist

To merge this PR, you must go through the following checklist and confirm you understood
and followed the instructions by checking all the boxes:

  • I confirm this PR is modifying Azure Resource Manager (ARM) related specifications, and not data plane related specifications.
  • I have reviewed following Resource Provider guidelines, including
    ARM resource provider contract and
    REST guidelines (estimated time: 4 hours).
    I understand this is required before I can proceed to the diagram Step 2, "ARM API changes review", for this PR.

Additional information

Viewing API changes

Support Java Components in Microsoft.App version 2025-01-01

Suppressing failures

Add new spec JavaComponents.json to stable/2025-01-01, and some example files

Getting help

  • First, please carefully read through this PR description, from top to bottom. Please fill out the Purpose of this PR and Due diligence checklist.
  • If you don't have permissions to remove or add labels to the PR, request write access per aka.ms/azsdk/access#request-access-to-rest-api-or-sdk-repositories
  • To understand what you must do next to merge this PR, see the Next Steps to Merge comment. It will appear within few minutes of submitting this PR and will continue to be up-to-date with current PR state.
  • For guidance on fixing this PR CI check failures, see the hyperlinks provided in given failure
    and https://aka.ms/ci-fix.
  • For help with ARM review (PR workflow diagram Step 2), see https://aka.ms/azsdk/pr-arm-review.
  • If the PR CI checks appear to be stuck in queued state, please add a comment with contents /azp run.
    This should result in a new comment denoting a PR validation pipeline has started and the checks should be updated after few minutes.
  • If the help provided by the previous points is not enough, post to https://aka.ms/azsdk/support/specreview-channel and link to this PR.

@openapi-pipeline-app
Copy link

openapi-pipeline-app bot commented Jan 2, 2025

Next Steps to Merge

✅ All automated merging requirements have been met! To get your PR merged, see aka.ms/azsdk/specreview/merge.

@openapi-pipeline-app
Copy link

openapi-pipeline-app bot commented Jan 2, 2025

Generated ApiView

Language Package Name ApiView Link
Go sdk/resourcemanager/appcontainers/armappcontainers There is no API change compared with the previous version
JavaScript @azure/arm-appcontainers https://apiview.dev/Assemblies/Review/ba41cd9978b542efb0688a072b2319a1?revisionId=38fd8225f26c478a803668d512e203e3
Java azure-resourcemanager-appcontainers https://apiview.dev/Assemblies/Review/7da9ac1e2db64477ada2ba8bbb71169b?revisionId=769220524c1f42b48080c49a2d70ff96
Python azure-mgmt-appcontainers https://apiview.dev/Assemblies/Review/1693ff33eb9c4a86a7684539954c49cf?revisionId=d8a6e7e107764a2ea42c5478eb3772a7

@raosuhas
Copy link
Member

raosuhas commented Jan 3, 2025

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

},
"dynamicPoolConfiguration": {
"lifecycleConfiguration": {
"type": "OnContainerExit",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shall we use Timed as sample given it is more commonly used, or we create 2 samples, one for Timed and one for OnContainerExit

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, thanks, another sample added and there is one for Timed and one for OnContainerExit now

@openapi-pipeline-app openapi-pipeline-app bot removed the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Jan 8, 2025
@azure-pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@ms-bogdan-rotaru
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@bowen5
Copy link
Contributor

bowen5 commented Jan 23, 2025

@razvanbadea-msft would you review again? thanks.

@rkmanda
Copy link
Member

rkmanda commented Jan 25, 2025

@openapi-pipeline-app openapi-pipeline-app bot removed the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Jan 25, 2025
@yitaopan
Copy link
Member Author

yitaopan commented Jan 26, 2025

Pl add a suppression for this false alarm - https://github.com/Azure/azure-rest-api-specs/pull/31985/checks?check_run_id=35519395044 using this documentation https://github.com/Azure/autorest/blob/main/docs/generate/suppress-warnings.md

Hi @rkmanda , suppression added, could you please take a look again, thanks.

@openapi-pipeline-app openapi-pipeline-app bot added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Jan 26, 2025
@gary-x-li gary-x-li added the ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review label Jan 27, 2025
@openapi-pipeline-app openapi-pipeline-app bot removed the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Jan 27, 2025
@yitaopan yitaopan enabled auto-merge (squash) February 5, 2025 05:19
@yitaopan yitaopan disabled auto-merge February 5, 2025 05:19
@yitaopan yitaopan enabled auto-merge (squash) February 5, 2025 06:13
@yitaopan yitaopan merged commit 59b558a into Azure:release-app-Microsoft.app-2025-01-01 Feb 5, 2025
23 of 24 checks passed
najian added a commit that referenced this pull request Mar 25, 2025
* Copy files from stable/2024-03-01

Copied the files in a separate commit.
This allows reviewers to easily diff subsequent changes against the previous spec.

* Update version to stable/2025-01-01

Updated the API version from stable/2024-03-01 to stable/2025-01-01.

* Added tag for 2025-01-01 in readme file

* Support keda scaler auth using MSI (#31893)

* Support keda scaler auth using MSI

* fix lint

* fix lint

* update

* Add KEDA cooldownPeriod/pollingInterval property for Container App & Jobs (#31891)

* add keda propety

* fix prettier

* fix comment

* Enable BYO NFS Storage in 2025-01-01 (#31850)

* Enable BYO NFS Storage in 2025-01-01

* Fix code style

* Fix

---------

Co-authored-by: Layla Liu <layliu@microsoft.com>

* Add RunningStatus for ContainerApp (#31984)

* Enable Java Runtime in Microsoft.App 2025-01-01 (#31957)

* Enable Java Runtime in 2025-01-01
---------

Co-authored-by: najian <jiangnan8924@gmail.com>

* Support env msi and cert from key vault (#31875)

* Support env msi and cert from key vault

* add spell check ci

* Support Java Components in Microsoft.App version 2025-01-01 (#31958)

* add java components support in version 2025-01-01

* enable lenient model deduplication in go

---------

Co-authored-by: Chenjie Shi <tadelesh.shi@live.cn>

* Update proxy resource type to v5 (#31997)

* update proxy resource type to v5

---------

Co-authored-by: Nan Jiang <naji@microsoft.com>

* remove deduplication config for go sdk (#32111)

* Azure Container Apps SessionPool Api Version 2025-01-01 (#31985)

* SessionPool Api Version 2025-01-01

* Fix example

* DynamicPoolConfiguration.LifecycleConfiguration

* Fix

* Test

* Test

* Test

* test

* Test

* Test

* Test

* Test

* Test

* Test

* Restore

* Test

* Test

* Test

* Restore

* Use TrackedResource for SessionPool patch

* Remove tracked resource and only support tags for patch

* Fix lintdiff

* Update lifecycle type

* Add supress

* fix

* Fix LintDiff failed in Release app microsoft.app 2025 01 01 (#33078)

* Fix LintDiff failed
---------

Co-authored-by: Nan Jiang <naji@microsoft.com>

* Adding managed identity settings (#32009)

* Don't add 201 according to breaking change review comments (#33094)

* Revert "Fix LintDiff failed in Release app microsoft.app 2025 01 01 (#33078)"

This reverts commit 58c987f.

* Fix example

* suppression PutResponseCodes per Breaking change review comments

---------

Co-authored-by: Nan Jiang <naji@microsoft.com>

---------

Co-authored-by: Nan Jiang <naji@microsoft.com>
Co-authored-by: njucz <740360112@qq.com>
Co-authored-by: Zunli Hu <zuh@microsoft.com>
Co-authored-by: LaylaLiu-gmail <38268900+LaylaLiu-gmail@users.noreply.github.com>
Co-authored-by: Layla Liu <layliu@microsoft.com>
Co-authored-by: zhenqxuMSFT <zhenqxu@microsoft.com>
Co-authored-by: Songbo Wang <sonwan@microsoft.com>
Co-authored-by: Chenjie Shi <tadelesh.shi@live.cn>
Co-authored-by: Yitao Pan <yitaopan@microsoft.com>
Co-authored-by: Mike Harder <mharder@microsoft.com>
Co-authored-by: Vaclav Turecek <vturecek@microsoft.com>
pjpatel12 pushed a commit to pjpatel12/azure-rest-api-specs that referenced this pull request Apr 29, 2025
* Copy files from stable/2024-03-01

Copied the files in a separate commit.
This allows reviewers to easily diff subsequent changes against the previous spec.

* Update version to stable/2025-01-01

Updated the API version from stable/2024-03-01 to stable/2025-01-01.

* Added tag for 2025-01-01 in readme file

* Support keda scaler auth using MSI (Azure#31893)

* Support keda scaler auth using MSI

* fix lint

* fix lint

* update

* Add KEDA cooldownPeriod/pollingInterval property for Container App & Jobs (Azure#31891)

* add keda propety

* fix prettier

* fix comment

* Enable BYO NFS Storage in 2025-01-01 (Azure#31850)

* Enable BYO NFS Storage in 2025-01-01

* Fix code style

* Fix

---------

Co-authored-by: Layla Liu <layliu@microsoft.com>

* Add RunningStatus for ContainerApp (Azure#31984)

* Enable Java Runtime in Microsoft.App 2025-01-01 (Azure#31957)

* Enable Java Runtime in 2025-01-01
---------

Co-authored-by: najian <jiangnan8924@gmail.com>

* Support env msi and cert from key vault (Azure#31875)

* Support env msi and cert from key vault

* add spell check ci

* Support Java Components in Microsoft.App version 2025-01-01 (Azure#31958)

* add java components support in version 2025-01-01

* enable lenient model deduplication in go

---------

Co-authored-by: Chenjie Shi <tadelesh.shi@live.cn>

* Update proxy resource type to v5 (Azure#31997)

* update proxy resource type to v5

---------

Co-authored-by: Nan Jiang <naji@microsoft.com>

* remove deduplication config for go sdk (Azure#32111)

* Azure Container Apps SessionPool Api Version 2025-01-01 (Azure#31985)

* SessionPool Api Version 2025-01-01

* Fix example

* DynamicPoolConfiguration.LifecycleConfiguration

* Fix

* Test

* Test

* Test

* test

* Test

* Test

* Test

* Test

* Test

* Test

* Restore

* Test

* Test

* Test

* Restore

* Use TrackedResource for SessionPool patch

* Remove tracked resource and only support tags for patch

* Fix lintdiff

* Update lifecycle type

* Add supress

* fix

* Fix LintDiff failed in Release app microsoft.app 2025 01 01 (Azure#33078)

* Fix LintDiff failed
---------

Co-authored-by: Nan Jiang <naji@microsoft.com>

* Adding managed identity settings (Azure#32009)

* Don't add 201 according to breaking change review comments (Azure#33094)

* Revert "Fix LintDiff failed in Release app microsoft.app 2025 01 01 (Azure#33078)"

This reverts commit 58c987f.

* Fix example

* suppression PutResponseCodes per Breaking change review comments

---------

Co-authored-by: Nan Jiang <naji@microsoft.com>

---------

Co-authored-by: Nan Jiang <naji@microsoft.com>
Co-authored-by: njucz <740360112@qq.com>
Co-authored-by: Zunli Hu <zuh@microsoft.com>
Co-authored-by: LaylaLiu-gmail <38268900+LaylaLiu-gmail@users.noreply.github.com>
Co-authored-by: Layla Liu <layliu@microsoft.com>
Co-authored-by: zhenqxuMSFT <zhenqxu@microsoft.com>
Co-authored-by: Songbo Wang <sonwan@microsoft.com>
Co-authored-by: Chenjie Shi <tadelesh.shi@live.cn>
Co-authored-by: Yitao Pan <yitaopan@microsoft.com>
Co-authored-by: Mike Harder <mharder@microsoft.com>
Co-authored-by: Vaclav Turecek <vturecek@microsoft.com>
nwnt pushed a commit to nwnt/azure-rest-api-specs that referenced this pull request Jun 10, 2025
* Copy files from stable/2024-03-01

Copied the files in a separate commit.
This allows reviewers to easily diff subsequent changes against the previous spec.

* Update version to stable/2025-01-01

Updated the API version from stable/2024-03-01 to stable/2025-01-01.

* Added tag for 2025-01-01 in readme file

* Support keda scaler auth using MSI (Azure#31893)

* Support keda scaler auth using MSI

* fix lint

* fix lint

* update

* Add KEDA cooldownPeriod/pollingInterval property for Container App & Jobs (Azure#31891)

* add keda propety

* fix prettier

* fix comment

* Enable BYO NFS Storage in 2025-01-01 (Azure#31850)

* Enable BYO NFS Storage in 2025-01-01

* Fix code style

* Fix

---------

Co-authored-by: Layla Liu <layliu@microsoft.com>

* Add RunningStatus for ContainerApp (Azure#31984)

* Enable Java Runtime in Microsoft.App 2025-01-01 (Azure#31957)

* Enable Java Runtime in 2025-01-01
---------

Co-authored-by: najian <jiangnan8924@gmail.com>

* Support env msi and cert from key vault (Azure#31875)

* Support env msi and cert from key vault

* add spell check ci

* Support Java Components in Microsoft.App version 2025-01-01 (Azure#31958)

* add java components support in version 2025-01-01

* enable lenient model deduplication in go

---------

Co-authored-by: Chenjie Shi <tadelesh.shi@live.cn>

* Update proxy resource type to v5 (Azure#31997)

* update proxy resource type to v5

---------

Co-authored-by: Nan Jiang <naji@microsoft.com>

* remove deduplication config for go sdk (Azure#32111)

* Azure Container Apps SessionPool Api Version 2025-01-01 (Azure#31985)

* SessionPool Api Version 2025-01-01

* Fix example

* DynamicPoolConfiguration.LifecycleConfiguration

* Fix

* Test

* Test

* Test

* test

* Test

* Test

* Test

* Test

* Test

* Test

* Restore

* Test

* Test

* Test

* Restore

* Use TrackedResource for SessionPool patch

* Remove tracked resource and only support tags for patch

* Fix lintdiff

* Update lifecycle type

* Add supress

* fix

* Fix LintDiff failed in Release app microsoft.app 2025 01 01 (Azure#33078)

* Fix LintDiff failed
---------

Co-authored-by: Nan Jiang <naji@microsoft.com>

* Adding managed identity settings (Azure#32009)

* Don't add 201 according to breaking change review comments (Azure#33094)

* Revert "Fix LintDiff failed in Release app microsoft.app 2025 01 01 (Azure#33078)"

This reverts commit 58c987f.

* Fix example

* suppression PutResponseCodes per Breaking change review comments

---------

Co-authored-by: Nan Jiang <naji@microsoft.com>

---------

Co-authored-by: Nan Jiang <naji@microsoft.com>
Co-authored-by: njucz <740360112@qq.com>
Co-authored-by: Zunli Hu <zuh@microsoft.com>
Co-authored-by: LaylaLiu-gmail <38268900+LaylaLiu-gmail@users.noreply.github.com>
Co-authored-by: Layla Liu <layliu@microsoft.com>
Co-authored-by: zhenqxuMSFT <zhenqxu@microsoft.com>
Co-authored-by: Songbo Wang <sonwan@microsoft.com>
Co-authored-by: Chenjie Shi <tadelesh.shi@live.cn>
Co-authored-by: Yitao Pan <yitaopan@microsoft.com>
Co-authored-by: Mike Harder <mharder@microsoft.com>
Co-authored-by: Vaclav Turecek <vturecek@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Approved-Suppression ARMReview ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review resource-manager SuppressionReviewRequired

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants