Skip to content

Watchlists 2024-09-01#31040

Merged
xuhumsft merged 5 commits intoAzure:dev-Sentinel-securityinsights-Microsoft.SecurityInsights-2024-09-01from
nbatyrbb:dev-Sentinel-securityinsights-Microsoft.SecurityInsights-2024-09-01
Oct 23, 2024
Merged

Watchlists 2024-09-01#31040
xuhumsft merged 5 commits intoAzure:dev-Sentinel-securityinsights-Microsoft.SecurityInsights-2024-09-01from
nbatyrbb:dev-Sentinel-securityinsights-Microsoft.SecurityInsights-2024-09-01

Conversation

@nbatyrbb
Copy link
Contributor

@nbatyrbb nbatyrbb commented Oct 15, 2024 •
edited
Loading

ARM (Control Plane) API Specification Update Pull Request

Tip

Overwhelmed by all this guidance? See the Getting help section at the bottom of this PR description.

PR review workflow diagram

Please understand this diagram before proceeding. It explains how to get your PR approved & merged.

spec_pr_review_workflow_diagram

Purpose of this PR

What's the purpose of this PR? Check the specific option that applies. This is mandatory!

  • New resource provider.
  • New API version for an existing resource provider. (If API spec is not defined in TypeSpec, the PR should have been created in adherence to OpenAPI specs PR creation guidance).
  • Update existing version for a new feature. (This is applicable only when you are revising a private preview API version.)
  • Update existing version to fix OpenAPI spec quality issues in S360.
  • Convert existing OpenAPI spec to TypeSpec spec (do not combine this with implementing changes for a new API version).
  • Other, please clarify:
    • edit this with your clarification

Due diligence checklist

To merge this PR, you must go through the following checklist and confirm you understood
and followed the instructions by checking all the boxes:

  • I confirm this PR is modifying Azure Resource Manager (ARM) related specifications, and not data plane related specifications.
  • I have reviewed following Resource Provider guidelines, including
    ARM resource provider contract and
    REST guidelines (estimated time: 4 hours).
    I understand this is required before I can proceed to the diagram Step 2, "ARM API changes review", for this PR.

Additional information

Viewing API changes

For convenient view of the API changes made by this PR, refer to the URLs provided in the table
in the Generated ApiView comment added to this PR. You can use ApiView to show API versions diff.

Suppressing failures

If one or multiple validation error/warning suppression(s) is detected in your PR, please follow the
suppressions guide to get approval.

Getting help

  • First, please carefully read through this PR description, from top to bottom. Please fill out the Purpose of this PR and Due diligence checklist.
  • If you don't have permissions to remove or add labels to the PR, request write access per aka.ms/azsdk/access#request-access-to-rest-api-or-sdk-repositories
  • To understand what you must do next to merge this PR, see the Next Steps to Merge comment. It will appear within few minutes of submitting this PR and will continue to be up-to-date with current PR state.
  • For guidance on fixing this PR CI check failures, see the hyperlinks provided in given failure
    and https://aka.ms/ci-fix.
  • For help with ARM review (PR workflow diagram Step 2), see https://aka.ms/azsdk/pr-arm-review.
  • If the PR CI checks appear to be stuck in queued state, please add a comment with contents /azp run.
    This should result in a new comment denoting a PR validation pipeline has started and the checks should be updated after few minutes.
  • If the help provided by the previous points is not enough, post to https://aka.ms/azsdk/support/specreview-channel and link to this PR.

@openapi-pipeline-app
Copy link

openapi-pipeline-app bot commented Oct 15, 2024 •
edited
Loading

Next Steps to Merge

Next steps that must be taken to merge this PR:
  • ❌ Your PR has breaking changes in the generated SDK for Go (label: BreakingChange-Go-Sdk). Refer to step 3 in the PR workflow diagram.
  • ❌ Your PR has breaking changes in the generated SDK for Python (label: BreakingChange-Python-Sdk). Refer to step 3 in the PR workflow diagram.

@openapi-pipeline-app
Copy link

openapi-pipeline-app bot commented Oct 15, 2024 •
edited
Loading

Generated ApiView

Language Package Name ApiView Link
Go sdk/resourcemanager/securityinsights/armsecurityinsights https://apiview.dev/Assemblies/Review/06b0c4a98e094807b7c161c14692f77d?revisionId=bf85e0db3cb84ba6a5001d58d47f6222
JavaScript @azure/arm-securityinsight https://apiview.dev/Assemblies/Review/495feca01b564258a5b2e6d5ed3ad0e2?revisionId=624b0a9c064c4359827c38d896612375
Swagger Microsoft.SecurityInsights https://apiview.dev/Assemblies/Review/d30cc3bd7c484ad880bc3b8126f67ba5?revisionId=ff6218eb477b4a6b9e75f15e771327bc

@azure-sdk azure-sdk mentioned this pull request Oct 15, 2024
Closed
This was referenced Oct 15, 2024
Closed
Closed
Closed
@azure-sdk azure-sdk mentioned this pull request Oct 15, 2024
Closed
@xuhumsft xuhumsft added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Oct 21, 2024
@xuhumsft
Copy link
Member

xuhumsft commented Oct 21, 2024

For the Breaking Change(Cross-Version), we were told it won't be reviewed until the PR to main. So, we cannot start the breaking change review process until then. However, the same or similar change in previous preview release.

@openapi-pipeline-app openapi-pipeline-app bot removed the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Oct 22, 2024
@xuhumsft xuhumsft added WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required and removed ARMChangesRequested labels Oct 23, 2024
@openapi-pipeline-app openapi-pipeline-app bot removed the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Oct 23, 2024
@xuhumsft xuhumsft added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Oct 23, 2024
@ramoka178 ramoka178 added the ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review label Oct 23, 2024
@openapi-pipeline-app openapi-pipeline-app bot removed the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Oct 23, 2024
@xuhumsft xuhumsft merged commit ff48f20 into Azure:dev-Sentinel-securityinsights-Microsoft.SecurityInsights-2024-09-01 Oct 23, 2024
@xuhumsft xuhumsft mentioned this pull request Oct 23, 2024
Merged
8 tasks
xuhumsft added a commit that referenced this pull request Nov 20, 2024
@xuhumsft @nbatyrbb
@sagamzu @msyyc @tadelesh @ni-bhandari
Dev sentinel securityinsights microsoft.security insights 2024 09 01 (#…
52543df 
…30800)

* Copy files from stable/2024-03-01

Copied the files in a separate commit.
This allows reviewers to easily diff subsequent changes against the previous spec.

* Update version to stable/2024-09-01

Updated the API version from stable/2024-03-01 to stable/2024-09-01.

* Added tag for 2024-09-01 in readme file

* fix validation error

* fix lint diff error - rleationTypes

* suppress addtional properties in alertRules

* update the common type version to resolve go-sdk error

* fix prettier error

* fix the model validation error

* fix the prettier error

* Watchlists 2024-09-01 (#31040)

* Watchlists 2024-09-01

* Fix errors

* prettier run

* address pr feedback

* address pr feedback

* Add stable version for Connectordefinitions API (#30812)

* add stable version for definition API

* update readme file

* update readme file

* update cSpell

* Create sdk-suppressions.yaml

---------

Co-authored-by: Yuchao Yan <yuchaoyan@microsoft.com>

* Add new kind (RestApiPoller) to DataConnectors STABLE  API (#30813)

* add restApiPoller kind to dataConnectors

* exe prettier

* fix prettier check (#31449)

* Update readme.python.md

* Update sdk-suppressions.yaml

* Fix some typos in DataConnectors and DataConnectorDefinitions APIs (#31581)

* Update sdk-suppressions.yaml

* DataConnectors - MDTI and PMDTI connectors 2024-09-01 (#31491)

* fix prettier check

* mdti stable swagger

* pmdti stable swagger

* fix example name

* fix pmdti swagger

* add pmdti examples

* fix spellcheck

* fix enums

* prettier fix

* update lookback

* lookback period for pmdti

* fix date-time format in examples

* minor format fix

---------

Co-authored-by: xuhumsft <116764429+xuhumsft@users.noreply.github.com>

---------

Co-authored-by: nbatyrbb <115049492+nbatyrbb@users.noreply.github.com>
Co-authored-by: sagamzu <52034287+sagamzu@users.noreply.github.com>
Co-authored-by: Yuchao Yan <yuchaoyan@microsoft.com>
Co-authored-by: Chenjie Shi <tadelesh.shi@live.cn>
Co-authored-by: ni-bhandari <120053375+ni-bhandari@users.noreply.github.com>
@nbatyrbb nbatyrbb deleted the dev-Sentinel-securityinsights-Microsoft.SecurityInsights-2024-09-01 branch January 8, 2025 21:54
pjpatel12 pushed a commit to pjpatel12/azure-rest-api-specs that referenced this pull request Apr 29, 2025
@xuhumsft @nbatyrbb
@sagamzu @msyyc @tadelesh @ni-bhandari @pjpatel12
Dev sentinel securityinsights microsoft.security insights 2024 09 01 (A…
83ecbd0 
…zure#30800)

* Copy files from stable/2024-03-01

Copied the files in a separate commit.
This allows reviewers to easily diff subsequent changes against the previous spec.

* Update version to stable/2024-09-01

Updated the API version from stable/2024-03-01 to stable/2024-09-01.

* Added tag for 2024-09-01 in readme file

* fix validation error

* fix lint diff error - rleationTypes

* suppress addtional properties in alertRules

* update the common type version to resolve go-sdk error

* fix prettier error

* fix the model validation error

* fix the prettier error

* Watchlists 2024-09-01 (Azure#31040)

* Watchlists 2024-09-01

* Fix errors

* prettier run

* address pr feedback

* address pr feedback

* Add stable version for Connectordefinitions API (Azure#30812)

* add stable version for definition API

* update readme file

* update readme file

* update cSpell

* Create sdk-suppressions.yaml

---------

Co-authored-by: Yuchao Yan <yuchaoyan@microsoft.com>

* Add new kind (RestApiPoller) to DataConnectors STABLE  API (Azure#30813)

* add restApiPoller kind to dataConnectors

* exe prettier

* fix prettier check (Azure#31449)

* Update readme.python.md

* Update sdk-suppressions.yaml

* Fix some typos in DataConnectors and DataConnectorDefinitions APIs (Azure#31581)

* Update sdk-suppressions.yaml

* DataConnectors - MDTI and PMDTI connectors 2024-09-01 (Azure#31491)

* fix prettier check

* mdti stable swagger

* pmdti stable swagger

* fix example name

* fix pmdti swagger

* add pmdti examples

* fix spellcheck

* fix enums

* prettier fix

* update lookback

* lookback period for pmdti

* fix date-time format in examples

* minor format fix

---------

Co-authored-by: xuhumsft <116764429+xuhumsft@users.noreply.github.com>

---------

Co-authored-by: nbatyrbb <115049492+nbatyrbb@users.noreply.github.com>
Co-authored-by: sagamzu <52034287+sagamzu@users.noreply.github.com>
Co-authored-by: Yuchao Yan <yuchaoyan@microsoft.com>
Co-authored-by: Chenjie Shi <tadelesh.shi@live.cn>
Co-authored-by: ni-bhandari <120053375+ni-bhandari@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ramoka178 ramoka178 ramoka178 left review comments

Assignees

No one assigned

Labels

ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review BreakingChange-Go-Sdk BreakingChange-Python-Sdk resource-manager

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@nbatyrbb @xuhumsft @ramoka178 @azure-sdk @AzureRestAPISpecReview