Skip to content

Event Hubs: reverted removal of Messaging plan from namespace #2831

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
v-Ajnava wants to merge 1 commit into from
Closed

Event Hubs: reverted removal of Messaging plan from namespace #2831

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
72 changes: 72 additions & 0 deletions specification/eventhub/resource-manager/Microsoft.EventHub/stable/2017-04-01/EventHub.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -391,6 +391,37 @@
}
}
}
},
"/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.EventHub/namespaces/{namespaceName}/messagingplan": {
"get": {
Copy link
Copy Markdown
Contributor

@hovsepm hovsepm Apr 6, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do not see a network payload example - please add "x-ms-examples" for this operation

"tags": [
"MessagingPlan"
],
"operationId": "Namespaces_MessagingPlanGet",
Copy link
Copy Markdown
Contributor

@hovsepm hovsepm Apr 6, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Namespaces_MessagingPlanGet [](start = 24, length = 27)

change the name to - Namespaces_GetMessagingPlan

"description": "Gets a description for the specified namespace.",
Copy link
Copy Markdown
Contributor

@hovsepm hovsepm Apr 6, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gets a description for the specified namespace. [](start = 24, length = 47)

Please fix the description. Seems to be copied from somewhere else.

"parameters": [
{
"$ref": "#/parameters/resourceGroupNameParameter"
},
{
"$ref": "#/parameters/namespaceNameParameter"
},
{
"$ref": "#/parameters/ApiVersionParameter"
},
{
"$ref": "#/parameters/SubscriptionIdParameter"
}
],
"responses": {
"200": {
Copy link
Copy Markdown
Contributor

@hovsepm hovsepm Apr 6, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 

     "200": [](start = 0, length = 16)

you need to specify default error response schema as well.

"description": "Messaging Plan successfully returned.",
"schema": {
"$ref": "#/definitions/MessagingPlan"
}
}
}
}
},
"/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.EventHub/namespaces/{namespaceName}/AuthorizationRules": {
"get": {
Expand Down Expand Up @@ -2503,6 +2534,47 @@
}
},
"description": "The response of the List MessagingRegions operation."
},
"MessagingPlanproperties": {
Copy link
Copy Markdown
Contributor

@hovsepm hovsepm Apr 6, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

MessagingPlanproperties [](start = 2, length = 23)

Properties should start with capital P

Copy link
Copy Markdown
Contributor

@hovsepm hovsepm Apr 6, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

MessagingPlanproperties [](start = 2, length = 23)

this entire type is only used as service return type. Please mark each property as "readOnly": true

"properties": {
"sku": {
"format": "int32",
"type": "integer",
"description": "Sku type"
},
"selectedEventHubUnit": {
"format": "int32",
"type": "integer",
"description": "Selected event hub unit"
},
"updatedAt": {
"type": "string",
"format": "date-time",
"readOnly": true,
"description": "The exact time the messaging plan was updated."
},
"revision": {
"format": "int64",
"type": "integer",
"description": "revision number"
}
},
"description": "Messaging Region"
Copy link
Copy Markdown
Contributor

@hovsepm hovsepm Apr 6, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Messaging Region [](start = 22, length = 16)

Please add better description of the model. I'm not clear how this model even relates to regions. The only exposed operation in the swagger is "Get" on Messaging plan which suggests that there should be only one Messaging plan per namespace. Did you miss "List" operation?

},
"MessagingPlan": {
"type": "object",
"properties": {
"properties": {
"x-ms-client-flatten": true,
"$ref": "#/definitions/MessagingPlanproperties"
}
},
"allOf": [
{
"$ref": "#/definitions/TrackedResource"
}
],
"description": "Messaging"
}
},
"parameters": {
Expand Down