Event Hubs: reverted removal of Messaging plan from namespace#2831
Event Hubs: reverted removal of Messaging plan from namespace#2831v-Ajnava wants to merge 1 commit intoAzure:masterfrom
Conversation
Automation for azure-sdk-for-pythonA PR has been created for you based on this PR content. Once this PR will be merged, content will be added to your service PR: |
Automation for azure-sdk-for-nodeA PR has been created for you based on this PR content. Once this PR will be merged, content will be added to your service PR: |
Automation for azure-libraries-for-javaA PR has been created for you based on this PR content. Once this PR will be merged, content will be added to your service PR: |
Automation for azure-sdk-for-goA PR has been created for you based on this PR content. Once this PR will be merged, content will be added to your service PR: |
| "MessagingPlan" | ||
| ], | ||
| "operationId": "Namespaces_MessagingPlanGet", | ||
| "description": "Gets a description for the specified namespace.", |
There was a problem hiding this comment.
Gets a description for the specified namespace. [](start = 24, length = 47)
Please fix the description. Seems to be copied from somewhere else.
| "tags": [ | ||
| "MessagingPlan" | ||
| ], | ||
| "operationId": "Namespaces_MessagingPlanGet", |
There was a problem hiding this comment.
Namespaces_MessagingPlanGet [](start = 24, length = 27)
change the name to - Namespaces_GetMessagingPlan
| }, | ||
| "description": "The response of the List MessagingRegions operation." | ||
| }, | ||
| "MessagingPlanproperties": { |
There was a problem hiding this comment.
MessagingPlanproperties [](start = 2, length = 23)
Properties should start with capital P
| }, | ||
| "description": "The response of the List MessagingRegions operation." | ||
| }, | ||
| "MessagingPlanproperties": { |
There was a problem hiding this comment.
MessagingPlanproperties [](start = 2, length = 23)
this entire type is only used as service return type. Please mark each property as "readOnly": true
| "description": "revision number" | ||
| } | ||
| }, | ||
| "description": "Messaging Region" |
There was a problem hiding this comment.
Messaging Region [](start = 22, length = 16)
Please add better description of the model. I'm not clear how this model even relates to regions. The only exposed operation in the swagger is "Get" on Messaging plan which suggests that there should be only one Messaging plan per namespace. Did you miss "List" operation?
| } | ||
| }, | ||
| "/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.EventHub/namespaces/{namespaceName}/messagingplan": { | ||
| "get": { |
There was a problem hiding this comment.
I do not see a network payload example - please add "x-ms-examples" for this operation
| } | ||
| ], | ||
| "responses": { | ||
| "200": { |
There was a problem hiding this comment.
"200": [](start = 0, length = 16)
you need to specify default error response schema as well.
hovsepm
added
the
WaitForARMFeedback
|
@ravbhatnagar Could you check if this operation was approved by ARM? |
|
@v-Ajnava also "Regions_ListBySku" opertaion does not have a payload sample. Could you add it in your PR? Because of it we have Linter rule failures. |
|
Hi There, I am the AutoRest Linter Azure bot. I am here to help. My task is to analyze the situation from the AutoRest linter perspective. Please review the below analysis result: 💡 Please review potentially introduced Error(s)/Warning(s): Analysis Report 💡 File: AutoRest Linter Guidelines | AutoRest Linter Issues | Send feedback Thanks for your co-operation. |
4 participants
This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.
PR information
api-versionin the path should match theapi-versionin the spec).Quality of Swagger