Skip to content

[ContainerApp] Support peer traffic encryption. #28159

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
LGDoor merged 1 commit into from
Mar 13, 2024
Merged

[ContainerApp] Support peer traffic encryption. #28159

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 16 additions & 0 deletions specification/app/resource-manager/Microsoft.App/stable/2024-03-01/ManagedEnvironments.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1259,6 +1259,22 @@
"$ref": "#/definitions/Mtls"
}
}
},
"peerTrafficConfiguration": {
"description": "Peer traffic settings for the Managed Environment",
"type": "object",
"properties": {
"encryption": {
"description": "Peer traffic encryption settings for the Managed Environment",
"type": "object",
"properties": {
"enabled": {
"type": "boolean",
Copy link
Copy Markdown
Member

@raosuhas raosuhas Mar 12, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

boolean

Consider making this an Enum. Also please check the other Lint Diff warnings for this PR here :

https://github.com/Azure/azure-rest-api-specs/pull/28159/checks?check_run_id=22421639508

Copy link
Copy Markdown
Contributor Author

@LGDoor LGDoor Mar 13, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your feedback. It's intended to keep consistent with the existing peerAuthentication.mtls.enabled which is also boolean. For the rest "AvoidNestedProperties" warnings, it isn't applicable here.

"description": "Boolean indicating whether the peer traffic encryption is enabled"
}
}
}
}
}
},
"x-ms-client-flatten": true
Expand Down
5 changes: 5 additions & 0 deletions ...-manager/Microsoft.App/stable/2024-03-01/examples/ManagedEnvironments_CreateOrUpdate.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,6 +51,11 @@
"mtls": {
"enabled": true
}
},
"peerTrafficConfiguration": {
"encryption": {
"enabled": true
}
}
}
}
Expand Down
5 changes: 5 additions & 0 deletions ...pp/resource-manager/Microsoft.App/stable/2024-03-01/examples/ManagedEnvironments_Get.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,6 +65,11 @@
"mtls": {
"enabled": true
}
},
"peerTrafficConfiguration": {
"encryption": {
"enabled": true
}
}
}
}
Expand Down