[ContainerApp] Support peer traffic encryption. by LGDoor · Pull Request #28159 · Azure/azure-rest-api-specs

LGDoor · 2024-03-08T03:27:28Z

ARM (Control Plane) API Specification Update Pull Request

Tip

Overwhelmed by all this guidance? See the Getting help section at the bottom of this PR description.

Note

As of January 2024 there is no PR assignee. This is expected. See https://aka.ms/azsdk/pr-arm-review.

PR review workflow diagram

Please understand this diagram before proceeding. It explains how to get your PR approved & merged.

Click here to see the details of Step 1, Breaking Changes review

If you are in purview of Step 1 of the diagram, follow the Breaking Changes review process.
IMPORTANT! This applies even if you believe your PR was mislabeled, for any reason, including tool failure.

Click here to see the details of Step 2, ARM review

See https://aka.ms/azsdk/pr-arm-review.

Click here to see the diagram footnotes

Diagram footnotes

[1] See ARM review queue (for PR merge queues, see [2]).
[2] public repo merge queue, private repo merge queue (for ARM review queue, [1])
The ARM reviewer on-call engineer visits the merge queue twice a day, so the approximate ETA for merges is 12 - 24 hours.

Purpose of this PR

What's the purpose of this PR? Check the specific option that applies. This is mandatory!

New resource provider.
New API version for an existing resource provider. (If API spec is not defined in TypeSpec, the PR should have been generated using OpenAPI Hub).
Update existing version for a new feature. (This is applicable only when you are revising a private preview API version.)
Update existing version to fix OpenAPI spec quality issues in S360.
Other, please clarify:
- edit this with your clarification

Due diligence checklist

To merge this PR, you must go through the following checklist and confirm you understood
and followed the instructions by checking all the boxes:

I confirm this PR is modifying Azure Resource Manager (ARM) related specifications, and not data plane related specifications.
I have reviewed following Resource Provider guidelines, including
ARM resource provider contract and
REST guidelines (estimated time: 4 hours).
I understand this is required before I can proceed to the diagram Step 2, "ARM API changes review", for this PR.

Additional information

Viewing API changes

For convenient view of the API changes made by this PR, refer to the URLs provided in the table
in the Generated ApiView comment added to this PR. You can use ApiView to show API versions diff.

Suppressing failures

If one or multiple validation error/warning suppression(s) is detected in your PR, please follow the
suppressions guide to get approval.

Getting help

First, please carefully read through this PR description, from top to bottom. Please fill out the Purpose of this PR and Due diligence checklist.
To understand what you must do next to merge this PR, see the Next Steps to Merge comment. It will appear within few minutes of submitting this PR and will continue to be up-to-date with current PR state.
For guidance on fixing this PR CI check failures, see the hyperlinks provided in given failure
and https://aka.ms/ci-fix.
For help with PR workflow diagram Step 2 (ARM review), see https://aka.ms/azsdk/pr-arm-review.
If the PR CI checks appear to be stuck in queued state, please add a comment with contents /azp run.
This should result in a new comment denoting a PR validation pipeline has started and the checks should be updated after few minutes.
If the help provided by the previous points is not enough, post to https://aka.ms/azsdk/support/specreview-channel and link to this PR.

openapi-pipeline-app · 2024-03-08T03:27:31Z

Next Steps to Merge

Next steps that must be taken to merge this PR:

❌ Your PR is in purview of ARM review (label: ARMReview). Please ensure your PR is on the ARM PR review queue - see instructions in steps 1 and 2 in the PR description diagram.

openapi-pipeline-app · 2024-03-08T03:27:32Z

Swagger Validation Report

️️✔️BreakingChange succeeded [Detail] [Expand]

There are no breaking changes.

️⚠️Breaking Change(Cross-Version): 10 Warnings warning [Detail]

compared swaggers (via Oad v0.10.5)]	new version	base version
ManagedEnvironments.json	2024-03-01(28e2077)	2023-05-01(main)
ManagedEnvironments.json	2024-03-01(28e2077)	2023-11-02-preview(main)

The following breaking changes are detected by comparison with the latest preview version:

Rule	Message
⚠️ 1006 - RemovedDefinition	The new version is missing a definition that was found in the old version. Was 'UserAssignedIdentities' removed or renamed? New: Microsoft.App/stable/2024-03-01/ManagedEnvironments.json#L1046:3 Old: Microsoft.App/preview/2023-11-02-preview/ManagedEnvironments.json#L1049:3
⚠️ 1006 - RemovedDefinition	The new version is missing a definition that was found in the old version. Was 'ManagedServiceIdentityType' removed or renamed? New: Microsoft.App/stable/2024-03-01/ManagedEnvironments.json#L1046:3 Old: Microsoft.App/preview/2023-11-02-preview/ManagedEnvironments.json#L1049:3
⚠️ 1006 - RemovedDefinition	The new version is missing a definition that was found in the old version. Was 'ManagedServiceIdentity' removed or renamed? New: Microsoft.App/stable/2024-03-01/ManagedEnvironments.json#L1046:3 Old: Microsoft.App/preview/2023-11-02-preview/ManagedEnvironments.json#L1049:3
⚠️ 1033 - RemovedProperty	The new version is missing a property found in the old version. Was 'identity' renamed or removed? New: Microsoft.App/stable/2024-03-01/ManagedEnvironments.json#L1147:7 Old: Microsoft.App/preview/2023-11-02-preview/ManagedEnvironments.json#L1299:7
⚠️ 1033 - RemovedProperty	The new version is missing a property found in the old version. Was 'dynamicJsonColumns' renamed or removed? New: Microsoft.App/stable/2024-03-01/ManagedEnvironments.json#L1308:7 Old: Microsoft.App/preview/2023-11-02-preview/ManagedEnvironments.json#L1456:7
⚠️ 1033 - RemovedProperty	The new version is missing a property found in the old version. Was 'appInsightsConfiguration' renamed or removed? New: Microsoft.App/stable/2024-03-01/ManagedEnvironments.json#L1155:11 Old: Microsoft.App/preview/2023-11-02-preview/ManagedEnvironments.json#L1311:11
⚠️ 1033 - RemovedProperty	The new version is missing a property found in the old version. Was 'openTelemetryConfiguration' renamed or removed? New: Microsoft.App/stable/2024-03-01/ManagedEnvironments.json#L1155:11 Old: Microsoft.App/preview/2023-11-02-preview/ManagedEnvironments.json#L1311:11
⚠️ 1033 - RemovedProperty	The new version is missing a property found in the old version. Was 'certificateKeyVaultProperties' renamed or removed? New: Microsoft.App/stable/2024-03-01/CommonDefinitions.json#L303:7 Old: Microsoft.App/preview/2023-11-02-preview/CommonDefinitions.json#L303:7
⚠️ 1033 - RemovedProperty	The new version is missing a property found in the old version. Was 'certificateKeyVaultProperties' renamed or removed? New: Microsoft.App/stable/2024-03-01/CommonDefinitions.json#L914:11 Old: Microsoft.App/preview/2023-11-02-preview/CommonDefinitions.json#L1262:11
⚠️ 1033 - RemovedProperty	The new version is missing a property found in the old version. Was 'certificateType' renamed or removed? New: Microsoft.App/stable/2024-03-01/CommonDefinitions.json#L914:11 Old: Microsoft.App/preview/2023-11-02-preview/CommonDefinitions.json#L1262:11

️⚠️LintDiff: 3 Warnings warning [Detail]

compared tags (via openapi-validator v2.2.0)	new version	base version
package-2024-03	package-2024-03(28e2077)	package-2024-03(release-app-Microsoft.App-2024-03-01)

[must fix]The following errors/warnings are introduced by current PR:

Rule	Message	Related RPC [For API reviewers]
⚠️ AvoidNestedProperties	Consider using x-ms-client-flatten to provide a better end user experience Location: Microsoft.App/stable/2024-03-01/ManagedEnvironments.json#L1263
⚠️ AvoidNestedProperties	Consider using x-ms-client-flatten to provide a better end user experience Location: Microsoft.App/stable/2024-03-01/ManagedEnvironments.json#L1267
⚠️ EnumInsteadOfBoolean	Booleans properties are not descriptive in all cases and can make them to use, evaluate whether is makes sense to keep the property as boolean or turn it into an enum. Location: Microsoft.App/stable/2024-03-01/ManagedEnvironments.json#L1271

The following errors/warnings exist before current PR submission:

Only 30 items are listed, please refer to log for more details.

Rule	Message
`❌` ResourceNameRestriction	The resource name parameter 'environmentName' should be defined with a 'pattern' restriction. Location: Microsoft.App/stable/2024-03-01/ManagedEnvironments.json#L101
`❌` LroErrorContent	Error response content of long running operations must follow the error schema provided in the common types v2 and above. Location: Microsoft.App/stable/2024-03-01/ManagedEnvironments.json#L197
`❌` DeleteResponseCodes	Long-running delete operations must have responses with 202, 204 and default return codes. They also must have no other response codes. Location: Microsoft.App/stable/2024-03-01/ManagedEnvironments.json#L211
`❌` LroLocationHeader	A 202 response should include an Location response header. Location: Microsoft.App/stable/2024-03-01/ManagedEnvironments.json#L240
`❌` LroErrorContent	Error response content of long running operations must follow the error schema provided in the common types v2 and above. Location: Microsoft.App/stable/2024-03-01/ManagedEnvironments.json#L249
`❌` PatchBodyParametersSchema	Properties of a PATCH request body must not be required, property:location. Location: Microsoft.App/stable/2024-03-01/ManagedEnvironments.json#L286
`❌` LroLocationHeader	A 202 response should include an Location response header. Location: Microsoft.App/stable/2024-03-01/ManagedEnvironments.json#L301
`❌` LroErrorContent	Error response content of long running operations must follow the error schema provided in the common types v2 and above. Location: Microsoft.App/stable/2024-03-01/ManagedEnvironments.json#L307
`❌` ResourceNameRestriction	The resource name parameter 'environmentName' should be defined with a 'pattern' restriction. Location: Microsoft.App/stable/2024-03-01/ManagedEnvironments.json#L319
`❌` ResourceNameRestriction	The resource name parameter 'environmentName' should be defined with a 'pattern' restriction. Location: Microsoft.App/stable/2024-03-01/ManagedEnvironments.json#L369
`❌` ResourceNameRestriction	The resource name parameter 'certificateName' should be defined with a 'pattern' restriction. Location: Microsoft.App/stable/2024-03-01/ManagedEnvironments.json#L369
`❌` PutResponseCodes	Synchronous and long-running PUT operations must have responses with 200, 201 and default return codes. They also must not have other response codes. Location: Microsoft.App/stable/2024-03-01/ManagedEnvironments.json#L422
`❌` ResourceNameRestriction	The resource name parameter 'environmentName' should be defined with a 'pattern' restriction. Location: Microsoft.App/stable/2024-03-01/ManagedEnvironments.json#L597
`❌` ResourceNameRestriction	The resource name parameter 'managedCertificateName' should be defined with a 'pattern' restriction. Location: Microsoft.App/stable/2024-03-01/ManagedEnvironments.json#L597
`❌` PutResponseCodes	Synchronous and long-running PUT operations must have responses with 200, 201 and default return codes. They also must not have other response codes. Location: Microsoft.App/stable/2024-03-01/ManagedEnvironments.json#L650
`❌` NoErrorCodeResponses	Invalid status code specified. Please refer to the documentation for the allowed set. Location: Microsoft.App/stable/2024-03-01/ManagedEnvironments.json#L703
`❌` LroErrorContent	Error response content of long running operations must follow the error schema provided in the common types v2 and above. Location: Microsoft.App/stable/2024-03-01/ManagedEnvironments.json#L710
`❌` ResourceNameRestriction	The resource name parameter 'environmentName' should be defined with a 'pattern' restriction. Location: Microsoft.App/stable/2024-03-01/ManagedEnvironments.json#L839
`❌` ResourceNameRestriction	The resource name parameter 'environmentName' should be defined with a 'pattern' restriction. Location: Microsoft.App/stable/2024-03-01/ManagedEnvironments.json#L889
`❌` ResourceNameRestriction	The resource name parameter 'environmentName' should be defined with a 'pattern' restriction. Location: Microsoft.App/stable/2024-03-01/ManagedEnvironments.json#L948
`❌` ResourceNameRestriction	The resource name parameter 'environmentName' should be defined with a 'pattern' restriction. Location: Microsoft.App/stable/2024-03-01/ManagedEnvironments.json#L995
⚠️ LatestVersionOfCommonTypesMustBeUsed	Use the latest version v5 of types.json. Location: Microsoft.App/stable/2024-03-01/ManagedEnvironments.json#L28
⚠️ LatestVersionOfCommonTypesMustBeUsed	Use the latest version v5 of types.json. Location: Microsoft.App/stable/2024-03-01/ManagedEnvironments.json#L31
⚠️ LatestVersionOfCommonTypesMustBeUsed	Use the latest version v5 of types.json. Location: Microsoft.App/stable/2024-03-01/ManagedEnvironments.json#L68
⚠️ LatestVersionOfCommonTypesMustBeUsed	Use the latest version v5 of types.json. Location: Microsoft.App/stable/2024-03-01/ManagedEnvironments.json#L71
⚠️ LatestVersionOfCommonTypesMustBeUsed	Use the latest version v5 of types.json. Location: Microsoft.App/stable/2024-03-01/ManagedEnvironments.json#L74
⚠️ LatestVersionOfCommonTypesMustBeUsed	Use the latest version v5 of types.json. Location: Microsoft.App/stable/2024-03-01/ManagedEnvironments.json#L111
⚠️ LatestVersionOfCommonTypesMustBeUsed	Use the latest version v5 of types.json. Location: Microsoft.App/stable/2024-03-01/ManagedEnvironments.json#L114
⚠️ LatestVersionOfCommonTypesMustBeUsed	Use the latest version v5 of types.json. Location: Microsoft.App/stable/2024-03-01/ManagedEnvironments.json#L124
⚠️ LatestVersionOfCommonTypesMustBeUsed	Use the latest version v5 of types.json. Location: Microsoft.App/stable/2024-03-01/ManagedEnvironments.json#L156

️️✔️Avocado succeeded [Detail] [Expand]

Validation passes for Avocado.

️️✔️SwaggerAPIView succeeded [Detail] [Expand]

️️✔️TypeSpecAPIView succeeded [Detail] [Expand]

️️✔️ModelValidation succeeded [Detail] [Expand]

Validation passes for ModelValidation.

️️✔️SemanticValidation succeeded [Detail] [Expand]

Validation passes for SemanticValidation.

️️✔️SpellCheck succeeded [Detail] [Expand]

Validation passes for SpellCheck.

️️✔️PR Summary succeeded [Detail] [Expand]

Validation passes for Summary.

️️✔️Automated merging requirements met succeeded [Detail] [Expand]

_{Posted by Swagger Pipeline | How to fix these errors?}

openapi-pipeline-app · 2024-03-08T03:27:32Z

Swagger Generation Artifacts

️️✔️ApiDocPreview succeeded [Detail] [Expand]

 Please click here to preview with your @microsoft account.

️⚠️SDK Breaking Change Tracking warning [Detail]

Breaking Changes Tracking

⚠️azure-sdk-for-go - sdk/resourcemanager/appcontainers/armappcontainers - 3.0.0

+	Field `EndTime`, `StartTime`, `Status`, `Template` of struct `JobExecution` has been removed

️⚠️ azure-sdk-for-python-track2 warning [Detail]

⚠️Warning [Logs] Generate from c835a47264a709a708d3d17f049b3eb37fa8c469. SDK Automation 14.0.0

command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
cmderr	[automation_init.sh] WARNING: azure-devtools 1.2.1 does not provide the extra 'ci-tools'
cmderr	[automation_init.sh] WARNING: azure-devtools 1.2.1 does not provide the extra 'ci-tools'
cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json

️✔️track2_azure-mgmt-appcontainers [View full logs] [Preview SDK Changes]
- azure-mgmt-appcontainers-1.0.0b1.zip
- azure_mgmt_appcontainers-1.0.0b1-py3-none-any.whl
```
info	[Changelog] ### Features Added
info	[Changelog]
info	[Changelog]   - Model ManagedEnvironment has a new parameter peer_traffic_configuration
```

️⚠️ azure-sdk-for-java warning [Detail]

⚠️Warning [Logs] Generate from c835a47264a709a708d3d17f049b3eb37fa8c469. SDK Automation 14.0.0

command	./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json
cmderr	[init.sh] [notice] A new release of pip is available: 23.0.1 -> 24.0
cmderr	[init.sh] [notice] To update, run: pip install --upgrade pip
cmderr	[init.sh] [notice] A new release of pip is available: 23.0.1 -> 24.0
cmderr	[init.sh] [notice] To update, run: pip install --upgrade pip
cmderr	[init.sh] t
cmderr	[init.sh]                                  Dload  Upload   Total   Spent    Left  Speed
cmderr	[init.sh] 
  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0k
cmderr	[init.sh] Downloading https://nodejs.org/dist/v18.15.0/node-v18.15.0-linux-x64.tar.xz...
cmderr	[init.sh] Computing checksum with sha256sum
cmderr	[init.sh] Checksums matched!
command	./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json

️✔️azure-resourcemanager-appcontainers [View full logs] [Preview SDK Changes]

️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]

️✔️Succeeded [Logs] Generate from c835a47264a709a708d3d17f049b3eb37fa8c469. SDK Automation 14.0.0

command	sh ./eng/scripts/automation_init.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
command	generator automation-v2 ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json

️✔️sdk/resourcemanager/appcontainers/armappcontainers [View full logs] [Preview SDK Changes] Breaking Change Detected

info	[Changelog] ### Breaking Changes
info	[Changelog]
info	[Changelog] - Field `EndTime`, `StartTime`, `Status`, `Template` of struct `JobExecution` has been removed
info	[Changelog]
info	[Changelog] ### Features Added
info	[Changelog]
info	[Changelog] - New struct `JobExecutionProperties`
info	[Changelog] - New struct `ManagedEnvironmentPropertiesPeerTrafficConfiguration`
info	[Changelog] - New struct `ManagedEnvironmentPropertiesPeerTrafficConfigurationEncryption`
info	[Changelog] - New field `Properties` in struct `JobExecution`
info	[Changelog] - New field `PeerTrafficConfiguration` in struct `ManagedEnvironmentProperties`
info	[Changelog]
info	[Changelog] Total 1 breaking change(s), 8 additive change(s).

️️✔️ azure-sdk-for-js succeeded [Detail] [Expand]

️✔️Succeeded [Logs] Generate from c835a47264a709a708d3d17f049b3eb37fa8c469. SDK Automation 14.0.0

command	sh .scripts/automation_init.sh ../azure-sdk-for-js_tmp/initInput.json ../azure-sdk-for-js_tmp/initOutput.json
warn	File azure-sdk-for-js_tmp/initOutput.json not found to read
command	sh .scripts/automation_generate.sh ../azure-sdk-for-js_tmp/generateInput.json ../azure-sdk-for-js_tmp/generateOutput.json

️✔️@azure/arm-appcontainers [View full logs] [Preview SDK Changes]

azure-arm-appcontainers-2.1.0.tgz

info	[Changelog] **Features**
info	[Changelog]
info	[Changelog]   - Added Interface ManagedEnvironmentPropertiesPeerTrafficConfiguration
info	[Changelog]   - Added Interface ManagedEnvironmentPropertiesPeerTrafficConfigurationEncryption
info	[Changelog]   - Interface ManagedEnvironment has a new optional parameter peerTrafficConfiguration

️⚠️ azure-resource-manager-schemas warning [Detail]

⚠️Warning [Logs] Generate from c835a47264a709a708d3d17f049b3eb37fa8c469. Schema Automation 14.0.0

command	.sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json
cmderr	[initScript.sh] notice
cmderr	[initScript.sh] npm notice New minor version of npm available! 10.2.4 -> 10.5.0
cmderr	[initScript.sh] npm notice Changelog: <https://github.com/npm/cli/releases/tag/v10.5.0>
cmderr	[initScript.sh] npm notice Run `npm install -g npm@10.5.0` to update!
cmderr	[initScript.sh] npm notice
warn	File azure-resource-manager-schemas_tmp/initOutput.json not found to read
command	.sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json

️✔️app [View full logs] [Preview Schema Changes]

️️✔️ azure-powershell succeeded [Detail] [Expand]

️✔️Succeeded [Logs] Generate from c835a47264a709a708d3d17f049b3eb37fa8c469. SDK Automation 14.0.0

command	sh ./tools/SwaggerCI/init.sh ../azure-powershell_tmp/initInput.json ../azure-powershell_tmp/initOutput.json
command	pwsh ./tools/SwaggerCI/psci.ps1 ../azure-powershell_tmp/generateInput.json ../azure-powershell_tmp/generateOutput.json

️✔️Az.app.DefaultTag [View full logs] [Preview SDK Changes]
- Az.ContainerAppsApi.0.1.0.nupkg

_{Posted by Swagger Pipeline | How to fix these errors?}

openapi-pipeline-app · 2024-03-08T03:27:33Z

Generated ApiView

Language	Package Name	ApiView Link
Go	sdk/resourcemanager/appcontainers/armappcontainers	https://apiview.dev/Assemblies/Review/c5375c6f5a4443168e64c981277b8377?revisionId=3afa9776a4ee43fe938a5d849925ec9f
Java	azure-resourcemanager-appcontainers	https://apiview.dev/Assemblies/Review/7da9ac1e2db64477ada2ba8bbb71169b?revisionId=433ae141455c42d4bfc105bc1f23a72e
JavaScript	@azure/arm-appcontainers	https://apiview.dev/Assemblies/Review/ba41cd9978b542efb0688a072b2319a1?revisionId=de92725f092d4802b6999d11758ab3f6
Swagger	Microsoft.App	https://apiview.dev/Assemblies/Review/53999dbad23b45cba7812a00a713cab8?revisionId=d5cb9d8c81a043d3bfdac25957d9dd66

raosuhas · 2024-03-12T00:02:22Z

specification/app/resource-manager/Microsoft.App/stable/2024-03-01/ManagedEnvironments.json

+                  "type": "object",
+                  "properties": {
+                    "enabled": {
+                      "type": "boolean",


boolean

Consider making this an Enum. Also please check the other Lint Diff warnings for this PR here :

https://github.com/Azure/azure-rest-api-specs/pull/28159/checks?check_run_id=22421639508

Thanks for your feedback. It's intended to keep consistent with the existing peerAuthentication.mtls.enabled which is also boolean. For the rest "AvoidNestedProperties" warnings, it isn't applicable here.

openapi-workflow-bot · 2024-03-12T00:02:35Z

Please address or respond to feedback from the ARM API reviewer.
When you are ready to continue the ARM API review, please remove the ARMChangesRequested label.
This will notify the reviewer to have another look.
If the feedback provided needs further discussion, please use this Teams channel to post your questions - aka.ms/azsdk/support/specreview-channel.
Please include [ARM Query] in the title of your question to indicate that it is ARM-related.

* Adds base for updating Microsoft.App from version stable/2023-05-01 to version 2024-03-01 * Updates readme * Updates API version in new specs and examples * [ContainerApp] Support peer traffic encryption. (#28159) * fix (#28426) * Add new feature GPU and job diagnostics to 2024-03-01 (#27875) * fix * fix * Add more features to 2024-03-01 which are same with 2023-05-02-preview (#28369) * fix * fix * fix * update readme * add sdk-suppressions.yaml --------- Co-authored-by: Alancere <804873052@qq.com> --------- Co-authored-by: Xiangyang Yu <yyddxxmm@gmail.com> Co-authored-by: Alancere <804873052@qq.com>

[ContainerApp] Support peer traffic encryption.

28e2077

LGDoor requested review from Juliehzl and jijohn14 as code owners March 8, 2024 03:27

azure-sdk mentioned this pull request Mar 8, 2024

[AutoPR sdk/resourcemanager/appcontainers/armappcontainers] [ContainerApp] Support peer traffic encryption. azure-sdk/azure-sdk-for-go#9171

Closed

openapi-pipeline-app bot added the CI-BreakingChange-Go label Mar 8, 2024

AzureRestAPISpecReview added ARMReview resource-manager WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Mar 8, 2024

raosuhas reviewed Mar 12, 2024

View reviewed changes

raosuhas added the ARMChangesRequested label Mar 12, 2024

openapi-workflow-bot bot removed the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Mar 12, 2024

LGDoor removed the ARMChangesRequested label Mar 13, 2024

openapi-workflow-bot bot added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Mar 13, 2024

zhenqxuMSFT approved these changes Mar 13, 2024

View reviewed changes

LGDoor merged commit b0f4f78 into release-app-Microsoft.App-2024-03-01 Mar 13, 2024

LGDoor deleted the aca-e2e-encryption-stable branch March 13, 2024 09:19

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Comments

[ContainerApp] Support peer traffic encryption.#28159

[ContainerApp] Support peer traffic encryption.#28159
LGDoor merged 1 commit intorelease-app-Microsoft.App-2024-03-01from
aca-e2e-encryption-stable

LGDoor commented Mar 8, 2024 •

edited

Loading

Uh oh!

openapi-pipeline-app bot commented Mar 8, 2024 •

edited

Loading

Uh oh!

openapi-pipeline-app bot commented Mar 8, 2024 •

edited

Loading

Uh oh!

openapi-pipeline-app bot commented Mar 8, 2024 •

edited

Loading

Breaking Changes Tracking

Uh oh!

openapi-pipeline-app bot commented Mar 8, 2024 •

edited

Loading

Uh oh!

raosuhas Mar 12, 2024

Uh oh!

LGDoor Mar 13, 2024

Uh oh!

openapi-workflow-bot bot commented Mar 12, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Comments

Conversation

LGDoor commented Mar 8, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

ARM (Control Plane) API Specification Update Pull Request

PR review workflow diagram

Diagram footnotes

Purpose of this PR

Due diligence checklist

Additional information

Getting help

Uh oh!

openapi-pipeline-app bot commented Mar 8, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Next Steps to Merge

Uh oh!

openapi-pipeline-app bot commented Mar 8, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Swagger Validation Report

Uh oh!

openapi-pipeline-app bot commented Mar 8, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Swagger Generation Artifacts

Breaking Changes Tracking

Uh oh!

openapi-pipeline-app bot commented Mar 8, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Generated ApiView

Uh oh!

raosuhas Mar 12, 2024

Choose a reason for hiding this comment

Uh oh!

LGDoor Mar 13, 2024

Choose a reason for hiding this comment

Uh oh!

openapi-workflow-bot bot commented Mar 12, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

LGDoor commented Mar 8, 2024 •

edited

Loading

openapi-pipeline-app bot commented Mar 8, 2024 •

edited

Loading

openapi-pipeline-app bot commented Mar 8, 2024 •

edited

Loading

openapi-pipeline-app bot commented Mar 8, 2024 •

edited

Loading

openapi-pipeline-app bot commented Mar 8, 2024 •

edited

Loading