Skip to content

Issues resource with Comments and Attachments subresources were added#2768

Closed
promoisha wants to merge 3 commits intoAzure:masterfrom
promoisha:glfeokti_issues_resource
Closed

Issues resource with Comments and Attachments subresources were added#2768
promoisha wants to merge 3 commits intoAzure:masterfrom
promoisha:glfeokti_issues_resource

Conversation

@promoisha
Copy link
Contributor

@promoisha promoisha commented Mar 28, 2018

This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.

PR information

  • The title of the PR is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
  • Except for special cases involving multiple contributors, the PR is started from a fork of the main repository, not a branch.
  • If applicable, the PR references the bug/issue that it fixes.
  • Swagger files are correctly named (e.g. the api-version in the path should match the api-version in the spec).

Quality of Swagger

@promoisha
Copy link
Contributor Author

Updated my previously approved PR (#2576) based on @olydis comments.

@AutorestCI
Copy link

AutorestCI commented Mar 28, 2018

Automation for azure-sdk-for-node

A PR has been created for you:
Azure/azure-sdk-for-node#2584

@olydis olydis closed this Mar 29, 2018
@AutorestCI
Copy link

AutorestCI commented Mar 29, 2018

Automation for azure-libraries-for-java

Nothing to generate for azure-libraries-for-java

@olydis
Copy link
Contributor

olydis commented Mar 29, 2018

@promoisha Please always reopen old PRs if you want to continue working on them - this way, the reivew history is right there, it is clear whether comments have been addressed, etc. 🙂 If you don't have permissions to reopen (I'm not sure), we'll gladly assist!

I reopened the old PR.

@AutorestCI
Copy link

AutorestCI commented Mar 29, 2018

Automation for azure-sdk-for-python

Nothing to generate for azure-sdk-for-python

@AutorestCI
Copy link

AutorestCI commented Mar 29, 2018

Automation for azure-sdk-for-go

A PR has been created for you:
Azure/azure-sdk-for-go#1467

@promoisha
Copy link
Contributor Author

@olydis yeah, I don't have permissions to reopen that's why I opened the new one :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants