Issues resource with Comments and Attachments subresources were added #2576

promoisha · 2018-03-02T00:32:07Z

Issues resource with Comments and Attachments subresources were added under theAPI resource.

This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.

PR information

The title of the PR is clear and informative.
There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
Except for special cases involving multiple contributors, the PR is started from a fork of the main repository, not a branch.
If applicable, the PR references the bug/issue that it fixes.
Swagger files are correctly named (e.g. the api-version in the path should match the api-version in the spec).

Quality of Swagger

I have read the contribution guidelines.
My spec meets the review criteria:
- The spec conforms to the Swagger 2.0 specification.
- The spec follows the guidelines described in the Swagger checklist document.
- Validation tools were run on swagger spec(s) and have all been fixed in this PR.

olydis · 2018-03-02T00:35:39Z

@ravbhatnagar new operations

AutorestCI · 2018-03-02T00:43:11Z

Automation for azure-sdk-for-python

Nothing to generate for azure-sdk-for-python

promoisha · 2018-03-02T00:48:53Z

@solankisamir

AutorestCI · 2018-03-02T00:53:26Z

Automation for azure-sdk-for-go

Encountered a Subprocess error: (azure-sdk-for-go)

Command: ['/usr/local/bin/autorest', '/tmp/tmpm5vf3ydx/rest/specification/apimanagement/resource-manager/readme.md', '--go', '--go-sdk-folder=/tmp/tmpm5vf3ydx/sdk', '--multiapi', '[email protected]/autorest.go@~2.1.95', '--use-onever', '--verbose']
Finished with return code 1
and output:

AutoRest code generation utility [version: 2.0.4259; node: v7.10.1]
(C) 2018 Microsoft Corporation.
https://aka.ms/autorest
   Loading AutoRest core      '/tmp/.autorest/@[email protected]/node_modules/@microsoft.azure/autorest-core/dist' (2.0.4259)
   Loading AutoRest extension '@microsoft.azure/autorest.go' (~2.1.95->2.1.95)
   Loading AutoRest extension '@microsoft.azure/autorest.modeler' (2.3.38->2.3.38)
Processing batch task - {"tag":"package-2017-03"} .
Processing batch task - {"tag":"package-2016-10"} .
Processing batch task - {"tag":"package-2016-07"} .
FATAL: swagger-document/compose - FAILED
FATAL: Error: '$.parameters.SubscriptionIdParameter.description' has incompatible values (---
  -
  Subscription credentials which uniquely identify Microsoft Azure subscription.
  The subscription ID forms part of the URI for every service call.
, ---
  -
  Subscription credentials which uniquely identify the Microsoft Azure
  subscription. The subscription ID forms part of the URI for every service
  call.
).
Process() cancelled due to exception : '$.parameters.SubscriptionIdParameter.description' has incompatible values (---
  -
  Subscription credentials which uniquely identify Microsoft Azure subscription.
  The subscription ID forms part of the URI for every service call.
, ---
  -
  Subscription credentials which uniquely identify the Microsoft Azure
  subscription. The subscription ID forms part of the URI for every service
  call.
).
Failure during batch task - {"tag":"package-2016-07"} -- Error: '$.parameters.SubscriptionIdParameter.description' has incompatible values (---
  -
  Subscription credentials which uniquely identify Microsoft Azure subscription.
  The subscription ID forms part of the URI for every service call.
, ---
  -
  Subscription credentials which uniquely identify the Microsoft Azure
  subscription. The subscription ID forms part of the URI for every service
  call.
)..
  Error: '$.parameters.SubscriptionIdParameter.description' has incompatible values (---
  -
  Subscription credentials which uniquely identify Microsoft Azure subscription.
  The subscription ID forms part of the URI for every service call.
, ---
  -
  Subscription credentials which uniquely identify the Microsoft Azure
  subscription. The subscription ID forms part of the URI for every service
  call.
).

… under API resource

…into glfeokti_issues_resource

promoisha · 2018-03-07T01:44:05Z

Hi, @ravbhatnagar! Could you please take a look? Thanks!

ravbhatnagar · 2018-03-08T23:50:39Z

Looks good. Signing off from ARM side.

promoisha · 2018-03-09T00:21:12Z

@olydis Don't merge this PR, as the API is not out yet.

olydis

Looking good overall, just one likely bug and some minor suggestions! 🙂 On which date is this API going live?

olydis · 2018-03-10T09:35:07Z

...ation/apimanagement/resource-manager/Microsoft.ApiManagement/stable/2017-03-01/apimapis.json

+            "in": "body",
+            "required": true,
+            "schema": {
+              "$ref": "#/definitions/IssueAttachmentPutContract"


Just a non-technical suggestion: I'd not put "Put" in the name of this class, it's a technical detail of the API and not helpful to SDK users. Unfortunately, I thing there is no big consensus for naming these things, but I've seen things like "...Setting" or "...Parameters" before (where "..." is the underlying resource type, i.e. IssueAttachmentContract in this case). Maybe you can take a quick look at other "put" operations in this RP to find the common naming strategy 🙂

olydis · 2018-03-10T09:37:16Z

...ation/apimanagement/resource-manager/Microsoft.ApiManagement/stable/2017-03-01/apimapis.json

+      ],
+      "description": "Issue contract Properties."
+    },
+    "IssueCommentCollection": {


Applies to all ...Collection types: Could you mark all properties as readOnly: true?

olydis · 2018-03-10T09:43:13Z

...ation/apimanagement/resource-manager/Microsoft.ApiManagement/stable/2017-03-01/apimapis.json

+      ],
+      "description": "Issue Attachment Contract details."
+    },
+    "IssueAttachmentPutContractProperties": {


not used anywhere - thanks to the example you provided for the put operation, this was caught by our tooling 😃 Pretty sure you wanted to use this schema for IssueAttachmentPutContract's properties. (My naming comment regarding using "Put" in the name of this type of course also applies for this type)

olydis · 2018-03-20T21:12:05Z

@promoisha please respond to outstanding comments/questions. Will otherwise close this PR due to inactivity (can be reopened once you are ready to move forward).

olydis · 2018-03-23T17:57:04Z

@salameer @promoisha Closing due to inactivity. Feel free to reopen once you're ready to address outstanding issues.

AutorestCI · 2018-03-23T17:58:09Z

Automation for azure-libraries-for-java

Nothing to generate for azure-libraries-for-java

AutorestCI · 2018-03-23T18:05:47Z

Automation for azure-sdk-for-node

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-node#2593

olydis · 2018-03-29T04:05:06Z

@promoisha Is this API already public/live or when is that going to happen? Just so I can merge at the right point in time 🙂

olydis

LGTM! Will merge once you confirmed whether/when this is live 🙂

promoisha · 2018-03-29T17:41:03Z

@olydis it's hitting the production right now, so I assume it's safe to merge :). Thanks a lot!

olydis · 2018-03-29T17:43:55Z

@promoisha Thank you!

azuresdkci assigned olydis Mar 2, 2018

olydis added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Mar 2, 2018

promoisha force-pushed the glfeokti_issues_resource branch from 6baa209 to f164fc7 Compare March 2, 2018 00:47

promoisha force-pushed the glfeokti_issues_resource branch 2 times, most recently from 5d9e129 to 0950562 Compare March 2, 2018 00:55

Issues resource with Comments and Attachments subresources were added…

bf2a1ed

… under API resource

promoisha force-pushed the glfeokti_issues_resource branch from 0950562 to bf2a1ed Compare March 2, 2018 03:45

Merge branch 'master' of https://github.com/Azure/azure-rest-api-specs …

4bc635c

…into glfeokti_issues_resource

ravbhatnagar added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Mar 8, 2018

olydis suggested changes Mar 10, 2018

View reviewed changes

olydis added the Reviewed-ChangesRequested <valid label in PR review process>add this label when assignee request changes after review label Mar 21, 2018

olydis closed this Mar 23, 2018

AutorestCI mentioned this pull request Mar 23, 2018

[AutoPR apimanagement/resource-manager] Issues resource with Comments and Attachments subresources were added Azure/azure-sdk-for-go#1414

Closed

readonly=true for collection types properties

81a3368

promoisha mentioned this pull request Mar 28, 2018

Issues resource with Comments and Attachments subresources were added #2768

Closed

10 tasks

olydis reopened this Mar 29, 2018

AutorestCI mentioned this pull request Mar 29, 2018

[AutoPR apimanagement/resource-manager] Issues resource with Comments and Attachments subresources were added Azure/azure-sdk-for-go#1468

Closed

AutorestCI mentioned this pull request Mar 29, 2018

[AutoPR apimanagement/resource-manager] Issues resource with Comments and Attachments subresources were added Azure/azure-sdk-for-node#2585

Merged

olydis approved these changes Mar 29, 2018

View reviewed changes

olydis added Approved-OkToMerge <valid label in PR review process>add this label when assignee approve to merge the updates and removed Reviewed-ChangesRequested <valid label in PR review process>add this label when assignee request changes after review labels Mar 29, 2018

olydis merged commit e4b3652 into Azure:master Mar 29, 2018

promoisha mentioned this pull request Apr 3, 2018

Issues Resource added to version 2018-01-01 #2806

Merged

10 tasks

Issues resource with Comments and Attachments subresources were added #2576

Issues resource with Comments and Attachments subresources were added #2576

Uh oh!

Conversation

promoisha commented Mar 2, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR information

Quality of Swagger

Uh oh!

olydis commented Mar 2, 2018

Uh oh!

AutorestCI commented Mar 2, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Automation for azure-sdk-for-python

Uh oh!

promoisha commented Mar 2, 2018

Uh oh!

AutorestCI commented Mar 2, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Automation for azure-sdk-for-go

Uh oh!

promoisha commented Mar 7, 2018

Uh oh!

ravbhatnagar commented Mar 8, 2018

Uh oh!

promoisha commented Mar 9, 2018

Uh oh!

olydis left a comment

Choose a reason for hiding this comment

Uh oh!

olydis Mar 10, 2018

Choose a reason for hiding this comment

Uh oh!

olydis Mar 10, 2018

Choose a reason for hiding this comment

Uh oh!

olydis Mar 10, 2018

Choose a reason for hiding this comment

Uh oh!

olydis commented Mar 20, 2018

Uh oh!

olydis commented Mar 23, 2018

Uh oh!

AutorestCI commented Mar 23, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Automation for azure-libraries-for-java

Uh oh!

AutorestCI commented Mar 23, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Automation for azure-sdk-for-node

Uh oh!

olydis commented Mar 29, 2018

Uh oh!

olydis left a comment

Choose a reason for hiding this comment

Uh oh!

promoisha commented Mar 29, 2018

Uh oh!

olydis commented Mar 29, 2018

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

promoisha commented Mar 2, 2018 •

edited

Loading

AutorestCI commented Mar 2, 2018 •

edited

Loading

AutorestCI commented Mar 2, 2018 •

edited

Loading

AutorestCI commented Mar 23, 2018 •

edited

Loading

AutorestCI commented Mar 23, 2018 •

edited

Loading