[NetApp] Merge release netapp microsoft.net app 2023 07 01#26989
Conversation
…1 to version 2023-07-01
* Update to api-version 2023-07-01 * update common types to v5 * update common types to v5 * Add default schema, reference common types * pretty
Next Steps to Merge✔️ All automated merging requirements have been met! Refer to step 4 in the PR workflow diagram (even if your PR is for data plane, not ARM). |
Swagger Validation Report
|
| compared swaggers (via Oad v0.10.4)] | new version | base version |
|---|---|---|
| netapp.json | 2023-07-01(5544c89) | 2023-05-01(main) |
| netapp.json | 2023-07-01(5544c89) | 2023-05-01-preview(main) |
The following breaking changes are detected by comparison with the latest stable version:
Only 28 items are listed, please refer to log for more details.
The following breaking changes are detected by comparison with the latest preview version:
Only 28 items are listed, please refer to log for more details.
| Rule | Message |
|---|---|
| The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/providers/Microsoft.NetApp/locations/{location}/regionInfos' removed or restructured? Old: Microsoft.NetApp/preview/2023-05-01-preview/netapp.json#L295:5 |
|
| The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/providers/Microsoft.NetApp/locations/{location}/regionInfos/default' removed or restructured? Old: Microsoft.NetApp/preview/2023-05-01-preview/netapp.json#L338:5 |
|
| The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.NetApp/netAppAccounts/{accountName}/migrateEncryption' removed or restructured? Old: Microsoft.NetApp/preview/2023-05-01-preview/netapp.json#L850:5 |
|
| The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.NetApp/netAppAccounts/{accountName}/capacityPools/{poolName}/volumes/{volumeName}/splitCloneFromParent' removed or restructured? Old: Microsoft.NetApp/preview/2023-05-01-preview/netapp.json#L1601:5 |
|
| The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.NetApp/netAppAccounts/{accountName}/capacityPools/{poolName}/volumes/{volumeName}/latestBackupStatus/current' removed or restructured? Old: Microsoft.NetApp/preview/2023-05-01-preview/netapp.json#L3047:5 |
|
| The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.NetApp/netAppAccounts/{accountName}/accountBackups' removed or restructured? Old: Microsoft.NetApp/preview/2023-05-01-preview/netapp.json#L3142:5 |
|
| The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.NetApp/netAppAccounts/{accountName}/accountBackups/{backupName}' removed or restructured? Old: Microsoft.NetApp/preview/2023-05-01-preview/netapp.json#L3195:5 |
|
| The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.NetApp/netAppAccounts/{accountName}/backupVaults/{backupVaultName}/backups' removed or restructured? Old: Microsoft.NetApp/preview/2023-05-01-preview/netapp.json#L3294:5 |
|
| The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.NetApp/netAppAccounts/{accountName}/backupVaults/{backupVaultName}/backups/{backupName}' removed or restructured? Old: Microsoft.NetApp/preview/2023-05-01-preview/netapp.json#L3350:5 |
|
| The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.NetApp/netAppAccounts/{accountName}/backupVaults' removed or restructured? Old: Microsoft.NetApp/preview/2023-05-01-preview/netapp.json#L4660:5 |
|
| The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.NetApp/netAppAccounts/{accountName}/backupVaults/{backupVaultName}' removed or restructured? Old: Microsoft.NetApp/preview/2023-05-01-preview/netapp.json#L4706:5 |
|
| The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.NetApp/netAppAccounts/{accountName}/backupVaults/{backupVaultName}/backups/{backupName}/restoreFiles' removed or restructured? Old: Microsoft.NetApp/preview/2023-05-01-preview/netapp.json#L4936:5 |
|
| The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.NetApp/netAppAccounts/{accountName}/capacityPools/{poolName}/volumes/{volumeName}/migrateBackups' removed or restructured? Old: Microsoft.NetApp/preview/2023-05-01-preview/netapp.json#L5000:5 |
|
| The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.NetApp/netAppAccounts/{accountName}/migrateBackups' removed or restructured? Old: Microsoft.NetApp/preview/2023-05-01-preview/netapp.json#L5064:5 |
|
| The new version is missing a definition that was found in the old version. Was 'backup' removed or renamed? New: Microsoft.NetApp/stable/2023-07-01/netapp.json#L4177:3 Old: Microsoft.NetApp/preview/2023-05-01-preview/netapp.json#L5123:3 |
|
| The new version is missing a definition that was found in the old version. Was 'backupPatch' removed or renamed? New: Microsoft.NetApp/stable/2023-07-01/netapp.json#L4177:3 Old: Microsoft.NetApp/preview/2023-05-01-preview/netapp.json#L5123:3 |
|
| The new version is missing a definition that was found in the old version. Was 'backupProperties' removed or renamed? New: Microsoft.NetApp/stable/2023-07-01/netapp.json#L4177:3 Old: Microsoft.NetApp/preview/2023-05-01-preview/netapp.json#L5123:3 |
|
| The new version is missing a definition that was found in the old version. Was 'backupPatchProperties' removed or renamed? New: Microsoft.NetApp/stable/2023-07-01/netapp.json#L4177:3 Old: Microsoft.NetApp/preview/2023-05-01-preview/netapp.json#L5123:3 |
|
| The new version is missing a definition that was found in the old version. Was 'backupRestoreFiles' removed or renamed? New: Microsoft.NetApp/stable/2023-07-01/netapp.json#L4177:3 Old: Microsoft.NetApp/preview/2023-05-01-preview/netapp.json#L5123:3 |
|
| The new version is missing a definition that was found in the old version. Was 'encryptionMigrationRequest' removed or renamed? New: Microsoft.NetApp/stable/2023-07-01/netapp.json#L4177:3 Old: Microsoft.NetApp/preview/2023-05-01-preview/netapp.json#L5123:3 |
|
| The new version is missing a definition that was found in the old version. Was 'backupVault' removed or renamed? New: Microsoft.NetApp/stable/2023-07-01/netapp.json#L4177:3 Old: Microsoft.NetApp/preview/2023-05-01-preview/netapp.json#L5123:3 |
|
| The new version is missing a definition that was found in the old version. Was 'backupVaultPatch' removed or renamed? New: Microsoft.NetApp/stable/2023-07-01/netapp.json#L4177:3 Old: Microsoft.NetApp/preview/2023-05-01-preview/netapp.json#L5123:3 |
|
| The new version is missing a definition that was found in the old version. Was 'backupVaultProperties' removed or renamed? New: Microsoft.NetApp/stable/2023-07-01/netapp.json#L4177:3 Old: Microsoft.NetApp/preview/2023-05-01-preview/netapp.json#L5123:3 |
|
| The new version is missing a definition that was found in the old version. Was 'backupsMigrationRequest' removed or renamed? New: Microsoft.NetApp/stable/2023-07-01/netapp.json#L4177:3 Old: Microsoft.NetApp/preview/2023-05-01-preview/netapp.json#L5123:3 |
|
| The new version is missing a client parameter that was found in the old version. Was 'BackupName' removed or renamed? New: Microsoft.NetApp/stable/2023-07-01/netapp.json#L7923:3 Old: Microsoft.NetApp/preview/2023-05-01-preview/netapp.json#L9355:3 |
|
| The new version is missing a client parameter that was found in the old version. Was 'BackupVaultName' removed or renamed? New: Microsoft.NetApp/stable/2023-07-01/netapp.json#L7923:3 Old: Microsoft.NetApp/preview/2023-05-01-preview/netapp.json#L9355:3 |
|
| The '$ref' property points to different models in the old and new versions. New: Microsoft.NetApp/stable/2023-07-01/netapp.json#L743:13 Old: Microsoft.NetApp/preview/2023-05-01-preview/netapp.json#L790:13 |
|
| The '$ref' property points to different models in the old and new versions. New: common-types/resource-management/v5/types.json#L307:9 Old: Microsoft.NetApp/preview/2023-05-01-preview/netapp.json#L8329:9 |
️️✔️CredScan succeeded [Detail] [Expand]
There is no credential detected.
️⚠️LintDiff: 0 Warnings warning [Detail]
| compared tags (via openapi-validator v2.1.6) | new version | base version |
|---|---|---|
| package-netapp-2023-07-01 | package-netapp-2023-07-01(5544c89) | default(main) |
The following errors/warnings exist before current PR submission:
Only 28 items are listed, please refer to log for more details.
| Rule | Message |
|---|---|
OperationsApiResponseSchema |
The response schema of operations API '/providers/Microsoft.NetApp/operations' does not match the ARM specification. Please standardize the schema. Location: Microsoft.NetApp/stable/2023-07-01/netapp.json#L59 |
OperationsApiSchemaUsesCommonTypes |
Operations API path must follow the schema provided in the common types. Location: Microsoft.NetApp/stable/2023-07-01/netapp.json#L60 |
GetCollectionOnlyHasValueAndNextLink |
Get endpoints for collections of resources must only have the value and nextLink properties in their model.Location: Microsoft.NetApp/stable/2023-07-01/netapp.json#L252 |
ResourceNameRestriction |
The resource name parameter 'quotaLimitName' should be defined with a 'pattern' restriction. Location: Microsoft.NetApp/stable/2023-07-01/netapp.json#L270 |
XmsPageableForListCalls |
x-ms-pageable extension must be specified for LIST APIs.Location: Microsoft.NetApp/stable/2023-07-01/netapp.json#L314 |
GetCollectionOnlyHasValueAndNextLink |
Get endpoints for collections of resources must only have the value and nextLink properties in their model.Location: Microsoft.NetApp/stable/2023-07-01/netapp.json#L335 |
LroLocationHeader |
A 202 response should include an Location response header. Location: Microsoft.NetApp/stable/2023-07-01/netapp.json#L675 |
UnSupportedPatchProperties |
Mark the top-level property 'location', specified in the patch operation body, as readOnly or immutable. You could also choose to remove it from the request payload of the Patch operation. This property is not patchable. Location: Microsoft.NetApp/stable/2023-07-01/netapp.json#L706 |
LroLocationHeader |
A 202 response should include an Location response header. Location: Microsoft.NetApp/stable/2023-07-01/netapp.json#L735 |
PostResponseCodes |
200 return code does not have a schema specified. LRO POST must have a 200 return code if only if the final response is intended to have a schema, if not the 200 return code must not be specified. Location: Microsoft.NetApp/stable/2023-07-01/netapp.json#L760 |
LroLocationHeader |
A 202 response should include an Location response header. Location: Microsoft.NetApp/stable/2023-07-01/netapp.json#L785 |
UnSupportedPatchProperties |
Mark the top-level property 'location', specified in the patch operation body, as readOnly or immutable. You could also choose to remove it from the request payload of the Patch operation. This property is not patchable. Location: Microsoft.NetApp/stable/2023-07-01/netapp.json#L968 |
LroLocationHeader |
A 202 response should include an Location response header. Location: Microsoft.NetApp/stable/2023-07-01/netapp.json#L1000 |
LroLocationHeader |
A 202 response should include an Location response header. Location: Microsoft.NetApp/stable/2023-07-01/netapp.json#L1045 |
PutResponseCodes |
Synchronous and long-running PUT operations must have responses with 200, 201 and default return codes. They also must not have other response codes. Location: Microsoft.NetApp/stable/2023-07-01/netapp.json#L1166 |
LroLocationHeader |
A 202 response should include an Location response header. Location: Microsoft.NetApp/stable/2023-07-01/netapp.json#L1215 |
UnSupportedPatchProperties |
Mark the top-level property 'location', specified in the patch operation body, as readOnly or immutable. You could also choose to remove it from the request payload of the Patch operation. This property is not patchable. Location: Microsoft.NetApp/stable/2023-07-01/netapp.json#L1243 |
LroLocationHeader |
A 202 response should include an Location response header. Location: Microsoft.NetApp/stable/2023-07-01/netapp.json#L1278 |
LroLocationHeader |
A 202 response should include an Location response header. Location: Microsoft.NetApp/stable/2023-07-01/netapp.json#L1333 |
PostResponseCodes |
200 return code does not have a schema specified. LRO POST must have a 200 return code if only if the final response is intended to have a schema, if not the 200 return code must not be specified. Location: Microsoft.NetApp/stable/2023-07-01/netapp.json#L1419 |
LroLocationHeader |
A 202 response should include an Location response header. Location: Microsoft.NetApp/stable/2023-07-01/netapp.json#L1459 |
PostResponseCodes |
200 return code does not have a schema specified. LRO POST must have a 200 return code if only if the final response is intended to have a schema, if not the 200 return code must not be specified. Location: Microsoft.NetApp/stable/2023-07-01/netapp.json#L1533 |
PostResponseCodes |
200 return code does not have a schema specified. LRO POST must have a 200 return code if only if the final response is intended to have a schema, if not the 200 return code must not be specified. Location: Microsoft.NetApp/stable/2023-07-01/netapp.json#L1670 |
LroLocationHeader |
A 202 response should include an Location response header. Location: Microsoft.NetApp/stable/2023-07-01/netapp.json#L1710 |
LroLocationHeader |
A 202 response should include an Location response header. Location: Microsoft.NetApp/stable/2023-07-01/netapp.json#L1769 |
XmsPageableForListCalls |
x-ms-pageable extension must be specified for LIST APIs.Location: Microsoft.NetApp/stable/2023-07-01/netapp.json#L1791 |
GetCollectionOnlyHasValueAndNextLink |
Get endpoints for collections of resources must only have the value and nextLink properties in their model.Location: Microsoft.NetApp/stable/2023-07-01/netapp.json#L1821 |
PostResponseCodes |
200 return code does not have a schema specified. LRO POST must have a 200 return code if only if the final response is intended to have a schema, if not the 200 return code must not be specified. Location: Microsoft.NetApp/stable/2023-07-01/netapp.json#L1892 |
️❌Avocado: 9 Errors, 0 Warnings failed [Detail]
| Rule | Message |
|---|---|
MISSING_APIS_IN_DEFAULT_TAG |
The default tag should contain all APIs. The API path /subscriptions/{}/resourceGroups/{}/providers/Microsoft.NetApp/netAppAccounts/{}/capacityPools/{}/volumes/{}/mountTargets is not in the default tag. Please make sure the missing API swaggers are in the default tag.readme: specification/netapp/resource-manager/readme.md json: Microsoft.NetApp/stable/2019-10-01/netapp.json |
MISSING_APIS_IN_DEFAULT_TAG |
The default tag should contain all APIs. The API path /subscriptions/{}/resourceGroups/{}/providers/Microsoft.NetApp/netAppAccounts/{}/snapshotPolicies/{}/listVolumes is not in the default tag. Please make sure the missing API swaggers are in the default tag.readme: specification/netapp/resource-manager/readme.md json: Microsoft.NetApp/stable/2020-09-01/netapp.json |
MISSING_APIS_IN_DEFAULT_TAG |
The default tag should contain all APIs. The API path /subscriptions/{}/resourceGroups/{}/providers/Microsoft.NetApp/netAppAccounts/{}/accountBackups is not in the default tag. Please make sure the missing API swaggers are in the default tag.readme: specification/netapp/resource-manager/readme.md json: Microsoft.NetApp/stable/2022-11-01/netapp.json |
MISSING_APIS_IN_DEFAULT_TAG |
The default tag should contain all APIs. The API path /subscriptions/{}/resourceGroups/{}/providers/Microsoft.NetApp/netAppAccounts/{}/accountBackups/{} is not in the default tag. Please make sure the missing API swaggers are in the default tag.readme: specification/netapp/resource-manager/readme.md json: Microsoft.NetApp/stable/2022-11-01/netapp.json |
MISSING_APIS_IN_DEFAULT_TAG |
The default tag should contain all APIs. The API path /subscriptions/{}/resourceGroups/{}/providers/Microsoft.NetApp/netAppAccounts/{}/capacityPools/{}/volumes/{}/backups is not in the default tag. Please make sure the missing API swaggers are in the default tag.readme: specification/netapp/resource-manager/readme.md json: Microsoft.NetApp/stable/2022-11-01/netapp.json |
MISSING_APIS_IN_DEFAULT_TAG |
The default tag should contain all APIs. The API path /subscriptions/{}/resourceGroups/{}/providers/Microsoft.NetApp/netAppAccounts/{}/capacityPools/{}/volumes/{}/backups/{} is not in the default tag. Please make sure the missing API swaggers are in the default tag.readme: specification/netapp/resource-manager/readme.md json: Microsoft.NetApp/stable/2022-11-01/netapp.json |
MISSING_APIS_IN_DEFAULT_TAG |
The default tag should contain all APIs. The API path /subscriptions/{}/resourceGroups/{}/providers/Microsoft.NetApp/netAppAccounts/{}/vaults is not in the default tag. Please make sure the missing API swaggers are in the default tag.readme: specification/netapp/resource-manager/readme.md json: Microsoft.NetApp/stable/2022-05-01/netapp.json |
MISSING_APIS_IN_DEFAULT_TAG |
The default tag should contain all APIs. The API path /subscriptions/{}/resourceGroups/{}/providers/Microsoft.NetApp/netAppAccounts/{}/capacityPools/{}/volumes/{}/backupStatus is not in the default tag. Please make sure the missing API swaggers are in the default tag.readme: specification/netapp/resource-manager/readme.md json: Microsoft.NetApp/stable/2022-11-01/netapp.json |
MISSING_APIS_IN_DEFAULT_TAG |
The default tag should contain all APIs. The API path /subscriptions/{}/resourceGroups/{}/providers/Microsoft.NetApp/netAppAccounts/{}/capacityPools/{}/volumes/{}/backups/{}/restoreFiles is not in the default tag. Please make sure the missing API swaggers are in the default tag.readme: specification/netapp/resource-manager/readme.md json: Microsoft.NetApp/stable/2022-11-01/netapp.json |
️️✔️SwaggerAPIView succeeded [Detail] [Expand]
️️✔️TypeSpecAPIView succeeded [Detail] [Expand]
️️✔️ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️️✔️PoliCheck succeeded [Detail] [Expand]
Validation passed for PoliCheck.
️️✔️SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
️️✔️Lint(RPaaS) succeeded [Detail] [Expand]
Validation passes for Lint(RPaaS).
️️✔️PR Summary succeeded [Detail] [Expand]
Validation passes for Summary.
️️✔️Automated merging requirements met succeeded [Detail] [Expand]
Swagger Generation Artifacts
|
Generated ApiView
|
|
All changes approved here this is to publish release branch to main. |
|
Please address or respond to feedback from the ARM API reviewer. |
|
Hi @audunn! For review efficiency consideration, when creating a new API version, it is required to place API specs of the base version in the first commit, and push new version updates into successive commits. You can use OpenAPIHub to initialize the PR for adding a new version. |
|
All changes, including breaking, approved in below PR to release branch, this is to sync with main and publish release branch to main. |
|
Not sure why its flagging Volumes_ResetCifsPassword now did not in pr on release. This is not changing in this update, fixing anyway. |
@visingla-ms yes, trying to figure out why it flags now with those MISSING_APIS_IN_DEFAULT_TAG issues when it did not in the private pr. BTW the APIs flaged as missing have been deprecated they were removed and that change approved in previous api-versions not in this PR |
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
|
the reason why I suggest these changes is beacause of this issue Azure/azure-sdk-for-js#27929 |
Good catch, thank you @kazrael2119 . Updated |
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
|
/pr RequestMerge |
* Adds base for updating Microsoft.NetApp from version stable/2023-05-01 to version 2023-07-01 * Updates readme * Updates API version in new specs and examples * [NetAppFiles] Update rest to 2023-07-01 (#26817) * Update to api-version 2023-07-01 * update common types to v5 * update common types to v5 * Add default schema, reference common types * pretty * readme * Volumes_ResetCifsPassword * readme * readme * readme * readme * update examples * update example
ARM (Control Plane) API Specification Update Pull Request
PR review workflow diagram
Please understand this diagram before proceeding. It explains how to get your PR approved & merged.
Click here to see the details of Step 1
Breaking changes review (Diagram Step 1)
If the automation determines you have breaking changes, i.e. Step 1 from the diagram applies to you,
you must follow the breaking changes process.
IMPORTANT This applies even if:
Such claims must be reviewed, and the process is the same.
Click here to see the details of Step 2
ARM API changes review (Diagram Step 2)
ARMReviewlabel.Click here to see the diagram footnotes
Diagram footnotes
[1] ARM review queue (for merge queues, see [2])
The PRs are processed by time opened, ascending. Your PR may show up on 2nd or later page.
If you addressed Step 1 from the diagram and your PR is not showing up in the queue, ensure the label
ARMChangesRequestedis removed from your PR. This should cause the label
WaitForARMFeedbackto be added.[2] public repo merge queue, private repo merge queue (for ARM review queue, [1])
If you need further help with anything, see
Getting helpsection below.Purpose of this PR
What's the purpose of this PR? Check all that apply. This is mandatory!
Due diligence checklist
To merge this PR, you must go through the following checklist and confirm you understood
and followed the instructions by checking all the boxes:
ARM resource provider contract and
REST guidelines (estimated time: 4 hours).
I understand this is required before I can proceed to the Diagram Step 2, "ARM API changes Review", for this PR.
Additional information
Viewing API changes
For convenient view of the API changes made by this PR, refer to the URLs provided in the table
in the
Generated ApiViewcomment added to this PR. You can use ApiView to show API versions diff.Suppressing failures
If one or multiple validation error/warning suppression(s) is detected in your PR, please follow the
Swagger-Suppression-Process
to get approval.
Getting help
Purpose of this PRandDue diligence checklist.Next Steps to Mergecomment. It will appear within few minutes of submitting this PR and will continue to be up-to-date with current PR state.and https://aka.ms/ci-fix.
queuedstate, please add a comment with contents/azp run.This should result in a new comment denoting a
PR validation pipelinehas started and the checks should be updated after few minutes.