Skip to content

[NetAppFiles] Update rest to 2023-07-01#26817

Merged
visingla-ms merged 5 commits into
Azure:release-netapp-Microsoft.NetApp-2023-07-01from
audunn:updateRestTo2023-07-01
Dec 5, 2023
Merged

[NetAppFiles] Update rest to 2023-07-01#26817
visingla-ms merged 5 commits into
Azure:release-netapp-Microsoft.NetApp-2023-07-01from
audunn:updateRestTo2023-07-01

Conversation

@audunn
Copy link
Copy Markdown
Member

@audunn audunn commented Nov 22, 2023

ARM (Control Plane) API Specification Update Pull Request

PR review workflow diagram

Please understand this diagram before proceeding. It explains how to get your PR approved & merged.

diagram

Click here to see the details of Step 1

Breaking changes review (Diagram Step 1)

If the automation determines you have breaking changes, i.e. Step 1 from the diagram applies to you,
you must follow the breaking changes process.
IMPORTANT This applies even if:

  • The tool fails while it shouldn't, e.g. due to runtime exception, or incorrect detection of breaking changes.
  • You believe there is no need for you to request breaking change approval, for any reason.
    Such claims must be reviewed, and the process is the same.
Click here to see the details of Step 2

ARM API changes review (Diagram Step 2)

  • If this PR is in purview of ARM review then automation will add the ARMReview label.
  • If you want to force ARM review, add the label yourself.
  • Proceed according to the diagram at the top of this comment.
Click here to see the diagram footnotes

Diagram footnotes

[1] ARM review queue (for merge queues, see [4])
The PRs are processed by time opened, ascending. Your PR may show up on 2nd or later page.
If you addressed Step 1 from the diagram and your PR is not showing up in the queue, ensure the label ARMChangesRequested
is removed from your PR. This should cause the label WaitForARMFeedback to be added.
[2] https://aka.ms/azsdk/support/specreview-channel
[3] List of SDK breaking changes approvers in pinned Teams announcement
[4] public repo merge queue, private repo merge queue (for ARM review queue, [1])

If you need further help with anything, see Getting help section below.

Purpose of this PR

What's the purpose of this PR? Check all that apply. This is mandatory!

  • New API version. (If API spec is not defined in TypeSpec, the PR should have been generated using OpenAPI Hub).
  • Update existing version for a new feature. (This is applicable only when you are revising a private preview API version.)
  • Update existing version to fix swagger quality issues in S360.
  • Other, please clarify:
    • edit this with your clarification

Due diligence checklist

To merge this PR, you must go through the following checklist and confirm you understood
and followed the instructions by checking all the boxes:

  • I confirm this PR is modifying Azure Resource Manager (ARM) related specifications, and not data plane related specifications.
  • I have reviewed following Resource Provider guidelines, including
    ARM resource provider contract and
    REST guidelines (estimated time: 4 hours).
    I understand this is required before I can proceed to the Diagram Step 2, "ARM API changes Review", for this PR.

Additional information

Viewing API changes

For convenient view of the API changes made by this PR, refer to the URLs provided in the table
in the Generated ApiView comment added to this PR. You can use ApiView to show API versions diff.

Suppressing failures

If one or multiple validation error/warning suppression(s) is detected in your PR, please follow the
Swagger-Suppression-Process
to get approval.

Getting help

  • For general PR approval workflow, see the diagram at the top of this comment.
  • For guidance on fixing this PR CI check failures, see the hyperlinks provided in given failure
    and https://aka.ms/ci-fix.
  • If the PR CI checks appear to be stuck in queued state, please add a comment with contents /azp run.
    This should result in a new comment denoting a PR validation pipeline has started and the checks should be updated after few minutes.
  • If the help provided by the previous points is not enough, post to https://aka.ms/azsdk/support/specreview-channel and link to this PR.

@audunn audunn requested a review from tadelesh as a code owner November 22, 2023 14:56
@openapi-pipeline-app
Copy link
Copy Markdown

openapi-pipeline-app Bot commented Nov 22, 2023

Next Steps to Merge

✔️ All automated merging requirements have been met! Refer to step 4 in the PR workflow diagram (even if your PR is for data plane, not ARM).

@openapi-pipeline-app
Copy link
Copy Markdown

openapi-pipeline-app Bot commented Nov 22, 2023

Swagger Validation Report

️️✔️BreakingChange succeeded [Detail] [Expand]
There are no breaking changes.
️❌Breaking Change(Cross-Version): 99 Errors, 135 Warnings failed [Detail]
compared swaggers (via Oad v0.10.4)] new version base version
netapp.json 2023-07-01(0f15820) 2023-05-01(main)
netapp.json 2023-07-01(0f15820) 2022-11-01-preview(main)

The following breaking changes are detected by comparison with the latest stable version:

Only 30 items are listed, please refer to log for more details.

Rule Message
1023 - TypeFormatChanged The new version has a different format than the previous one.
New: Microsoft.NetApp/stable/2023-07-01/netapp.json#L85:9
Old: Microsoft.NetApp/stable/2023-05-01/netapp.json#L82:9
1023 - TypeFormatChanged The new version has a different format than the previous one.
New: Microsoft.NetApp/stable/2023-07-01/netapp.json#L135:9
Old: Microsoft.NetApp/stable/2023-05-01/netapp.json#L129:9
1023 - TypeFormatChanged The new version has a different format than the previous one.
New: Microsoft.NetApp/stable/2023-07-01/netapp.json#L185:9
Old: Microsoft.NetApp/stable/2023-05-01/netapp.json#L176:9
1023 - TypeFormatChanged The new version has a different format than the previous one.
New: Microsoft.NetApp/stable/2023-07-01/netapp.json#L235:9
Old: Microsoft.NetApp/stable/2023-05-01/netapp.json#L223:9
1023 - TypeFormatChanged The new version has a different format than the previous one.
New: common-types/resource-management/v5/types.json#L14:9
Old: common-types/resource-management/v3/types.json#L14:9
1023 - TypeFormatChanged The new version has a different format than the previous one.
New: Microsoft.NetApp/stable/2023-07-01/netapp.json#L278:9
Old: Microsoft.NetApp/stable/2023-05-01/netapp.json#L263:9
1023 - TypeFormatChanged The new version has a different format than the previous one.
New: Microsoft.NetApp/stable/2023-07-01/netapp.json#L321:9
Old: Microsoft.NetApp/stable/2023-05-01/netapp.json#L303:9
1023 - TypeFormatChanged The new version has a different format than the previous one.
New: Microsoft.NetApp/stable/2023-07-01/netapp.json#L361:9
Old: Microsoft.NetApp/stable/2023-05-01/netapp.json#L340:9
1023 - TypeFormatChanged The new version has a different format than the previous one.
New: Microsoft.NetApp/stable/2023-07-01/netapp.json#L411:9
Old: Microsoft.NetApp/stable/2023-05-01/netapp.json#L390:9
1023 - TypeFormatChanged The new version has a different format than the previous one.
New: Microsoft.NetApp/stable/2023-07-01/netapp.json#L473:9
Old: Microsoft.NetApp/stable/2023-05-01/netapp.json#L452:9
1023 - TypeFormatChanged The new version has a different format than the previous one.
New: common-types/resource-management/v5/types.json#L14:9
Old: common-types/resource-management/v3/types.json#L14:9
1023 - TypeFormatChanged The new version has a different format than the previous one.
New: Microsoft.NetApp/stable/2023-07-01/netapp.json#L513:9
Old: Microsoft.NetApp/stable/2023-05-01/netapp.json#L489:9
1023 - TypeFormatChanged The new version has a different format than the previous one.
New: Microsoft.NetApp/stable/2023-07-01/netapp.json#L556:9
Old: Microsoft.NetApp/stable/2023-05-01/netapp.json#L529:9
1023 - TypeFormatChanged The new version has a different format than the previous one.
New: Microsoft.NetApp/stable/2023-07-01/netapp.json#L597:9
Old: Microsoft.NetApp/stable/2023-05-01/netapp.json#L567:9
1023 - TypeFormatChanged The new version has a different format than the previous one.
New: Microsoft.NetApp/stable/2023-07-01/netapp.json#L659:9
Old: Microsoft.NetApp/stable/2023-05-01/netapp.json#L626:9
1023 - TypeFormatChanged The new version has a different format than the previous one.
New: Microsoft.NetApp/stable/2023-07-01/netapp.json#L705:9
Old: Microsoft.NetApp/stable/2023-05-01/netapp.json#L669:9
1023 - TypeFormatChanged The new version has a different format than the previous one.
New: Microsoft.NetApp/stable/2023-07-01/netapp.json#L767:9
Old: Microsoft.NetApp/stable/2023-05-01/netapp.json#L731:9
1023 - TypeFormatChanged The new version has a different format than the previous one.
New: Microsoft.NetApp/stable/2023-07-01/netapp.json#L814:9
Old: Microsoft.NetApp/stable/2023-05-01/netapp.json#L775:9
1023 - TypeFormatChanged The new version has a different format than the previous one.
New: common-types/resource-management/v5/types.json#L14:9
Old: common-types/resource-management/v3/types.json#L14:9
1023 - TypeFormatChanged The new version has a different format than the previous one.
New: Microsoft.NetApp/stable/2023-07-01/netapp.json#L860:9
Old: Microsoft.NetApp/stable/2023-05-01/netapp.json#L818:9
1023 - TypeFormatChanged The new version has a different format than the previous one.
New: Microsoft.NetApp/stable/2023-07-01/netapp.json#L904:9
Old: Microsoft.NetApp/stable/2023-05-01/netapp.json#L859:9
1023 - TypeFormatChanged The new version has a different format than the previous one.
New: Microsoft.NetApp/stable/2023-07-01/netapp.json#L967:9
Old: Microsoft.NetApp/stable/2023-05-01/netapp.json#L919:9
1023 - TypeFormatChanged The new version has a different format than the previous one.
New: Microsoft.NetApp/stable/2023-07-01/netapp.json#L1027:9
Old: Microsoft.NetApp/stable/2023-05-01/netapp.json#L976:9
1023 - TypeFormatChanged The new version has a different format than the previous one.
New: Microsoft.NetApp/stable/2023-07-01/netapp.json#L1073:9
Old: Microsoft.NetApp/stable/2023-05-01/netapp.json#L1019:9
1023 - TypeFormatChanged The new version has a different format than the previous one.
New: common-types/resource-management/v5/types.json#L14:9
Old: common-types/resource-management/v3/types.json#L14:9
1023 - TypeFormatChanged The new version has a different format than the previous one.
New: Microsoft.NetApp/stable/2023-07-01/netapp.json#L1126:9
Old: Microsoft.NetApp/stable/2023-05-01/netapp.json#L1069:9
1023 - TypeFormatChanged The new version has a different format than the previous one.
New: Microsoft.NetApp/stable/2023-07-01/netapp.json#L1173:9
Old: Microsoft.NetApp/stable/2023-05-01/netapp.json#L1113:9
1023 - TypeFormatChanged The new version has a different format than the previous one.
New: Microsoft.NetApp/stable/2023-07-01/netapp.json#L1242:9
Old: Microsoft.NetApp/stable/2023-05-01/netapp.json#L1179:9
1023 - TypeFormatChanged The new version has a different format than the previous one.
New: Microsoft.NetApp/stable/2023-07-01/netapp.json#L1305:9
Old: Microsoft.NetApp/stable/2023-05-01/netapp.json#L1242:9
1023 - TypeFormatChanged The new version has a different format than the previous one.
New: Microsoft.NetApp/stable/2023-07-01/netapp.json#L1365:9
Old: Microsoft.NetApp/stable/2023-05-01/netapp.json#L1299:9


The following breaking changes are detected by comparison with the latest preview version:

Only 30 items are listed, please refer to log for more details.

Rule Message
⚠️ 1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.NetApp/netAppAccounts/{accountName}/capacityPools/{poolName}/volumes/{volumeName}/latestBackupStatus/current' removed or restructured?
Old: Microsoft.NetApp/preview/2022-11-01-preview/netapp.json#L2676:5
⚠️ 1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.NetApp/netAppAccounts/{accountName}/accountBackups' removed or restructured?
Old: Microsoft.NetApp/preview/2022-11-01-preview/netapp.json#L2771:5
⚠️ 1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.NetApp/netAppAccounts/{accountName}/accountBackups/{backupName}' removed or restructured?
Old: Microsoft.NetApp/preview/2022-11-01-preview/netapp.json#L2821:5
⚠️ 1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.NetApp/netAppAccounts/{accountName}/backupVaults/{backupVaultName}/backups' removed or restructured?
Old: Microsoft.NetApp/preview/2022-11-01-preview/netapp.json#L2912:5
⚠️ 1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.NetApp/netAppAccounts/{accountName}/backupVaults/{backupVaultName}/backups/{backupName}' removed or restructured?
Old: Microsoft.NetApp/preview/2022-11-01-preview/netapp.json#L2968:5
⚠️ 1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.NetApp/netAppAccounts/{accountName}/backupVaults' removed or restructured?
Old: Microsoft.NetApp/preview/2022-11-01-preview/netapp.json#L4280:5
⚠️ 1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.NetApp/netAppAccounts/{accountName}/backupVaults/{backupVaultName}' removed or restructured?
Old: Microsoft.NetApp/preview/2022-11-01-preview/netapp.json#L4326:5
⚠️ 1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.NetApp/netAppAccounts/{accountName}/backupVaults/{backupVaultName}/backups/{backupName}/restoreFiles' removed or restructured?
Old: Microsoft.NetApp/preview/2022-11-01-preview/netapp.json#L4559:5
⚠️ 1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.NetApp/netAppAccounts/{accountName}/capacityPools/{poolName}/volumes/{volumeName}/migrateBackups' removed or restructured?
Old: Microsoft.NetApp/preview/2022-11-01-preview/netapp.json#L4626:5
⚠️ 1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.NetApp/netAppAccounts/{accountName}/migrateBackups' removed or restructured?
Old: Microsoft.NetApp/preview/2022-11-01-preview/netapp.json#L4693:5
⚠️ 1006 - RemovedDefinition The new version is missing a definition that was found in the old version. Was 'backup' removed or renamed?
New: Microsoft.NetApp/stable/2023-07-01/netapp.json#L4175:3
Old: Microsoft.NetApp/preview/2022-11-01-preview/netapp.json#L4755:3
⚠️ 1006 - RemovedDefinition The new version is missing a definition that was found in the old version. Was 'backupPatch' removed or renamed?
New: Microsoft.NetApp/stable/2023-07-01/netapp.json#L4175:3
Old: Microsoft.NetApp/preview/2022-11-01-preview/netapp.json#L4755:3
⚠️ 1006 - RemovedDefinition The new version is missing a definition that was found in the old version. Was 'backupProperties' removed or renamed?
New: Microsoft.NetApp/stable/2023-07-01/netapp.json#L4175:3
Old: Microsoft.NetApp/preview/2022-11-01-preview/netapp.json#L4755:3
⚠️ 1006 - RemovedDefinition The new version is missing a definition that was found in the old version. Was 'backupPatchProperties' removed or renamed?
New: Microsoft.NetApp/stable/2023-07-01/netapp.json#L4175:3
Old: Microsoft.NetApp/preview/2022-11-01-preview/netapp.json#L4755:3
⚠️ 1006 - RemovedDefinition The new version is missing a definition that was found in the old version. Was 'backupRestoreFiles' removed or renamed?
New: Microsoft.NetApp/stable/2023-07-01/netapp.json#L4175:3
Old: Microsoft.NetApp/preview/2022-11-01-preview/netapp.json#L4755:3
⚠️ 1006 - RemovedDefinition The new version is missing a definition that was found in the old version. Was 'backupVault' removed or renamed?
New: Microsoft.NetApp/stable/2023-07-01/netapp.json#L4175:3
Old: Microsoft.NetApp/preview/2022-11-01-preview/netapp.json#L4755:3
⚠️ 1006 - RemovedDefinition The new version is missing a definition that was found in the old version. Was 'backupVaultPatch' removed or renamed?
New: Microsoft.NetApp/stable/2023-07-01/netapp.json#L4175:3
Old: Microsoft.NetApp/preview/2022-11-01-preview/netapp.json#L4755:3
⚠️ 1006 - RemovedDefinition The new version is missing a definition that was found in the old version. Was 'backupVaultProperties' removed or renamed?
New: Microsoft.NetApp/stable/2023-07-01/netapp.json#L4175:3
Old: Microsoft.NetApp/preview/2022-11-01-preview/netapp.json#L4755:3
⚠️ 1006 - RemovedDefinition The new version is missing a definition that was found in the old version. Was 'backupsMigrationRequest' removed or renamed?
New: Microsoft.NetApp/stable/2023-07-01/netapp.json#L4175:3
Old: Microsoft.NetApp/preview/2022-11-01-preview/netapp.json#L4755:3
⚠️ 1007 - RemovedClientParameter The new version is missing a client parameter that was found in the old version. Was 'BackupName' removed or renamed?
New: Microsoft.NetApp/stable/2023-07-01/netapp.json#L7921:3
Old: Microsoft.NetApp/preview/2022-11-01-preview/netapp.json#L8712:3
⚠️ 1007 - RemovedClientParameter The new version is missing a client parameter that was found in the old version. Was 'BackupVaultName' removed or renamed?
New: Microsoft.NetApp/stable/2023-07-01/netapp.json#L7921:3
Old: Microsoft.NetApp/preview/2022-11-01-preview/netapp.json#L8712:3
⚠️ 1017 - ReferenceRedirection The '$ref' property points to different models in the old and new versions.
New: Microsoft.NetApp/stable/2023-07-01/netapp.json#L743:13
Old: Microsoft.NetApp/preview/2022-11-01-preview/netapp.json#L595:13
⚠️ 1017 - ReferenceRedirection The '$ref' property points to different models in the old and new versions.
New: common-types/resource-management/v5/types.json#L307:9
Old: Microsoft.NetApp/preview/2022-11-01-preview/netapp.json#L7966:9
⚠️ 1017 - ReferenceRedirection The '$ref' property points to different models in the old and new versions.
New: Microsoft.NetApp/stable/2023-07-01/netapp.json#L5484:9
Old: Microsoft.NetApp/preview/2022-11-01-preview/netapp.json#L6063:9
⚠️ 1017 - ReferenceRedirection The '$ref' property points to different models in the old and new versions.
New: Microsoft.NetApp/stable/2023-07-01/netapp.json#L5610:9
Old: Microsoft.NetApp/preview/2022-11-01-preview/netapp.json#L6217:9
⚠️ 1017 - ReferenceRedirection The '$ref' property points to different models in the old and new versions.
New: Microsoft.NetApp/stable/2023-07-01/netapp.json#L5613:9
Old: Microsoft.NetApp/preview/2022-11-01-preview/netapp.json#L6241:9
⚠️ 1017 - ReferenceRedirection The '$ref' property points to different models in the old and new versions.
New: Microsoft.NetApp/stable/2023-07-01/netapp.json#L6271:9
Old: Microsoft.NetApp/preview/2022-11-01-preview/netapp.json#L6938:9
⚠️ 1017 - ReferenceRedirection The '$ref' property points to different models in the old and new versions.
New: Microsoft.NetApp/stable/2023-07-01/netapp.json#L6274:9
Old: Microsoft.NetApp/preview/2022-11-01-preview/netapp.json#L6963:9
⚠️ 1017 - ReferenceRedirection The '$ref' property points to different models in the old and new versions.
New: Microsoft.NetApp/stable/2023-07-01/netapp.json#L1283:13
Old: Microsoft.NetApp/preview/2022-11-01-preview/netapp.json#L1108:13
⚠️ 1023 - TypeFormatChanged The new version has a different format than the previous one.
New: Microsoft.NetApp/stable/2023-07-01/netapp.json#L85:9
Old: Microsoft.NetApp/preview/2022-11-01-preview/netapp.json#L82:9
️⚠️LintDiff: 0 Warnings warning [Detail]
compared tags (via openapi-validator v2.1.6) new version base version
package-netapp-2023-07 package-netapp-2023-07(0f15820) default(release-netapp-Microsoft.NetApp-2023-07-01)

The following errors/warnings exist before current PR submission:

Only 30 items are listed, please refer to log for more details.

Rule Message
OperationsApiResponseSchema The response schema of operations API '/providers/Microsoft.NetApp/operations' does not match the ARM specification. Please standardize the schema.
Location: Microsoft.NetApp/stable/2023-07-01/netapp.json#L59
OperationsApiSchemaUsesCommonTypes Operations API path must follow the schema provided in the common types.
Location: Microsoft.NetApp/stable/2023-07-01/netapp.json#L60
GetCollectionOnlyHasValueAndNextLink Get endpoints for collections of resources must only have the value and nextLink properties in their model.
Location: Microsoft.NetApp/stable/2023-07-01/netapp.json#L252
ResourceNameRestriction The resource name parameter 'quotaLimitName' should be defined with a 'pattern' restriction.
Location: Microsoft.NetApp/stable/2023-07-01/netapp.json#L270
GetCollectionOnlyHasValueAndNextLink Get endpoints for collections of resources must only have the value and nextLink properties in their model.
Location: Microsoft.NetApp/stable/2023-07-01/netapp.json#L335
LroLocationHeader A 202 response should include an Location response header.
Location: Microsoft.NetApp/stable/2023-07-01/netapp.json#L675
UnSupportedPatchProperties Mark the top-level property 'location', specified in the patch operation body, as readOnly or immutable. You could also choose to remove it from the request payload of the Patch operation. These properties are not patchable.
Location: Microsoft.NetApp/stable/2023-07-01/netapp.json#L706
LroLocationHeader A 202 response should include an Location response header.
Location: Microsoft.NetApp/stable/2023-07-01/netapp.json#L735
PostResponseCodes 200 return code does not have a schema specified. LRO POST must have a 200 return code if only if the final response is intended to have a schema, if not the 200 return code must not be specified.
Location: Microsoft.NetApp/stable/2023-07-01/netapp.json#L760
LroLocationHeader A 202 response should include an Location response header.
Location: Microsoft.NetApp/stable/2023-07-01/netapp.json#L785
UnSupportedPatchProperties Mark the top-level property 'location', specified in the patch operation body, as readOnly or immutable. You could also choose to remove it from the request payload of the Patch operation. These properties are not patchable.
Location: Microsoft.NetApp/stable/2023-07-01/netapp.json#L968
LroLocationHeader A 202 response should include an Location response header.
Location: Microsoft.NetApp/stable/2023-07-01/netapp.json#L1000
LroLocationHeader A 202 response should include an Location response header.
Location: Microsoft.NetApp/stable/2023-07-01/netapp.json#L1045
PutResponseCodes Synchronous and long-running PUT operations must have responses with 200, 201 and default return codes. They also must not have other response codes.
Location: Microsoft.NetApp/stable/2023-07-01/netapp.json#L1166
LroLocationHeader A 202 response should include an Location response header.
Location: Microsoft.NetApp/stable/2023-07-01/netapp.json#L1215
UnSupportedPatchProperties Mark the top-level property 'location', specified in the patch operation body, as readOnly or immutable. You could also choose to remove it from the request payload of the Patch operation. These properties are not patchable.
Location: Microsoft.NetApp/stable/2023-07-01/netapp.json#L1243
LroLocationHeader A 202 response should include an Location response header.
Location: Microsoft.NetApp/stable/2023-07-01/netapp.json#L1278
LroLocationHeader A 202 response should include an Location response header.
Location: Microsoft.NetApp/stable/2023-07-01/netapp.json#L1333
PostResponseCodes 200 return code does not have a schema specified. LRO POST must have a 200 return code if only if the final response is intended to have a schema, if not the 200 return code must not be specified.
Location: Microsoft.NetApp/stable/2023-07-01/netapp.json#L1419
LroLocationHeader A 202 response should include an Location response header.
Location: Microsoft.NetApp/stable/2023-07-01/netapp.json#L1459
PostResponseCodes 200 return code does not have a schema specified. LRO POST must have a 200 return code if only if the final response is intended to have a schema, if not the 200 return code must not be specified.
Location: Microsoft.NetApp/stable/2023-07-01/netapp.json#L1481
LroLocationHeader A 202 response should include an Location response header.
Location: Microsoft.NetApp/stable/2023-07-01/netapp.json#L1512
PostResponseCodes 200 return code does not have a schema specified. LRO POST must have a 200 return code if only if the final response is intended to have a schema, if not the 200 return code must not be specified.
Location: Microsoft.NetApp/stable/2023-07-01/netapp.json#L1531
PostResponseCodes 200 return code does not have a schema specified. LRO POST must have a 200 return code if only if the final response is intended to have a schema, if not the 200 return code must not be specified.
Location: Microsoft.NetApp/stable/2023-07-01/netapp.json#L1668
LroLocationHeader A 202 response should include an Location response header.
Location: Microsoft.NetApp/stable/2023-07-01/netapp.json#L1708
LroLocationHeader A 202 response should include an Location response header.
Location: Microsoft.NetApp/stable/2023-07-01/netapp.json#L1767
GetCollectionOnlyHasValueAndNextLink Get endpoints for collections of resources must only have the value and nextLink properties in their model.
Location: Microsoft.NetApp/stable/2023-07-01/netapp.json#L1819
PostResponseCodes 200 return code does not have a schema specified. LRO POST must have a 200 return code if only if the final response is intended to have a schema, if not the 200 return code must not be specified.
Location: Microsoft.NetApp/stable/2023-07-01/netapp.json#L1890
LroLocationHeader A 202 response should include an Location response header.
Location: Microsoft.NetApp/stable/2023-07-01/netapp.json#L1921
PostResponseCodes 200 return code does not have a schema specified. LRO POST must have a 200 return code if only if the final response is intended to have a schema, if not the 200 return code must not be specified.
Location: Microsoft.NetApp/stable/2023-07-01/netapp.json#L1943
️️✔️Avocado succeeded [Detail] [Expand]
Validation passes for Avocado.
️️✔️SwaggerAPIView succeeded [Detail] [Expand]
️️✔️TypeSpecAPIView succeeded [Detail] [Expand]
️️✔️ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️️✔️SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
️️✔️PR Summary succeeded [Detail] [Expand]
Validation passes for Summary.
️️✔️Automated merging requirements met succeeded [Detail] [Expand]
Posted by Swagger Pipeline | How to fix these errors?

@openapi-pipeline-app
Copy link
Copy Markdown

openapi-pipeline-app Bot commented Nov 22, 2023

Swagger Generation Artifacts

️️✔️ApiDocPreview succeeded [Detail] [Expand]
 Please click here to preview with your @microsoft account. 
️⚠️SDK Breaking Change Tracking warning [Detail]

Breaking Changes Tracking

⚠️azure-sdk-for-go - sdk/resourcemanager/netapp/armnetapp - Approved - 6.0.0
+	Field `DeploymentSpecID` of struct `VolumeGroupMetaData` has been removed
⚠️azure-sdk-for-python-track2 - track2_azure-mgmt-netapp - Approved - 11.0.0
+	Model VolumeGroupMetaData no longer has parameter deployment_spec_id
⚠️azure-sdk-for-js - @azure/arm-netapp - Approved - 20.0.0
+	Interface VolumeGroupMetaData no longer has parameter deploymentSpecId
+	Type of parameter userAssignedIdentities of interface ManagedServiceIdentity is changed from {
        [propertyName: string]: UserAssignedIdentity;
    } to {
        [propertyName: string]: UserAssignedIdentity | null;
    }
️⚠️ azure-sdk-for-python-track2 warning [Detail]
  • ⚠️Warning [Logs] Generate from fd04bd893130075b78ed33a28a9bccf4712a8b95. SDK Automation 14.0.0
    command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
    cmderr	[automation_init.sh] WARNING: azure-devtools 1.2.1 does not provide the extra 'ci-tools'
    cmderr	[automation_init.sh] WARNING: azure-devtools 1.2.1 does not provide the extra 'ci-tools'
    cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
    command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
    cmderr	[automation_generate.sh]
    cmderr	[automation_generate.sh] npm notice New major version of npm available! 9.8.1 -> 10.2.4
    cmderr	[automation_generate.sh] npm notice Changelog: <https://github.com/npm/cli/releases/tag/v10.2.4>
    cmderr	[automation_generate.sh] npm notice Run `npm install -g npm@10.2.4` to update!
    cmderr	[automation_generate.sh] npm notice
  • ️✔️track2_azure-mgmt-netapp [View full logs]  [Preview SDK Changes] Breaking Change Detected
    info	[Changelog] ### Breaking Changes
    info	[Changelog]
    info	[Changelog]   - Model VolumeGroupMetaData no longer has parameter deployment_spec_id
️❌ azure-sdk-for-net-track2 failed [Detail]
  • Failed [Logs] Generate from fd04bd893130075b78ed33a28a9bccf4712a8b95. SDK Automation 14.0.0
    command	pwsh ./eng/scripts/Automation-Sdk-Init.ps1 ../azure-sdk-for-net_tmp/initInput.json ../azure-sdk-for-net_tmp/initOutput.json
    command	pwsh ./eng/scripts/Invoke-GenerateAndBuildV2.ps1 ../azure-sdk-for-net_tmp/generateInput.json ../azure-sdk-for-net_tmp/generateOutput.json
    cmderr	[Invoke-GenerateAndBuildV2.ps1] �[31;1mGeneratePackage: �[0m/mnt/vss/_work/1/s/azure-sdk-for-net/eng/scripts/automation/GenerateAndBuildLib.ps1:714
    cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1mLine |
    cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1m 714 | �[0m         �[36;1mGeneratePackage -projectFolder $projectFolder -sdkRootPath $s�[0m …
    cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1m     | �[31;1m         ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    cmderr	[Invoke-GenerateAndBuildV2.ps1] �[31;1m�[36;1m     | �[31;1mFailed to build sdk. exit code: False
    cmderr	[Invoke-GenerateAndBuildV2.ps1] �[0m
  • Azure.ResourceManager.NetApp [View full logs]  [Preview SDK Changes] Breaking Change Detected
    info	[Changelog] Breaking Changes: /home/cloudtest/.nuget/packages/microsoft.dotnet.apicompat/5.0.0-beta.20467.1/build/Microsoft.DotNet.ApiCompat.targets(82,5): error : MembersMustExist : Member 'public void Azure.ResourceManager.NetApp.Models.NetAppVolumeGroupMetadata.DeploymentSpecId.set(System.String)' does not exist in the implementation but it does exist in the contract. [/mnt/vss/_work/1/s/azure-sdk-for-net/sdk/netapp/Azure.ResourceManager.NetApp/src/Azure.ResourceManager.NetApp.csproj::TargetFramework=netstandard2.0],
    info	[Changelog] /home/cloudtest/.nuget/packages/microsoft.dotnet.apicompat/5.0.0-beta.20467.1/build/Microsoft.DotNet.ApiCompat.targets(96,5): error : ApiCompat failed for '/mnt/vss/_work/1/s/azure-sdk-for-net/artifacts/bin/Azure.ResourceManager.NetApp/Debug/netstandard2.0/Azure.ResourceManager.NetApp.dll' [/mnt/vss/_work/1/s/azure-sdk-for-net/sdk/netapp/Azure.ResourceManager.NetApp/src/Azure.ResourceManager.NetApp.csproj::TargetFramework=netstandard2.0]
️️✔️ azure-sdk-for-js succeeded [Detail] [Expand]
  • ️✔️Succeeded [Logs] Generate from fd04bd893130075b78ed33a28a9bccf4712a8b95. SDK Automation 14.0.0
    command	sh .scripts/automation_init.sh ../azure-sdk-for-js_tmp/initInput.json ../azure-sdk-for-js_tmp/initOutput.json
    warn	File azure-sdk-for-js_tmp/initOutput.json not found to read
    command	sh .scripts/automation_generate.sh ../azure-sdk-for-js_tmp/generateInput.json ../azure-sdk-for-js_tmp/generateOutput.json
  • ️✔️@azure/arm-netapp [View full logs]  [Preview SDK Changes] Breaking Change Detected
    info	[Changelog] **Features**
    info	[Changelog]
    info	[Changelog]   - Enum KnownRelationshipStatus has a new value Failed
    info	[Changelog]   - Enum KnownRelationshipStatus has a new value Unknown
    info	[Changelog]
    info	[Changelog] **Breaking Changes**
    info	[Changelog]
    info	[Changelog]   - Interface VolumeGroupMetaData no longer has parameter deploymentSpecId
    info	[Changelog]   - Type of parameter userAssignedIdentities of interface ManagedServiceIdentity is changed from {
    info	[Changelog]         [propertyName: string]: UserAssignedIdentity;
    info	[Changelog]     } to {
    info	[Changelog]         [propertyName: string]: UserAssignedIdentity | null;
    info	[Changelog]     }
️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]
  • ️✔️Succeeded [Logs] Generate from fd04bd893130075b78ed33a28a9bccf4712a8b95. SDK Automation 14.0.0
    command	sh ./eng/scripts/automation_init.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
    command	generator automation-v2 ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json
  • ️✔️sdk/resourcemanager/netapp/armnetapp [View full logs]  [Preview SDK Changes] Breaking Change Detected
    info	[Changelog] ### Breaking Changes
    info	[Changelog]
    info	[Changelog] - Field `DeploymentSpecID` of struct `VolumeGroupMetaData` has been removed
    info	[Changelog]
    info	[Changelog] ### Features Added
    info	[Changelog]
    info	[Changelog] - New value `RelationshipStatusFailed`, `RelationshipStatusUnknown` added to enum type `RelationshipStatus`
    info	[Changelog]
    info	[Changelog] Total 1 breaking change(s), 2 additive change(s).
️⚠️ azure-sdk-for-java warning [Detail]
  • ⚠️Warning [Logs] Generate from fd04bd893130075b78ed33a28a9bccf4712a8b95. SDK Automation 14.0.0
    command	./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json
    cmderr	[init.sh] [notice] A new release of pip is available: 23.0.1 -> 23.3.1
    cmderr	[init.sh] [notice] To update, run: pip install --upgrade pip
    cmderr	[init.sh] [notice] A new release of pip is available: 23.0.1 -> 23.3.1
    cmderr	[init.sh] [notice] To update, run: pip install --upgrade pip
    command	./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json
  • ️✔️azure-resourcemanager-netapp [View full logs]  [Preview SDK Changes]
️⚠️ azure-resource-manager-schemas warning [Detail]
  • ⚠️Warning [Logs] Generate from fd04bd893130075b78ed33a28a9bccf4712a8b95. Schema Automation 14.0.0
    command	.sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json
    cmderr	[initScript.sh] npm notice
    cmderr	[initScript.sh] npm notice New major version of npm available! 8.19.4 -> 10.2.4
    cmderr	[initScript.sh] npm notice Changelog: <https://github.com/npm/cli/releases/tag/v10.2.4>
    cmderr	[initScript.sh] npm notice Run `npm install -g npm@10.2.4` to update!
    cmderr	[initScript.sh] npm notice
    warn	File azure-resource-manager-schemas_tmp/initOutput.json not found to read
    command	.sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json
  • ️✔️netapp [View full logs]  [Preview Schema Changes]
️❌ azure-powershell failed [Detail]
  • Pipeline Framework Failed [Logs] Generate from fd04bd893130075b78ed33a28a9bccf4712a8b95. SDK Automation 14.0.0
    command	sh ./tools/SwaggerCI/init.sh ../azure-powershell_tmp/initInput.json ../azure-powershell_tmp/initOutput.json
    command	pwsh ./tools/SwaggerCI/psci.ps1 ../azure-powershell_tmp/generateInput.json ../azure-powershell_tmp/generateOutput.json
    SSL error: syscall failure: Broken pipe
    Error: SSL error: syscall failure: Broken pipe
  • ⚠️Az.netapp.DefaultTag [View full logs
    error	Fatal error: SSL error: syscall failure: Broken pipe
    error	The following packages are still pending:
    error		Az.netapp.DefaultTag
Posted by Swagger Pipeline | How to fix these errors?

@openapi-pipeline-app
Copy link
Copy Markdown

openapi-pipeline-app Bot commented Nov 22, 2023

Generated ApiView

Language Package Name ApiView Link
Go sdk/resourcemanager/netapp/armnetapp https://apiview.dev/Assemblies/Review/28263df76eb94ad890837efa7060d113
Java azure-resourcemanager-netapp https://apiview.dev/Assemblies/Review/18bc933018e94d72a1f6a48c30c4c006
.Net Azure.ResourceManager.NetApp https://apiview.dev/Assemblies/Review/4993dfa77b63441eae17daf562eb4b3d
JavaScript @azure/arm-netapp https://apiview.dev/Assemblies/Review/6121844da26d4ead80d17c65575676bf

@openapi-workflow-bot
Copy link
Copy Markdown

Please address or respond to feedback from the ARM API reviewer.
When you are ready to continue the ARM API review, please remove the ARMChangesRequested label.
This will notify the reviewer to have another look.
If the feedback provided needs further discussion, please use this Teams channel to post your questions - aka.ms/azsdk/support/specreview-channel.
Please include [ARM Query] in the title of your question to indicate that it is ARM-related.

@JeffreyRichter JeffreyRichter added the Approved-BreakingChange DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374 label Nov 27, 2023
@openapi-workflow-bot openapi-workflow-bot Bot added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Nov 28, 2023
@sjanamma sjanamma added the ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review label Dec 2, 2023
@openapi-workflow-bot openapi-workflow-bot Bot removed the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Dec 2, 2023
@Alancere Alancere added the Approved-SdkBreakingChange-Go Approve the breaking change tracking for azure-sdk-for-go label Dec 4, 2023
@audunn
Copy link
Copy Markdown
Member Author

audunn commented Dec 5, 2023

/pr RequestMerge

@visingla-ms visingla-ms merged commit 671fbde into Azure:release-netapp-Microsoft.NetApp-2023-07-01 Dec 5, 2023
audunn added a commit to audunn/azure-rest-api-specs that referenced this pull request Dec 7, 2023
* Update to api-version 2023-07-01

* update common types to v5

* update common types to v5

* Add default schema, reference common types

* pretty
ms-henglu pushed a commit that referenced this pull request Dec 22, 2023
* Adds base for updating Microsoft.NetApp from version stable/2023-05-01 to version 2023-07-01

* Updates readme

* Updates API version in new specs and examples

* [NetAppFiles] Update rest to 2023-07-01 (#26817)

* Update to api-version 2023-07-01

* update common types to v5

* update common types to v5

* Add default schema, reference common types

* pretty

* readme

* Volumes_ResetCifsPassword

* readme

* readme

* readme

* readme

* update examples

* update example
arifibrahim4 pushed a commit that referenced this pull request Feb 26, 2024
* Adds base for updating Microsoft.NetApp from version stable/2023-05-01 to version 2023-07-01

* Updates readme

* Updates API version in new specs and examples

* [NetAppFiles] Update rest to 2023-07-01 (#26817)

* Update to api-version 2023-07-01

* update common types to v5

* update common types to v5

* Add default schema, reference common types

* pretty

* readme

* Volumes_ResetCifsPassword

* readme

* readme

* readme

* readme

* update examples

* update example
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Approved-BreakingChange DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374 Approved-SdkBreakingChange-Go Approve the breaking change tracking for azure-sdk-for-go Approved-SdkBreakingChange-JavaScript Approved-SdkBreakingChange-Python ARMReview ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review BreakingChangeReviewRequired <valid label in PR review process>add this label when breaking change review is required CI-BreakingChange-Go CI-BreakingChange-JavaScript resource-manager

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants