Skip to content

java, simplify openai client.tsp #26699

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
weidongxu-microsoft merged 6 commits into from
Nov 15, 2023
Merged

java, simplify openai client.tsp #26699

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
294cb96
java, openai client.tsp
weidongxu-microsoft Nov 14, 2023
212d94d
move ImageGenerationResponseFormat to impl
weidongxu-microsoft Nov 14, 2023
52af094
update
weidongxu-microsoft Nov 14, 2023
a0cc9f9
move ImageLocation to impl
weidongxu-microsoft Nov 14, 2023
0d48109
revert ImageGenerationResponseFormat,ImageLocation
weidongxu-microsoft Nov 14, 2023
657d84b
remove ChatCompletionsOptions and ChatCompletions, they should be inf…
weidongxu-microsoft Nov 15, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 2 additions & 14 deletions specification/cognitiveservices/OpenAI.Inference/client.tsp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,23 +24,11 @@ using Azure.ClientGenerator.Core;
@@usage(Azure.OpenAI.ImageGenerations, Usage.input | Usage.output);

// Java will need to have those models expose in public surface.
@@access(Azure.OpenAI.AudioTaskLabel, Access.public, "java");
@@access(Azure.OpenAI.AudioTranscription, Access.public, "java");
@@access(Azure.OpenAI.AudioTranscriptionSegment, Access.public, "java");
@@access(Azure.OpenAI.AudioTranscriptionOptions, Access.public, "java");
@@access(Azure.OpenAI.AudioTranslation, Access.public, "java");
@@access(Azure.OpenAI.AudioTranslationSegment, Access.public, "java");
@@access(Azure.OpenAI.AzureChatExtensionConfiguration, Access.public, "java");
@@access(Azure.OpenAI.AzureChatExtensionType, Access.public, "java");
@@access(Azure.OpenAI.AudioTranslationOptions, Access.public, "java");
@@access(Azure.OpenAI.AzureOpenAIOperationState, Access.public, "java");
@@access(Azure.OpenAI.ChatChoice, Access.public, "java");
@@access(Azure.OpenAI.ChatCompletions, Access.public, "java");
// Error: Model 'ChatCompletionsOptions' cannot be set as access=public, as it refers Union 'FunctionCallPreset | FunctionName'
// @@access(Azure.OpenAI.ChatCompletionsOptions, Access.public, "java");
@@access(Azure.OpenAI.ChatMessage, Access.public, "java");
@@access(Azure.OpenAI.ChatRole, Access.public, "java");
@@access(Azure.OpenAI.FunctionCall, Access.public, "java");
@@access(Azure.OpenAI.FunctionDefinition, Access.public, "java");
@@access(Azure.OpenAI.FunctionName, Access.public, "java");

@@access(Azure.OpenAI.AzureCognitiveSearchIndexFieldMappingOptions,
Access.public
Expand Down
2 changes: 1 addition & 1 deletion specification/cognitiveservices/OpenAI.Inference/tspconfig.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ options:
enable-sync-stack: true
generate-tests: false
custom-types-subpackage: "implementation.models"
custom-types: "FunctionCallModelBase,FunctionCallPreset,FunctionCallPresetFunctionCallModel,FunctionNameFunctionCallModel"
custom-types: "FunctionCallPreset"
Copy link
Copy Markdown
Contributor

@XiaofeiCao XiaofeiCao Nov 15, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the effect of this change?

Copy link
Copy Markdown
Member Author

@weidongxu-microsoft weidongxu-microsoft Nov 15, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It moves this model to impl. Maybe we can use @internal

"@azure-tools/typespec-ts":
package-dir: "openai"
generateMetadata: false
Expand Down